re: [1/2] msvcrt: Implement _mbsupr_s (try2).

2011-03-17 Thread Dan Kegel
Konrad wrote: > + c = _mbctoupper(_mbsnextc(s)); > + /* Note that I assume that the size of the character is unchanged */ > + if (c > 255) > + { > + *s++=(c>>8); > + c=c & 0xff; > + } > + *s++=c; Tests might be in order... (Here's one possible inter

Re: msxml3: Prevent a crash at second call to vsnprintf

2011-03-17 Thread Nikolay Sivov
On 3/18/2011 02:00, André Hentschel wrote: i did test that now for a while and if the first time the buffer isn't enough and len gets incremented (no matter how much) then the next call to vnsprintf crashes. that seems to happen only with 64 bits and i would blame Ubuntu for it :) see http://t

Re: wineport: Add support for ctz().

2011-03-17 Thread Adam Martinson
On 03/17/2011 02:04 PM, Alexander Kochetkov wrote: For my purposes the 'return -1' path will never be taken, so it's not needed. I want to be able to do: while (bitmap) { i = ctz(bitmap); /* get the LSB index */ bitmap ^= 1<< i; /* zero LSB */ /* for each set bit i... */ } If the

Re: Spammer on AppDB

2011-03-17 Thread Rosanne DiMesio
On Thu, 17 Mar 2011 16:09:30 -0600 Erich Hoover wrote: > Account named "AnnaT": > http://appdb.winehq.org/objectManager.php?sClass=version&iId=7440#Comment-67977 I've deleted the comment and the user. -- Rosanne DiMesio

Spammer on AppDB

2011-03-17 Thread Erich Hoover
Account named "AnnaT": http://appdb.winehq.org/objectManager.php?sClass=version&iId=7440#Comment-67977

Re: msvcrt: add implementation of _mbsupr_s and _mbslwr_s

2011-03-17 Thread Austin English
On Thu, Mar 17, 2011 at 09:39, Konrad Rzepecki wrote: > --- >  dlls/msvcr100/msvcr100.spec |    4 +- >  dlls/msvcr80/msvcr80.spec   |    4 +- >  dlls/msvcr90/msvcr90.spec   |    4 +- >  dlls/msvcrt/mbcs.c          |   72 > +++ >  dlls/msvcrt/msvcrt.spec    

Re: wineport: Add support for ctz().

2011-03-17 Thread Adam Martinson
On 03/17/2011 02:54 AM, Marcus Meissner wrote: On Wed, Mar 16, 2011 at 01:26:31PM -0500, Adam Martinson wrote: On 03/16/2011 08:34 AM, Alexandre Julliard wrote: Adam Martinson writes: @@ -239,6 +243,19 @@ extern int getopt_long_only (int ___argc, char *const *___argv, int ffs( int x );

Re: wineport: Add support for ctz().

2011-03-17 Thread Adam Martinson
On 03/17/2011 03:23 AM, David Laight wrote: On Wed, Mar 16, 2011 at 01:26:31PM -0500, Adam Martinson wrote: __builtin_ctz() compiles to: mov0x8(%ebp),%eax bsf%eax,%eax (ffs()-1) compiles to: mov$0x,%edx bsf0x8(%ebp),%eax cmove %edx,%eax ... So yes, there is a reason,

Re: usp10: corrections to ScriptXtoCP

2011-03-17 Thread Nikolay Sivov
On 3/17/2011 18:20, Aric Stewart wrote: It is correct for both LRT and RTL runs --- dlls/usp10/tests/usp10.c | 211 +- dlls/usp10/usp10.c | 128 +++- 2 files changed, 259 insertions(+), 80 deletions(-) Maybe it's bet

Solution for "Could not find dependent assembly" error

2011-03-17 Thread Alexandru Bolboaca-Diaconu
Hello, I didn't know exactly where to report that, so here it is, and I hope it's useful. When running Torchlight, I got the following error: "fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC90.CRT" (9.0.21022.8)""

re: Please ban this spammer from the forum

2011-03-17 Thread Dan Kegel
Done.

Please ban this spammer from the forum

2011-03-17 Thread Rosanne DiMesio
We've had repeated spam posts from user darlingntq9 over the past couple of days. Please ban him/her from the forum. -- Rosanne DiMesio

Re: [2/2] server: Make sure that CreateFile(CREATE_ALWAYS) overwrites existing file attributes.

2011-03-17 Thread Alexandre Julliard
Dmitry Timoshkov writes: > @@ -1829,6 +1828,11 @@ struct fd *open_fd( struct fd *root, const char *name, > int flags, mode_t *mode, > return NULL; > } > ftruncate( fd->unix_fd, 0 ); > +if (flags & O_CREAT) > +{ > +

Re: wineport: Add support for ctz().

2011-03-17 Thread David Laight
On Wed, Mar 16, 2011 at 01:26:31PM -0500, Adam Martinson wrote: > > __builtin_ctz() compiles to: > mov0x8(%ebp),%eax > bsf%eax,%eax > > (ffs()-1) compiles to: > mov$0x,%edx > bsf0x8(%ebp),%eax > cmove %edx,%eax ... > > So yes, there is a reason, ctz() is at least 50% fas

Re: wineport: Add support for ctz().

2011-03-17 Thread Marcus Meissner
On Wed, Mar 16, 2011 at 01:26:31PM -0500, Adam Martinson wrote: > On 03/16/2011 08:34 AM, Alexandre Julliard wrote: > >Adam Martinson writes: > > > >>@@ -239,6 +243,19 @@ extern int getopt_long_only (int ___argc, char *const > >>*___argv, > >> int ffs( int x ); > >> #endif > >> > >>+#if defined

Re: wined3d/device: Avoid repeated calculations of idx and shift in IWineD3DDeviceImpl_MarkStateDirty(). (resend)

2011-03-17 Thread Adam Martinson
On 03/16/2011 02:55 PM, Alexandre Julliard wrote: Adam Martinson writes: On 03/16/2011 02:24 PM, Alexandre Julliard wrote: Adam Martinson writes: Look at any d3d app with oprofile. That function is called EVERYWHERE. In my testing this reduces IWineD3DDeviceImpl_MarkStateDirty() from 4.

Re: wined3d/device: Avoid repeated calculations of idx and shift in IWineD3DDeviceImpl_MarkStateDirty(). (resend)

2011-03-17 Thread Adam Martinson
On 03/16/2011 02:24 PM, Alexandre Julliard wrote: Adam Martinson writes: Look at any d3d app with oprofile. That function is called EVERYWHERE. In my testing this reduces IWineD3DDeviceImpl_MarkStateDirty() from 4.8% of wined3d CPU time to 3.3%. What compiler are you using? I don't see any

Re: wineport: Add support for ctz().

2011-03-17 Thread Adam Martinson
On 03/16/2011 08:34 AM, Alexandre Julliard wrote: Adam Martinson writes: @@ -239,6 +243,19 @@ extern int getopt_long_only (int ___argc, char *const *___argv, int ffs( int x ); #endif +#if defined(__GNUC__)&& (GCC_VERSION>= 30406) +#define ctz(x) __builtin_ctz(x) +#elif defined(__GNU

Re: wined3d/device: Avoid repeated calculations of idx and shift in IWineD3DDeviceImpl_MarkStateDirty(). (resend)

2011-03-17 Thread Adam Martinson
On 03/16/2011 08:39 AM, Alexandre Julliard wrote: Adam Martinson writes: --- dlls/wined3d/device.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) You still need to demonstrate that this is an improvement. Compilers are pretty good nowadays, and doing such micro-