Re: Two more summer of code ideas

2011-03-14 Thread Juan Lang
Hi Dan, > I added sandboxing and message-mode pipes to > http://wiki.winehq.org/SummerOfCode > > (Yes, it's literally a pipe dream :-) I think it's too much for the scope of a SoC project, personally. I think it should be possible with help from the kernel. For example, Steve French expressed

Two more summer of code ideas

2011-03-14 Thread Dan Kegel
I added sandboxing and message-mode pipes to http://wiki.winehq.org/SummerOfCode (Yes, it's literally a pipe dream :-) - Dan

Re: correct comctl32 implementation

2011-03-14 Thread Frank Richter
On 11.03.2011 10:28, Nikolay Sivov wrote: > In version 6 all user32 controls are reimplemented with theme support in > comctl32, while user32 classes are kept of course. This is done with > specific entries in comctl32 manifest, on load comctl32 all builtin > classes are re-registered to the ones f

Re: comctl32: Update progress bar only if it moves

2011-03-14 Thread Nikolay Sivov
On 3/15/2011 00:16, Maarten Lankhorst wrote: --- Hopefully helps a little with lord of the rings online installer. It seems to be fanatical about updating the position, which may result in too many unnecessary redraws. Patch is wrong. This is inefficient but it's how native control works, it i

Re: d3dx9_36: Start effect parsing.

2011-03-14 Thread Henri Verbeet
2011/3/14 Rico Schüller : > Yes, it is the shader/effect version. I used the value because I was not > able to generate other targets for d3dx9 with the current sdk. > > I think a mask for the effect ((tag >> 16) == 0xfeff)) would be fine here. > There shouldn't be a huge difference between the ver

Re: d3dx9_36: Start effect parsing.

2011-03-14 Thread Rico Schüller
Am 13.03.2011 22:59, schrieb Henri Verbeet: 2011/3/13 Rico Schüller: +if (tag != 0xfeff0901) Looks like the kind of thing you'd want a constant or inline function for. If I were to guess, the feff part means it's an effect (similar to the for d3d9 pixel shaders and the fffe for d3d9 ve

Re: [PATCH 5/5] shdocvw/tests: Added IShellBrowser, IBrowserService and IDocObjectService existance tests

2011-03-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9936 Your paranoid android.

Re: [PATCH 2/5] shdocvw: Added IShellBrowser interface stub

2011-03-14 Thread Huw Davies
On Mon, Mar 14, 2011 at 05:03:37PM +0100, Piotr Caban wrote: > +static HRESULT WINAPI ShellBrowser_QueryInterface( > +IShellBrowser* iface, > +REFIID riid, > +void **ppvObject) > +{ > +ShellBrowser *This = impl_from_IShellBrowser(iface); > +*ppvObject = NULL; > + > +

Re: [PATCH 2/2] winmm: Parse MCI colon notation as in T:MM:SS:F

2011-03-14 Thread Alexandre Julliard
writes: > @@ -975,18 +975,31 @@ static WORDMCI_GetMessage(LPCWSTR lpCmd) > */ > static BOOLMCI_GetDWord(DWORD* data, LPWSTR* ptr) > { > -DWORDval; > -LPWSTR ret; > +DWORDval, total = 0; > +LPWSTR ret, src = *ptr; > +int

Re: [PATCH 3/3] winecoreaudio: Fix 64-bits incompatibilities

2011-03-14 Thread Alexandre Julliard
writes: > Dear 64bit users, > > here I turned a couple of DWORD into DWORD_PTR by analogy with other such > patches. > I'm using a 32bit bit system where it makes no difference, so please check. > I'm wondering why, if such types make a difference on 64 bit, there > aren't crashes seen on testhq