Re: correct comctl32 implementation

2011-03-11 Thread Andrew Green
Thank you for the quick reply. so is it the case is that multiple dll's versions will be generated to be used by SxS(as WinSxS contains multiple comctl32.dll)? I know uxtheme draws primitives. What I meant to ask was will any work have to be done in uxtheme(apart from maybe the occasional bug fix,

Help: afxctl.h missing

2011-03-11 Thread Jaytirth S. Khairatkar
Hello, I am getting the following error when I am trying to compile in Winelib error: afxctl.h: No such file or directory How should I resolve this? thanks and regards Jaytirth Khairatkar -- Jaytirth S. Khairatkar System Architecture and Algorithms Mobile: 9223529523

Re: wineport: Add fast builtin & asm versions of ffs() + ctz() where supported.

2011-03-11 Thread Adam Martinson
On 03/11/2011 07:28 AM, Alexandre Julliard wrote: Adam Martinson writes: @@ -236,7 +241,40 @@ extern int getopt_long_only (int ___argc, char *const *___argv, #endif /* HAVE_GETOPT_LONG */ #ifndef HAVE_FFS -int ffs( int x ); +#if defined(__i386__) || defined(__x86_64__) +#def

Re: wined3d/context: Remove a trivial call to context_validate_onscreen_formats() in context_apply_blit_state().

2011-03-11 Thread Adam Martinson
On 03/11/2011 06:50 AM, Henri Verbeet wrote: Sigh. I've asked you a very simple question about the performance impact of these changes *twice* now, and you ignored the question both times. Unless you have evidence that the compiler fails to eliminate the call by itself, and this actually makes a

Re: wineport: Use a lookup table to make our slow ffs() a bit faster.

2011-03-11 Thread Adam Martinson
On 03/11/2011 07:19 AM, Alexandre Julliard wrote: Henri Verbeet writes: Something like the following may be faster: static const int bit_pos[] = { 0x00, 0x01, 0x0e, 0x02, 0x0f, 0x1b, 0x12, 0x03, 0x1e, 0x10, 0x1c, 0x16, 0x18, 0x13, 0x0a, 0x04, 0x1f, 0x0d, 0x1a, 0x11, 0x1d, 0x15,

Re: include: Add rmxftmpl.h header.

2011-03-11 Thread Dylan Smith
On Fri, Mar 11, 2011 at 9:44 AM, Alexandre Julliard wrote: > > That stuff needs to be generated from source, you can't just copy the > native header contents. > Is the following acceptable? 1. Implement IDirectXFileSaveObject::SaveTemplates 2. Create programs/dxfconv as a wine program that uses

Re: wineport: Use a lookup table to make our slow ffs() a bit faster.

2011-03-11 Thread David Laight
On Fri, Mar 11, 2011 at 05:51:27AM -0800, Dan Kegel wrote: > > Large lookup tables can dirty the L1 cache and slow other things down. And even small tables can also be a slow data cache miss in the critical path. Of course, when benchmarking, the table is all in the cache! In real life it is like

Re: wineport: Add fast builtin & asm versions of ffs() + ctz() where supported.

2011-03-11 Thread David Laight
On Fri, Mar 11, 2011 at 02:28:27PM +0100, Alexandre Julliard wrote: > Adam Martinson writes: > > > @@ -236,7 +241,40 @@ extern int getopt_long_only (int ___argc, char *const > > *___argv, > > #endif /* HAVE_GETOPT_LONG */ > > > > #ifndef HAVE_FFS > > -int ffs( int x ); > > +#if defined(

Re: programs/dxdiag: beginnings of support for /t option

2011-03-11 Thread Drew Goodwin
Thanks for the feedback Henri! Andrew Nguyen also gave some comments. We address the issue and resubmit today or over the weekend. On Fri, Mar 11, 2011 at 7:20 AM, Henri Verbeet wrote: > On 10 March 2011 20:35, Drew Goodwin wrote: > > +length = MultiByteToWideChar(0, 0, name, -1, NULL, 0)+

Re: [PATCH 1/6] user32: Add get/release routines for accessing cursor frames.

2011-03-11 Thread Alexandre Julliard
Erich Hoover writes: > The idea of the get_icon_data() is to return the frame data for a > particular icon step, so for split animated cursors (patch 3) the > routine can appropriately call get_icon_ptr() on the "sub-icon" (and > release_icon_data can call release_icon_ptr). I considered calling

Re: [PATCH 1/6] user32: Add get/release routines for accessing cursor frames.

2011-03-11 Thread Erich Hoover
On Fri, Mar 11, 2011 at 8:01 AM, Alexandre Julliard wrote: > Erich Hoover writes: >> @@ -135,6 +139,16 @@ static void release_icon_ptr( HICON handle, struct >> cursoricon_object *ptr ) >>      release_user_handle_ptr( ptr ); >>  } >> >> +struct static_cursoricon_object *get_icon_data( struct cur

Re: programs/dxdiag: beginnings of support for /t option

2011-03-11 Thread Henri Verbeet
On 10 March 2011 20:35, Drew Goodwin wrote: > +length = MultiByteToWideChar(0, 0, name, -1, NULL, 0)+1; > +{ > +/* Allocate on the stack */ > +WCHAR nameW[length]; Oh, and variable length arrays are a C99 feature, Wine tries to mostly stick to C89.

New winetricks 20110311b: winetricks is dead, long live winetricks

2011-03-11 Thread Dan Kegel
winetricks-20110311b is now released. Changes since winetricks-20110123 (for anyone who has not been using the alpha versions): - manages multiple wineprefixes - apps are now installed into separate wineprefixes by default - gui now split into separate pages for games, benchmarks, apps, dlls, font

Re: [PATCH 1/6] user32: Add get/release routines for accessing cursor frames.

2011-03-11 Thread Alexandre Julliard
Erich Hoover writes: > @@ -135,6 +139,16 @@ static void release_icon_ptr( HICON handle, struct > cursoricon_object *ptr ) > release_user_handle_ptr( ptr ); > } > > +struct static_cursoricon_object *get_icon_data( struct cursoricon_object > *obj, int istep ) > +{ > +return &obj->fram

re: links down

2011-03-11 Thread Dan Kegel
Looks like 2.8 sp1 is still up, though: http://www.microsoft.com/downloads/en/details.aspx?familyid=78cac895-efc2-4f8e-a9e0-3a1afbd5922e&displaylang=en I'll update winetricks, thanks. (And I'll put together a fast link checker for winetricks; doing a full run with an empty cache takes too long to

Re: programs/dxdiag: beginnings of support for /t option

2011-03-11 Thread Henri Verbeet
On 10 March 2011 20:35, Drew Goodwin wrote: > I'm a CS student at UCLA. I and some classmates are adding features to > wine's dxdiag. Here's the first patch, with code by Steve Feng, Andrew > Freer, and myself, properly copyrighted and licensed under the LGPL. Once > this is accepted, we will send

Re: include: Add rmxftmpl.h header.

2011-03-11 Thread Alexandre Julliard
Dylan Smith writes: > Manually parsed a hexdump of D3DRM_XTEMPLATES from the native header; > comments to show the corresponding text encoding. I used a test > application to dump D3DRM_XTEMPLATES with this header and the native > header to confirm that this header binary compatible with the n

re: wineport: Use a lookup table to make our slow ffs() a bit faster.

2011-03-11 Thread Dan Kegel
Do you actually have a system that doesn't have HAVE_FFS set? On my machine, int main(int argc, char **argv) { return ffs(argc); } compiles to pushl %ebp movl%esp, %ebp movl$-1, %edx bsfl8(%ebp), %eax cmove %edx, %eax addl$1, %eax

Re: cryptnet/tests: Partially revert commit de6e33f306a3b1b424ad1a9c41e85d3692ef9e4d

2011-03-11 Thread Joris Huizer
Hello, I found a small (copy/paste) mistake in this patch: -/* w2k3,XP, newer w2k: CRYPT_E_NO_MATCH */ -ok(!ret && (GetLastError() == CRYPT_E_NO_MATCH), +/* w2k3,XP, newer w2k: CRYPT_E_NO_MATCH, older w2k: CRYPT_E_ASN1_BADTAG */ +ok(!ret && (GetLastError() == CRYPT_E_NO_MATCH || +

Re: wineport: Add fast builtin & asm versions of ffs() + ctz() where supported.

2011-03-11 Thread Alexandre Julliard
Adam Martinson writes: > @@ -236,7 +241,40 @@ extern int getopt_long_only (int ___argc, char *const > *___argv, > #endif /* HAVE_GETOPT_LONG */ > > #ifndef HAVE_FFS > -int ffs( int x ); > +#if defined(__i386__) || defined(__x86_64__) > +#define HAVE_FFS > +static inline

Re: wineport: Use a lookup table to make our slow ffs() a bit faster.

2011-03-11 Thread Alexandre Julliard
Henri Verbeet writes: > Something like the following may be faster: > > static const int bit_pos[] = > { > 0x00, 0x01, 0x0e, 0x02, 0x0f, 0x1b, 0x12, 0x03, > 0x1e, 0x10, 0x1c, 0x16, 0x18, 0x13, 0x0a, 0x04, > 0x1f, 0x0d, 0x1a, 0x11, 0x1d, 0x15, 0x17, 0x09, > 0x0c, 0x19, 0x14, 0x08,

Re: wineport: Use a lookup table to make our slow ffs() a bit faster.

2011-03-11 Thread Henri Verbeet
Something like the following may be faster: static const int bit_pos[] = { 0x00, 0x01, 0x0e, 0x02, 0x0f, 0x1b, 0x12, 0x03, 0x1e, 0x10, 0x1c, 0x16, 0x18, 0x13, 0x0a, 0x04, 0x1f, 0x0d, 0x1a, 0x11, 0x1d, 0x15, 0x17, 0x09, 0x0c, 0x19, 0x14, 0x08, 0x0b, 0x07, 0x06, 0x05, }; const unsign

Re: wined3d/context: Remove a trivial call to context_validate_onscreen_formats() in context_apply_blit_state().

2011-03-11 Thread Henri Verbeet
On 10 March 2011 20:22, Adam Martinson wrote: > -context_validate_onscreen_formats(device, context, NULL); > +/* It's silly to call context_validate_onscreen_formats() with a > NULL depth_stencil. */ Sigh. I've asked you a very simple question about the performance impact of these

Re: wininet(4/7): Implement commiting a url cache entry that already existed (try 2)

2011-03-11 Thread Alexandre Julliard
Juan Lang writes: > With the previous patches applied, this no longer fails for me on > Alexandre's apparently corrupt index.dat. Note that the index.dat I sent you was created from scratch, by running the wininet tests in an empty wineprefix. So if it's really corrupt it means wininet has corru

Links down

2011-03-11 Thread Diego Diaz
sh winetricks mdac25 Executing wget -O mdac_typ.exe -nd -c --read-timeout=300 --retry-connrefused --header Accept-Encoding: gzip,deflate http://download.microsoft.com/download/e/e/4/ee4fe9ee-6fa1-4ab6-ab8c-fe1769f4edcf/mdac_typ.exe --2011-03-10 16:16:31-- http://download.microsoft.com/download/e/e/

Re: d3dxcreatebox patch

2011-03-11 Thread David Adam
2011/3/10 Alexandre Julliard > Matteo Bruni writes: > > > 2011/3/10 David Adam : > >> Thanks for the feedback. What do you mean by "you are forcing a > particular > >> vertex ordering3"? > > > > I mean that you are testing the vertices of the mesh returned by > > D3DXCreateBox in the order gener

Re: msxml3: Ignore XML Property ResolveExternals

2011-03-11 Thread Nikolay Sivov
On 3/11/2011 13:46, Alistair Leslie-Hughes wrote: Hi, Changelog: msxml3: Ignore XML Property ResolveExternals Please correct naming: static const WCHAR PropertyNewParserW[] = {'N','e','w','P','a','r','s','e','r',0}; static const WCHAR PropValueXPathW[] = {'X','P','a','t','h',0}; stati

Re: correct comctl32 implementation

2011-03-11 Thread Nikolay Sivov
On 3/11/2011 06:22, Andrew Green wrote: I have been researching how i could implement the gsoc Theming - Implement Wine theming support. Though I'm a bit confused what is wanted. So is the case that completely separate dll's should be written for different versions and be loaded by side-by-side a