Re: Make sure This->bsc.doc will be initialized while opening a zero byte html file, fix bug 25999 . modified: dlls/mshtml/navigate.c

2011-03-08 Thread Saulius Krasuckas
* On Tue, 8 Mar 2011, Jacek Caban wrote: > > What's the exact problem you're trying to fix? AFAIK, builtin IE crashes on loading empty file: http://bugs.winehq.org/show_bug.cgi?id=25999 S.

Re: [PATCH 4/4] d3d9: Surfaces always have resource type WINED3DRTYPE_SURFACE.

2011-03-08 Thread Henri Verbeet
On 8 March 2011 23:48, Stefan Dösinger wrote: > Actually I think we have a test that shows that if the surface is part of a > texture it has resource type WINED3DRTYPE_TEXTURE. (Unverified, it's too late > so I am too lazy to look for the exact test atm) > It's not working very well then, surfac

Re: [PATCH 4/4] d3d9: Surfaces always have resource type WINED3DRTYPE_SURFACE.

2011-03-08 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Actually I think we have a test that shows that if the surface is part of a texture it has resource type WINED3DRTYPE_TEXTURE. (Unverified, it's too late so I am too lazy to look for the exact test atm) Am 08.03.2011 um 19:41 schrieb Henri Verbeet:

Re: winegcc preprocessor macro containing wine version?

2011-03-08 Thread Roderick Colenbrander
On Tue, Mar 8, 2011 at 10:03 PM, Dan Kegel wrote: > Robert McDonald asked: >> I want to be able to define a structure if I'm compiling with Wine 1.2.2 >> but not with Wine 1.3.15, since the structure definition exists in the >> latter but not the former.  Is there a preprocessor macro pre-defined

re: winegcc preprocessor macro containing wine version?

2011-03-08 Thread Dan Kegel
Robert McDonald asked: > I want to be able to define a structure if I'm compiling with Wine 1.2.2 > but not with Wine 1.3.15, since the structure definition exists in the > latter but not the former. Is there a preprocessor macro pre-defined by > winegcc that holds the Wine version? #include "con

Re: winealsa.drv: Waveout rewrite to allow multiple waveopens

2011-03-08 Thread Maarten Lankhorst
Hi Joerg, Op 08-03-11 12:36, joerg-cyril.hoe...@t-systems.com schreef: Maarten, let me apologize for barely taking the time to look at the extra patches you write outside of the main git tree. I hope other people find more time to try them out with real apps and report on their findings. Here

winegcc preprocessor macro containing wine version?

2011-03-08 Thread Robert McDonald
I want to be able to define a structure if I'm compiling with Wine 1.2.2 but not with Wine 1.3.15, since the structure definition exists in the latter but not the former. Is there a preprocessor macro pre-defined by winegcc that holds the Wine version? Maybe that's not the best long-term solu

Re: Make sure This->bsc.doc will be initialized while opening a zero byte html file, fix bug 25999 . modified: dlls/mshtml/navigate.c

2011-03-08 Thread Jacek Caban
Hi Zuno, I don't think that's the right place for the fix. What's the exact problem you're trying to fix? AFAICS the only important difference your patch makes is that on_start_nsrequest will be always called in read_stream_data (possibly many times), but it's also called in on_stop_nsrequest

Re: widl: Pass the switchtype attribute from an alias to the base type

2011-03-08 Thread Alexandre Julliard
Eric Kohl writes: > Hi, > > this patch ensures that client and server code for non-encapsulated > unions is generated correctly. The switchtype attribute must be passed > to from a type alias to the base type in order to get recognized by > write_union_tfs(). Modifying the base type doesn't seem

Re: [1/2] wininet: Partially implement FreeUrlCacheSpaceW.

2011-03-08 Thread Alexandre Julliard
Alexander Scott-Johns writes: > +if (file == INVALID_HANDLE_VALUE) > +{ > +if (GetLastError() == ERROR_SHARING_VIOLATION) > +{ > +WCHAR title[128]; > +LoadStringW(WININET_hModule, IDS_CACHE_IN_USE, message, > sizeof(message)/sizeof(*message)); > +

Re: wininet(3/7): Account for disk space used by cache

2011-03-08 Thread Alexandre Julliard
Juan Lang writes: > +{ > +ULARGE_INTEGER currentSize, addedSize, limit; > + > +currentSize.u.LowPart = pHeader->dwCacheUsageLow; > +currentSize.u.HighPart = pHeader->dwCacheUsageHigh; > +addedSize.u.HighPart = fileSizeHigh; > +addedSize.u.LowPart = fileSizeLow; > +currentS

winealsa.drv: Waveout rewrite to allow multiple waveopens

2011-03-08 Thread Joerg-Cyril.Hoehle
Maarten, let me apologize for barely taking the time to look at the extra patches you write outside of the main git tree. I hope other people find more time to try them out with real apps and report on their findings. Here are a few comments of mine on your winealsa rewrite (beside bug #22261,

Re: [3/3] msi: Assume a file is present if the target exists with the same size and there's no file version or hash to verif

2011-03-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9778 Your paranoid android.

Re: [2/3] msi: Load media info even if there's no file to install.

2011-03-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9777 Your paranoid android.