Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=9673
Your paranoid android.
Dmitry Timoshkov wrote:
> Are you going to encourage packagers to include whatever patches
> they deem to be "an important feature" for the users, and still claim
> that provide an official Wine binary package?
There's a middle ground: ship both vanilla and patched wine, and make
vanilla the defau
Aric Stewart writes:
> Looks like WS2_ConnectEx is at fault.
>
> It is being called with a sendBuf of NULL which results in n_iovecs
> and first_iovec being set to 0 resulting in a len of 0.
Most likely it shouldn't be trying to send anything in that case.
--
Alexandre Julliard
julli...@winehq
Looks like WS2_ConnectEx is at fault.
It is being called with a sendBuf of NULL which results in n_iovecs and
first_iovec being set to 0 resulting in a len of 0.
I see no evidence of checking for this case along that codepath.
-aric
On 3/4/11 10:47 AM, Alexandre Julliard wrote:
Aric Stewart
I was seeing this coming through WS2_async_send.
I will investigate and give you a better code path that is resulting in
this.
-aric
On 3/4/11 10:47 AM, Alexandre Julliard wrote:
Aric Stewart writes:
@@ -1781,6 +1781,9 @@ static int WS2_send( int fd, struct ws2_async *wsa )
Aric Stewart writes:
> @@ -1781,6 +1781,9 @@ static int WS2_send( int fd, struct ws2_async *wsa )
> wsa->iovec[wsa->first_iovec].iov_len -= n;
> }
> }
> +/* BSD and OS/X return EMSGSIZE if hdr.msg_iovlen is 0 */
> +else if ( hdr.msg_iovlen == 0 && errno == EMSGS
Juan Lang writes:
> From 13fce7b5e1efa74219d334bbce6661bd49a00601 Mon Sep 17 00:00:00 2001
> From: Juan Lang
> Date: Wed, 2 Mar 2011 10:41:12 -0800
> Subject: [PATCH 08/19] Obey cache directives and flags regarding caching
It fails here:
../../../tools/runtest -q -P wine -M urlmon.dll -T ../..
Rico Schüller writes:
> DEFINE_GUID is used twice (dlls/dxguid/dx10guid.c and
> dlls/d3dcompiler_41/reflection.c) which could be bad. But the define
> was removed from the d3d11shader.h from ms, so it isn't officially
> available anymore. Should that be in a separate header to reduce
> redundancy
Juan Lang writes:
> Brought to you by copy and paste.
There's no reason to duplicate all that code.
--
Alexandre Julliard
julli...@winehq.org