Re: Fixed default cyLogical in IFont constructor

2011-03-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9650 Your paranoid android.

RFC: mmap override patch #2

2011-03-03 Thread Chris Robinson
An updated attempt at the mmap override patch that I previously sent. This version properly uses a signed type for the mmap wrapper (as off_t/off64_t are signed types), fixes a few things with the munmap wrapper relating to truncated and sliced file_views, and implements a mremap wrapper for Lin

d3dcompiler_41: reflection interface.

2011-03-03 Thread Rico Schüller
Hi, attached is a hacky patch which forwards the reflection interface from d3dcompiler_41 to d3dcompiler_43. I have a question to that implementation: DEFINE_GUID is used twice (dlls/dxguid/dx10guid.c and dlls/d3dcompiler_41/reflection.c) which could be bad. But the define was removed from

Re: Please help me with document extraction.

2011-03-03 Thread Max TenEyck Woodbury
On 02/27/2011 05:55 PM, Alexandre Julliard wrote: The other reason is that a decent documentation of the Windows API would be huge; look at how much information there is on MSDN, and that's still incomplete. It's completely impossible to maintain something of that size in the middle of the sourc

Re: wininet(2/6): Store entries in url cache with valid expiration date

2011-03-03 Thread Alexandre Julliard
Juan Lang writes: > +if (ret) > +{ > +ret = FALSE; > +num = strtoulW(ptr, &nextPtr, 10); > +if (nextPtr > ptr && *nextPtr == ':' && num <= 59) > +{ > +ptr = nextPtr + 1; > +st.wMinute = (WORD)num; > +ret = TRUE; > +

Re: [PATCH 3/3] mshtml: Added support for indexed access to form elements

2011-03-03 Thread Alexandre Julliard
Jacek Caban writes: > On 3/3/11 2:45 PM, Alexandre Julliard wrote: >> Jacek Caban writes: >> >>> +/* FIXME: Implement in more generic and safe way */ >>> +for(ptr = name; *ptr&& isdigitW(*ptr); ptr++) >>> +i = i*10 + (*ptr-'0'); >> What's wrong with strtoulW? > > We don't want t

Re: [PATCH 3/3] mshtml: Added support for indexed access to form elements

2011-03-03 Thread Jacek Caban
On 3/3/11 2:45 PM, Alexandre Julliard wrote: Jacek Caban writes: +/* FIXME: Implement in more generic and safe way */ +for(ptr = name; *ptr&& isdigitW(*ptr); ptr++) +i = i*10 + (*ptr-'0'); What's wrong with strtoulW? We don't want to use strings like "+1" or with leasing sp

Re: [PATCH 3/3] mshtml: Added support for indexed access to form elements

2011-03-03 Thread Alexandre Julliard
Jacek Caban writes: > +/* FIXME: Implement in more generic and safe way */ > +for(ptr = name; *ptr && isdigitW(*ptr); ptr++) > +i = i*10 + (*ptr-'0'); What's wrong with strtoulW? -- Alexandre Julliard julli...@winehq.org

Re: mountmgr.sys: start detecting USB devices

2011-03-03 Thread Damjan Jovanovic
On Thu, Mar 3, 2011 at 1:45 PM, Maarten Lankhorst wrote: > Hi Damjan, > > Op 02-03-11 18:52, Damjan Jovanovic schreef: >> >> Changelog: >> * mountmgr.sys: start detecting USB devices > > I'd love to get this kind of work in, but since libhal has been deprecated > for a while, wouldn't it be better

Re: mountmgr.sys: start detecting USB devices

2011-03-03 Thread Maarten Lankhorst
Hi Damjan, Op 02-03-11 18:52, Damjan Jovanovic schreef: Changelog: * mountmgr.sys: start detecting USB devices I'd love to get this kind of work in, but since libhal has been deprecated for a while, wouldn't it be better to use libudev directly instead of expanding our usage of libhal? Che

Re: Why am I getting create_view out of memory?

2011-03-03 Thread Alexandre Julliard
Peter Urbanec writes: > Could someone please explain to me what's going on here? Quick look at > the code indicates that there is a 4MB heap used for "views" (I have > no idea what these are) and presumably that heap is exhausted. Is this > likely a resource leak somewhere? Not necessarily. The

Re: WineHQ Bug 26271

2011-03-03 Thread Dmitry Timoshkov
[Please do not exclude wine-devel when repying] Andreas Bierfert wrote: > > That's precisely my point. How many users are prepared to compile Wine > > from source when they report a bug with such a Wine build, and > > somebody > > asks them to either use a package without custom patches or compi

Re: wininet(3/6): Default to 10 minutes expiration for cache entries

2011-03-03 Thread Dmitry Timoshkov
Juan Lang wrote: > +if (!expirationFound) > +{ > +SYSTEMTIME st; > + > +/* With no known age, default to 10 minutes until expiration. */ > +GetSystemTime(&st); > +if (st.wMinute < 50) > +st.wMinute += 10; > +else > +{ > +

Re: winex11.drv: Ensure that wintab xinput_handle is not NULL.

2011-03-03 Thread Peter Urbanec
On 01/03/11 17:13, John Klehm wrote: Nice find on this code path being able to run without loading xinput. It was as a result of a user sending me some crash logs. I never managed to reproduce this issue. I don't even have access to a tablet to test. My patch was pretty much a result of "NUL