Re: ddraw: Check for the Palette before using it

2011-02-28 Thread Henri Verbeet
2011/2/28 André Hentschel : >         *Pal = wined3d_palette_get_parent(wined3d_palette); > -        IDirectDrawPalette_AddRef(*Pal); > +        if (*Pal) IDirectDrawPalette_AddRef(*Pal); > +        else hr = DDERR_NOPALETTEATTACHED; This doesn't make sense, the parent shouldn't be NULL. You should

Re: winex11.drv: Ensure that wintab xinput_handle is not NULL.

2011-02-28 Thread John Klehm
On Mon, Feb 28, 2011 at 8:50 PM, Peter Urbanec wrote: > --- >  dlls/winex11.drv/wintab.c |   13 ++--- >  1 files changed, 10 insertions(+), 3 deletions(-) > Nice find on this code path being able to run without loading xinput. I have a couple comments: You don't need to guard inside Get

Re: Fwd: Applications for Mentoring Organizations Now Being Accepted

2011-02-28 Thread Maarten Lankhorst
Hi Dan, Op 28-02-11 21:41, Dan Kegel schreef: So, shall I do the honors? I've already been applying wine for summer of code this year, haven't finished it up though, you could always join as second backup admin. However I'd like everyone to have another look at our http://wiki.winehq.org/Sum

Re: shlwapi/tests: remove win9x hacks (try 2)

2011-02-28 Thread Nikolay Sivov
On 3/1/2011 01:28, Austin English wrote: Apparently it's flaky on win2k...cleared WTB: https://testbot.winehq.org/JobDetails.pl?Key=9585 -/* shlwapi on Win98 SE does not appear to apply delimiters to the output - * and does not correctly handle extremely large values. */ -ok(!strcmp(r

Re: ntprint/tests: remove win9x hacks

2011-02-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9577 Your paranoid android.

Re: shlwapi/tests: remove win9x hacks

2011-02-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9576 Your paranoid android.

Fwd: Applications for Mentoring Organizations Now Being Accepted

2011-02-28 Thread Dan Kegel
So, shall I do the honors? -- Forwarded message -- From: Carol Smith Date: Mon, Feb 28, 2011 at 12:35 PM Subject: Applications for Mentoring Organizations Now Being Accepted To: Google Summer of Code Announce Hi all, We're pleased to announce the applications for mentoring org

Re: Please help me with document extraction.

2011-02-28 Thread Alexandre Julliard
Max TenEyck Woodbury writes: > Frankly, I believe embedded documentation is the way to go. It is _not_ > a panacea, but it is better than trying to maintain a separate set of > functional documentation. I have seen cases where it worked. Not great > but OK. I tried the separate document approach

Re: Please help me with document extraction.

2011-02-28 Thread André Hentschel
Am 28.02.2011 17:20, schrieb Max TenEyck Woodbury: >> I think the idea of building upon the existing "documentation" somewhere else >> has a better chance than the "deal on the 100" >> > Frankly, I believe embedded documentation is the way to go. It is _not_ > a panacea, but it is better than tryin

Re: Please help me with document extraction.

2011-02-28 Thread Max TenEyck Woodbury
On 02/28/2011 08:08 AM, André Hentschel wrote: Am 27.02.2011 20:37, schrieb Max TenEyck Woodbury: I've picked up Perl in the last couple weeks. An interesting language with lots of adopted features. It's been easy to learn, so I think I will _not_ need help with the language itself, but I will l

Re: gdi32: Fixes GetDIBits for top-down destination bitmaps (Bug #26236).

2011-02-28 Thread Alexandre Julliard
John Edmonds writes: > Resolves Bug #26236. Please update the test cases to catch this. -- Alexandre Julliard julli...@winehq.org

Re: Please help me with document extraction.

2011-02-28 Thread André Hentschel
Am 27.02.2011 20:37, schrieb Max TenEyck Woodbury: > I've picked up Perl in the last couple weeks. An interesting language > with lots of adopted features. It's been easy to learn, so I think I > will _not_ need help with the language itself, but I will listen to any > advice. When i started with

Re: d3dx9_36: Stub ID3DXRenderToSurface, with tests

2011-02-28 Thread Henri Verbeet
On 27 February 2011 20:22, Misha Koshelev wrote: > +static HRESULT WINAPI > ID3DXRenderToSurfaceImpl_QueryInterface(ID3DXRenderToSurface *iface, REFIID > riid, void **ppobj) > +{ > +ID3DXRenderToSurfaceImpl *This = impl_from_ID3DXRenderToSurface(iface); You don't actually need "This" here.

Re: jscript: Fixed corner cases in parseInt implementation

2011-02-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9558 Your paranoid android.

Re: Valgrind --malloc-fill=A5 --free-fill=DE crashes Wine

2011-02-28 Thread Joerg-Cyril.Hoehle
Hi, Maarten Lankhorst wrote: >> It turns out that malloc-fill is harmless, -free-fill causes havoc currently. >It's most likely a valgrind/wine bug, does this patch work? Yes, that did the job with wine-1.3.12-14. So is it a Valgrind or a Wine bug? Thank you, Jörg Höhle