Re: kernel32/tests: remove win9x hacks (try 2)

2011-02-23 Thread James McKenzie
On 2/23/11 12:13 PM, Austin English wrote: On Wed, Feb 23, 2011 at 03:17, Damjan Jovanovic wrote: On Wed, Feb 23, 2011 at 11:38 AM, Austin English wrote: -- -Austin So test.winehq.org doesn't test Win9x any more, but why are we throwing away perfectly good Win9x tests that took years to

Re: kernel32/tests: remove win9x hacks

2011-02-23 Thread James McKenzie
On 2/23/11 2:38 AM, Austin English wrote: On Wed, Feb 23, 2011 at 01:32, Paul Vriens wrote: On 02/23/2011 10:15 AM, Austin English wrote: SetLastError(0xdeadbeef); ret = GetFullPathNameW(NULL, 0, NULL, NULL); I think you can get rid of the above two as well as they are merely used

Re: Apologies to the List

2011-02-23 Thread James McKenzie
On 2/22/11 10:44 PM, Tom Wickline wrote: On Wed, Feb 23, 2011 at 10:52 AM, James McKenzie mailto:jjmckenzi...@earthlink.net>> wrote: On 2/22/11 4:37 AM, Alexandre Julliard wrote: James McKenziemailto:jjmckenzi...@earthlink.net>> writes: First, my tirade was not int

Re: kernel32/tests: remove win9x hacks (try 2)

2011-02-23 Thread Austin English
On Wed, Feb 23, 2011 at 03:17, Damjan Jovanovic wrote: > On Wed, Feb 23, 2011 at 11:38 AM, Austin English > wrote: >> -- >> -Austin >> >> >> >> > > So test.winehq.org doesn't test Win9x any more, but why are we > throwing away perfectly good Win9x tests that took years to get in? Because the cod

Re: include: Add an errno number

2011-02-23 Thread André Hentschel
Am 23.02.2011 19:32, schrieb Alexandre Julliard: > André Hentschel writes: > >> @@ -23,6 +23,7 @@ >> >> # define EPERM 1 >> # define ENOENT 2 >> +# define ENOFILE ENOENT > > I don't see that in the MS headers. > true, sorry again -- Best Regards, André Hentschel

Re: winspool.drv: return maximum possible size of the buffer when no buffer is specified

2011-02-23 Thread Alexandre Julliard
Vitaly Perov writes: > @@ -7247,7 +7247,7 @@ static BOOL get_job_info_2(job_t *job, JOB_INFO_2W > *ji2, LPBYTE buf, DWORD cbBuf > else > { > /* align DEVMODE to a DWORD boundary */ > -shift= (4 - ( (DWORD_PTR) ptr & 3)) & 3; > +shift= ptr ?

Re: include: Add an errno number

2011-02-23 Thread Alexandre Julliard
André Hentschel writes: > @@ -23,6 +23,7 @@ > > # define EPERM 1 > # define ENOENT 2 > +# define ENOFILE ENOENT I don't see that in the MS headers. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 1/2] user32: make DIB_GetBitmapInfo checks stricter

2011-02-23 Thread Alexandre Julliard
Wolfram Sang writes: > @@ -988,6 +988,9 @@ static void test_LoadImage(void) > bmpimage[0x18]++; /* biWidth > 65535 */ > test_LoadImageFile("BMP (too wide)", bmpimage, sizeof(bmpimage), "bmp", > 0); > bmpimage[0x18]--; > +bmpimage[0x11]++; /* biSize > 2^24 */ > +test_LoadIm

Re: avicap32: Use define instead of hardcoded value

2011-02-23 Thread André Hentschel
sry, please ignore that one. -- Best Regards, André Hentschel

Re: comctl32: Add missing break (Coverity)

2011-02-23 Thread Michael Stefaniuc
Nikolay Sivov wrote: > On 2/23/2011 19:56, Michael Stefaniuc wrote: >> Nikolay Sivov wrote: >>> On 2/23/2011 19:28, Amine Khaldi wrote: CIDs 1581 and 1583. @@ -1852,6 +1852,7 @@ COMBOEX_EditWndProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam, case VK_UP: >

Re: comctl32: Add missing break (Coverity)

2011-02-23 Thread Marcus Meissner
On Wed, Feb 23, 2011 at 08:24:46PM +0300, Nikolay Sivov wrote: > >>> } > >>>+break; > >>> case DL_CANCELDRAG: > >>> /* Clear drag arrow */ > >>> DrawInsert(hwnd, hwndList, -1); > >>Why? Looks to me it's fine to clear on dropped case too. Coverity is a > >>bit paranoi

Re: comctl32: Add missing break (Coverity)

2011-02-23 Thread Nikolay Sivov
On 2/23/2011 19:56, Michael Stefaniuc wrote: Nikolay Sivov wrote: On 2/23/2011 19:28, Amine Khaldi wrote: CIDs 1581 and 1583. @@ -1852,6 +1852,7 @@ COMBOEX_EditWndProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam, case VK_UP: step = -1; +break; case

Re: [PATCH] user32: remove side effect code out of asserts() (Coverity)

2011-02-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9432 Your paranoid android.

Re: comctl32: Add missing break (Coverity)

2011-02-23 Thread Michael Stefaniuc
Nikolay Sivov wrote: > On 2/23/2011 19:28, Amine Khaldi wrote: >> CIDs 1581 and 1583. >> @@ -1852,6 +1852,7 @@ COMBOEX_EditWndProc (HWND hwnd, UINT uMsg, >> WPARAM wParam, LPARAM lParam, >> >> case VK_UP: >> step = -1; >> +break; >> case VK_DOWN: >> /* by

Re: gdi32: first look for a printer driver name in the registry (try 3)

2011-02-23 Thread Dmitry Timoshkov
Vitaly Perov wrote: > +if (!hKey) RegCloseKey(hKey); This is a typo. -- Dmitry.

Re: d3dcompiler_43: Add missing break (Coverity)

2011-02-23 Thread Matteo Bruni
2011/2/23 Amine Khaldi : > CID 1585. > > Regards, > Amine. > This doesn't seem to be the correct fix. With that break you aren't going to return any string and that will cause problems thereafter. You should replace the "case 2:" with "default:" instead (like BWRITERSPR_RASTOUT some rows above).

Re: comctl32: Add missing break (Coverity)

2011-02-23 Thread Nikolay Sivov
On 2/23/2011 19:28, Amine Khaldi wrote: CIDs 1581 and 1583. @@ -1852,6 +1852,7 @@ COMBOEX_EditWndProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam, case VK_UP: step = -1; +break; case VK_DOWN: /* by default, step is 1 */ oldItem = Sen

Re: comctl32: Add missing break (Coverity)

2011-02-23 Thread Marcus Meissner
On Wed, Feb 23, 2011 at 05:28:28PM +0100, Amine Khaldi wrote: > CIDs 1581 and 1583. > > Regards, > Amine. the comboex one seems to be intended to fall through to the next case. Ciao, Marcus

Re: [PATCH] cryptui: fixed bad sizeof() (Coverity)

2011-02-23 Thread Marcus Meissner
On Wed, Feb 23, 2011 at 07:29:41AM -0700, Vitaliy Margolen wrote: > On 02/22/2011 09:30 PM, Marcus Meissner wrote: > >Hi, > > > >CID 1181. copying a pointer to a struct into a struct is likely bad, > >fixed. > > > >-memcpy(&infoW,&info, sizeof(info)); > >+memcpy(&infoW, info, sizeof(*info))

Re: [PATCH] cryptui: fixed bad sizeof() (Coverity)

2011-02-23 Thread Vitaliy Margolen
On 02/22/2011 09:30 PM, Marcus Meissner wrote: Hi, CID 1181. copying a pointer to a struct into a struct is likely bad, fixed. -memcpy(&infoW,&info, sizeof(info)); +memcpy(&infoW, info, sizeof(*info)); Should probably use direct struct copying instead: infoW = *info; Vitaliy.

Re: [2/5] msxml3: Remove appendChild() forward (try2)

2011-02-23 Thread Jacek Caban
On 2/23/11 1:27 PM, Nikolay Sivov wrote: On 2/23/2011 15:25, Jacek Caban wrote: On 2/23/11 1:21 PM, Nikolay Sivov wrote: -TRACE("(%p)->(%p %p)\n", This, newChild, outNewChild); - -hr = IXMLDOMNode_get_nodeType(newChild,&type); +hr = IXMLDOMNode_get_nodeType(child,&type); if(FA

Re: [2/5] msxml3: Remove appendChild() forward (try2)

2011-02-23 Thread Nikolay Sivov
On 2/23/2011 15:25, Jacek Caban wrote: On 2/23/11 1:21 PM, Nikolay Sivov wrote: -TRACE("(%p)->(%p %p)\n", This, newChild, outNewChild); - -hr = IXMLDOMNode_get_nodeType(newChild,&type); +hr = IXMLDOMNode_get_nodeType(child,&type); if(FAILED(hr) || type == NODE_ATTRIBUTE) { -

Re: [2/5] msxml3: Remove appendChild() forward (try2)

2011-02-23 Thread Jacek Caban
On 2/23/11 1:21 PM, Nikolay Sivov wrote: -TRACE("(%p)->(%p %p)\n", This, newChild, outNewChild); - -hr = IXMLDOMNode_get_nodeType(newChild,&type); +hr = IXMLDOMNode_get_nodeType(child,&type); if(FAILED(hr) || type == NODE_ATTRIBUTE) { -if(outNewChild) *outNewChild = NULL

Re: [1/5] msxml3: Remove forward to removeChild() method for nodes

2011-02-23 Thread Nikolay Sivov
On 2/23/2011 03:33, Nikolay Sivov wrote: Remove forward to removeChild() method for nodes Ignore that please, I'll resend all 5 patches soon.

Coverity Scans Revived

2011-02-23 Thread Amine Khaldi
Hello folks, Recently we (myself and Urias from Haiku) have been working on getting the coverity scans up and running again. I'm happy to announce that we succeeded ! :) I submitted a scan and the results are up online. I'll submit further scans when necessary, like it's already done with cl

Re: kernel32/tests: remove win9x hacks (try 2)

2011-02-23 Thread Damjan Jovanovic
On Wed, Feb 23, 2011 at 11:38 AM, Austin English wrote: > -- > -Austin > > > > So test.winehq.org doesn't test Win9x any more, but why are we throwing away perfectly good Win9x tests that took years to get in?

Re: kernel32/tests: remove win9x hacks

2011-02-23 Thread Austin English
On Wed, Feb 23, 2011 at 01:32, Paul Vriens wrote: > On 02/23/2011 10:15 AM, Austin English wrote: >> >>      SetLastError(0xdeadbeef); >>      ret = GetFullPathNameW(NULL, 0, NULL, NULL); > > I think you can get rid of the above two as well as they are merely used to > trigger the ERROR_CALL_NOT_I

Re: kernel32/tests: remove win9x hacks

2011-02-23 Thread Paul Vriens
On 02/23/2011 10:15 AM, Austin English wrote: SetLastError(0xdeadbeef); ret = GetFullPathNameW(NULL, 0, NULL, NULL); I think you can get rid of the above two as well as they are merely used to trigger the ERROR_CALL_NOT_IMPLEMENTED. -is_win9x = !ret&& GetLastError() == ERRO