Re: RFC: Patch to change what sets the is_win9x in riched20/tests

2011-02-21 Thread Paul Vriens
On 02/22/2011 01:21 AM, James McKenzie wrote: All: Upon examining other test code that creates a variable called is_win9x, I realized that using get_version and comparing it to a fixed value may not be best for the riched20 tests and have attached a proposed change to how this variable is set. I

RFC: Patch to change what sets the is_win9x in riched20/tests

2011-02-21 Thread James McKenzie
All: Upon examining other test code that creates a variable called is_win9x, I realized that using get_version and comparing it to a fixed value may not be best for the riched20 tests and have attached a proposed change to how this variable is set. It uses a called function, lstrcmpW and if

Apologies to the List

2011-02-21 Thread James McKenzie
First, my tirade was not intended to be as such. I wanted to pull the patch because it was incorrect and I did not want anyone else working on it while I silently trimmed it and made it better. Second, I realize this has affected my 'Jeremy White' score. I hope that AJ understands why the code

Re: fix sharing handling for CreateFile

2011-02-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9411 Your paranoid android.

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

2011-02-21 Thread Rico Schüller
Am 21.02.2011 20:19, schrieb Misha Koshelev: Thanks Rico. Still trying to investigate this further. Perhaps, if you have any more hints as to how you arrived at this magical value, much appreciated. I got to this value by running the attached test patch applied after yours. You probably may

Re: Two enhancement requests for winetricks

2011-02-21 Thread Dan Kegel
On Wed, Jun 9, 2010 at 6:03 AM, Dan Kegel wrote: > On Wed, Jun 9, 2010 at 3:03 AM, Octavian Voicu > wrote: >> If you implement a status feature for every trick, you can change the >> main UI into a list of checkboxes, with the installed tricks already >> ticked. > > Right, of course.  I had even

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

2011-02-21 Thread Misha Koshelev
2011/2/20 Rico Schüller : > Hi, > > I have a small hint to the D3DXFloat32To16Array function. It seems that some > values are handled in some other way. > > A small test: >        D3DXFLOAT16 res; >        union p >        { >            float f; >            DWORD d; >        } x; > >        x.d =

Re: [PATCH 2/2] jscript: Added more uninitialization tests

2011-02-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9399 Your paranoid android.

Re: Valgrind --malloc-fill=A5 --free-fill=DE crashes Wine

2011-02-21 Thread Maarten Lankhorst
Hi Joerg, Op 21-02-11 12:26, joerg-cyril.hoe...@t-systems.com schreef: Hi, I used to run Valgrind with the additional options --malloc-fill=A5 --free-fill=DE around Wine 1.2 times. Now I retried it and it crashes Wine 1.3.13 and 1.3.14 (it fails to load kernel32.dll). It turns out that malloc-

Re: ws2_32: make gethostbyname fail if WSAStartup was not called before

2011-02-21 Thread Alexandre Julliard
Alexandre Goujon writes: > @@ -1104,6 +1106,7 @@ int WINAPI WSAStartup(WORD wVersionRequested, LPWSADATA > lpWSAData) > /* don't do anything with lpWSAData->lpVendorInfo */ > /* (some apps don't allocate the space for this field) */ > > +WSAStartup_called = TRUE; > TRACE("su

Re: gdiplus: Implement in-memory font-storage

2011-02-21 Thread Vincent Povirk
I approve of this product and/or service. On Mon, Feb 21, 2011 at 3:54 AM, Maarten Lankhorst wrote: > --- > > > >

Re: server: Fix compilation on systems with a two-argument sched_setaffinity prototype.

2011-02-21 Thread Alexandre Julliard
Andrew Nguyen writes: > My motivation was to determine the reason that the reporter of bug 26088 > (http://bugs.winehq.org/show_bug.cgi?id=26088) felt the need to compile > Wine configured with --without-pthread, which doesn't seem to be > something anyone should be doing. CentOS 3 seemed to be a

Re: msxml3: Assign the IBindStatusCallback as soon as it created.

2011-02-21 Thread Jacek Caban
On 2/18/11 10:24 AM, Alistair Leslie-Hughes wrote: Hi, This stops a crash in httprequest_get_responseText, when running from a webpage since "This->bsc" was NULL. Tests, please. Jacek

Valgrind --malloc-fill=A5 --free-fill=DE crashes Wine

2011-02-21 Thread Joerg-Cyril.Hoehle
Hi, I used to run Valgrind with the additional options --malloc-fill=A5 --free-fill=DE around Wine 1.2 times. Now I retried it and it crashes Wine 1.3.13 and 1.3.14 (it fails to load kernel32.dll). It turns out that malloc-fill is harmless, -free-fill causes havoc currently. Am I the only one us

Re: server: Fix compilation on systems with a two-argument sched_setaffinity prototype.

2011-02-21 Thread Andrew Nguyen
On 02/21/2011 04:43 AM, Michael Stefaniuc wrote: > Hello Andrew! > > Andrew Nguyen wrote: >> This lets Wine compile successfully on CentOS 3. > CentOS 3? Alexandre was bitching about RHEL 5 being "prediluvian" ... > RHEL 3 has a 2.4.21 based kernel, is over 7 years old and EOL. I'm not > sure it i

Re: mshtml: Implement IHTMLAnchorElement get/put target

2011-02-21 Thread Jacek Caban
On 2/18/11 9:54 AM, Alistair Leslie-Hughes wrote: static HRESULT WINAPI HTMLAnchorElement_get_target(IHTMLAnchorElement *iface, BSTR *p) { HTMLAnchorElement *This = impl_from_IHTMLAnchorElement(iface); -FIXME("(%p)->(%p)\n", This, p); -return E_NOTIMPL; +nsAString target_st

Re: msxml3: Add IObjectWithSite support to IXMLHttpRequest

2011-02-21 Thread Jacek Caban
On 2/17/11 10:47 AM, Alistair Leslie-Hughes wrote: Hi, Changelog: msxml3: Add IObjectWithSite support to IXMLHttpRequest More tests, please. Jacek

Re: server: Fix compilation on systems with a two-argument sched_setaffinity prototype.

2011-02-21 Thread Michael Stefaniuc
Hello Andrew! Andrew Nguyen wrote: > This lets Wine compile successfully on CentOS 3. CentOS 3? Alexandre was bitching about RHEL 5 being "prediluvian" ... RHEL 3 has a 2.4.21 based kernel, is over 7 years old and EOL. I'm not sure it is worth spending the effort to make current Wine compile and r