Re: comctl32/tests: Add casts to avoid two comparisons of different int types.

2011-02-15 Thread Gerald Pfeifer
On Sun, 13 Feb 2011, Janne Hakonen wrote: > Actually, now with your change you are comparing ULONG_PTR to ULONG. > With 64 bit binary the left side of comparison is a 64 bit pointer and > right side is 32 bit value. Thanks, Janne. I have adjusted, tested and resubmitted the first hunk of the p

Re: Anyone using Wine D3D under Parallels?

2011-02-15 Thread Misha Koshelev
On Tue, Feb 15, 2011 at 6:50 PM, Henri Verbeet wrote: > On 15 February 2011 21:37, Misha Koshelev wrote: >> and noticed that although glxinfo reports: >> misha@ubuntu:~/.wine/drive_c/Program Files/Tag$ glxinfo | grep -i render >> direct rendering: Yes >> OpenGL renderer string: Parallels using NV

Re: [PATCH] Implement software DXT1 compression

2011-02-15 Thread Henri Verbeet
I haven't investigated very closely, but my impression is that you want to use libsquish. I'm not sure if it has C bindings, or if the API is entirely right for what we need, but maybe they accept patches.

Re: Anyone using Wine D3D under Parallels?

2011-02-15 Thread Henri Verbeet
On 15 February 2011 21:37, Misha Koshelev wrote: > and noticed that although glxinfo reports: > misha@ubuntu:~/.wine/drive_c/Program Files/Tag$ glxinfo | grep -i render > direct rendering: Yes > OpenGL renderer string: Parallels using NVIDIA GeForce GT 330M OpenGL Engine > Is that a 32-bit or 64-b

valgrind results - now with better debug info

2011-02-15 Thread Austin English
Howdy all, I've added a few more suppressions, and after a suggestion by Nikolay, added some debugging symbols: austin@debian:~/src/winezeug/valgrind$ dpkg -l | grep dbg ii cups-dbg 1.4.5-2 Common UNIX Printing System(tm) - debugging symbols ii libc6-dbg

Re: D3DXCreateTorus patch... thoughts?

2011-02-15 Thread Misha Koshelev
On Sun, Feb 13, 2011 at 11:37 PM, David Adam wrote: > Here is  cool link to show what D3DXCreateTorus does: > http://www.xmission.com/~legalize/book/snippets/rt_D3DXSphere.zip > > A+ > > David > Fixed small typo in spec file. Thank you Misha From fdb0abe017a084194ec70636b2c24de063112569 Mon Sep

Re: Re: [PATCH] Implement software DXT1 compression

2011-02-15 Thread alberto
Hi Stefan. I'm not really into opengl internals, so I think the best solution for now is to implement 1), and give complete support when the blitting code will be in a better shape. Would this be okay? if (!context->valid) { context_release(context); FIXME("No gl context, c

Anyone using Wine D3D under Parallels?

2011-02-15 Thread Misha Koshelev
I am trying some simple patches for: http://bugs.winehq.org/show_bug.cgi?id=24642 and noticed that although glxinfo reports: misha@ubuntu:~/.wine/drive_c/Program Files/Tag$ glxinfo | grep -i render direct rendering: Yes OpenGL renderer string: Parallels using NVIDIA GeForce GT 330M OpenGL Engine

Re: [PATCH] Implement software DXT1 compression

2011-02-15 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 15.02.2011 um 14:39 schrieb albe...@mattea.info: > Good idea. This new patch implements this approach. It seems to be working > perfectly at least with the nvidia blob. It is also much smaller than the > previous one, and doesn't require hacks like

Re: [website] Turn on gzip compression

2011-02-15 Thread Jeremy Newman
Actually, a better way to accomplish this is to add: php_flag zlib.output_compression On to the .htaccess file. I'm a little surprised it was not there already. -N On 02/15/2011 01:02 PM, André Hentschel wrote: First make sure that works with your server... --- site |3 +++ 1 files cha

Re: [PATCH 3/4] urlmon: Properly handle BINDSTATUS_BEGINDOWNLOADDATA.

2011-02-15 Thread Janne Hakonen
On 2/15/11 5:13 PM, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDeta

Re: [1/2] winex11.drv: Add PS_USERSTYLE support to pens (take 2)

2011-02-15 Thread Alexandre Julliard
Daniel writes: > @@ -54,11 +56,13 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE *physDev, > HPEN hpen ) > elp = HeapAlloc( GetProcessHeap(), 0, size ); > > GetObjectW( hpen, size, elp ); > -/* FIXME: add support for user style pens */ > + > logpen.lopnStyle

Re: [PATCH 3/4] urlmon: Properly handle BINDSTATUS_BEGINDOWNLOADDATA.

2011-02-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9273 Your paranoid android.

Re: [PATCH 3/4] urlmon: Properly handle BINDSTATUS_BEGINDOWNLOADDATA.

2011-02-15 Thread Jacek Caban
On 2/15/11 5:13 PM, Marvin wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails

Re: [PATCH 2/4] urlmon: Read remaining protocol data if report_data was called after binding finished.

2011-02-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9272 Your paranoid android.

Re: [PATCH] Fixed several links in the documentation...

2011-02-15 Thread Alexandre Julliard
m...@mtew.isa-geek.net writes: > @@ -204,7 +204,7 @@ int CDECL MSVCRT__chdir(const char * newdir) > /* > * _wchdir (MSVCRT.@) > * > - * Unicode version of _chdir. > + * Unicode version of MSVCRT__chdir. You don't w

Re: gdi32: Fixed GetDIBits for top-down bitmaps (try 2).

2011-02-15 Thread Alexandre Julliard
Jack Edmonds writes: > gdi32/dib.c: Reversed source bitmap pointer instead of destination > bitmap pointer. > Removed check for destination bitmap height when > determining whether to copy the source bitmap upside down. > gdi32/tests/bitmap.c: Added a test for cop

Re: [3/5] msxml3/xsl: Basic put_input() method for IXSLProcessor

2011-02-15 Thread Nikolay Sivov
On 2/15/2011 18:53, Jacek Caban wrote: Hi Nikolay, On 2/14/11 9:04 PM, Nikolay Sivov wrote: Basic put_input() method for IXSLProcessor +IXMLDOMNode *old_input = This->input; +HRESULT hr; -FIXME("(%p): stub\n", This); -return E_NOTIMPL; +TRACE("(%p)->(type=%d)\n", This, V

Re: [4/5] msxml3/xsl: Store output stream for processor

2011-02-15 Thread Jacek Caban
Hi Nikolay, On 2/14/11 9:04 PM, Nikolay Sivov wrote: + case VT_UNKNOWN: +hr = IUnknown_QueryInterface(V_UNKNOWN(&output),&IID_IStream, (void**)&This->output); +break; You leak This->output here. Jacek

Re: [3/5] msxml3/xsl: Basic put_input() method for IXSLProcessor

2011-02-15 Thread Jacek Caban
On 2/15/11 4:53 PM, Jacek Caban wrote: Hi Nikolay, On 2/14/11 9:04 PM, Nikolay Sivov wrote: Basic put_input() method for IXSLProcessor +TRACE("(%p)->(type=%d)\n", This, V_VT(&input)); I missed it in my previous mail, but we have debugstr_variant for this in msxml3 now. Jacek

Re: [3/5] msxml3/xsl: Basic put_input() method for IXSLProcessor

2011-02-15 Thread Jacek Caban
Hi Nikolay, On 2/14/11 9:04 PM, Nikolay Sivov wrote: Basic put_input() method for IXSLProcessor +IXMLDOMNode *old_input = This->input; +HRESULT hr; -FIXME("(%p): stub\n", This); -return E_NOTIMPL; +TRACE("(%p)->(type=%d)\n", This, V_VT(&input)); + +/* try IXMLDOMNode

Re: Re: [PATCH] Implement software DXT1 compression

2011-02-15 Thread alberto
> An idea that was proposed before was to delegate the conversion (and the > patents burden) to the OpenGL drivers, something like using > glCompressedTexImage2D() / glGetCompressedTexImage(). Not sure > whether there are hidden issues with that approach (except, well, requiring > an OpenGL driver

Re: [1/4] mshtml: Ignore IActiveScript interface for IXMLHTTPRequest (resend)

2011-02-15 Thread Alistair Leslie-Hughes
Hi Jacek, On 14/02/2011 9:48 PM, Jacek Caban wrote: On 2/14/11 10:03 AM, Alistair Leslie-Hughes wrote: Changelog: mshtml: Ignore IActiveScript interface for IXMLHTTPRequest mshtml? + else if ( IsEqualGUID( riid,&IID_IActiveScript)) + { + TRACE("(%p)->(IID_IActiveScript %p) returning NULL\n",

Re: [1/2] winex11.drv: Add PS_USERSTYLE support to pens (take 2)

2011-02-15 Thread Daniel
OK, actually it looks like the problem is already in X11DRV_SelectPen and is unlikely to occur, so my patches are good. Still, I'm thinking that if GetObjectW fails (http://source.winehq.org/source/dlls/winex11.drv/pen.c#L45) then we should immediately exit the function returning zero rather than