Re: [1/2] winex11.drv: Add PS_USERSTYLE support to pens (take 2)

2011-02-14 Thread Daniel
grr, please disregard previous patches. I've discovered a problem that can lead to use of un-initialized values. Daniel On 02/15/2011 01:09 AM, Daniel wrote: > Clean up per Vitaliy's direction. Also found a FIXME comment that needed > to be removed. > > Daniel > > >

Re: gdi32: correct substitutions (take 2)

2011-02-14 Thread Dmitry Timoshkov
Rafał Mużyło wrote: > Corrected version of the previous patch. > This time I'm not adding a new helper function, just putting it in one > place. > Corrections: > - as oppossed to get_font_subst, reverse check can have more than one > result, so changed to adjust all of them > - just in case a->

Re: Re: [PATCH] Implement software DXT1 compression

2011-02-14 Thread Matteo Bruni
2011/2/14 : > Hi Stefan, thanks for your answer. I've checked the nvidia texture tools > but, sadly, I think it's impossible to use them in wine: while they have c > bindings, those bindings lack the essential function > nvttSetOutputOptionsOutputHandler(NvttOutputOptions * outputOptions, > nvttOu

Re: wine is passing make test again :-)

2011-02-14 Thread Alexandre Julliard
Juan Lang writes: >> Frankly, I'm a bit surprised and disappointed to see that people are not >> taking responsibility for fixing failures they introduced in tests. I don't >> expect to have time to clean up after them for the next month or so. > > Hopefully, if we can get the tests passing as a

Re: Re: [PATCH] Implement software DXT1 compression

2011-02-14 Thread alberto
Hi Stefan, thanks for your answer. I've checked the nvidia texture tools but, sadly, I think it's impossible to use them in wine: while they have c bindings, those bindings lack the essential function nvttSetOutputOptionsOutputHandler(NvttOutputOptions * outputOptions, nvttOutputHandler outputHandl

Re: [PATCH] Implement software DXT1 compression

2011-02-14 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 14.02.2011 um 16:50 schrieb albe...@mattea.info: > I would also like some feedback about > the patent situation, e.g. if the patch can be mainlined as it is or if it > would be better to load libtxc_dxtn directly at runtime. I'm afraid neither solu

Re: wine is passing make test again :-)

2011-02-14 Thread Juan Lang
> Frankly, I'm a bit surprised and disappointed to see that people are not > taking responsibility for fixing failures they introduced in tests. I don't > expect to have time to clean up after them for the next month or so. Hopefully, if we can get the tests passing as a more normal occurrence, we

Re: wine is passing make test again :-)

2011-02-14 Thread Greg Geldorp
> From: Andre Hentschel > and now without the 9x stuff the result page looks better again, someone > just need to fix his user32 test :) Frankly, I'm a bit surprised and disappointed to see that people are not taking responsibility for fixing failures they introduced in tests. I don't expect to ha

Re: kernel32/process: Add stderr redirection for native linux programs started from windows program

2011-02-14 Thread Stefan Leichter
Am Montag 14 Februar 2011, 07:13:21 schrieb Igor Egorov: > A week ago I submitted a patch for stderr redirection > (http://www.winehq.org/pipermail/wine-patches/2011-February/098578.html), > is there still something wrong with it? Will it be accepted? If you look at http://source.winehq.org/patche

[PATCH] Implement software DXT1 compression

2011-02-14 Thread alberto
This patch adds conversion functions from WINED3DFMT_B8G8R8_UNORM, WINED3DFMT_B5G5R5A1_UNORM and WINED3DFMT_B5G5R5X1_UNORM to WINED3DFMT_DXT1. It uses code slighty modified from libtxc_dxtn. It fixes at least LEGO Stunt Rally, probably other games too. I didn't implement dxt3 and dxt5 since I haven

Re: Austin English : shell32/tests: Don't check return values inside of if(0) ( LLVM/Clang).

2011-02-14 Thread Michael Stefaniuc
Charles, Charles Davis wrote: > Austin, > > Static analyzer checks for unreachable assignments (like the ones that > were removed in this patch) were turned off in Clang trunk recently (as > of r125415). Looks like Clang was wrong ;). the ones that Austin removed are still pointless. The code is

Re: Austin English : shell32/tests: Don't check return values inside of if(0) ( LLVM/Clang).

2011-02-14 Thread Charles Davis
Austin, Static analyzer checks for unreachable assignments (like the ones that were removed in this patch) were turned off in Clang trunk recently (as of r125415). Looks like Clang was wrong ;). Chip

Re: winex11.drv: Add PS_USERSTYLE support to pens

2011-02-14 Thread Vitaliy Margolen
On 02/14/2011 03:55 AM, Daniel wrote: Hello all. This only covers the screen. Support still needs to be added to printers. + case PS_USERSTYLE: { +for(i = 0; i < physDev->pen.dash_len ; i++) { Please follow file style - curly braces on separate line. No braces for single lin

Re: D3DXCreateTorus patch... thoughts?

2011-02-14 Thread David Adam
Here is cool link to show what D3DXCreateTorus does: http://www.xmission.com/~legalize/book/snippets/rt_D3DXSphere.zip A+ David

Re: kernel32: Implement and test GetVolumePathNamesForVolumeName.

2011-02-14 Thread Alexandre Julliard
Hans Leidekker writes: > BOOL WINAPI GetVolumePathNamesForVolumeNameW(LPCWSTR volumename, LPWSTR > volumepathname, DWORD buflen, PDWORD returnlen) > { > -FIXME("(%s, %p, %d, %p), stub!\n", debugstr_w(volumename), > volumepathname, buflen, returnlen); > -SetLastError(ERROR_CALL_NOT_IMP

Re: [4/4] mshtml: Add IDispatchEx support to IXMLHTTPRequest

2011-02-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9250 Your paranoid android.

Re: [1/4] mshtml: Ignore IActiveScript interface for IXMLHTTPRequest (resend)

2011-02-14 Thread Jacek Caban
On 2/14/11 10:03 AM, Alistair Leslie-Hughes wrote: Changelog: mshtml: Ignore IActiveScript interface for IXMLHTTPRequest mshtml? +else if ( IsEqualGUID( riid,&IID_IActiveScript)) +{ +TRACE("(%p)->(IID_IActiveScript %p) returning NULL\n", This, ppvObject); +*ppvObj