Re: [PATCH 2/2] msvcrt: Implement _strnicoll.

2011-02-11 Thread Eryk Wieliczko
Please reject this set as it is obviously wrong. -- Eryk Wieliczko 2011/2/11 Dmitry Timoshkov : > Eryk Wieliczko wrote: > >>  /* >> + *           _strnicoll (MSVCRT.@) >> + */ >> +int CDECL MSVCRT__strnicoll(const char* str1, co

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-11 Thread David Laight
On Fri, Feb 11, 2011 at 11:16:55PM +0100, Stefan D?singer wrote: > Its just that this function goes to great lengths to > make sure it doesn't rely on the actual encoding that it is annoying that we > have to give it up for detecting the sign of zeroes. In that case why not? int is_neq_z(d

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-11 Thread Stefan Dösinger
Am Freitag 11 Februar 2011, 22:39:05 schrieb David Laight: > The 'usual' non-IEEE fp systems are vax (you probably can't put enough > memory in a vax to run wine!) and some arm systems where the two 32bit > words of a double aren't stored in the expected order! I don't expect to find any non-IEEE s

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-11 Thread David Laight
On Fri, Feb 11, 2011 at 10:20:10PM +0100, Stefan D?singer wrote: > Am Freitag 11 Februar 2011, 20:48:58 schrieb Misha Koshelev: > > > +if (*((unsigned int *)&in) == 0x) return 0x; > > +if (*((unsigned int *)&in) == 0x8000) return 0x8000; > Thinking about it, there's somethi

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-11 Thread Stefan Dösinger
Am Freitag 11 Februar 2011, 20:48:58 schrieb Misha Koshelev: > +if (*((unsigned int *)&in) == 0x) return 0x; > +if (*((unsigned int *)&in) == 0x8000) return 0x8000; Thinking about it, there's something about this line that is not so nice: It relies on the actual encoding o

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-11 Thread Misha Koshelev
On Fri, Feb 11, 2011 at 3:58 PM, Stefan Dösinger wrote: > Am Freitag 11 Februar 2011, 20:48:58 schrieb Misha Koshelev: >> Stefan et al: >> >> Thank you. How about this guy? > >> +    if (exp > 31) >> +    { >> +        /* too big */ >> +        ret = 0x7fff; /* INF */ >> +    } > That's not INF, t

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-11 Thread Stefan Dösinger
Am Freitag 11 Februar 2011, 20:48:58 schrieb Misha Koshelev: > Stefan et al: > > Thank you. How about this guy? > +if (exp > 31) > +{ > +/* too big */ > +ret = 0x7fff; /* INF */ > +} That's not INF, that is NaN. Or, if you don't read it as a special value the highest

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-11 Thread Misha Koshelev
On Wed, Feb 9, 2011 at 4:40 AM, Stefan Dösinger wrote: > Am Dienstag 08 Februar 2011, 22:45:52 schrieb Misha Koshelev: >> I don't have msvc. Please suggest how I can check this. Thank you. Yours >> Misha > According to http://www.johndcook.com/math_h.html it exists, but has a > different name. So

Re: [rfc] dsound: decrease sound latency

2011-02-11 Thread Austin English
On Fri, Feb 11, 2011 at 01:43, Maarten Lankhorst wrote: >  Hi all, > > Please test this and let me know if it's causing any problems in sound > playback, preferably with media applications and games, any feedback would > be appreciated. The patch won't fix existing problems, it should just > decre

Re: iphlpapi: Hint what to do when icmp does not work

2011-02-11 Thread Charles Davis
On 2/11/11 11:31 AM, Janne Hakonen wrote: > Maybe this information could be added to http://wiki.winehq.org/FAQ > instead? Judging from wine-users, nobody bothers to read that, at least until someone tells them to. For that matter, nobody bothers to read the logs either. It's kinda sad, actually.

Re: iphlpapi: Hint what to do when icmp does not work

2011-02-11 Thread Janne Hakonen
Maybe this information could be added to http://wiki.winehq.org/FAQ instead? Janne -Original Message- From: Charles Davis Sent: Friday, February 11, 2011 8:17 PM To: wine-devel@winehq.org Subject: Re: iphlpapi: Hint what to do when icmp does not work On 2/11/11 11:12 AM, André Hentsch

Re: iphlpapi: Hint what to do when icmp does not work

2011-02-11 Thread Charles Davis
On 2/11/11 11:12 AM, André Hentschel wrote: > Otherwise the user might try running wine as root or doesn't know that this > error can be easily fixed when needed. > --- > dlls/iphlpapi/icmp.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/iphlpapi/icmp.c b/dll

Re: [PATCH 01/13] dsound: New sample rate converter core functions.

2011-02-11 Thread Juan Lang
> It looks like introducing bigger patches is a kind of mission impossible. That's not a bad analogy. Your mission, Krzysztof, should you choose to accept it, to improve sound resampling in Wine :) --Juan

Re: Resend: Who does c2man?

2011-02-11 Thread Juan Lang
> It looks like Jon Griffiths is the one I need to contact. Is he still > around? He's often disconnected, but he does respond to email from time to time. --Juan

Re: Resend: Who does c2man?

2011-02-11 Thread Max TenEyck Woodbury
On 02/11/2011 12:20 PM, GOUJON Alexandre wrote: On 02/11/2011 05:19 PM, Max TenEyck Woodbury wrote: I have just been going over tools/c2man and have a fair number of questions about it. You can ask them here. This is why wine-devel exists. There is also IRC (http://wiki.winehq.org/IRC) But ke

Re: [PATCH 01/13] dsound: New sample rate converter core functions.

2011-02-11 Thread Krzysztof Nikiel
2011/2/11 : > Hi, > > The question how to split is interesting. I haven't found the answer > about how to split my future MIDI player rewrite either. Like yours, > it will replace old functions with something new. It looks like introducing bigger patches is a kind of mission impossible. > > So

Re: CD handling on MacOS - the big picture?

2011-02-11 Thread Ken Thomases
On Feb 11, 2011, at 10:23 AM, wrote: > Mixed CDs occur in some games, but some audio CDs > contain "bonus content" as well. > > On MacOS, mixed CDs are mounted as two volumes > - the audio part, > - the data/binary section > not unlike Gnome which also displays 2 disc icons on the desktop. >

Re: Resend: Who does c2man?

2011-02-11 Thread GOUJON Alexandre
On 02/11/2011 05:19 PM, Max TenEyck Woodbury wrote: I have just been going over tools/c2man and have a fair number of questions about it. You can ask them here. This is why wine-devel exists. There is also IRC (http://wiki.winehq.org/IRC) But keep in mind that everyone is very busy. So ask some

[PATCH 01/13] dsound: New sample rate converter core functions.

2011-02-11 Thread Joerg-Cyril.Hoehle
Hi, The question how to split is interesting. I haven't found the answer about how to split my future MIDI player rewrite either. Like yours, it will replace old functions with something new. Some guidelines are: - Each patch should be self contained and a logical unit, e.g. + a bug fix, pos

Re: [PATCH 01/13] dsound: New sample rate converter core functions.

2011-02-11 Thread Krzysztof Nikiel
2011/2/11 Maarten Lankhorst : >> Well, previous version of this patch was rejected as "needs >> splitting", it's basically too big to be send as a single patch. It >> can be applied as several smaller chunks or rejected as a whole. I >> don't think there is any other option. > > Thanks for looking

CD handling on MacOS - the big picture?

2011-02-11 Thread Joerg-Cyril.Hoehle
Hi, the last years have seen individual patches by K. Thomases and C. Davis to Mac OSX' CD handling, but I don't see the big picture. Mixed CDs occur in some games, but some audio CDs contain "bonus content" as well. On MacOS, mixed CDs are mounted as two volumes - the audio part, - the data/b

Resend: Who does c2man?

2011-02-11 Thread Max TenEyck Woodbury
I have just been going over tools/c2man and have a fair number of questions about it. I can probably dig some of the answers out myself, but it would probably go faster and raise less fuss if I can talk to the person (people) who have worked on it previously. Please send me email with contact inf

Re: [PATCH 01/13] dsound: New sample rate converter core functions.

2011-02-11 Thread Maarten Lankhorst
Hi Krzysztof, Op 11-02-11 12:16, Krzysztof Nikiel schreef: 2011/2/11 Dmitry Timoshkov: Krzysztof Nikiel wrote: You can't send Makefile changes separately from added/removed files, a patch should not add dead code. Could you explain "dead code", all 13 parts need to be applied, otherwise th

Re: [PATCH 01/13] dsound: New sample rate converter core functions. (resend)

2011-02-11 Thread Krzysztof Nikiel
2011/2/11 Vitaliy Margolen : > On 02/11/2011 04:34 AM, Krzysztof Nikiel wrote: >> >> +typedef double sample_t; >> >> +static inline sample_t getsample(LPBYTE buf, INT bps) >> +{ >> +        tmp = ((sample_t) (*((BYTE *) buf)) - 128.0); > > No need to type cast. "buf" already a pointer to the BYTE.

Testmail

2011-02-11 Thread Detlef Riekenberg
Hi Just a test, as my patches do not show up in the mail archive. Detlef ___ WEB.DE DSL Doppel-Flat ab 19,99 €/mtl.! Jetzt mit gratis Handy-Flat! http://produkte.web.de/go/DSL_Doppel_Flatrate/2

Re: [PATCH] dsound: More accurate volume calculation.

2011-02-11 Thread Krzysztof Nikiel
Sure, I'm working on it. 2011/2/11 Vitaliy Margolen : > On 02/11/2011 02:38 AM, Krzysztof Nikiel wrote: >> >> I have changed this when creating the new resampler patch but it's not >> really related to the main patchset. > > The patch is wrapped. Please send it as attachment. Also please no HTML w

Re: [PATCH] dsound: More accurate volume calculation.

2011-02-11 Thread Vitaliy Margolen
On 02/11/2011 02:38 AM, Krzysztof Nikiel wrote: I have changed this when creating the new resampler patch but it's not really related to the main patchset. The patch is wrapped. Please send it as attachment. Also please no HTML when sending patches. Vitaliy

Re: [PATCH 01/13] dsound: New sample rate converter core functions. (resend)

2011-02-11 Thread Vitaliy Margolen
Nice job! If it will make Wine's sound better - it would be awesome. Haven't read the entire patch series. But few nit picks so far. On 02/11/2011 04:34 AM, Krzysztof Nikiel wrote: +typedef double sample_t; +static inline sample_t getsample(LPBYTE buf, INT bps) +{ +tmp = ((sample_t) (*

Re: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest

2011-02-11 Thread Nikolay Sivov
On 2/11/2011 15:56, Jacek Caban wrote: On 2/11/11 12:02 PM, Nikolay Sivov wrote: On 2/11/2011 13:30, Alistair Leslie-Hughes wrote: Hi, -- From: "Nikolay Sivov" Sent: Friday, February 11, 2011 9:27 PM To: "Alistair Leslie-Hughes" Cc: Subject: R

Re: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest

2011-02-11 Thread Jacek Caban
On 2/11/11 12:02 PM, Nikolay Sivov wrote: On 2/11/2011 13:30, Alistair Leslie-Hughes wrote: Hi, -- From: "Nikolay Sivov" Sent: Friday, February 11, 2011 9:27 PM To: "Alistair Leslie-Hughes" Cc: Subject: Re: msxml3: Ignore IActiveScript interfac

Re: [PATCH 01/13] dsound: New sample rate converter core functions. (resend)

2011-02-11 Thread Owen Rudge
It looks like it may be too big to be accepted. Anyway, I will try to resend it with 4 space indent for new files. Hopefully these patches won't get wrapped this time. Your patches still appear to be being wrapped by your mail client. Try sending them as an attachment instead of inline (i.e., u

Re: [PATCH 01/13] dsound: New sample rate converter core functions.

2011-02-11 Thread Krzysztof Nikiel
2011/2/11 Ricardo Filipe : > > > 2011/2/11 Krzysztof Nikiel >> >> 2011/2/11 Dmitry Timoshkov : >> > Krzysztof Nikiel wrote: >> > >> >> > You can't send Makefile changes separately from added/removed >> >> > files, a patch should not add dead code. >> >> >> >> Could you explain "dead code", all 13

Re: [PATCH 01/13] dsound: New sample rate converter core functions.

2011-02-11 Thread Ricardo Filipe
2011/2/11 Krzysztof Nikiel > 2011/2/11 Dmitry Timoshkov : > > Krzysztof Nikiel wrote: > > > >> > You can't send Makefile changes separately from added/removed > >> > files, a patch should not add dead code. > >> > >> Could you explain "dead code", all 13 parts need to be applied, > >> otherwise

Re: [PATCH 01/13] dsound: New sample rate converter core functions.

2011-02-11 Thread Krzysztof Nikiel
2011/2/11 Dmitry Timoshkov : > Krzysztof Nikiel wrote: > >> > You can't send Makefile changes separately from added/removed >> > files, a patch should not add dead code. >> >> Could you explain "dead code", all 13 parts need to be applied, >> otherwise the code will be broken. > > Wine should comp

Re: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest

2011-02-11 Thread Nikolay Sivov
On 2/11/2011 13:30, Alistair Leslie-Hughes wrote: Hi, -- From: "Nikolay Sivov" Sent: Friday, February 11, 2011 9:27 PM To: "Alistair Leslie-Hughes" Cc: Subject: Re: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest On 2/11/2011 12:25,

Re: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest

2011-02-11 Thread Alistair Leslie-Hughes
Hi, -- From: "Nikolay Sivov" Sent: Friday, February 11, 2011 9:27 PM To: "Alistair Leslie-Hughes" Cc: Subject: Re: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest On 2/11/2011 12:25, Alistair Leslie-Hughes wrote: Hi, On 11/02/2011

Re: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest

2011-02-11 Thread Nikolay Sivov
On 2/11/2011 12:25, Alistair Leslie-Hughes wrote: Hi, On 11/02/2011 8:12 PM, Nikolay Sivov wrote: On 2/11/2011 10:51, Alistair Leslie-Hughes wrote: Hi, Changelog: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest What's a purpose of this? To remove the FIXME from appearing in the

Re: [PATCH 01/13] dsound: New sample rate converter core functions.

2011-02-11 Thread Dmitry Timoshkov
Krzysztof Nikiel wrote: > High quality sample rate converter. > New code seems simplier and faster despite the big sound quality > improvement. > > This patchset only makes sense when applying all 13 parts. It looks like at least some patches got wrapped by your mailer. You can't send Makefile

[rfc] dsound: decrease sound latency

2011-02-11 Thread Maarten Lankhorst
Hi all, Please test this and let me know if it's causing any problems in sound playback, preferably with media applications and games, any feedback would be appreciated. The patch won't fix existing problems, it should just decrease the audio lag. As such I would prefer only to receive feedb

winspool.drv : Implement AbortPrinter() function

2011-02-11 Thread Loïc Maury
--- dlls/winspool.drv/info.c | 95 +- 1 files changed, 93 insertions(+), 2 deletions(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index e4a464a..f16914a 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -

Re: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest

2011-02-11 Thread Alistair Leslie-Hughes
Hi, On 11/02/2011 8:12 PM, Nikolay Sivov wrote: On 2/11/2011 10:51, Alistair Leslie-Hughes wrote: Hi, Changelog: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest What's a purpose of this? To remove the FIXME from appearing in the logs. Best Regards Alistair Leslie-Hughes

Re: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest

2011-02-11 Thread Nikolay Sivov
On 2/11/2011 10:51, Alistair Leslie-Hughes wrote: Hi, Changelog: msxml3: Ignore IActiveScript interface for IXMLHTTPRequest What's a purpose of this? Best Regards Alistair Leslie-Hughes