Re: avifil32: Skip tests when we couldn't create or open the AVI file

2011-02-10 Thread Juan Lang
> Nevertheless, I do think the case could happen again (not enough disk space > for instance). IMO, cases like this aren't worth worrying about. They're like out of memory conditions: sure, they can happen, but there's not much we can do about them. The disk space requirements of the tests aren

Re: avifil32: Skip tests when we couldn't create or open the AVI file

2011-02-10 Thread GOUJON Alexandre
On 02/11/2011 12:10 AM, Julius Schwartzenberg wrote: Is there a specific situation in which the file creation fails? I expected the temporary directory would always be writable when I created it like that. Maybe that is not a good assumption when writing tests though? I wrote the patch because

Re: [PATCH 2/2] msvcrt: Implement _strnicoll.

2011-02-10 Thread Dmitry Timoshkov
Eryk Wieliczko wrote: > /* > + * _strnicoll (MSVCRT.@) > + */ > +int CDECL MSVCRT__strnicoll(const char* str1, const char* str2, int digits) > +{ > +int res; > + > +res = strncmp(str1, str2, digits); > +if

.chm files for builtin programs?

2011-02-10 Thread Dan Kegel
Hi all, The native dxdiag uses a .chm file for its help system, so ours might as well, too. I see there's a .chm file checked in to git (in dlls/itss/tests). Any objection to checking a .chm file into programs/dxdiag, along with its source files and script to build it? I think there's an open sour

Re: ole32/tests: make sure to use a return value (LLVM/Clang) (2/3)

2011-02-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9189 Your paranoid android.

Re: avifil32: Skip tests when we couldn't create or open the AVI file

2011-02-10 Thread Julius Schwartzenberg
GOUJON Alexandre wrote: I know I sent this patch about two weeks ago but I thought it was pending because of the 1.3.13 release. So, does anyone has an idea how to make this patch applied in the current tree ? The context is that we don't fail when we couldn't create or open the AVI file. (I thi

Re: shell32/tests: make sure return values are used (LLVM/Clang) (4/7)

2011-02-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9177 Your paranoid android.

Re: msi/tests: make sure to use a return value (LLVM/Clang) (2/2)

2011-02-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9162 Your paranoid android.

Re: user32/tests: Add test for nested default Button in Dialogs

2011-02-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9151 Your paranoid android.

Re: avifil32: Skip tests when we couldn't create or open the AVI file

2011-02-10 Thread GOUJON Alexandre
On 01/30/2011 07:29 PM, Alexandre Goujon wrote: --- dlls/avifil32/tests/api.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/dlls/avifil32/tests/api.c b/dlls/avifil32/tests/api.c index 14ad4b4..c1ba878 100644 --- a/dlls/avifil32/tests/api.c +++ b/dlls/avif

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-10 Thread Misha Koshelev
On Thu, Feb 10, 2011 at 6:13 AM, Stefan Dösinger wrote: >> The brace goes in column 1 so that [[ and ]] work in vi. >> Putting the function name in column 1 lets you search for the >> definition using the anchored regexp ^function_name\> > Code style in Wine doesn't have anything to do with editor

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-10 Thread Stefan Dösinger
> The brace goes in column 1 so that [[ and ]] work in vi. > Putting the function name in column 1 lets you search for the > definition using the anchored regexp ^function_name\> Code style in Wine doesn't have anything to do with editors. The basic rule is that when you change existing code or ad

Re: [3/3] user32: SetParent() needs to map window rectangle to the new parent.

2011-02-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9136 Your paranoid android.