Re: rpcrt4/tests: remove a dead assignment (LLVM/Clang)

2011-02-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9120 Your paranoid android.

Re: rpcrt4/tests: remove a dead assignment (LLVM/Clang)

2011-02-09 Thread Austin English
On Wed, Feb 9, 2011 at 15:53, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot

Re: winex11.drv: map_window should honor iconic state

2011-02-09 Thread Alexandre Julliard
Alexander Lakhin writes: > +data->iconic = (new_style & WS_MINIMIZE) != 0; > + > if (!data->embedded) > { > update_net_wm_states( display, data ); > sync_window_style( display, data ); > wine_tsx11_lock(); > XMapWindow( display, data->whole_window

Re: ntdll: Increase buffer size for debugging functions

2011-02-09 Thread Alexandre Julliard
Maarten Lankhorst writes: > Since warn+debugstr takes user data increase and basically does > WARN("%s\n", msg); the buffer size is too small, increasing the size > makes the lord of the rings online launcher print messages to WARN > without crashing That's just hiding the bug. -- Alexandre Ju

Re: error message for ddraw

2011-02-09 Thread André Hentschel
Am 09.02.2011 08:20, schrieb David Adam: > When I test the following test > > rc = IDirectDraw_SetCooperativeLevel(lpDD, NULL, DDSCL_FULLSCREEN | > DDSCL_EXCLUSIVE | DDSCL_CREATEDEVICEWINDOW); > ok(rc==DDERR_INVALIDPARAMS, "Expected DDERR_INVALIDPARAMS, received > %x\n", rc); > > in my

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-09 Thread David Laight
On Tue, Feb 08, 2011 at 01:02:36PM +0800, Dmitry Timoshkov wrote: > > +static inline float float_16_to_32(const unsigned short *in) { > > ... Also placing a brace on its own line would follow the style > of other functions. The brace goes in column 1 so that [[ and ]] work in vi. Putting the fun

error message for ddraw

2011-02-09 Thread David Adam
When I test the following test rc = IDirectDraw_SetCooperativeLevel(lpDD, NULL, DDSCL_FULLSCREEN | DDSCL_EXCLUSIVE | DDSCL_CREATEDEVICEWINDOW); ok(rc==DDERR_INVALIDPARAMS, "Expected DDERR_INVALIDPARAMS, received %x\n", rc); in my vista box, I receive the following failing message ddrawm

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

2011-02-09 Thread Loïc Maury
Hello Mr.Eikum, On 09/02/11 16:30, Andrew Eikum wrote: On 02/09/2011 09:09 AM, Loïc Maury wrote: The indentation looks fine to me now. You've got an extra newline after the "if(printer->doc)" block and before the "else." The formatting on the TRACE statement is still bizarre. Fix the commas

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-09 Thread Misha Koshelev
On Wed, Feb 9, 2011 at 4:40 AM, Stefan Dösinger wrote: > Am Dienstag 08 Februar 2011, 22:45:52 schrieb Misha Koshelev: >> I don't have msvc. Please suggest how I can check this. Thank you. Yours >> Misha > According to http://www.johndcook.com/math_h.html it exists, but has a > different name. So

Patch 21026 superseded by patch 71118.

2011-02-09 Thread Max TenEyck Woodbury
No text.

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

2011-02-09 Thread Andrew Eikum
On 02/09/2011 09:09 AM, Loïc Maury wrote: The indentation looks fine to me now. You've got an extra newline after the "if(printer->doc)" block and before the "else." The formatting on the TRACE statement is still bizarre. Fix the commas and put it on just a couple of lines. No reason for one

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

2011-02-09 Thread Loïc Maury
Hello Mr.Le Cam On Tue, Feb 8, 2011 at 10:07 PM, Nicolas Le Cam wrote: > > > 2011/2/8 Loïc Maury > > >> Hello Mr.Timoshkov, >> >> Thank you for your reply. >> >>> Loīc Maury wrote: >>> >>> >>> After the various comments, I have modified the patch. >>> First of all set your tab size to 8,

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

2011-02-09 Thread Loïc Maury
Hello Mr.Eikum, Thank you for your reply. On 08/02/11 18:13, Andrew Eikum wrote: On 02/08/2011 10:48 AM, Loïc Maury wrote: First of all set your tab size to 8, and ask your editor to not use tabs at all. I have modified my editor, but I don't know if it 's correct now ? The indentation l

Re: [PATCH 2/5] d3dx9_36: Implemented ID3DXConstantTable_SetIntArray and ID3DXConstantTable_SetInt

2011-02-09 Thread Matteo Bruni
2011/2/9 Travis Athougies : > > On Feb 8, 2011, at 4:10 AM, Matteo Bruni wrote: > >>> +       /* We need the for loop, since we need to convert the integer to >>> a float */ >>> +        for (i = 0; i < count && i < desc.RegisterCount; i++) >>> +        { >>> +            row[0] = (float)n[i]; >>

Re: d3dx9_36: make sure return values are used (LLVM/Clang)

2011-02-09 Thread Matteo Bruni
hr = IDirect3DTexture9_GetLevelDesc(texture, 0, &desc); +ok(hr == D3D_OK, "D3DXCreateTexture returned %#x, expected %#x\n", hr, D3D_OK); Copy-paste error, it should be GetLevelDesc in the ok() message. :)

Re: user32: Add message tests for SetParent().

2011-02-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9096 Your paranoid android.

Re: d3dx9_36: Implement a few tests for D3DXCreateBox

2011-02-09 Thread Stefan Dösinger
Am Mittwoch 09 Februar 2011, 07:34:21 schrieb David Adam: > +wnd = CreateWindow("static", "d3dx9_test", 0, 0, 0, 0, 0, NULL, NULL, NULL, NULL); The class "static" doesn't work on Windows 7, I am afraid you'll need a proper window class. And I think a CreateWindow failure should count as test

Re: Wine and Summer of Code 2011

2011-02-09 Thread Stefan Dösinger
Count me in as potential mentor as well Am Dienstag 08 Februar 2011, 21:51:55 schrieb Eric Durbin: > On Tue, Feb 8, 2011 at 12:04 PM, Dan Kegel wrote: > > http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/ > > faqs#mentor_apply says projects can apply starting on Feb 28. >

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-09 Thread Stefan Dösinger
Am Dienstag 08 Februar 2011, 22:45:52 schrieb Misha Koshelev: > I don't have msvc. Please suggest how I can check this. Thank you. Yours > Misha According to http://www.johndcook.com/math_h.html it exists, but has a different name. So we'd need some wrapper around it in libwine. Maybe one exists