Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.

2011-02-08 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > This test is supposed to show the root of the problem with the test > > application attached to the bug 13951. It appears that the check performed > > by server/window.c,is_top_level_window() is not correct (which leads to > > a SetWindowPos() failure to set foregrou

Re: mshtml/tests: make sure return values are used (LLVM/Clang)

2011-02-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9073 Your paranoid android.

Re: secur32/tests: make sure a return value is used (LLVM/Clang)

2011-02-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9068 Your paranoid android.

Re: [PATCH 2/5] d3dx9_36: Implemented ID3DXConstantTable_SetIntArray and ID3DXConstantTable_SetInt

2011-02-08 Thread Travis Athougies
On Feb 8, 2011, at 4:10 AM, Matteo Bruni wrote: + /* We need the for loop, since we need to convert the integer to a float */ +for (i = 0; i < count && i < desc.RegisterCount; i++) +{ +row[0] = (float)n[i]; The cast is unneeded, and the comment above is

Re: comctl32/tests: Use a function instead of a macro for CheckSize test

2011-02-08 Thread Vitaliy Margolen
On 02/08/2011 04:45 PM, EG Galano wrote: This fixes the warnings: comctl32/tests/tab.c:525: warning: logical `&&' with non-zero constant will always evaluate as true comctl32/tests/tab.c:545: warning: logical `&&' with non-zero constant will always evaluate as true comctl32/tests/tab.c:568: warni

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-08 Thread Charles Davis
On 2/8/11 2:45 PM, Misha Koshelev wrote: > I don't have msvc. Please suggest how I can check this. By looking on MSDN. All the library functions that Visual C++ supports are documented there. Chip

Re: comctl32/tests: Use a function instead of a macro for CheckSize test

2011-02-08 Thread Nikolay Sivov
On 2/9/2011 02:45, EG Galano wrote: Main problem with that - you will lost ok() context in test output, line numbers will be always the same. Look like it's resolved in other places - a thin macro to pass a line number to a function and ok_(, ) test inside.

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.

2011-02-08 Thread Alexandre Julliard
Dmitry Timoshkov writes: > This test is supposed to show the root of the problem with the test > application attached to the bug 13951. It appears that the check performed > by server/window.c,is_top_level_window() is not correct (which leads to > a SetWindowPos() failure to set foreground window

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-08 Thread Misha Koshelev
I don't have msvc. Please suggest how I can check this. Thank you. Yours Misha On Feb 8, 2011 4:01 PM, "Stefan Dösinger" wrote: Am Dienstag 08 Februar 2011, 17:52:06 schrieb Misha Koshelev: > switch (fpclassify(in)) Is this portable? Does it work on msvc too?

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

2011-02-08 Thread Nicolas Le Cam
2011/2/8 Loïc Maury > > Hello Mr.Timoshkov, > > Thank you for your reply. > >> Loīc Maury wrote: >> >> >> After the various comments, I have modified the patch. >>> >> First of all set your tab size to 8, and ask your editor to not use tabs >> at all. >> > I have modified my editor, but I don't

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-08 Thread Stefan Dösinger
Am Dienstag 08 Februar 2011, 17:52:06 schrieb Misha Koshelev: > switch (fpclassify(in)) Is this portable? Does it work on msvc too? signature.asc Description: This is a digitally signed message part.

Re: Wine and Summer of Code 2011

2011-02-08 Thread Eric Durbin
On Tue, Feb 8, 2011 at 12:04 PM, Dan Kegel wrote: > > http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/faqs#mentor_apply > says projects can apply starting on Feb 28. > > In preparation, I moved the 2010 projects from > http://wiki.winehq.org/SummerOfCode > to > http://wik

Re: Wine and Summer of Code 2011

2011-02-08 Thread Austin English
On Tue, Feb 8, 2011 at 10:17, Juan Lang wrote: > Hi Dan, > >> Who's interested in mentoring this year?  And can y'all think of any >> fresh ideas for the suggested projects list, or ideas that should be >> retired? > > Isn't IUri implemented?  That idea looks like it could be retired. > > Also, th

Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases. (try 2)

2011-02-08 Thread Janne Hakonen
This test is safe, but it depends on the caller setting handle to some value other than INVALID_HANDLE_VALUE. I think it might be safer to have NotifyAddrChange set the handle value instead, and to mark the test todo_wine. I'm worried that some other app might assume that the call to NotifyAddrC

Re: Wine and Summer of Code 2011

2011-02-08 Thread Juan Lang
Hi Dan, > Who's interested in mentoring this year?  And can y'all think of any > fresh ideas for the suggested projects list, or ideas that should be > retired? Isn't IUri implemented? That idea looks like it could be retired. Also, the DOS VGA modes idea: how is that affected by the DOSBox in

Re: po: Update French translation

2011-02-08 Thread Frédéric Delanoy
2011/2/8 Paul Vriens > On 02/08/2011 05:28 PM, Frédéric Delanoy wrote: > >> #: avifil32.rc:27 >> +#, fuzzy >> > > Hi, > > Are you adding the 'fuzzy' on purpose? I think that the fuzzy ones are > ignored for translations: > > > http://source.winehq.org/git/wine.git/?a=commitdiff;h=1898f22ca5d2d79

Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases. (try 2)

2011-02-08 Thread Juan Lang
Hi Janne, +handle = NULL; +ZeroMemory(&overlapped, sizeof(overlapped)); +overlapped.hEvent = CreateEvent(NULL, FALSE, FALSE, NULL); +ret = gNotifyAddrChange(&handle, &overlapped); +ok(ret == ERROR_IO_PENDING, "NotifyAddrChange returned %d, expected ERROR_IO_PENDING\n", ret); +

Wine and Summer of Code 2011

2011-02-08 Thread Dan Kegel
http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/faqs#mentor_apply says projects can apply starting on Feb 28. In preparation, I moved the 2010 projects from http://wiki.winehq.org/SummerOfCode to http://wiki.winehq.org/SummerOfCode/PreviousProjects I also added a DSS Prov

Re: po: Update French translation

2011-02-08 Thread Paul Vriens
On 02/08/2011 05:28 PM, Frédéric Delanoy wrote: #: avifil32.rc:27 +#, fuzzy msgid "Waveform: %s" msgstr "Waveform : %s" #: avifil32.rc:28 +#, fuzzy msgid "Waveform" msgstr "Waveform" Hi, Are you adding the 'fuzzy' on purpose? I think that the fuzzy ones are ignored for translatio

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

2011-02-08 Thread Andrew Eikum
On 02/08/2011 10:48 AM, Loïc Maury wrote: First of all set your tab size to 8, and ask your editor to not use tabs at all. I have modified my editor, but I don't know if it 's correct now ? The indentation looks fine to me now. You've got an extra newline after the "if(printer->doc)" block

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-08 Thread Misha Koshelev
On Tue, Feb 8, 2011 at 12:02 AM, Dmitry Timoshkov wrote: > Misha Koshelev wrote: > >> +static inline unsigned short float_32_to_16(const float *in) > >> +static inline float float_16_to_32(const unsigned short *in) { > > Is there a reason that you pass a pointer to the helper instead of > a value

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

2011-02-08 Thread Loïc Maury
Hello Mr.Timoshkov, Thank you for your reply. Loïc Maury wrote: After the various comments, I have modified the patch. First of all set your tab size to 8, and ask your editor to not use tabs at all. I have modified my editor, but I don't know if it 's correct now ? + TRACE("(%s, %s

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

2011-02-08 Thread Dmitry Timoshkov
Loïc Maury wrote: > After the various comments, I have modified the patch. First of all set your tab size to 8, and ask your editor to not use tabs at all. > + TRACE("(%s, %s, %p, %d, %d)\n",debugstr_w(printer->name) > + ,debugstr_w(printer->printername) > + ,pri

Try to Implement my first Stub function - AbortPrinter() - (try 2).

2011-02-08 Thread Loïc Maury
Hello, After the various comments, I have modified the patch. What do you think ? Thank You Loïc --- dlls/winspool.drv/info.c | 97 +- 1 files changed, 95 insertions(+), 2 deletions(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/in

Re: [PATCH 3/5] d3dx9_36: Implemented ID3DXConstantTable_SetVector and ID3DXConstantTable_SetVectorArray

2011-02-08 Thread Matteo Bruni
> +            if (is_vertex_shader(This->desc.Version)) > +                IDirect3DDevice9_SetVertexShaderConstantF(device, > desc.RegisterIndex + i, (float *)fvector, > +                        desc.RegisterCount); You should probably just use 1 instead of desc.RegisterCount in SetVertexShader

Re: [PATCH 2/5] d3dx9_36: Implemented ID3DXConstantTable_SetIntArray and ID3DXConstantTable_SetInt

2011-02-08 Thread Matteo Bruni
> +       /* We need the for loop, since we need to convert the integer to a > float */ > +        for (i = 0; i < count && i < desc.RegisterCount; i++) > +        { > +            row[0] = (float)n[i]; The cast is unneeded, and the comment above is too.

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.

2011-02-08 Thread Dmitry Timoshkov
Marvin wrote: > === W7PROX64 (64 bit win) === > win.c:3480: Test failed: SetForegroundWindow() failed That's pretty strange, a standalone test I sent to testbot passed without any failures. -- Dmitry.

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.

2011-02-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9039 Your paranoid android.

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.

2011-02-08 Thread Nicolas Le Cam
2011/2/8 Jack Edmonds > Fixes bug 25698 and addresses one of the test cases in bug 24278 (possibly > resolves bug 24278 but more testing is required to be sure). > > dib.c: Fills BITMAPINFOHEADER with correct width and height when bits == > NULL and copying from a top-to-bottom bitmap. > For top-

Re: gdi32/tests: Use virtual screen size instead of primary monitor screen size.

2011-02-08 Thread Dmitry Timoshkov
Peter Urbanec wrote: > It seems that GetSystemMetrics(SM_CXVIRTUALSCREEN) is supported on Win2k > and later, but not on NT4. Presumably, on an NT4 system, the test could > use GetSystemMetrics(SM_CXSCREEN) and it would work as long as there is > only one monitor. > > What's the proper incanta

Re: gdi32/tests: Use virtual screen size instead of primary monitor screen size.

2011-02-08 Thread Peter Urbanec
On 08/02/11 16:02, Marvin wrote: Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9028 Your paranoid android. === WNT4WSSP6 (32 bit clipping) === clipping.c:438: Test failed: expected 0,0-0,0, got 0,0-800,600 It seems that GetSystemMetrics(SM_CXVIRTUALSCREEN) is suppo

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.

2011-02-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9030 Your paranoid android.

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.

2011-02-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9029 Your paranoid android.