Re: winex11.drv: initialize drawable (clang)

2011-01-25 Thread denis bonnenfant
Le mardi 25 janvier 2011 à 19:10 +0100, Henri Verbeet a écrit : > 2011/1/25 André Hentschel : > > http://austinenglish.com/logs/clang_analyzer/report-dRpLpZ.html#EndPath > > then the if condition is reliable > I don't think that can happen unless hwnd is NULL and top is non-NULL, > which looks like

Re: kernel32: Removing - key from keybindings.

2011-01-25 Thread Trygve Vea
On Tue, Jan 25, 2011 at 8:35 PM, Trygve Vea wrote: > Fixes bug 25856, introduced in 2a219b948c451213fb4554352b86f3784a8f7e32. > It seems that Eric Pouech already posted an identical patch, which has been applied. This is then unnecessary. I apologize for the noise. -- Trygve Vea

Re: wine-patches

2011-01-25 Thread Juan Lang
Hi Vincent, > I sent this email on wine-patch but... nothing. > > Am I doing something wrong ? Sorry, I should have replied earlier. The patch doesn't appear to fix anything, so it's unclear where you're going with it. It'd be better to send a more complete patch series. For example, +static B

wine-patches

2011-01-25 Thread Vincent Hardy
Hi, I sent this email on wine-patch but... nothing. Am I doing something wrong ? Am I blacklisted ? Vincent --- Begin Message --- >From bdf47b42a1560e9e097770f54d8f36a234f6d686 Mon Sep 17 00:00:00 2001 From: Vincent Hardy Date: Mon, 24 Jan 2011 10:33:36 +0100 Subject: Loading PCSC-lite librar

Re: winex11.drv: initialize drawable (clang)

2011-01-25 Thread Henri Verbeet
2011/1/25 André Hentschel : > http://austinenglish.com/logs/clang_analyzer/report-dRpLpZ.html#EndPath > then the if condition is reliable I don't think that can happen unless hwnd is NULL and top is non-NULL, which looks like invalid input to me.

Re: po: Update the Dutch translation

2011-01-25 Thread Alexandre Julliard
Sven Baars writes: > Hey, > > All those po editors piss me off. First, the changes I make don't get > saved, then they do get saved but magically disappear when I try to > send them. Now I used poedit, which is apparently the only one that > works, and this one makes whole bunch of changes by its

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)

2011-01-25 Thread Loïc Maury
On Tue, Jan 25, 2011 at 12:29 AM, Ken Thomases wrote: > Loïc, > > Your mailer seems to have mangled your patch with line wrapping. There are > some suggestions on Wine's SubmittingPatches wiki page for avoiding this. > Primarily, you should attach the patch to your email. If you already did >

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 4)

2011-01-25 Thread Loïc Maury
--- dlls/ntdll/cdrom.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..6a6d8e0 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,10 @@ static NTSTATUS CDROM_Verify(int dev, int fd)

Re: [Bug 25402] Woody Two Legs crashes with unimplemented function msvcr90.dll._wcslwr_s

2011-01-25 Thread Eric Pouech
the spec should read wstr instead of ptr A+ 2011/1/25 > http://bugs.winehq.org/show_bug.cgi?id=25402 > > Andrew Millington changed: > > What|Removed |Added > > > Keywords|

Re: [PATCH 2/4] wined3d: Add support for the NULL format.

2011-01-25 Thread Henri Verbeet
On 25 January 2011 11:17, Stefan Dösinger wrote: > Am 24.01.2011 um 18:41 schrieb Henri Verbeet: > >> -    if (surface) >> +    if (surface && surface->resource.format->id != WINED3DFMT_NULL) > Doesn't this cause GL errors? In my testing I had to set the draw buffer to > GL_NONE to be able to dra

Re: [PATCH 2/4] wined3d: Add support for the NULL format.

2011-01-25 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 24.01.2011 um 18:41 schrieb Henri Verbeet: > -if (surface) > +if (surface && surface->resource.format->id != WINED3DFMT_NULL) Doesn't this cause GL errors? In my testing I had to set the draw buffer to GL_NONE to be able to draw without a