Re: [PATCH 5/5] d3dx9_36/tests: Added tests for ID3DXConstantTable_Set* functions

2011-01-21 Thread Travis Athougies
Regardless, I've modified the tests a so that they should pass on windows. Can you verify that they do? Travis. On Fri, Jan 21, 2011 at 9:22 PM, Henri Verbeet wrote: > On 22 January 2011 06:11, Travis Athougies wrote: >> The failed tests worry me since it passes on linux with a native >> d3dx9_

Re: [PATCH 5/5] d3dx9_36/tests: Added tests for ID3DXConstantTable_Set* functions

2011-01-21 Thread Henri Verbeet
On 22 January 2011 06:11, Travis Athougies wrote: > The failed tests worry me since it passes on linux with a native > d3dx9_36 dll. Have you tried a native d3dx9_36 with wine? Do the tests > still fail? > That's not a valid way to verify tests.

Re: [PATCH 5/5] d3dx9_36/tests: Added tests for ID3DXConstantTable_Set* functions

2011-01-21 Thread Travis Athougies
The failed tests worry me since it passes on linux with a native d3dx9_36 dll. Have you tried a native d3dx9_36 with wine? Do the tests still fail? Travis. On Thu, Jan 20, 2011 at 8:48 AM, Matteo Bruni wrote: > 2011/1/20 Travis Athougies : >> +static void test_setting_basic_table(IDirect3DDevice

Re: dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)

2011-01-21 Thread Vitaliy Margolen
On 01/21/2011 01:43 AM, Greg Geldorp wrote: I've tried to install the June 2010 DirectX redistributable on it Shame on me, I've totally forgot that the latest DX version for NT was DX3 that came with service pack. Don't recall thou if it was a separate install or not. The patch still should g

winscard

2011-01-21 Thread vince
Hi all, I'm back with a smaller and reworked winscard patch. In respond to Vitaly Margolen (http://www.winehq.org/pipermail/wine-devel/2010-September/087017.html) 1. I used configure to get the so name of the library. 2. I removed trailing spaces. 3. When this patch is approved, I will make a

Re: windowscodecs: Disable ICNS support when building for Mac OS X 10.4 Tiger.

2011-01-21 Thread Ken Thomases
On Jan 21, 2011, at 2:36 AM, Damjan Jovanovic wrote: > Should we reconsider libicns? Apple's APIs obviously can't be relied upon. On Jan 21, 2011, at 5:04 AM, Alexandre Julliard wrote: > Several other things are already broken on Mac OS X 10.4. Basic > functionality is there, but it's not worth

Re: [PATCH 4/5] d3dx9_36: Implemented ID3DXConstantTable_SetMatrix and ID3DXConstantTable_SetMatrixArray

2011-01-21 Thread Michael Stefaniuc
On 01/22/2011 12:22 AM, Travis Athougies wrote: matrix + i will advance by the size of 1 D3DXMATRIX, since matrix is a pointer to a D3DXMATRIX. Michael is right, I thought the code was clearer with the pointer arithmetic, but I now see more people are familiar with the array indexing style. Actua

Re: [PATCH 4/5] d3dx9_36: Implemented ID3DXConstantTable_SetMatrix and ID3DXConstantTable_SetMatrixArray

2011-01-21 Thread Travis Athougies
Oh I'm sorry. I now see what you mean, you were talking about the register index parameter to Set*ShaderConstantF? Yes, that should be changed. I will submit updated patches shortly. Travis. On Fri, Jan 21, 2011 at 3:22 PM, Travis Athougies wrote: > matrix + i will advance by the size of 1 D3DXM

Re: [PATCH 4/5] d3dx9_36: Implemented ID3DXConstantTable_SetMatrix and ID3DXConstantTable_SetMatrixArray

2011-01-21 Thread Travis Athougies
matrix + i will advance by the size of 1 D3DXMATRIX, since matrix is a pointer to a D3DXMATRIX. Michael is right, I thought the code was clearer with the pointer arithmetic, but I now see more people are familiar with the array indexing style. Travis. On Fri, Jan 21, 2011 at 8:47 AM, Matteo Bruni

Re: [PATCH 4/5] d3dx9_36: Implemented ID3DXConstantTable_SetMatrix and ID3DXConstantTable_SetMatrixArray

2011-01-21 Thread Matteo Bruni
2011/1/21 Michael Stefaniuc : > On 01/21/2011 06:56 AM, Travis Athougies wrote: >> On Thu, Jan 20, 2011 at 7:27 AM, Matteo Bruni >> wrote: >>> >>> 2011/1/20 Travis Athougies: +/* D3DXMATRIX is a union, one of whose elements is an array, so it can be cast to a float point

RE: dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)

2011-01-21 Thread Greg Geldorp
From: Vitaliy Margolen [mailto:wine-patc...@kievinfo.com] > Shame on me, I've totally forgot that the latest DX version for NT was DX3 > that came with service pack. Don't recall thou if it was a separate install > or not. Wikipedia says (http://en.wikipedia.org/wiki/DirectX#Releases) that DirectX

Re: Translating a same message used in different contexts

2011-01-21 Thread Akihiro Sagawa
On Thu, 20 Jan 2011, Alexandre Julliard wrote: > > So otherwise for context issues I believe the outcome of the WineConf > > discussion was that we'd insert a prefix in the two strings to > > translate, e.g. 'CTX-IDS_DESKTOP:Desktop' and > > 'CTX-IDS_DESKTOPDIRECTORY:Desktop', and have wrc remov

RE: shell32/tests: Add tests for IShellDispatch::NameSpace.

2011-01-21 Thread Greg Geldorp
> === W7PROX64 (32 bit shelldispatch) === > shelldispatch.c:80: Test failed: bad title I suppose the title here was "Program Files (x86)", it would be good to print the title that you got (using wine_dbgstr_w()). This test will probably fail when running as 32-bit executable on any Windows 64-bit

Re: shell32/tests: Add tests for IShellDispatch::NameSpace.

2011-01-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8506 Your paranoid android.

Re: windowscodecs: Disable ICNS support when building for Mac OS X 10.4 Tiger.

2011-01-21 Thread Alexandre Julliard
Damjan Jovanovic writes: > If distribution of Wine users among Linux and MacOS is roughly equal, then > even if we disable icons on only Intel MacOS X 10.4, it will break for > almost as many users as are using Ubuntu 10.04 and 10.10 put together. Several other things are already broken on Mac O

Re: windowscodecs: Disable ICNS support when building for Mac OS X 10.4 Tiger.

2011-01-21 Thread Damjan Jovanovic
On Fri, Jan 21, 2011 at 10:52 AM, Reece Dunn wrote: > On 21 January 2011 08:36, Damjan Jovanovic wrote: > > Should we reconsider libicns? Apple's APIs obviously can't be relied > upon. > > You could always: > > 1. check for native support (including presence of > kIconServices16PixelDataARGB) a

Re: [PATCH 4/5] d3dx9_36: Implemented ID3DXConstantTable_SetMatrix and ID3DXConstantTable_SetMatrixArray

2011-01-21 Thread Michael Stefaniuc
On 01/21/2011 06:56 AM, Travis Athougies wrote: Uh no. If I were to do that, matrix->m[1] would be the second row, not the second matrix. I'm trying to get at the second matrix. To illustrate this, suppose the matrix were at 0x8000 (not going to happen, but just pretend). matrix->m[1] would be at

Re: windowscodecs: Disable ICNS support when building for Mac OS X 10.4 Tiger.

2011-01-21 Thread Reece Dunn
On 21 January 2011 08:36, Damjan Jovanovic wrote: > Should we reconsider libicns? Apple's APIs obviously can't be relied upon. You could always: 1. check for native support (including presence of kIconServices16PixelDataARGB) and use if present; 2. check for libicns and use it if present; 3.

RE: dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)

2011-01-21 Thread Greg Geldorp
From: Vitaliy Margolen > On 01/20/2011 07:52 PM, Marvin wrote: > > === WNT4WSSP6 (32 bit device) === > > device.c:168: Test failed: DirectInputCreate() failed: 80040154 > > Does this box has any newer version of DX installed at all? If it doesn't > know about DX2 interfaces I'm guessing not. I've

Re: windowscodecs: Disable ICNS support when building for Mac OS X 10.4 Tiger.

2011-01-21 Thread Damjan Jovanovic
Should we reconsider libicns? Apple's APIs obviously can't be relied upon. On Fri, Jan 21, 2011 at 2:58 AM, Ken Thomases wrote: > > For http://bugs.winehq.org/show_bug.cgi?id=25778 > --- > dlls/windowscodecs/icnsformat.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) > > > > >