Re: [PATCH] windowscodecs/tests: Fix crash introduced with eaf394a9ac4c.

2011-01-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8269 Your paranoid android.

Re: kernel32/tests: Use the right return type and a better failed test message

2011-01-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8267 Your paranoid android.

Re: [PATCH 1/3] msvcr90: Implement _set_abort_behavior [try2]

2011-01-12 Thread Alexandre Julliard
Detlef Riekenberg writes: > @@ -36,6 +36,11 @@ static MSVCRT_purecall_handler purecall_handler = NULL; > > static const char szMsgBoxTitle[] = "Wine C++ Runtime Library"; > > +#ifndef _WRITE_ABORT_MSG > +#define _WRITE_ABORT_MSG 1 > +#define _CALL_REPORTFAULT 2 > +#endif These should go in

Re: msvcrt: Partially implement _set_abort_behavior

2011-01-12 Thread Nikolay Sivov
On 1/12/2011 07:56, Detlef Riekenberg wrote: On Mi, 2011-01-12 at 00:48 +0300, Nikolay Sivov wrote: Date: Wed, 12 Jan 2011 00:46:26 +0300 Subject: [PATCH 1/1] Partially implement _set_abort_behavior Please search the patches queue first. try 2: http://source.winehq.org/patches/data/70231 try 1

windowscodecs: Use Mac OS X native ICNS support, not libicns

2011-01-12 Thread Joerg-Cyril.Hoehle
Ken, Thank you! Indeed I never installed libicns on my Mac (why use an external library on the particular OS that created the need for ICNS format support?) and even reverted Damjan's patch to still create .png images like the Linux systems. Then I use sips -i to create .command files with icons

Re: d3d9/tests: Skip tests if not running in the foreground

2011-01-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8260 Your paranoid android.

Re: tests/amstream.c doesn't test anything

2011-01-12 Thread Nicolas Le Cam
2011/1/12 > Hi, > > please take a look at test.winehq.org > http://test.winehq.org/data/tests/amstream:amstream.html > > It appears that almost all native machines perform 0 tests on amstream. > As no skip is flagged, results appear all green. > The only exception are Wylda's XP machines. They ex

TestBot messing up patches

2011-01-12 Thread Greg Geldorp
> From: Andrew Nguyen > On 01/11/2011 05:32 AM, Marvin wrote: > > === WINEBUILD (build) === > > Patch failed to apply > > Patch failed to apply > > Again, the bot seems to screw up patch application for some reason. > Greg, could you take a look at the situation? Yeah, sorry about that. It appears

Re: windowscodecs: Use Mac OS X native ICNS support, not libicns.

2011-01-12 Thread elus89
I suggest passing this on to the devs of wineskin, a mac-based wine wrapper. Perhaps it could be added to a subsection of winetricks, too. It would need to be thoroughly tested of course... I am very much a newbie. But, if you have some bug-testing you need a guinea-pig for, and a well-written

tests/amstream.c doesn't test anything

2011-01-12 Thread Joerg-Cyril.Hoehle
Hi, please take a look at test.winehq.org http://test.winehq.org/data/tests/amstream:amstream.html It appears that almost all native machines perform 0 tests on amstream. As no skip is flagged, results appear all green. The only exception are Wylda's XP machines. They execute 16 tests but fail on

semi-updated valgrind results

2011-01-12 Thread Austin English
I ran the tests with Valgrind for wine 1.3.11 on Debian Squeeze. I haven't yet updated the suppressions file (I'd appreciate feedback on what to add :p), so the logs are a bit noisy... But, if you're curious, see http://austinenglish.com/logs/valgrind/ I haven't yet setup the tests on that machin

Re: [PATCH 1/3] winemenubuilder: Icon heights/widths of 0 mean 256, for Vista icons.

2011-01-12 Thread Ken Thomases
On Jan 12, 2011, at 3:22 AM, Damjan Jovanovic wrote: > On Wed, Jan 12, 2011 at 7:36 AM, Ken Thomases wrote: > >> Also, is it common for Windows icons to contain 64x64 variants? My >> impression is that it's not, but I have no hard data about that. In that >> case, it's typically better to sc

Re: [PATCH 1/3] winemenubuilder: Icon heights/widths of 0 mean 256, for Vista icons.

2011-01-12 Thread Damjan Jovanovic
On Wed, Jan 12, 2011 at 7:36 AM, Ken Thomases wrote: > On Jan 11, 2011, at 2:41 AM, Damjan Jovanovic wrote: > >> The 256x256 pixel icons are designed to be viewed in that size. They >> can, and often do, contain a different picture to the smaller icons. >> When you scale them down to a smaller siz