Re: [patch] Support NULL puLen in VerQueryValue

2011-01-03 Thread Andrew Nguyen
On 01/03/2011 09:25 PM, Rafael Ávila de Espíndola wrote: > I couldn't find any documentation saying that this must be supported, > but running google code search on VerQueryValue.*NULL found some uses. > > Cheers, > Rafael > > > > You should write some tests to examine the behavior of VerQuer

Re: [5/9] kernel32: Improve parameter validation for WriteConsoleOutputCharacterA. (try 3)

2011-01-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8100 Your paranoid android.

Re: [6/9] kernel32: Improve parameter validation for WriteConsoleOutputAttribute. (try 3)

2011-01-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8101 Your paranoid android.

Re: [9/9] kernel32: Improve parameter validation for FillConsoleOutputAttribute. (try 3)

2011-01-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8104 Your paranoid android.

Re: [2/9] kernel32: Improve parameter validation for WriteConsoleInputW. (try 3)

2011-01-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8097 Your paranoid android.

Re: [3/9] kernel32: Improve parameter validation for WriteConsoleInputA. (try 3)

2011-01-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8098 Your paranoid android.

Re: [8/9] kernel32/tests: Add tests for FillConsoleOutputCharacterA. (try 3)

2011-01-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8103 Your paranoid android.

Re: [2/9] kernel32: Improve parameter validation for WriteConsoleInputW. (try 3)

2011-01-03 Thread Andrew Nguyen
On 01/03/2011 09:37 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.wineh

Re: [9/9] kernel32: Improve parameter validation for FillConsoleOutputAttribute. (try 3)

2011-01-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8104 Your paranoid android.

Wine and Fontconfig

2011-01-03 Thread Yaron Shahrabani
Elad, an Hebrew user suggests: In several Wine apps Hebrew is displayed as square glyphs since there are no builting Hebrew glyphs in Wine's font (bug #23537). The question is why does Wine use the internal font as the default? The easier solution would be to use the "system" fonts as configured

Re: How to find out locking problem

2011-01-03 Thread Austin English
On Sat, Jan 1, 2011 at 10:00 PM, wrote: > Happy New Year! > > i notice, that since 1.3 i get quite offten locking issue. It looks > like, that last OK version was 1.2-rc7. This problem happens in > Bioshock on load/save, but i noticed that other users have same > problem with games on the same ga

Re: [PATCH] wine: pass $LDFLAGS also to $LDDLLFLAGS

2011-01-03 Thread Alexandre Julliard
Marcus Meissner writes: > This is helpful if you need to pass in special LDFLAGS, like -flto. LDFLAGS are already specified on the link command line, I don't think they should get hardcoded into winegcc. -- Alexandre Julliard julli...@winehq.org

Re: How to find out locking problem

2011-01-03 Thread Damjan Jovanovic
On Sun, Jan 2, 2011 at 7:36 PM, Henri Verbeet wrote: > On 2 January 2011 17:43,   wrote: >> The truth is, that wine outputs the first line ("...wait timed out >> in thread 001c, blocked by 0041...") only once and after that only >> the 2nd line repeats every 60sec ("...wait timed out in thread 004

Re: [02/13] kernel32: Avoid checking the output parameter for GetNumberOfConsoleInputEvents.

2011-01-03 Thread Alexandre Julliard
Andrew Nguyen writes: > @@ -991,9 +991,7 @@ BOOL WINAPI GetNumberOfConsoleInputEvents( HANDLE handle, > LPDWORD nrofevents ) > req->handle = console_handle_unmap(handle); > req->flush = FALSE; > if ((ret = !wine_server_call_err( req ))) > -{ > -if

Re: [PATCH 3/3] urlmon: Add some error handling to the http protocol. (try 2)

2011-01-03 Thread Jacek Caban
Hi David, The patch looks much better now, but needs a bit more. BTW, this would be better tested on protocol level (like we do in protocol.c) than moniker binding, but this will do too. On 1/3/11 3:47 AM, David Hedberg wrote: Try 2: Better tests, among other things. --- dlls/urlmon/http.c

Re: [2/3] kernel32: Added stubs for IDN functions

2011-01-03 Thread Alexandre Julliard
Thomas Mullaly writes: > @@ -1219,6 +1219,11 @@ > @ stdcall lstrlen(str) lstrlenA > @ stdcall lstrlenA(str) > @ stdcall lstrlenW(wstr) > +@ stdcall NormalizeString(long wstr long wstr long) > +@ stdcall IsNormalizedString(long wstr long) > +@ stdcall IdnToAscii(long wstr long wstr long) > +@ s

Re: configure: Use -Wundef if supported by the compiler.

2011-01-03 Thread Alexandre Julliard
Gerald Pfeifer writes: > I verified this does not cause any warning on FreeBSD 8.1 test > builds, and all the tools like bison and flex in somewhat current > versions. It's broken here with bison 2.4.1: make[1]: Entering directory `/home/julliard/wine/wine/libs/wpp' gcc -m32 -c -I. -I. -I../../

Re: [5/6] kernel32: Avoid checking the output parameter for WriteConsoleOutputCharacterW. (try 2)

2011-01-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8085 Your paranoid android.

Re: [4/6] kernel32: Improve parameter validation for WriteConsoleInputA. (try 2)

2011-01-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8084 Your paranoid android.

Re: [3/6] kernel32: Improve parameter validation for WriteConsoleInputW. (try 2)

2011-01-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8083 Your paranoid android.

Re: [03/13] kernel32: Improve parameter validation for WriteConsoleInputW.

2011-01-03 Thread Andrew Nguyen
On 01/02/2011 09:32 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.wineh