Re: [13/13] kernel32: Avoid checking the output parameter for ReadConsoleOutputAttribute.

2011-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8080 Your paranoid android.

Re: [10/13] kernel32: Avoid checking the output parameter for FillConsoleOutputAttribute.

2011-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8077 Your paranoid android.

Re: [06/13] kernel32: Remove superfluous output parameter check in WriteConsoleOutputCharacterA.

2011-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8073 Your paranoid android.

Re: [11/13] kernel32: Avoid checking the output parameter for ReadConsoleOutputCharacterW.

2011-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8078 Your paranoid android.

Re: [12/13] kernel32: Avoid checking the output parameter for ReadConsoleOutputCharacterA.

2011-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8079 Your paranoid android.

Re: [03/13] kernel32: Improve parameter validation for WriteConsoleInputW.

2011-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8070 Your paranoid android.

Re: [04/13] kernel32: Improve parameter validation for WriteConsoleInputA.

2011-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8071 Your paranoid android.

Re: [08/13] kernel32: Avoid checking the output parameter for FillConsoleOutputCharacterW.

2011-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8075 Your paranoid android.

Re: [09/13] kernel32/tests: Add tests for FillConsoleOutputCharacterA.

2011-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8076 Your paranoid android.

Re: [07/13] kernel32: Avoid checking the output parameter for WriteConsoleOutputAttribute.

2011-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8074 Your paranoid android.

Question on yHeight values for CHARFORMAT2A/CHARFORMAT2W

2011-01-02 Thread James McKenzie
All: It is interesting that I am getting NEGATIVE values for this. I've ran this against the testbot and received 195 as the value for the System font in WindowsXP/WindowsVista/Windows7 but when I run this against Wine installed on a Mac, I get -240. Is this expected behavior or should I fi

Re: RFC: include: Add '_ONCE' variants of DPRINTF, FIXME, WARN and ERR

2011-01-02 Thread Dan Kegel
On Sun, Jan 2, 2011 at 11:33 PM, Sven Baars wrote: > But I'm not sure if the ##__LINE__ is really necessary. Yeah, that was overkill. > #ifdef __WINESRC__ > #define ONCE(x) WINE_ONCE(x) > #endif Good idea. - Dan

Re: RFC: include: Add '_ONCE' variants of DPRINTF, FIXME, WARN and ERR

2011-01-02 Thread Sven Baars
Dan Kegel wrote: How about this: #define WINE_ONCE(x) { static int wine_once_var##__LINE__; if (!wine_once_var##__LINE__++) { x; }} Example use: -static int once; -if (!once++) FIXME_(keyboard)("(%p,%d,0x%08x,%X): stub\n",hwnd,id,modifiers,vk); +WINE_ONCE(FIXME_(keyboard)("(%p,%d,0

Re: msctf/tests: Wait a bit for registrations to become active on Win7

2011-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8042 Your paranoid android.

re: RFC: include: Add '_ONCE' variants of DPRINTF, FIXME, WARN and ERR

2011-01-02 Thread Dan Kegel
How about this: #define WINE_ONCE(x) { static int wine_once_var##__LINE__; if (!wine_once_var##__LINE__++) { x; }} Example use: -static int once; -if (!once++) FIXME_(keyboard)("(%p,%d,0x%08x,%X): stub\n",hwnd,id,modifiers,vk); +WINE_ONCE(FIXME_(keyboard)("(%p,%d,0x%08x,%X): stub\n",

Re: How to find out locking problem

2011-01-02 Thread Henri Verbeet
On 2 January 2011 17:43, wrote: > The truth is, that wine outputs the first line ("...wait timed out > in thread 001c, blocked by 0041...") only once and after that only > the 2nd line repeats every 60sec ("...wait timed out in thread 0045, > blocked by 0044..."). Don't know if that's normal in t

How to find out locking problem

2011-01-02 Thread wylda
Hi Henri, thank you for analysis, it's first time when i'm trying to help with this kind of problem... > > From that backtrace, it doesn't look like 001c is > waiting for a critical section at all. > The truth is, that wine outputs the first line ("...wait timed out in thread 001c, blocked by

Re: How to find out locking problem

2011-01-02 Thread Henri Verbeet
On 2 January 2011 13:59, wrote: > err:ntdll:RtlpWaitForCriticalSection section 0x7de77580 > "x11drv_main.c: X11DRV_CritSection" wait timed out in thread 001c, > blocked by 0041, retrying (60 sec) > ... > Backtracing for thread 001c in process 001b (C:\Program Files\2K > Games\BioShock\Builds\Rele

Re: wined3d: Update detection of vertex blend capabilities

2011-01-02 Thread Henri Verbeet
On 2 January 2011 10:52, Jeremy Chin wrote: > Newer video cards have stopped reporting the ARB_VERTEX_BLEND GL capability, > but ARB_VERTEX_PROGRAM implies the same capability. > I don't think so. If this works at all it's probably because you're passing some previous value of gl_max (like GL_MAX_

How to find out locking problem

2011-01-02 Thread wylda
> ...get the stacks of all running processes with the command > > bt all > > With luck, you can then see which two code paths are > competing for the lock. Thanks for tip! Are the following traces from problematic threads useful or will i have to post all the thread traces? (Just repeat: happens

RFC: include: Add '_ONCE' variants of DPRINTF, FIXME, WARN and ERR

2011-01-02 Thread Sven Baars
Hey all, adding '_ONCE' variants of DPRINTF, FIXME, WARN and ERR is a topic that came up before on wine devel. The first version of the attached patch was submitted by Max TenEyck Woodbury, but was deferred until after wine 1.2. I still thought it was a good idea to have the _ONCE variants, so