RFC: Pass ReadFile and WriteFile requests on sockets to ws2_32.dll

2010-12-13 Thread Erich Hoover
Attached is a patch to take kernel32/ntdll ReadFile and WriteFile requests on sockets and pass them to WSARecv and WSASend.  This patch is part of a series I'm working on for the infamous C&C networking bug (Bug #7929). The functionality added by this patch was requested by a previous RFC response

Re: [2/2] amstream: Be more verbose when whe can't test

2010-12-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7579 Your paranoid android.

Re: [PATCH 1/2] oleaut32: Convert ITypeInfo implementation to use standard linked list

2010-12-13 Thread Alexandre Julliard
Andrew Eikum writes: > Typelib objects on Windows support both the reading and the creation > interfaces. I find it unlikely that they maintain two different > structures depending on which interface is being used, as Wine > currently (sort of) does. I think the question is whether the > struct

Re: [PATCH 1/2] oleaut32: Convert ITypeInfo implementation to use standard linked list

2010-12-13 Thread Andrew Eikum
On 12/13/2010 10:03 AM, Alexandre Julliard wrote: Andrew Eikum writes: An array would work, especially for the static structures that are used now, but these cleanup patches were made with the goal of merging the typelib-reading and typelib-creation interfaces in mind. Specifically, impleme

Re: [PATCH 1/2] oleaut32: Convert ITypeInfo implementation to use standard linked list

2010-12-13 Thread Alexandre Julliard
Andrew Eikum writes: > An array would work, especially for the static structures that are > used now, but these cleanup patches were made with the goal of merging > the typelib-reading and typelib-creation interfaces in mind. > Specifically, implementing the typelib-creation interfaces using the

Re: [PATCH 1/2] oleaut32: Convert ITypeInfo implementation to use standard linked list

2010-12-13 Thread Andrew Eikum
On 12/13/2010 05:34 AM, Alexandre Julliard wrote: Andrew Eikum writes: -/* search element n in list */ -for(i=0; i< index; i++) +i = 0; +LIST_FOR_EACH_ENTRY (pTypeInfo,&This->typeinfo_list, ITypeInfoImpl, entry) +{ +if(i>= index) +break; +

REMINDER: Removal of wineaudioio.drv

2010-12-13 Thread Michael Stefaniuc
Just a reminder: If nobody speaks up wine-1.3.9 will be the last version to support audioio. On 12/08/2010 04:11 PM, Michael Stefaniuc wrote: I have just submitted a patch to remove wineaudioio.drv from Wine. It was used by Solaris but the Solaris versions 9 and 10 that are "supported" by Wine

Re: ntdll: Change NtQuerySystemInformation to return 100ns ticks for SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION info class (try 4)

2010-12-13 Thread Henri Verbeet
On 12 December 2010 23:57, Chris Robinson wrote: > Though I'll defer judgement to others as to what's better. > Avoid macros unless you really need them, IMO.

Re: msi: Fix testfailure on some 2k3 machines (try 2)

2010-12-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7572 Your paranoid android.

Re: [PATCH 1/2] oleaut32: Convert ITypeInfo implementation to use standard linked list

2010-12-13 Thread Alexandre Julliard
Andrew Eikum writes: > -/* search element n in list */ > -for(i=0; i < index; i++) > +i = 0; > +LIST_FOR_EACH_ENTRY (pTypeInfo, &This->typeinfo_list, ITypeInfoImpl, > entry) > +{ > +if(i >= index) > +break; > +++i; > +} It looks like an array

Re: msi: Fix testfailure on some 2k3 machines

2010-12-13 Thread André Hentschel
Am 13.12.2010 08:42, schrieb Hans Leidekker: > On Sun, 2010-12-12 at 22:44 +0100, André Hentschel wrote: > >> r = MsiOpenProductA(prodcode, &hprod); >> -ok(r == ERROR_INSTALL_PACKAGE_OPEN_FAILED || r == ERROR_SUCCESS, >> - "Expected ERROR_INSTALL_PACKAGE_OPEN_FAILED or ERROR_SUCCESS