Re: [PATCH 01/11] mshtml: Added IOleControl calls test.

2010-12-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7457 Your paranoid android.

Re: [1/4] shdocvw: skip some tests if a modern IE is not present

2010-12-05 Thread Paul Vriens
On 12/02/2010 04:38 AM, Andrew Bogott wrote: As suggested by Jacek. Hi Andrew, Even IE6 does things differently as can be seen: http://test.winehq.org/data/tests/shdocvw:intshcut.html Just a matter of adding a broken() statement and bailing out (with cleanup) if the IPropertyStorage_ReadMu

How to deal with variables where the size differs for 32 and 64bit

2010-12-05 Thread Paul Vriens
Hi, Just found the fix for the oledb32:convert tests on 64bit. We need to adjust our oledb.idl (see patch attached). How should I deal with the ok() messages where we currently specify the 32bit variant? I mean this will of course introduce warnings on the 64bit side. Do I need to create a

Re: Use of the L prefix for wide strings in resource files

2010-12-05 Thread Paul Vriens
On 12/05/2010 04:14 PM, Alexandre Julliard wrote: Paul Vriens writes: Hi, Yaron just made me aware of something he and I discussed briefly a few weeks ago. The shlwapi resource files uses the following: PUSHBUTTON L"&OK", IDOK, 105, 40, 50, 14, WS_GROUP | WS_TABSTOP PUSHBUTTON L"&Cancel

Re: Use of the L prefix for wide strings in resource files

2010-12-05 Thread Alexandre Julliard
Paul Vriens writes: > Hi, > > Yaron just made me aware of something he and I discussed briefly a few > weeks ago. > > The shlwapi resource files uses the following: > > PUSHBUTTON L"&OK", IDOK, 105, 40, 50, 14, WS_GROUP | WS_TABSTOP > PUSHBUTTON L"&Cancel", IDCANCEL, 160, 40, 50, 14, WS_GROUP |

Re: Use of the L prefix for wide strings in resource files

2010-12-05 Thread Reece Dunn
On 5 December 2010 14:09, Paul Vriens wrote: > Hi, > > Yaron just made me aware of something he and I discussed briefly a few weeks > ago. > > The shlwapi resource files uses the following: > >  PUSHBUTTON L"&OK", IDOK, 105, 40, 50, 14, WS_GROUP | WS_TABSTOP >  PUSHBUTTON L"&Cancel", IDCANCEL, 160

Use of the L prefix for wide strings in resource files

2010-12-05 Thread Paul Vriens
Hi, Yaron just made me aware of something he and I discussed briefly a few weeks ago. The shlwapi resource files uses the following: PUSHBUTTON L"&OK", IDOK, 105, 40, 50, 14, WS_GROUP | WS_TABSTOP PUSHBUTTON L"&Cancel", IDCANCEL, 160, 40, 50, 14, WS_GROUP | WS_TABSTOP PUSHBUTTON L"&Yes", I