Re: Death to win9x?

2010-12-03 Thread James McKenzie
On 12/3/10 11:15 AM, André Hentschel wrote: As the VMs in Testbot are now retired we might want to delete the "old" win9x testdata from test.winehq.org(we need a name for this, testviewer?) manually? André: I almost have to agree with this because we should not expect improvements for these

Re: Death to win9x?

2010-12-03 Thread Saulius Krasuckas
* On Fri, 3 Dec 2010, André Hentschel wrote: > As the VMs in Testbot are now retired we might want to delete the "old" > win9x testdata from test.winehq.org(we need a name for this, > testviewer?) manually? Wait, please. Was there some voting been held to make such sentence official? I think

Re: Death to win9x?

2010-12-03 Thread André Hentschel
As the VMs in Testbot are now retired we might want to delete the "old" win9x testdata from test.winehq.org(we need a name for this, testviewer?) manually? -- Best Regards, André Hentschel

Re: [PATCH 2/6] quartz: Add support for filtermapper3 to filtergraph

2010-12-03 Thread Alexandre Julliard
Maarten Lankhorst writes: > @@ -269,6 +269,9 @@ static HRESULT WINAPI > FilterGraphInner_QueryInterface(IUnknown * iface, > } else if (IsEqualGUID(&IID_IFilterMapper2, riid)) { > *ppvObj = This->pFilterMapper2; > TRACE(" returning IFilterMapper2 interface from aggregated

Re: [PATCH] user32/tests: Disable IME for msg tests.

2010-12-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7434 Your paranoid android.

Re: [PATCH] user32/tests: Close second window in DBCS WM_CHAR tests.

2010-12-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7432 Your paranoid android.

Re: [1/7] urlmon: Standardize COM implementation of IUri

2010-12-03 Thread Alexandre Julliard
Thomas Mullaly writes: > @@ -3567,7 +3567,7 @@ static HRESULT set_builder_component(LPWSTR *component, > DWORD *component_len, LP > return S_OK; > } > > -#define URI(x) ((IUri*) &(x)->lpIUriVtbl) > +#define URI(x) ((IUri*) &(x)->IUri_iface.lpVtbl) > #define URIBUILDER(

Re: Death to win9x?

2010-12-03 Thread K.King
<<< A majority of that effort is rewriting tests to make win9x happy, not rewriting behavior to fix win9x applications. >>> Understood <<< Few people (if any) want to intentionally break win9x applications, but spending a large amount of developer effort to maintain the tests there isn't really