Re: [PATCH 1/2] opencl: Initial stub implementation of OpenCL 1.0 (try 2)

2010-11-29 Thread Peter Urbanec
On 30/11/10 05:31, C.W. Betts wrote: It doesn't look like you look for Apple's OpenCL implementation, which uses. That was intentional. I have no way of testing on OSX, so rather than including untested code and giving the illusion of it working on OSX, I decided to leave that out. I am also

Re: [1/4] winmm/tests: Add tests for mmioOpen for the file name of the form EXAMPLE.EXT+ABC.

2010-11-29 Thread Dmitry Timoshkov
Alexander Puzankov wrote: > +lpProc = mmioInstallIOProc(FOURCC_DOS, (LPMMIOPROC)mmio_test_IOProc, > MMIO_INSTALLPROC); > +ok(lpProc == (LPMMIOPROC)mmio_test_IOProc, "mmioInstallIOProc error\n"); Please try to avoid this kind of casts, they hide the bugs. Also, if the tests depend on the

Re: [PATCH 1/5] ddraw/tests: Fix a typo.

2010-11-29 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7343 Your paranoid android.

Re: [PATCH 3/5] mshtml: Added SetUIHandler tests.

2010-11-29 Thread Paul Vriens
Hi Jacek, On 11/29/2010 12:18 AM, Jacek Caban wrote: --- dlls/mshtml/tests/htmldoc.c | 111 --- 1 files changed, 104 insertions(+), 7 deletions(-) This one introduced some test failures: http://test.winehq.org/data/tests/mshtml:htmldoc.html Just a matte

Re: [PATCH 3/5] wined3d: Pass an IWineD3DDeviceImpl pointer to drawStridedSlow().

2010-11-29 Thread Henri Verbeet
On 2010-11-29 23:08, Henri Verbeet wrote: > --- > dlls/wined3d/device.c | 12 > dlls/wined3d/drawprim.c| 59 ++- > dlls/wined3d/wined3d_private.h |2 +- > 3 files changed, 34 insertions(+), 39 deletions(-) > I messed up the com

Re: [1/5] gdi32: Separate font loading from adding a font to global font list. Take 4.

2010-11-29 Thread Alexandre Julliard
Dmitry Timoshkov writes: > --- > dlls/gdi32/freetype.c | 306 > + > 1 files changed, 206 insertions(+), 100 deletions(-) This is causing strange crashes during prefix creation on 64-bit (there's no backtrace unfortunately). -- Alexandre Jullia

Re: Crappy Deb build scripts

2010-11-29 Thread Austin English
On Thu, Nov 11, 2010 at 8:56 AM, Ben Klein wrote: > By request of Austin, my crappy build scripts. I finally had the > concentration to bundle all the right files together! I've made a 1.3.8 package for Squeeze i386, and tested it on a second machine. I've only made deb packages a few times befor

Re: [PATCH 1/2] opencl: Initial stub implementation of OpenCL 1.0 (try 2)

2010-11-29 Thread C.W. Betts
It doesn't look like you look for Apple's OpenCL implementation, which uses . You can do this: #ifdef __APPLE__ #include #else #include #endif On Nov 29, 2010, at 7:39 AM, Peter Urbanec wrote: > Resending because previous patch was mangled by Thunderbird. > > --- > configure.ac|

Re: user32/tests: Remove obsolete comment

2010-11-29 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7336 Your paranoid android.

Re: dsound.h: Undefine INTERFACE before using it.

2010-11-29 Thread Alexandre Julliard
Jacek Caban writes: > @@ -419,6 +419,7 @@ extern HRESULT WINAPI GetDeviceID(LPCGUID lpGuidSrc, > LPGUID lpGuidDest); > > /* > * IDirectSound interface > */ > +#undef INTERFACE > #define INTERFACE IDirectSound > D

Re: [PATCH 4/5] [Kernel32, Server]: fixed a couple of bugs when reading bare console input with overlapped operations

2010-11-29 Thread Alexandre Julliard
Eric Pouech writes: > @@ -3011,6 +3014,7 @@ BOOL CONSOLE_Init(RTL_USER_PROCESS_PARAMETERS *params) > /* reply->event shouldn't be created by server */ > } > SERVER_END_REQ; > +fcntl( 0, F_SETFL, O_NONBLOCK ); I don't think that's a good idea, the calling pr

Re: winex11: remove unused field

2010-11-29 Thread Marcus Meissner
On Sun, Nov 28, 2010 at 08:36:51PM -0600, Vincent Povirk wrote: > I don't know much about this area of Wine, but I think the change is > incorrect. > > The DC's transform is applied to the font when it is rendered. To do > this correctly, the glyphs must be transformed when they are > rasterized

Re: [PATCH] ntdll: Increase size of buffer used to read lines of /proc/cpuinfo

2010-11-29 Thread Damjan Jovanovic
On Mon, Nov 29, 2010 at 10:00 AM, Damjan Jovanovic wrote: > On Mon, Nov 29, 2010 at 2:03 AM, James Eder wrote: >> On 11/26/10 12:15 AM, Damjan Jovanovic wrote: >>> On Fri, Nov 26, 2010 at 6:56 AM, Vitaliy Margolen >>>  wrote: On 11/24/2010 07:19 PM, James McKenzie wrote: > On 11/24/10 6

Re: [PATCH] ntdll: Increase size of buffer used to read lines of /proc/cpuinfo

2010-11-29 Thread Damjan Jovanovic
On Mon, Nov 29, 2010 at 2:03 AM, James Eder wrote: > On 11/26/10 12:15 AM, Damjan Jovanovic wrote: >> On Fri, Nov 26, 2010 at 6:56 AM, Vitaliy Margolen >>  wrote: >>> On 11/24/2010 07:19 PM, James McKenzie wrote: On 11/24/10 6:56 PM, Vitaliy Margolen wrote: > On 11/24/2010 12:23 PM, jimp