Wineconf pictures

2010-11-24 Thread Marcus Meissner
Hi folks, Here are my Wineconf pictures: http://www.flickr.com/photos/marcusmeissner/sets/72157625430516298/ (I need to add Jeremy to the group picture as someone noticed. Or photoshop a better one, or at least Martin and Andrew better ;) I also took video of Alexandres keynote as a tes

Re: wininet: add a stub for InternetShowSecurityInfoByURL

2010-11-24 Thread Paul Vriens
On 11/25/2010 03:29 AM, Austin English wrote: Fixes http://bugs.winehq.org/show_bug.cgi?id=25278 Shouldn't you create the A-version and forward to that one in the .spec? -- Cheers, Paul.

Re: [PATCH] ntdll: Increase size of buffer used to read lines of /proc/cpuinfo

2010-11-24 Thread James McKenzie
On 11/24/10 6:56 PM, Vitaliy Margolen wrote: On 11/24/2010 12:23 PM, jimpor...@gmail.com wrote: From: James Eder -while (fgets(line,200,f) != NULL) +while (fgets(line,450,f) != NULL) You might as well then change this to "sizeof(line)". Just for my edification, is there not a better wa

Re: [PATCH] ntdll: Increase size of buffer used to read lines of /proc/cpuinfo

2010-11-24 Thread Vitaliy Margolen
On 11/24/2010 12:23 PM, jimpor...@gmail.com wrote: From: James Eder - while (fgets(line,200,f) != NULL) + while (fgets(line,450,f) != NULL) You might as well then change this to "sizeof(line)". Vitaliy.

Re: Patch for bug 25063 - _pclose should wait for the command processor to terminate and return it's exit status

2010-11-24 Thread James McKenzie
On 11/24/10 2:23 PM, Borut Razem wrote: Attached is the forth attempt for the patch. It is traditional to append or suffix with [Try #] so that those who are manually tracking patches can do so and so AJ can skip over your previous attempts if you made several tries between times that he looks

Re: Added unit test suite for process functions

2010-11-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7260 Your paranoid android.

Re: msxml3/tests: move domdoc.c schema-related tests to schema.c

2010-11-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7259 Your paranoid android.

Re: [1/2] opengl32/tests: Add tests for special case of SetPixelFormat

2010-11-24 Thread Matijn Woudt
On Wed, Nov 24, 2010 at 11:37 PM, Henri Verbeet wrote: > On 24 November 2010 23:34, Matijn Woudt wrote: >> That's what I had in mind first too, but I couldn't figure out how to >> get that handle over to device_init (in d3d9) where the window is used >> too. >> > Why do you need it there? > The

Re: [1/2] opengl32/tests: Add tests for special case of SetPixelFormat

2010-11-24 Thread Henri Verbeet
On 24 November 2010 23:34, Matijn Woudt wrote: > That's what I had in mind first too, but I couldn't figure out how to > get that handle over to device_init (in d3d9) where the window is used > too. > Why do you need it there?

Re: [1/2] opengl32/tests: Add tests for special case of SetPixelFormat

2010-11-24 Thread Matijn Woudt
On Wed, Nov 24, 2010 at 11:30 PM, Henri Verbeet wrote: > On 23 November 2010 23:57, Matijn Woudt wrote: >> I have created a patch that uses a dummy window. Please let me know if >> this is what you had in mind. It works for the game I created the >> original patch for. >> > The basic idea is simi

Re: [1/2] opengl32/tests: Add tests for special case of SetPixelFormat

2010-11-24 Thread Henri Verbeet
On 23 November 2010 23:57, Matijn Woudt wrote: > I have created a patch that uses a dummy window. Please let me know if > this is what you had in mind. It works for the game I created the > original patch for. > The basic idea is similar, but it would have to be done in wined3d, and integrated wit

Re: [1/2] msvcrt: Fixes multi-byte detection problem with MSVCRT_isleadbyte() (try 2)

2010-11-24 Thread Nagato
_mbspbrk works fine. From what I could tell from my testing, MSVCRT_isleadbyte goes through _isctype and ignores the locale by using MSVCRT__ctype which never gets updated for locales (or if it does usually get updated, it's somehow completely failing). 837Dh for example is a マ in Japanese (Shift-J

ntdll/tests: add tests for NtQueryVolumeInformationFile with FileFsVolumeInformation class

2010-11-24 Thread Louis Lenders
>You should take that info from the volume (as it's done now in >GetVolumeInformation) instead of hard-coded invalid values. I guess you're right, I wasn't aware of the fact that GetVolumeInformation already does such a job. > I'm guessing some of that kernel32 functionality will need to >be

Volunteer needed - a Lurker would be perfect!

2010-11-24 Thread Jeremy White
Hi Folks, Throughout the years, Wine has been lucky to have a procession of great volunteers who work on areas outside the code. And right now, we find ourselves in need of a new Wine Weekly News editor. Zachary Goldberg, our current editor, has really not been able to find the time to keep up a

Re: [1/2] msvcrt: Fixes multi-byte detection problem with MSVCRT_isleadbyte() (try 2)

2010-11-24 Thread Piotr Caban
_mbspbrk function needs to be fixed, not isleadbyte. Cheers, Piotr

Re: Wineconf notes?

2010-11-24 Thread Marcus Meissner
On Wed, Nov 24, 2010 at 04:18:43PM +0200, Damjan Jovanovic wrote: > Hi > > Can those of us that didn't go to Wineconf this year please see some > videos/slides/notes from those that did? I added a section to the wiki for it, please upload and link the slides there. :) http://wiki.winehq.org/Wine

Wineconf notes?

2010-11-24 Thread Damjan Jovanovic
Hi Can those of us that didn't go to Wineconf this year please see some videos/slides/notes from those that did? Thank you Damjan Jovanovic

Re: msvcrt: Add missing dereference of the time pointer.

2010-11-24 Thread Eryk Wieliczko
Yes, you're right. Thank you for spotting. Eryk 2010/11/24 Michael Stefaniuc : > --- > Eryk, > > I guess this is what you had in mind as checking the pointer for greater > 0 is redundant as it is already not-NULL. > > > > >  dlls/msvcrt/time.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 de

Re: COM implementation clean up

2010-11-24 Thread Michael Stefaniuc
Hello, Alexander Kochetkov wrote: > The code like > static inline MyObject *impl_from_IMyInterface(IMyInterface *iface) > { > return (MyObject*)((char*)iface - FIELD_OFFSET(MyObject, > IMyInterface_iface)); > } > > could be replaced with > static inline MyObject *impl_from_IMyInterface(IMyInt

Re: COM implementation clean up

2010-11-24 Thread Alexander Kochetkov
Hi all, The code like static inline MyObject *impl_from_IMyInterface(IMyInterface *iface) { return (MyObject*)((char*)iface - FIELD_OFFSET(MyObject, IMyInterface_iface)); } could be replaced with static inline MyObject *impl_from_IMyInterface(IMyInterface *iface) { return container_of(MyO