Re: [PATCH 5/5] shell32/tests: Added SHPropStg* tests (try2)

2010-11-19 Thread Alexandre Julliard
Piotr Caban writes: > --- > dlls/shell32/tests/Makefile.in |1 + > dlls/shell32/tests/misc.c | 437 > > 2 files changed, 438 insertions(+), 0 deletions(-) > create mode 100644 dlls/shell32/tests/misc.c It would be better to either put those in

Re: [resend]: [dlls/dbgeng]: add initial stub dll implementation

2010-11-19 Thread Volodymyr Shcherbyna
Ouch, I did not know that. OK, I will re-format comments sections and typo and will re-send patch again. Thanks for pointing out. 2010/11/19 Paul Vriens > On 11/19/2010 03:50 PM, Volodymyr Shcherbyna wrote: > >> (I am re-sending this patch as gmail did extra formattings to previous >> patches)

Re: [resend]: [dlls/dbgeng]: add initial stub dll implementation

2010-11-19 Thread Paul Vriens
On 11/19/2010 03:50 PM, Volodymyr Shcherbyna wrote: (I am re-sending this patch as gmail did extra formattings to previous patches) Hi, +MODULE= dbgeng.dll +IMPORTLIB = dbgebg Typo? You also have to use your own wording for the comments, if needed at all, to the functions. You can't jus

Re: [dlls/dbgeng]: add initial stub dll implementation

2010-11-19 Thread Volodymyr Shcherbyna
Hello Jerome, Thanks for the hint. Patch is sent again, I hope it will be accepted ;) -- avec meilleures salutations, Volodymyr 2010/11/19 Jerome Leclanche > Hi Volodymyr, > > The problem was that gmail garbled > http://source.winehq.org/patches/data/68619 because it was inline. > Resend your

Re: [dlls/dbgeng]: add initial stub dll implementation

2010-11-19 Thread Jerome Leclanche
Hi Volodymyr, The problem was that gmail garbled http://source.winehq.org/patches/data/68619 because it was inline. Resend your patch as an attachment like you did to wine-patches and tag it as [resend]. J. Leclanche On Fri, Nov 19, 2010 at 9:18 AM, Volodymyr Shcherbyna wrote: > Hello Alexan

Re: [2/3] msxml3: Validate node content in xmlnode_put_dataType() (resend)

2010-11-19 Thread Jacek Caban
On 11/19/10 6:22 AM, Adam Martinson wrote: --- dlls/msxml3/msxml_private.h |1 + dlls/msxml3/node.c | 113 ++- dlls/msxml3/schema.c| 94 +-- 3 files changed, 158 insertions(+), 50 deletions(-) @@

Re: building a winelib dll?

2010-11-19 Thread Seth Burleigh
The purpose of this dll is to make a binding to zeromq. Ive tried compilin natively using microsoft visual studio but it doesn't like the msvc90 dll that i have and i dont want to have to worry about distribution issues of that dll. Plus mingw is a pain to build with and often fails randomly. So i

RE: [dlls/dbgeng]: add initial stub dll implementation

2010-11-19 Thread Volodymyr Shcherbyna
Hello Alexandre, I assume you were checking my patch (id: 68619) ( http://source.winehq.org/patches/data/68619) and marked it as "Apply Failure". If so, can you please double check? For the sake of the test, I setup wine-git on another machine to see if this patch works, and it seems to be OK. Th