Re: [1/3] d3dx9: Implement D3DXFillTexture function.

2010-11-17 Thread Henri Verbeet
On 17 November 2010 17:23, Matteo Bruni wrote: > +static BOOL color_match(DWORD *value, DWORD *expected) Those should probably be const.

Re: Patch for bug 25063 - _pclose should wait for the command processor to terminate and return it's exit status

2010-11-17 Thread Borut Razem
On 11/17/2010 11:45 AM, Alexandre Julliard wrote: Borut Razem writes: Yes, it looks huge, but we can reduce by a third by removing empty lines and comments (just kidding ;-). But the run-time overhead is minimal: allocation of the array at the first popen call and reallocation if more then 16

Re: wanted: test.avi resource

2010-11-17 Thread Julius Schwartzenberg
joerg-cyril.hoe...@t-systems.com wrote: Currently there are no tests in Wine of mciavi or mciqtz. The reason is incredibly trivial: I'd need a test.avi with defined properties that the tests check, and of course the file should be as small as possible to not weight too much in git. There is al

Re: mciavi should be rewritten using the AVIFile interface

2010-11-17 Thread Maarten Lankhorst
Hi Joerg, 2010/11/17 : > Hi, > > MSDN documents (and I verified) that the MCIAVI allows to access an > open AVIFile object via the special name @NN...NN (decimal address). > Conversely, > open @-1024 type avivideo alias a > crashes native at address c000 -- except on w95 (KB140750). > > This

Re: msvcrt: Add implementation of _strncoll

2010-11-17 Thread Piotr Caban
On 11/17/10 15:14, Vitaly Perov wrote: On Monday 15 November 2010 17:16:32 Piotr Caban wrote: On 11/15/10 14:53, Vitaly Perov wrote: This function should be implemented without memory allocations. Why? I don't think it is possible to implement it without any memory allocations. I mean witho

Re: msvcrt: Add implementation of _strncoll (try 2)

2010-11-17 Thread Dmitry Timoshkov
Vitaly Perov wrote: > +result = strcoll(nstr1, nstr2); System strcoll() for strings in different encoding won't work properly. -- Dmitry.

Re: msvcrt: Add implementation of _strncoll

2010-11-17 Thread Vitaly Perov
On Monday 15 November 2010 17:16:32 Piotr Caban wrote: > On 11/15/10 14:53, Vitaly Perov wrote: > >> This function should be implemented without memory allocations. > > > > Why? I don't think it is possible to implement it without any memory > > allocations. > > I mean without copying the strings.

Re: [PATCH 4/4] ddraw/tests: Fix some failure messages.

2010-11-17 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7119 Your paranoid android.

Re: Icons for hh and winebrowser

2010-11-17 Thread Alexandre Julliard
Damjan Jovanovic writes: > Hi > > Could whoever draws icons for Wine please add icons for programs/hh > and programs/winebrowser? I've made a patch > (http://source.winehq.org/patches/data/68572) which generates icons > for Wine applications in the file browser "Open with" list, and these > appli

Icons for hh and winebrowser

2010-11-17 Thread Damjan Jovanovic
Hi Could whoever draws icons for Wine please add icons for programs/hh and programs/winebrowser? I've made a patch (http://source.winehq.org/patches/data/68572) which generates icons for Wine applications in the file browser "Open with" list, and these applications are just getting a wineglass. T

Re: mciavi should be rewritten using the AVIFile interface

2010-11-17 Thread Dmitry Timoshkov
wrote: > Hence mciavi.c should be rewritten to use the AVIFile API. I hope > that doing so will prevent a skew that I've observed with some apps, > where sound and video rendering do not match after a few seconds. It would be better to find and fix an actual bug instead of introducing a bunch o

Re: Patch for bug 25063 - _pclose should wait for the command processor to terminate and return it's exit status

2010-11-17 Thread Alexandre Julliard
Borut Razem writes: > Yes, it looks huge, but we can reduce by a third by removing empty > lines and comments (just kidding ;-). But the run-time overhead is > minimal: allocation of the array at the first popen call and > reallocation if more then 16 childs are popened, which will probably > hap

Re: [1/2] comctl32/treeview: Use a code set by dispinfo holder to convert data encoding after TVN_GETDISPINFO

2010-11-17 Thread Nikolay Sivov
On 11/17/2010 13:39, Alexandre Julliard wrote: Nikolay Sivov writes: hTree = create_treeview_control(); -fill_tree(hTree); +//fill_tree(hTree); You probably don't want this. Yeah, I want to remove it, cause it's useless. Will send again.

Re: [1/2] comctl32/treeview: Use a code set by dispinfo holder to convert data encoding after TVN_GETDISPINFO

2010-11-17 Thread Alexandre Julliard
Nikolay Sivov writes: > hTree = create_treeview_control(); > -fill_tree(hTree); > +//fill_tree(hTree); You probably don't want this. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] [Kernel32,Server]: implemented GetConsoleProcessList

2010-11-17 Thread Alexandre Julliard
Eric Pouech writes: > +if ((cpl.console = console_input_get( req->handle, FILE_READ_PROPERTIES > ))) > +{ > +data_size_t sz; > + > +reply->num_processes = sz = cpl.console->num_proc; > + > +if ((sz *= sizeof(process_id_t)) <= get_reply_max_size()) That's much

Re: [1/3] msxml3: Use the associated schema for domelem_get_dataType()

2010-11-17 Thread Alexandre Julliard
Adam Martinson writes: > +todo_wine ole_check(IXMLDOMNode_get_nodeTypedValue(node, &v)); > +/* TODO: which platforms return VT_UI8? */ > +todo_wine ok(V_VT(&v) == VT_NULL, "got variant type %i\n", V_VT(&v)); > +if (V_VT(&v) == VT_UI8) > +todo_wine ok(V_UI8(&v) == 0xFFF

Re: [1/3] msxml3: Use the associated schema for domelem_get_dataType()

2010-11-17 Thread Jacek Caban
Hi Adam, On 11/16/10 23:00, Adam Martinson wrote: > --- > dlls/msxml3/element.c | 95 +- > dlls/msxml3/msxml_private.h |1 + > dlls/msxml3/node.c | 248 ++-- > dlls/msxml3/tests/domdoc.c | 301 > ++

mciavi should be rewritten using the AVIFile interface

2010-11-17 Thread Joerg-Cyril.Hoehle
Hi, MSDN documents (and I verified) that the MCIAVI allows to access an open AVIFile object via the special name @NN...NN (decimal address). Conversely, open @-1024 type avivideo alias a crashes native at address c000 -- except on w95 (KB140750). This makes it likely that MCIAVI internally us

mciseq should be rewritten using winmm's midiStreamOut interface

2010-11-17 Thread Joerg-Cyril.Hoehle
Hi, midiOutShortMsg() is an incredibly bad API for SW synths. It's just good enough at the lowest level, to throw bytes to the serial hardware. It is antithetical to buffering. The machine is stressed to obey the event ASAP, which is travelling across several threads that hence need be set as t

Re: wanted: test.avi resource

2010-11-17 Thread Reece Dunn
On 17 November 2010 09:13, wrote: > Hi, > > How would that be incorporated into winetest.exe? As a resource, > copied at execution time to the current directory? You would add it to the AVI section of the resource block (RC file) for the test executable. That would be the best way, as it keeps t

wanted: test.avi resource

2010-11-17 Thread Joerg-Cyril.Hoehle
Hi, Currently there are no tests in Wine of mciavi or mciqtz. The reason is incredibly trivial: I'd need a test.avi with defined properties that the tests check, and of course the file should be as small as possible to not weight too much in git. If you happen to know clock.avi (found in some ve

RE: TestBot IPv6 enabled

2010-11-17 Thread Greg Geldorp
> From: Juan Lang > Ha, right you are. Hm. Well, a wireshark capture of the connection > might help, to verify that the web server is in fact attaching the > correct certificate to the connection in the IPv6 case. The URL in question is actually https://testbot.winehq.org/. Browsing there using