Re: wined3d: remove a useless variable

OK. I missed that. Sorry for the noise A+ David 2010/11/14 Nikolay Sivov > On 11/14/2010 22:41, David Adam wrote: > > > > 2010/11/14 Nikolay Sivov > >> On 11/14/2010 22:17, David Adam wrote: >> >> if(wined3d_settings.rendertargetlock_mode == RTL_DISABLE) { >>> -static BOOL

Re: wined3d: remove a useless variable

2010/11/14 Nikolay Sivov > On 11/14/2010 22:17, David Adam wrote: > > if(wined3d_settings.rendertargetlock_mode == RTL_DISABLE) { >> -static BOOL warned = FALSE; >> -if(!warned) { >> -ERR("The application tries to lock the render target, but >> render target lock

Re: [1/2] opengl32/tests: Add tests for special case of SetPixelFormat

It has been a while since I last looked at this area. The following bug came to my mind which is the same thing http://bugs.winehq.org/show_bug.cgi?id=9786 I would start by figuring out for what purpose and for what calls the game is using GetDC(0). Turn on some d3d debug channels and try to figur

Re: [PATCH 1/4] msvcp90: Added basic_string::swap implementation.

On 11/11/10 18:55, Vincas Miliūnas wrote: This implementation handles cases when basic_strings are allocated using different allocators, however WINE's implementation seems to ignore allocators. It's not ignoring allocators (but it's not setting allocator field). There's no legal way of accessi

Re: [1/2] opengl32/tests: Add tests for special case of SetPixelFormat

On Mon, Nov 15, 2010 at 12:06 AM, Roderick Colenbrander wrote: > Hi Matijn, > > What 3D API is this game using? Is it using Direct3D or OpenGL? > > If it is Direct3D then I have the feeling the 'issue' is getting fixed > in the wrong layer. It's using Direct3D, but I don't see how this can be fix

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 6

On 11/14/10 3:01 PM, James McKenzie wrote: > On 11/5/10 8:17 AM, Charles Davis wrote: >> Changes since try 5: >> o All case-sensitivity logic has been absorbed into find_file_in_dir(). >> o Eliminated one more stat(2) that I missed last time. >> o Eliminated a statfs(2) call on Linux. >> >> This is

Re: [1/2] opengl32/tests: Add tests for special case of SetPixelFormat

Hi Matijn, What 3D API is this game using? Is it using Direct3D or OpenGL? If it is Direct3D then I have the feeling the 'issue' is getting fixed in the wrong layer. Further I'm not really sure whether we want to allow pixel format 1 to be used at all. In case of Wine all pixel formats are hardw

Haiku talking about wine

Seems to have been a long thread recently about restarting a port of Wine to Haiku, see http://haikuware.com/bounty-discussion/1533-wine-bounty I don't think there was anything really happening, though.

Re: [PATCH] d3dcompiler: Add initial reflection parsing.

2010/11/14 Rico Schüller : > +HRESULT d3dcompiler_shader_reflection_init(const void *data, SIZE_T > data_size, void **reflector) Allocation and initialization are different things. Either way, it's unnecessary to make "reflector" void **. > +if (!IsEqualGUID(riid, &IID_ID3D11ShaderReflection

Re: [PATCH 5/5] d3dcompiler_43/tests: Added trigonometric function tests to HLSL test suite

On 12 November 2010 21:08, Travis Athougies wrote: > +    static struct hlsl_probe_info sin_probes[] = This should be const. As a general rule, try to pay attention to at least other patches to the same module. I fixed a couple of these about two weeks ago. Same goes for calculating the probe coun

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 6

On 11/5/10 8:17 AM, Charles Davis wrote: Changes since try 5: o All case-sensitivity logic has been absorbed into find_file_in_dir(). o Eliminated one more stat(2) that I missed last time. o Eliminated a statfs(2) call on Linux. This is a far as I think I can take it without gutting it completel

Re: crypt32/tests: Add tests for decoding enveloped messages.

Hi Alexander, On 11/02/2010 01:56 PM, Alexander Morozov wrote: +CryptAcquireContextA(&hCryptProv, NULL, MS_ENHANCED_PROV_A, PROV_RSA_FULL, + CRYPT_VERIFYCONTEXT); Other calls use pCryptAcquireContextA but I guess that had to do with some platforms in the past that didn't export CryptA

Re: wined3d: remove a useless variable

> > -static BOOL warned = FALSE; > -if(!warned) { > -ERR("The application tries to lock the render target, but render > target locking is disabled\n"); > -warned = TRUE; > -} > +ERR("The application tries to lock the render target, but render

Re: wined3d: remove a useless variable

On 11/14/2010 22:41, David Adam wrote: 2010/11/14 Nikolay Sivov > On 11/14/2010 22:17, David Adam wrote: if(wined3d_settings.rendertargetlock_mode == RTL_DISABLE) { -static BOOL warned = FALSE; -if(!warned) {

Re: wined3d: remove a useless variable

On 11/14/2010 22:17, David Adam wrote: if(wined3d_settings.rendertargetlock_mode == RTL_DISABLE) { -static BOOL warned = FALSE; -if(!warned) { -ERR("The application tries to lock the render target, but render target locking is disabled\n"); -warned

Re: [msi/tests] Cleanup properly on Win9x

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7053 Your paranoid android.

Re: [PATCH 10/10] mshtml: Added document fragment cloneNode implementation.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7048 Your paranoid android.

Re: [PATCH 07/10] mshtml: Correctly handle DOCUMENT_FRAGMENT_NODE in IHTMLDOMNode::get_nodeType.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7045 Your paranoid android.

Re: [5/5] gdi32: Add a buch of CreateScalableFontResource() tests.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7042 Your paranoid android.

Re: [4/4] gdi32: Add a buch of CreateScalableFontResource() tests.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7041 Your paranoid android.