Re: msxml3: Implement property SelectionNamespaces for XPath (try #3)

2010-09-14 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5234 Your paranoid android.

[PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-14 Thread Mike Frysinger
Newer versions of gcc/glibc with fortify checks enabled will complain about the handling of the network's szNames field. Currently it is always defined with a length of one which means writing more then a single byte will trigger: In function 'strcpy', inlined from '_ILCreateEntireNetwork'

[PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-14 Thread Mike Frysinger
Newer versions of gcc/glibc with fortify checks enabled will complain about the handling of the network's szNames field. Currently it is always defined with a length of one which means writing more then a single byte will trigger: In function 'strcpy', inlined from '_ILCreateEntireNetwork'

WineAPI wiki progress.

2010-09-14 Thread Max TenEyck Woodbury
The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php now has pages for the directories in the Wine Repository with classifications of the directory content. Please take a look at it and tell me if you think the content is useful and how it could be improved. None of the analysis

Re: [PATCH 2/2] secur32: Reorganize data returned by schan_DecryptMessage.

2010-09-14 Thread Piotr Caban
Hi, On 09/14/10 20:53, Henri Verbeet wrote: Personally I thought Mikko's series was nicer, not in the least for actually having tests. (Though I don't think it's good to have a dependency on mail.google.com.) I didn't know about Mikko's patches. I find his patches better then mine (more complet

Re: [PATCH 1/2] secur32: Improved error handling in schan_DecryptMessage.

2010-09-14 Thread Piotr Caban
Hi, On 09/14/10 20:53, Henri Verbeet wrote: On 14 September 2010 20:27, Piotr Caban wrote: +else if (ret == GNUTLS_E_DECRYPTION_FAILED) ... +return SEC_E_MESSAGE_ALTERED; Are those really the same? This is not exactly the same, but it should work in most cases.

Re: secur32: Reorganize data returned by schan_DecryptMessage.

2010-09-14 Thread Piotr Caban
Hi, On 09/14/10 20:52, Juan Lang wrote: -TRACE("context_handle %p, message %p, message_seq_no %d, quality %p\n", +FIXME("context_handle %p, message %p, message_seq_no %d, quality %p\n", Did you intend to leave this change in? Yes, this functions is very incomplete. It for example lacks

Re: Console issues in recent git

2010-09-14 Thread Eric Pouech
Le 12/09/2010 14:09, Jerome Leclanche a écrit : Set a 1440x900 virtual desktop in winecfg. what do you mean by: - run a program in winedbg (in my case, it was in a virtual desktop, too) => does it mean you got 2 virtual desktops ? or got a shell running in one virtual desktop ? - (?) Term

Re: Desktop window doesn't span entire screen in multi-monitor setup?

2010-09-14 Thread Alexandre Julliard
Damjan Jovanovic writes: > What's the problem here, that the desktop window is too small, or that > the window search criteria are too strict? The destop window is supposed to be the size of the whole screen. -- Alexandre Julliard julli...@winehq.org

Re: USB Device Support

2010-09-14 Thread Alexander Morozov
> Before I go off and try to update your USB device support for the latest > Wine release, are you continuing to maintain this code current to the Wine > Development and Wine Stable trunks? I will update patches. Thanks, Alexander

Re: [PATCH 1/2] secur32: Improved error handling in schan_DecryptMessage.

2010-09-14 Thread Henri Verbeet
On 14 September 2010 20:27, Piotr Caban wrote: > +else if (ret == GNUTLS_E_DECRYPTION_FAILED) ... > +return SEC_E_MESSAGE_ALTERED; Are those really the same?

Re: [PATCH 2/2] secur32: Reorganize data returned by schan_DecryptMessage.

2010-09-14 Thread Henri Verbeet
On 14 September 2010 20:28, Piotr Caban wrote: > --- >  dlls/secur32/schannel.c |   30 -- >  1 files changed, 20 insertions(+), 10 deletions(-) > Personally I thought Mikko's series was nicer, not in the least for actually having tests. (Though I don't think it's good t

Re: secur32: Reorganize data returned by schan_DecryptMessage.

2010-09-14 Thread Juan Lang
Hi Piotr, -TRACE("context_handle %p, message %p, message_seq_no %d, quality %p\n", +FIXME("context_handle %p, message %p, message_seq_no %d, quality %p\n", Did you intend to leave this change in? --Juan

Re: USB Device Support

2010-09-14 Thread Damjan Jovanovic
When last I heard from Alexander Morozov (October 2009), he wasn't working on those patches much, and had no interest in sending them to wine-patches. I did some work on USB since then, and sent some patches starting from around March 2010 (too many attempts to list, search for them). Most were re

Re: [1/3] dsound: Add support for 32-bit IEEE float buffers

2010-09-14 Thread Chris Robinson
On Tuesday, September 14, 2010 6:56:36 am Henri Verbeet wrote: > Come to think of it though, doesn't ALSA accept floating point values > itself anyway? Only if the device does. The dmix/default device usually can, but there's no guarantees for the various hw:x,y or surround* devices.

USB Device Support

2010-09-14 Thread James Mckenzie
Alexander: Before I go off and try to update your USB device support for the latest Wine release, are you continuing to maintain this code current to the Wine Development and Wine Stable trunks? Also, the USB Device Support in Wine Wiki page needs an update. The code at snicky.com is no longe

Re: [1/3] dsound: Add support for 32-bit IEEE float buffers

2010-09-14 Thread Henri Verbeet
On 14 September 2010 15:19, Chris Robinson wrote: > It likely doesn't matter, but it already has to check for values that exceed > the -1..+1 range, so one more check to see if it's positive or negative won't > make much of a difference, I don't think. Though if you'd rather do > I don't care much

Re: [1/3] dsound: Add support for 32-bit IEEE float buffers

2010-09-14 Thread Chris Robinson
On Tuesday, September 14, 2010 3:38:47 am Henri Verbeet wrote: > Is that correct in the first place though? This will produce a > non-uniform mapping for positive and negative values. IIRC the common > way to do these kinds of mappings is "((x * (2^n - 1)) - 1) / 2", > which would be "x * 127.5f -

Re: [1/3] dsound: Add support for 32-bit IEEE float buffers

2010-09-14 Thread Henri Verbeet
On 14 September 2010 03:00, Chris Robinson wrote: > On Monday, September 13, 2010 12:55:43 pm Owen Rudge wrote: >> +        if (*v < -1.0f) d = -128; >> +        if (*v <  0.0f) d = *v * 128.0f; >> +        if (*v >= 0.0f) d = *v * 127.0f; >> +        if (*v >  1.0f) d = 127; > > The way these che

Desktop window doesn't span entire screen in multi-monitor setup?

2010-09-14 Thread Damjan Jovanovic
$ xrandr -q Screen 0: minimum 320 x 200, current 2732 x 768, maximum 8192 x 8192 GetWindowRect(GetDesktopWindow(), &r); r.left, r.top, r.right, r.bottom are: 0 0 1366 768 This causes WindowFromPoint() to fail (returns NULL) when the point is on my second monitor, which causes X11 -> Wine drag and

Re: [1/2] windowscodecs: support ICO files with embedded PNGs (try 2)

2010-09-14 Thread Damjan Jovanovic
Then please leave out my next patch in this series too, since it will cause regressions without this one. On Tue, Sep 14, 2010 at 7:52 AM, Vincent Povirk wrote: > I'm in the process of reorganizing the ICO decoder to address bug > 24301 and take advantage of the rest of WIC. I'd prefer to leave t