re: [PATCH 1/3] Validate buffers passed to schan_DecryptMessage

2010-09-05 Thread Dan Kegel
Mikko wrote: > Communicating with an external server is an option, but I don't > know which would be a good server for testing. https://mail.google.com ? Be sure to skip if you can't connect.

Re: [2/2] attrib/tests: added tests for some flags

2010-09-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5041 Your paranoid android.

Re: [PATCH 2/2] shlwapi: Improved UrlEscapeW implementation

2010-09-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5038 Your paranoid android.

Re: [PATCH 1/2] shlwapi: Improved UrlCanonicalize implementation (try2)

2010-09-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5039 Your paranoid android.

Re: [PATCH 2/2] shlwapi: Improved UrlEscapeW implementation (try2)

2010-09-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5040 Your paranoid android.

Re: gdi32/tests: Fix a typ description in test_logpen.

2010-09-05 Thread James McKenzie
Gerald Pfeifer wrote: winebot claims this is causing a tons of test failures on W98SE, but that doesn't make sense at all. Gerald: What is the job id on the testbot? I don't see a failure message in Wine-Devel. James McKenzie

Re: [PATCH 1/2] shlwapi: Improved UrlCanonicalize implementation

2010-09-05 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5037 Your paranoid android.

Re: [1/5] urlmon: Implemented IUriBuilder_{Get/Set}Fragment (try 2)

2010-09-05 Thread Jacek Caban
Hi Thomas, On 9/5/10 8:10 PM, Thomas Mullaly wrote: Changes since previous attempt: 1. Perform lazy allocation/copy of a URI property when the IUriBuilder_Get* function is called, instead of always allocating when the IUriBuilder is created (addresses Jacek's comments). 2. Created helper f

Re: [PATCH 1/3] Validate buffers passed to schan_DecryptMessage

2010-09-05 Thread Mikko Rasa
The patch list requests me to write tests for this patch. I would do that, but there is a problem: I need a fully initialized schannel security context to use DecryptMessage. To acquire one I need to communicate with a server component. Wine is lacking an implementation of at least the Accep

Re: msxml3: IXMLDOMText_get_text return trimmed text when XML_TEXT_NODE

2010-09-05 Thread GOUJON Alexandre
On 09/05/2010 11:52 AM, David Laight wrote: Not to mention the bloatage of using 'inline' for something that size I modified my patch accordingly but as I can't check the preserveWhiteSpace property, I have to wait. Anyway, thanks for all your advices !

Re: msxml3: IXMLDOMText_get_text return trimmed text when XML_TEXT_NODE

2010-09-05 Thread David Laight
On Thu, Sep 02, 2010 at 12:10:26PM +0200, Alexandre Julliard wrote: > Alexandre Goujon writes: > > > +static inline BSTR bstr_trim(const BSTR str) > > +{ ... > > +} > > That's ugly and inefficient, especially since the common case is to not > modify it. Not to mention the bloatage of using 'inl

Re: [PATCH] winealsa.drv: Count micelem in mixer chans, don't add spare capture input for half-duplex mics.

2010-09-05 Thread David Laight
On Wed, Sep 01, 2010 at 05:40:35PM +0200, Alexandre Julliard wrote: > Jeff Cook writes: > > > @@ -520,7 +520,12 @@ static void ALSA_MixerInit(void) > > } > > > > /* Add master channel, uncounted channels and an extra for capture > > */ > > -mixdev[mixnum].chans +

Re: msvcp90: Fix 64-bit compilation warnings

2010-09-05 Thread David Laight
On Wed, Sep 01, 2010 at 11:56:40AM +0200, Alexandre Julliard wrote: > Piotr Caban writes: > > > @@ -596,7 +596,7 @@ DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_char_erase, > > 12) > > basic_string_char* __thiscall MSVCP_basic_string_char_erase( > > basic_string_char *this, size_t pos, s