Help with 6120d7cc145, causing bugs

2010-08-24 Thread Jeff Cook
Just wondering if I could get a bit more review on commit 6120d7cc145 which was committed in early August. Here's a link: http://source.winehq.org/git/wine.git/?a=commit;h=6120d7cc14522983fbc38026ab4fcb6e4a68cdf0 There have been a few bug reports filed against it recently, see http://bugs.wine

Re: Inviting Mono and pulseaudio to wineconf?

2010-08-24 Thread Jeff Cook
On Wed, Aug 25, 2010 at 12:10 AM, Roderick Colenbrander wrote: > I'm not against inviting Pulseaudio guys. Sure, Pulseaudio was added > to distributions way too early and there still are a lot of issues but > sound servers like pulseaudio are really the way to go for the future. > People want to b

Re: Inviting Mono and pulseaudio to wineconf?

2010-08-24 Thread Roderick Colenbrander
I'm not against inviting Pulseaudio guys. Sure, Pulseaudio was added to distributions way too early and there still are a lot of issues but sound servers like pulseaudio are really the way to go for the future. People want to be able to plug in lets say a usb headset (so another soundcard) when pla

Re: wine.inf: added .NET InstallRoot key

2010-08-24 Thread Hin-Tak Leung
--- On Tue, 24/8/10, Vincent Povirk wrote: > > And eventually mono will be > installed automatically like gecko is? > > If I ever get the damn thing to build fully on a Linux box, > yes. Is there a problem with that? Mono comes with a script called "build-mingw32.sh" for cross-compiling on lin

Re: Inviting Mono and pulseaudio to wineconf?

2010-08-24 Thread James McKenzie
Dan Kegel wrote: Would it be appropriate and useful to invite someone from Mono and Pulseaudio to attend Wineconf this year? We do have to work well with those projects, maybe that would help solve a couple current or future problems. Dan: +1 on Mono, -1 on PulseAudio James McKenzie

Re: d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

2010-08-24 Thread misha680
Henri Verbeet wrote: > > On 24 August 2010 05:05, Misha Koshelev wrote: >> +elements[idx].Stream = 0xFF; >> +elements[idx].Offset = D3DXGetDeclVertexSize(elements, 0); >> +elements[idx].Stream = 0; > That's ugly. > >> +memcpy(Declaration, elements, size * sizeof(D3D

Re: Ongoing Debian package maintenance.

2010-08-24 Thread Lei Zhang
On Tue, Aug 24, 2010 at 3:06 PM, Ben Klein wrote: > On 24 August 2010 04:34, Lei Zhang wrote: >> >> On Fri, Aug 20, 2010 at 4:00 PM, Ben Klein wrote: >> > Hello everyone, >> > >> > My health has not improved at all since my last call for help with the >> > Debian package management. I really nee

Re: [PATCH] inetcpl: Add initial applet

2010-08-24 Thread Juan Lang
Hi Detlef, were you planning to resubmit this patch? [1] A user asked how to import a certificate recently [2], and I directed him to install ie6 to do so, but that has a lot of side effects which may not be wanted. Using our own inetcpl.cpl would allow us to avoid that, by exposing cryptui.Crypt

Re: [3/3] d3dcompiler: Move D3DAssemble tests from d3dx9_36.

2010-08-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4739 Your paranoid android.

Re: [3/4] oleaut32/olepicture: Fix ::get_hPal() behaviour for certain picture types

2010-08-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4737 Your paranoid android.

Re: [3/3] d3dcompiler: Move D3DAssemble tests from d3dx9_36.

2010-08-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4740 Your paranoid android.

Re: [4/4] oleaut32/tests: Some tests for IPicture::get_Handle()

2010-08-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4738 Your paranoid android.

Re: Ongoing Debian package maintenance.

2010-08-24 Thread Ben Klein
On 24 August 2010 04:34, Lei Zhang wrote: > > On Fri, Aug 20, 2010 at 4:00 PM, Ben Klein wrote: > > Hello everyone, > > > > My health has not improved at all since my last call for help with the > > Debian package management. I really need someone to take over from me, or at > > least some help t

Inviting Mono and pulseaudio to wineconf?

2010-08-24 Thread Dan Kegel
Would it be appropriate and useful to invite someone from Mono and Pulseaudio to attend Wineconf this year? We do have to work well with those projects, maybe that would help solve a couple current or future problems.

Re : Re : Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread paulo lesgaz
Added new tests for d3d7. No change. All the tests passed on real Vista David De : Stefan Dösinger À : paulo lesgaz Cc : wine-devel@winehq.org Envoyé le : Mar 24 août 2010, 20h 00min 05s Objet : Re: Re : Re : ddraw [try 2]: SetCooperativeLevel with Full scre

Re: Re : Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread Stefan Dösinger
Am 24.08.2010 um 17:48 schrieb paulo lesgaz: > Is this patch correct to test d3d7 and d3d2 SetCooperativeLevel? > For now, all the tests pass on a real vista box. Actually, I missed something: The exising test tests IDirectDraw, not IDirectDraw7. So it is testing the oldest ddraw interface. Can

Re: wine.inf: added .NET InstallRoot key

2010-08-24 Thread Vincent Povirk
Yes, build-mingw32.sh works, but the resulting build is incomplete. For example, it lacks libgluezilla and a mozilla library to glue to, so the browsing component does not work. This is in the official Windows builds of Mono. I don't know what else is missing. On Tue, Aug 24, 2010 at 12:45 PM, Hi

Re: wine.inf: added .NET InstallRoot key

2010-08-24 Thread Vincent Povirk
> And eventually mono will be installed automatically like gecko is? If I ever get the damn thing to build fully on a Linux box, yes.

Re : Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread paulo lesgaz
Is this patch correct to test d3d7 and d3d2 SetCooperativeLevel? For now, all the tests pass on a real vista box. David De : Stefan Dösinger À : paulo lesgaz Cc : wine-devel@winehq.org Envoyé le : Mar 24 août 2010, 16h 44min 38s Objet : Re: Re : ddraw [try 2]

wine.inf: added .NET InstallRoot key

2010-08-24 Thread Louis Lenders
Dan Kegel kegel.com> writes: > > What is our intent with adding all these registry keys? > It seems as if they are helpful for installing mono, > but might get in the way of installing MS .net. > > If that's the intent, do y'all want me to make the > dotnet20 winetricks verb remove any registry

Re: Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread Stefan Dösinger
I think those tests should do, but have a few spelling issues and you're not releasing the surface. So if I understand things correctly: *) NORMAL | FULLSCREEN | EXCLUSIVE -> fullscreen mode *) NORMAL | EXCLUSIVE -> error *) NORMAL | FULLSCREEN -> windowed mode For testing older ddraw interface

Re: wine.inf: added .NET InstallRoot key

2010-08-24 Thread Dan Kegel
On Tue, Aug 24, 2010 at 1:52 PM, Alexandre Julliard wrote: >> What is our intent with adding all these registry keys? >> It seems as if they are helpful for installing mono, >> but might get in the way of installing MS .net. > > If they prevent installing MS .NET there should be a way to undo them

Re: wine.inf: added .NET InstallRoot key

2010-08-24 Thread Alexandre Julliard
Dan Kegel writes: > What is our intent with adding all these registry keys? > It seems as if they are helpful for installing mono, > but might get in the way of installing MS .net. If they prevent installing MS .NET there should be a way to undo them like we do for IE, by unregistering mscoree o

Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread paulo lesgaz
Such tests are what you were thinking about? They all passed on my real vista box. David De : Stefan Dösinger À : wine-devel@winehq.org Envoyé le : Mar 24 août 2010, 11h 30min 59s Objet : Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive +

Re: msvcrt:locale Remove todo_wine and add broken when necessary

2010-08-24 Thread GOUJON Alexandre
On 08/24/2010 02:51 PM, Octavian Voicu wrote: broken() only works for tests that fail on some Windows versions; it has no effect on Wine, see [1]. My mistake. Proper way to fix this bug is to make setlocale replicate Windows behavior. I'll investigate further to fix it this way. Than

Re: msvcrt:locale Remove todo_wine and add broken when necessary

2010-08-24 Thread Octavian Voicu
On Tue, Aug 24, 2010 at 12:44 PM, Alexandre Goujon wrote: > -        todo_wine ok(!strcmp(ret, "Chinese (Simplified)_People's Republic of > China.936") > +        ok(!strcmp(ret, "Chinese (Simplified)_People's Republic of > China.936") > +        || broken(!strcmp(ret, "Chinese_People's Republic

re: wine.inf: added .NET InstallRoot key

2010-08-24 Thread Dan Kegel
What is our intent with adding all these registry keys? It seems as if they are helpful for installing mono, but might get in the way of installing MS .net. If that's the intent, do y'all want me to make the dotnet20 winetricks verb remove any registry keys that confuse the dotnet20 installer?

Re: Wine Gecko 1.1.0 RC1

2010-08-24 Thread Jacek Caban
On 8/24/10 12:12 PM, Luca Bennati wrote: Applied the patch to master, recompiled ok. I put the rc1 cab in /usr/share/wine/gecko/, as always. In the creation of a new prefix, it gave me an err which wasn't there before: err:mshtml:init_xpcom AutoRegister(NULL) failed: 80070057 but 'wine iexpl

Re: mscoree: improve GetCORVersion

2010-08-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4727 Your paranoid android.

Wine Gecko 1.1.0 RC1

2010-08-24 Thread Luca Bennati
Applied the patch to master, recompiled ok. I put the rc1 cab in /usr/share/wine/gecko/, as always. In the creation of a new prefix, it gave me an err which wasn't there before: err:mshtml:init_xpcom AutoRegister(NULL) failed: 80070057 but 'wine iexplore' works better than before (sites that cra

Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread paulo lesgaz
The added tests show that the change is correct for d3d7 at least. How can I check that they are also correct for olders ddraw? David De : Henri Verbeet À : wine-devel@winehq.org Envoyé le : Mar 24 août 2010, 11h 41min 36s Objet : Re: ddraw [try 2]: SetCooper

Re: d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

2010-08-24 Thread Henri Verbeet
On 24 August 2010 05:05, Misha Koshelev wrote: > +elements[idx].Stream = 0xFF; > +elements[idx].Offset = D3DXGetDeclVertexSize(elements, 0); > +elements[idx].Stream = 0; That's ugly. > +memcpy(Declaration, elements, size * sizeof(D3DVERTEXELEMENT9)); That's unnecessary

Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread Henri Verbeet
This looks suspicious to me, you have to assume the code wasn't just added for the hell of it, even though with ddraw you're never quite sure. Do other ddraw versions behave the same? Please don't add trailing spaces, neither in the code nor in TRACEs.

Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread Stefan Dösinger
Hi, Can you add a test that tests in which mode ddraw is after such a call? Specfically, try to create a double buffered primary surface. If this succeeds, ddraw is in fullscreen mode. If ddraw is in normal mode you'll get DDERR_NOEXCLUSIVEMODE (or similar) back. Am 24.08.2010 um 10:00 schrieb

Re: Use SUBLANG_NEUTRAL for the Gaelic resources?

2010-08-24 Thread Huw Davies
On Tue, Aug 24, 2010 at 09:59:51AM +0200, Francois Gouget wrote: > > Are SUBLANG_GAELIC, SUBLANG_GAELIC_SCOTTISH and SUBLANG_GAELIC_MANX very > different languages? > > If not it would be better to use SUBLANG_NEUTRAL instead of > SUBLANG_GAELIC. For instance: I think they're different enough

Re: explorerframe/tests: Add a trailing '\n' to an ok() call.

2010-08-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4711 Your paranoid android.

Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4710 Your paranoid android.

Re: [PATCH 1/5] server: move is_removeable to fd_ops

2010-08-24 Thread Alexandre Julliard
Mike Kaplinskiy writes: > On Wed, Aug 4, 2010 at 1:29 AM, Mike Kaplinskiy > wrote: >> --- >>  server/change.c     |    2 ++ >>  server/device.c     |    1 + >>  server/fd.c         |   18 -- >>  server/file.c       |    1 + >>  server/file.h       |    3 +++ >>  server/mailslot.c

Re: How managing crashing tests ?

2010-08-24 Thread GOUJON Alexandre
On 08/23/2010 11:47 PM, Andrew Eikum wrote: Just don't execute the code on that platforms that don't support it. How to check if the platform supports that codepath can be tricky, and there are a lot of ways to do it. Some examples are to use GetProcAddress; use a different function (if it's n

Use SUBLANG_NEUTRAL for the Gaelic resources?

2010-08-24 Thread Francois Gouget
Are SUBLANG_GAELIC, SUBLANG_GAELIC_SCOTTISH and SUBLANG_GAELIC_MANX very different languages? If not it would be better to use SUBLANG_NEUTRAL instead of SUBLANG_GAELIC. For instance: dlls/mapi32/Ga.rc |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mapi32/Ga.r

Re: ddraw/tests: New visual back buffer flipping tests. (resend)

2010-08-24 Thread GOUJON Alexandre
On 08/23/2010 11:28 PM, Oldřich Jedlička wrote: My mistake, I've mixed up the C and C++ comments. I thought // is the C style (for a while). I will send the fixed patch In fact, // is not C++ only : it has been added in the C99 revision. But for compatibility, we don't accept C99. Have a look at