Re: [PATCH 1/2] quartz/tests: move shareable code to a separate file

2010-08-21 Thread Anton Khirnov
On Sat, Aug 21, 2010 at 07:50:50PM -0700, James McKenzie wrote: > Looks like you did not test the build before running it against the > testbot (I've been guilty of this as well.) > actually i did test it and it worked for some reason, must be magic :) in any case, after rebasing it doesn't -- and

Re: [PATCH 1/2] quartz/tests: move shareable code to a separate file

2010-08-21 Thread James McKenzie
(Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4626 Your

Re: [PATCH 2/5] ddraw/tests: New visual back buffer flipping tests. (try 5, resend)

2010-08-21 Thread Oldřich Jedlička
Hi Stefan, On Thursday 19 August 2010 15:40:53 Stefan Dösinger wrote: > This test contains a C++ comment, please remove it. Otherwise it looks ok, > as does patch 1 I will start sending patches one-by-one and wait until it is applied - as you recommended. It will not contain the [PATCH x/y] pref

Re: [PATCH 2/2] quartz: implement IBaseFilter_FindPin

2010-08-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4627 Your paranoid android.

Re: [PATCH 1/2] quartz/tests: move shareable code to a separate file

2010-08-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4626 Your paranoid android.

Re: Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread Frédéric Delanoy
2010/8/21 Octavian Voicu : > 2010/8/21 GOUJON Alexandre : >> [format] >>        headers = "To: wine-patches \nReply-To: >> wine-devel \n" > > As the name of the section suggests, this adds header lines to files > generated with `git format-patch'. If you then send those files with > `git send-email

Re: problem with ./configure & libGLU vs. libice-dev

2010-08-21 Thread Austin English
On Fri, Aug 20, 2010 at 4:26 PM, wrote: > > Hi, > > isn't there a problem with wine's configure script? I'm running on > new Debian Squezee and noticed (luckily), that when libice-dev is > installed, than ./configure can't find "-lGLU". > > But libice-dev doesn't have any influence on file "libGL

Re: Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread GOUJON Alexandre
On 08/21/2010 03:35 PM, Frédéric Delanoy wrote: This is used for git imap-send, and does not work for git-send-email (I checked). Following the relevant git send-email section (http://wiki.winehq.org/GitWine#head-f09f3498e5910648468960a60ecf0f51b0fd4815 - Sending the patches using smtp), I set "t

Re: Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread Octavian Voicu
2010/8/21 GOUJON Alexandre : > [format] >        headers = "To: wine-patches \nReply-To: > wine-devel \n" As the name of the section suggests, this adds header lines to files generated with `git format-patch'. If you then send those files with `git send-email', it should work. If you `git send-ema

Re: Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread Frédéric Delanoy
2010/8/21 GOUJON Alexandre : > On 08/21/2010 09:34 AM, Frédéric Delanoy wrote: >> >> Here's how my git config looks like: >> [sendemail] >> >> from = user >> to = wine-patches >> assume8bitEncoding = UTF-8 >> >> suppresscc = self >> chainreplyto = false >> thread = false >> suppressfrom = true >>

Re: appwiz.cpl: Removed sign comparison warning

2010-08-21 Thread Nikolay Sivov
On 8/21/2010 12:18, Marko Nikolic wrote: Nikolay Sivov wrote: On 8/20/2010 20:04, Marko Nikolic wrote: Changed variable type to match function return type. --- dlls/appwiz.cpl/appwiz.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/appwiz.cpl/appwiz.c b

Re: appwiz.cpl: Removed sign comparison warning

2010-08-21 Thread Marko Nikolic
Nikolay Sivov wrote: > On 8/20/2010 20:04, Marko Nikolic wrote: >> Changed variable type to match function return type. >> --- >> dlls/appwiz.cpl/appwiz.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/dlls/appwiz.cpl/appwiz.c b/dlls/appwiz.cpl/appwiz.c >> i

Re: dlls/d3dx9_36/bytecodewriter.c oddity

2010-08-21 Thread Gerald Pfeifer
On Thu, 19 Aug 2010, Matteo Bruni wrote: > Hmm, so srcidx is unused. Yes, that piece of code is useless now, it's > a remnant of an older version of that function where the source > register was handled by some ad-hoc code, which I since then replaced > with a call to the generic This->funcs->srcre

Re: crypt32: Correct CryptVerifyMessageSignature's use of pcbDecoded

2010-08-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4624 Your paranoid android.

Re: Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread GOUJON Alexandre
On 08/21/2010 09:34 AM, Frédéric Delanoy wrote: Here's how my git config looks like: [sendemail] from = user to = wine-patches assume8bitEncoding = UTF-8 suppresscc = self chainreplyto = false thread = false suppressfrom = true From http://wiki.winehq.org/GitWine#head-4051a521ff163340844

Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread Frédéric Delanoy
I've tried for some time to specify the wine-devel Reply-To using git-send-email, with little success so far Any idea how this might be done? Here's how my git config looks like: [sendemail] from = user to = wine-patches assume8bitEncoding = UTF-8 suppresscc = self chainreplyto = false thread

Re: [PATCH 2/5] shell32/tests: Add initial tests for the IExplorerBrowser control.

2010-08-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4601 Your paranoid android.

Re: [PATCH 4/5] shell32: Implement IExplorerBrowser::Initialize.

2010-08-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4603 Your paranoid android.

Re: [PATCH] ntdll/tests: Add tests for RtlIpv4AddressToString / RtlIpv4AddressToStringEx [try 5]

2010-08-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4600 Your paranoid android.

Re: [PATCH 3/5] shell32: Add IShellBrowser stub.

2010-08-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4602 Your paranoid android.

Re: [PATCH 5/5] shell32: Implement IExplorerBrowser::SetRect.

2010-08-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4604 Your paranoid android.

Re: advpakc/tests: Removed sign comparison warning in advpack tests

2010-08-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4599 Your paranoid android.