Re: [2/2] ws2_32, WS2_sendto: Avoid error when sending zero byte buffer (try 2)

2010-08-14 Thread Mike Kaplinskiy
Several things: - Don't set errno. For good practice it's more or less read-only. - All the tests have to pass after each patch, so if your tests fail (which they probably should) without your patch, add todo_wine and then remove them in the followup patch (or just send the tests second). - The

Re: kernel32/tests: GetVolumeInformationA X: succeeds iff drive's default dir is root. (try 2)

2010-08-14 Thread Greg Geldorp
Hi Joerg, I temporarily attached a second disk to all TestBot VMs and ran the test, both from the C: drive and from the (new) E: drive. Full results attached. In short: everything passes. Ge. volume.rpt Description: volume.rpt

RE: Wine users with a CD-ROM drive, please test

2010-08-14 Thread Greg Geldorp
Hi Joerg, > From: Joerg Hoehle > > I found out that some machines ignore > set c audio all off > which was in the testsuite, while others react to it and even > update the system preferences volume mixer control if > it happens to be open. > > I don't know whether that difference depends on the HW