Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 2)

2010-08-02 Thread Oldřich Jedlička
Hi Stefan, On Tuesday 03 August 2010 04:45:57 test...@testbot.winehq.org wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full res

Re: [PATCH 09/10] ddraw: Add checking of SURFACEDESC type into CreateSurface methods. (try 2)

2010-08-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4188 Your paranoid android.

Re: [PATCH 08/10] ddraw: Allow attaching backbuffers and primaries. (try 2)

2010-08-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4187 Your paranoid android.

Re: [PATCH 07/10] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 2)

2010-08-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4186 Your paranoid android.

Re: [PATCH 2/5] ws2_32/tests: test ConnectEx

2010-08-02 Thread Mike Kaplinskiy
On Mon, Aug 2, 2010 at 11:50 PM, Mike Kaplinskiy wrote: > --- >  dlls/ws2_32/tests/sock.c |  227 > ++ >  1 files changed, 227 insertions(+), 0 deletions(-) > Shoot, any chance you can just take #1 and take 2-5 from the first batch? That's an outdated n

Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 2)

2010-08-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4179 Your paranoid android.

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 2)

2010-08-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4178 Your paranoid android.

Re: [PATCH 02/10] ddraw/tests: New attachment/flipping tests for back buffers. (try 2)

2010-08-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4175 Your paranoid android.

Re: [PATCH 01/10] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests. (try 2)

2010-08-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4174 Your paranoid android.

Re: [5/5] wined3d: Fix NaN and Inf generation in msvc

2010-08-02 Thread Vitaly Budovski
On 02/08/2010, Henri Verbeet wrote: > On 2 August 2010 13:20, GOUJON Alexandre wrote: > > Why don't you use math.h NAN macro ? > > A quick search on google gave me > > http://www.gnu.org/software/libc/manual//html_node/Infinity-and-NaN.html > > > > That's not portable enough. > The INFINITY

Re: shdocvw: Update French translation

2010-08-02 Thread Frédéric Delanoy
Please discard; has been mangled by misconfigured git 2010/8/2 Frédéric Delanoy : > --- >  dlls/shdocvw/Fr.rc |    5 + >  1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/dlls/shdocvw/Fr.rc b/dlls/shdocvw/Fr.rc > index 94b4a7e..b7326bb 100644 > --- a/dlls/shdocvw/Fr.rc > +++ b

Re: wordpad: Added Hebrew translation.

2010-08-02 Thread Yaron Shahrabani
On Mon, Aug 2, 2010 at 6:33 PM, Alexandre Julliard wrote: > Paul Vriens writes: > > >> Eventually we probably have to but I'm not sure what Alexandre > >> thinks about introducing it (now). We probably also have to teach > >> our tools (like the translation site) that detects translat

Re: write: Added Hebrew translation

2010-08-02 Thread Yaron Shahrabani
LOL, I knew I forgot something... Yaron Shahrabani On Mon, Aug 2, 2010 at 6:13 PM, Paul Vriens wrote: > On 08/02/2010 04:57 PM, Yaron Shahrabani wrote: > >> +++ b/programs/write/He.rc >> @@ -0,0 +1,30 @@ >> +/* >> + * English language support >> > > Should be 'Hebrew' of course ;) > > -- > C

Re: wordpad: Added Hebrew translation.

2010-08-02 Thread Yaron Shahrabani
On Sun, Aug 1, 2010 at 4:59 PM, Paul Vriens wrote: > Hi Yaron, > > > On 08/01/2010 10:52 AM, Yaron Shahrabani wrote: > >> Alexander and Paul, please notice I added the EXSTYLE WS_EX_LAYOUTRTL >> for the dialogs, hope that helps. >> >> Also found out that menus does not need any special RTL propert

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-02 Thread Ricardo Filipe
2010/8/2 Jeff Cook : > What compiler are you running? It works fine for me and I don't see > any errors or warnings. > > On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard > wrote: >> Jeff Cook writes: >> >>> @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer) >>>      for (id = 0; id <

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-02 Thread Jeff Cook
What compiler are you running? It works fine for me and I don't see any errors or warnings. On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard wrote: > Jeff Cook writes: > >> @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer) >>      for (id = 0; id < mmixer->chans; ++id) >>      { >>

Latest version of ddraw/tests plus fixes

2010-08-02 Thread Oldřich Jedlička
Hi Stefan, Roderick, I've sent my latest version of ddraw/tests plus some fixes right now (it takes some time to get to wine-patches ML), one of them fixes bug #9008. Unfortunately I don't have much spare time (and actually I didn't have it the whole time working on patches), my spare time is almo

Re: The WineAPI wiki.

2010-08-02 Thread Gert van den Berg
On Mon, Aug 2, 2010 at 19:26, Max TenEyck Woodbury wrote: > On 08/02/2010 01:04 PM, Gert van den Berg wrote: > >> There seem to be several interfaces to retreive MSDN articles... Some >> of those interface might be more stable / provide a way to retrieve a >> current link? (Framing the content wou

Re: The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
On 08/02/2010 01:04 PM, Gert van den Berg wrote: There seem to be several interfaces to retreive MSDN articles... Some of those interface might be more stable / provide a way to retrieve a current link? (Framing the content would probably not be allowed, but retreiving links should be...) If i

Re: The WineAPI wiki.

2010-08-02 Thread Gert van den Berg
On Mon, Aug 2, 2010 at 18:16, Max TenEyck Woodbury wrote: > There should be links to the Microsoft documentation in each article, > but Microsoft has been known to move their documentation around without > maintaining redirects. To avoid being at Microsoft's mercy in this, a > summary (*not* a dup

Re: The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
On 08/02/2010 11:18 AM, James Mckenzie wrote: Max TenEyck Woodbury wrote: On 08/02/2010 07:00 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: I have started the WineAPI wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php?title=Main_Page You have chosen not very goo

Re: The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
On 08/02/2010 11:25 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: Further, there is a little confusing and incorrect information in the Microsoft documentation. Bluntly, the Microsoft documentation is what they want it to be. We need to document what it really is. Regardless of the

Re: [PATCH 1/4] wined3d: separate driver info from GPU info

2010-08-02 Thread Roderick Colenbrander
On Mon, Aug 2, 2010 at 2:58 AM, Henri Verbeet wrote: > On 1 August 2010 05:37, Roderick Colenbrander wrote: >>  struct driver_version_information >>  { >> +    WORD vendor;                        /* reported PCI card vendor ID  */ > ... >> +    enum wined3d_display_driver driver; >> +}; > That do

Re: wordpad: Added Hebrew translation.

2010-08-02 Thread Alexandre Julliard
Paul Vriens writes: >> Eventually we probably have to but I'm not sure what Alexandre >> thinks about introducing it (now). We probably also have to teach >> our tools (like the translation site) that detects translation >> differences/issues to cope with this. >> >> So I shouldn'

Re: The WineAPI wiki.

2010-08-02 Thread Dmitry Timoshkov
Max TenEyck Woodbury wrote: > >> Further, there is a little confusing and incorrect information in the > >> Microsoft documentation. Bluntly, the Microsoft documentation is what > >> they want it to be. We need to document what it really is. > > > > Regardless of the quality of Microsoft document

Re: The WineAPI wiki.

2010-08-02 Thread James Mckenzie
Max TenEyck Woodbury wrote: >Sent: Aug 2, 2010 4:25 AM >To: wine-devel@winehq.org >Subject: Re: The WineAPI wiki. > >On 08/02/2010 07:00 AM, Dmitry Timoshkov wrote: >> Max TenEyck Woodbury wrote: >> >>> I have started the WineAPI wiki at >>> >>> https://sourceforge.net/apps/mediawiki/wineapi/inde

Re: wordpad: Added Hebrew translation.

2010-08-02 Thread Paul Vriens
On 08/02/2010 05:04 PM, Yaron Shahrabani wrote: On Sun, Aug 1, 2010 at 4:59 PM, Paul Vriens mailto:paul.vriens.w...@gmail.com>> wrote: Hi Yaron, On 08/01/2010 10:52 AM, Yaron Shahrabani wrote: Alexander and Paul, please notice I added the EXSTYLE WS_EX_LAYOUTRTL

Re: write: Added Hebrew translation

2010-08-02 Thread Paul Vriens
On 08/02/2010 04:57 PM, Yaron Shahrabani wrote: +++ b/programs/write/He.rc @@ -0,0 +1,30 @@ +/* + * English language support Should be 'Hebrew' of course ;) -- Cheers, Paul.

Re: The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
On 08/02/2010 07:53 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: You have chosen not very good name. There is no such a thing as Wine API, Wine implements Win32 API, and doesn't specify/add anything custom to it. The name "WineAPI" implies that Wine defines its own API which is not

Re: winex11.drv: implement drag and drop from X to OLE (try 3)

2010-08-02 Thread Alexandre Julliard
Damjan Jovanovic writes: > @@ -300,6 +499,66 @@ static void X11DRV_XDND_ResolveProperty(Display > *display, Window xwin, Time tm, > wine_tsx11_unlock(); > } > > +/* We get the list of formats in descending order of preference, yet the > linked > + * list is a stack so th

Re: winex11.drv: implement X session management (try 2)

2010-08-02 Thread Alexandre Julliard
Damjan Jovanovic writes: > +static void SM_Init(void) > +{ > +CreateThread(NULL, 0, manage_session, NULL, 0, NULL); > +} > +#endif /* defined(SONAME_LIBSM) */ You don't want to create a new thread in every process for this. It will cause lots of trouble. -- Alexandre Julliard julli...@wine

Re: [PATCH 07/10] explorerframe/nstc: Implement Initialize.

2010-08-02 Thread Alexandre Julliard
David Hedberg writes: > +/* Native accepts a NULL prc, so should we. */ > +if(prc) > +SetWindowPos(This->hwnd_main, HWND_TOP, prc->left, prc->top, > + prc->right - prc->left, prc->bottom - prc->top, > SWP_SHOWWINDOW); It would be better to create it directly

Re: shell32: Partial implementation of IShellItem::BindToHandler.

2010-08-02 Thread Nikolay Sivov
On 8/2/2010 16:07, David Hedberg wrote: On Mon, Aug 2, 2010 at 10:50 AM, Nikolay Sivov wrote: Ok, this test is present already cause Desktop list is an empty list. So please change this test for mkid.cb magic value to _ILIsEmpty() in BindToObject() and all other occurrences too (InitializeTre

Re: [PATCH 1/5] include/mswsock: add WS_ prefix if necessary

2010-08-02 Thread Alexandre Julliard
Mike Kaplinskiy writes: > @@ -173,11 +174,28 @@ typedef BOOL (WINAPI * LPFN_TRANSMITFILE)(SOCKET, > HANDLE, DWORD, DWORD, LPOVERLA > typedef BOOL (WINAPI * LPFN_TRANSMITPACKETS)(SOCKET, > LPTRANSMIT_PACKETS_ELEMENT, DWORD, DWORD, LPOVERLAPPED, DWORD); > typedef INT (WINAPI * LPFN_WSARECVMSG)

Re: shell32: Partial implementation of IShellItem::BindToHandler.

2010-08-02 Thread David Hedberg
On Mon, Aug 2, 2010 at 10:50 AM, Nikolay Sivov wrote: > > Ok, this test is present already cause Desktop list is an empty list. So > please change this test for > mkid.cb magic value to _ILIsEmpty() in BindToObject() and all other > occurrences too (InitializeTreeView() for example). > Is someth

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-02 Thread Alexandre Julliard
Jeff Cook writes: > @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer) > for (id = 0; id < mmixer->chans; ++id) > { > line *mline = &mmixer->lines[id]; > +if (!mline->elem) > +{ > +break; > +} > int ofs = CONTROLSPERLINE *

Re: [5/5] shdocvw: Recurse into directories when adding Favorites

2010-08-02 Thread Alexandre Julliard
Alexander Nicolaysen Sørnes writes: > @@ -109,10 +109,10 @@ static void add_fav_to_menu(HMENU menu, LPWSTR title, > LPCWSTR url) > { > MENUITEMINFOW item; > /* Subtract the number of standard elements in the Favorites menu */ > -INT favcount = GetMenuItemCount(menu) - 2; > +st

Re: The WineAPI wiki.

2010-08-02 Thread Dmitry Timoshkov
Max TenEyck Woodbury wrote: > > You have chosen not very good name. There is no such a thing as Wine API, > > Wine implements Win32 API, and doesn't specify/add anything custom to it. > > The name "WineAPI" implies that Wine defines its own API which is not true, > > and is confusing. > > > This

GetVolumeInformationA: please test this on MS-Windows

2010-08-02 Thread Joerg-Cyril.Hoehle
Jeff Zaroyko wrote: >Would you mind supplying a new binary? Testbot did it for us: job #4154 https://testbot.winehq.org/JobDetails.pl?Key=4154 Regards, Jörg Höhle

Re: mshtml: Send more informative messages to OleInPlaceFrame

2010-08-02 Thread Jacek Caban
On 08/02/10 13:30, Alexander Nicolaysen Sørnes wrote: > These are displayed in Internet Explorer. > > > Alexander N. Sørnes > +LPCWSTR get_statustext(INT id, BOOL has_arg, LPCWSTR arg_in) WHy do you need has_arg argument? Isn't NULL arg_in enough to recognize no argument? +{ +static LPWSTR

Re: [5/5] wined3d: Fix NaN and Inf generation in msvc

2010-08-02 Thread Henri Verbeet
On 2 August 2010 13:20, GOUJON Alexandre wrote: > Why don't you use math.h NAN macro ? > A quick search on google gave me > http://www.gnu.org/software/libc/manual//html_node/Infinity-and-NaN.html > That's not portable enough.

Re: The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
On 08/02/2010 07:00 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: I have started the WineAPI wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php?title=Main_Page You have chosen not very good name. There is no such a thing as Wine API, Wine implements Win32 API, and do

Re: [5/5] wined3d: Fix NaN and Inf generation in msvc

2010-08-02 Thread GOUJON Alexandre
On 08/02/2010 12:00 PM, Henri Verbeet wrote: On 31 July 2010 08:48, Stefan Dösinger wrote: This workaround isn't ideal, Yeah, I don't think this is much of an improvement Why don't you use math.h NAN macro ? A quick search on google gave me http://www.gnu.org/software/libc/manual/

Re: The WineAPI wiki.

2010-08-02 Thread Dmitry Timoshkov
Max TenEyck Woodbury wrote: > I have started the WineAPI wiki at > > https://sourceforge.net/apps/mediawiki/wineapi/index.php?title=Main_Page You have chosen not very good name. There is no such a thing as Wine API, Wine implements Win32 API, and doesn't specify/add anything custom to it. The n

The WineAPI wiki.

2010-08-02 Thread Max TenEyck Woodbury
I have started the WineAPI wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php?title=Main_Page Some issues have come up that may need to be discussed here. In particular, there is going to be an 'Overview' section for many articles and I think the information to fill it in should co

Re: [5/5] wined3d: Fix NaN and Inf generation in msvc

2010-08-02 Thread Henri Verbeet
On 31 July 2010 08:48, Stefan Dösinger wrote: > This workaround isn't ideal, Yeah, I don't think this is much of an improvement.

Re: [PATCH 1/4] wined3d: separate driver info from GPU info

2010-08-02 Thread Henri Verbeet
On 1 August 2010 05:37, Roderick Colenbrander wrote: >  struct driver_version_information >  { > +    WORD vendor;                        /* reported PCI card vendor ID  */ ... > +    enum wined3d_display_driver driver; > +}; That doesn't make all that much sense.

Re: [PATCH 4/4] jscript: Use generic property for Error.number.

2010-08-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4153 Your paranoid android.

Re: GetVolumeInformationA: please test this on MS-Windows

2010-08-02 Thread Jeff Zaroyko
On Mon, Aug 2, 2010 at 7:03 PM, wrote: > Hi, > > Jeff Zaroyko wrote: >>No failures outside of MinGW. > Thanks. This validates the relationship between GetVolumeInformation > and the per-drive current directory on win95/98/2k/xp/7. > >>Inside MinGW, I invoke cmd to run the batch file: >>volume: 40

Re: [PATCH 3/4] jscript: Fixed test crash on some win9x installations.

2010-08-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4152 Your paranoid android.

Re: [PATCH 2/4] jscript: Use generic properties for NaN and Infinity implementation.

2010-08-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4151 Your paranoid android.

GetVolumeInformationA: please test this on MS-Windows

2010-08-02 Thread Joerg-Cyril.Hoehle
Hi, Jeff Zaroyko wrote: >No failures outside of MinGW. Thanks. This validates the relationship between GetVolumeInformation and the per-drive current directory on win95/98/2k/xp/7. >Inside MinGW, I invoke cmd to run the batch file: >volume: 406 tests executed (0 marked as todo, 2 failures), 0 ski

Re: shell32: Partial implementation of IShellItem::BindToHandler.

2010-08-02 Thread Nikolay Sivov
On 8/2/2010 12:07, David Hedberg wrote: Hi, On Mon, Aug 2, 2010 at 7:04 AM, Nikolay Sivov wrote: On 8/2/2010 02:36, David Hedberg wrote: +static HRESULT ShellItem_get_shellfolder(ShellItem *This, IBindCtx *pbc, IShellFolder **ppsf) +{ +IShellFolder *desktop; +HRESULT ret; + +re

Re: shell32: Partial implementation of IShellItem::BindToHandler.

2010-08-02 Thread David Hedberg
Hi, On Mon, Aug 2, 2010 at 7:04 AM, Nikolay Sivov wrote: >  On 8/2/2010 02:36, David Hedberg wrote: >> >> +static HRESULT ShellItem_get_shellfolder(ShellItem *This, IBindCtx *pbc, >> IShellFolder **ppsf) >> +{ >> +    IShellFolder *desktop; >> +    HRESULT ret; >> + >> +    ret = SHGetDesktopFold