Re: wiki slightly broken still?

2010-07-29 Thread Francois Gouget
On Thu, 29 Jul 2010, Dimi Paun wrote: > On Thu, 2010-07-29 at 18:17 +0200, Michael Stefaniuc wrote: > > Yes, the LocalBadContent page got pretty long; I'm fairly sure it's > > the spam checking that takes so long. > > I tried to empty it, and it does seem to help. However, it's not > the only cau

Re: Right-To-Left (RTL) languages and Wine

2010-07-29 Thread Paul Vriens
On 07/29/2010 08:13 PM, Alexandre Julliard wrote: Paul Vriens writes: I've been in talks with a Hebrew translator for some time now and I'd like to have Wine being able to start doing more RTL stuff. I'm looking for example at http://bugs.winehq.org/show_bug.cgi?id=1158 If I run an English w

Re: [2/4] tools: enable .lnk thumbnailing in Gnome

2010-07-29 Thread Nicholas van Oudtshoorn
On 07/28/2010 08:54 AM, Scott Ritchie wrote: On 07/26/2010 03:57 AM, Alexandre Julliard wrote: Damjan Jovanovic writes: diff --git a/tools/Makefile.in b/tools/Makefile.in index a9ec324..a0c9c99 100644 --- a/tools/Makefile.in +++ b/tools/Makefile.in @@ -75,6 +75,8 @@ install install-lib:: wine

Re: [2/4] tools: enable .lnk thumbnailing in Gnome

2010-07-29 Thread Nicholas van Oudtshoorn
On 07/28/2010 08:54 AM, Scott Ritchie wrote: On 07/26/2010 03:57 AM, Alexandre Julliard wrote: Damjan Jovanovic writes: diff --git a/tools/Makefile.in b/tools/Makefile.in index a9ec324..a0c9c99 100644 --- a/tools/Makefile.in +++ b/tools/Makefile.in @@ -75,6 +75,8 @@ install install-lib:: wine

Re: explorer: implement X session management

2010-07-29 Thread Paul "TBBle" Hampson
On 30 July 2010 01:30, Dmitry Timoshkov wrote: > Damjan Jovanovic wrote: >> Changelog: >> * explorer: implement X session management > Explorer should not have X11 as a dependency. This should be implemented > inside of winex11.drv. A (previously-discussed years ago) model for DirectInput/RawI

Re: [PATCH] d3dx9_36/tests: Added HLSL test suite.

2010-07-29 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4052 Your paranoid android.

Re: [1/2] richedit: Return correct values when EM_SETTEXTMODE fails.

2010-07-29 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4043 Your paranoid android.

Re: [PATCH] d3dx9_36/tests: Added HLSL test suite.

2010-07-29 Thread David Adam
On a real Vista windows box, tests fail at line 372: test failed: sin: Got 2: unexpected values line 385:test failed: cos: Got 2: unexpected values A+ David

Re: wiki slightly broken still?

2010-07-29 Thread Uwe Bonnes
> "Octavian" == Octavian Voicu writes: >> "What is the name for a billion bytes?" Terabyte, at least in germany. Billion -> 10^12. 10^9 -> "Milliarde" So these questions can be tricky... -- Uwe Bonnesb...@elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik

Re: [PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

2010-07-29 Thread Oldřich Jedlička
Hi Roderick, On Thursday 22 July 2010 22:26:39 Roderick Colenbrander wrote: > On Thu, Jul 22, 2010 at 10:14 PM, Stefan Dösinger > > wrote: > > Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: > >> DirectX 1 interface allowed creation of explicit back buffers, so move > >> the restrictive checks

Re: wiki slightly broken still?

2010-07-29 Thread Octavian Voicu
On Thu, Jul 29, 2010 at 8:41 PM, Dan Kegel wrote: > I like the idea.  It is hard, but here are some possible questions: > > "What is the first name of the Finn who created the Linux operating system?" > "What is the abbreviation for the GNU C Compiler?" > "What is the name of the simple text edito

Re: [PATCH 3/8] explorerframe/nstc: Add host window and create a treeview.

2010-07-29 Thread David Hedberg
On Thu, Jul 29, 2010 at 9:19 PM, David Hedberg wrote: > --- >  dlls/explorerframe/explorerframe_main.h |    3 + >  dlls/explorerframe/nstc.c               |  211 > ++- >  dlls/explorerframe/tests/nstc.c         |   49 +++- >  3 files changed, 260 insertions(+), 3 d

Re: shell32: Initialize memory to zero in IShellItemArray constructor.

2010-07-29 Thread David Hedberg
On Thu, Jul 29, 2010 at 9:16 PM, Nikolay Sivov wrote: > I don't see a reason for this. If you want to zero two remaining fields do > it explicitly. Also this helper doesn't need WINAPI it seems. > Ok, please ignore this one then, I'll try again.

Re: shell32: Initialize memory to zero in IShellItemArray constructor.

2010-07-29 Thread Nikolay Sivov
On 7/29/2010 22:21, David Hedberg wrote: This is needed as we might, if passed an invalid riid, hit ::Release before we get to initialize array or item_count. --- dlls/shell32/shellitem.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/shellitem.c b/dlls

Re: Right-To-Left (RTL) languages and Wine

2010-07-29 Thread Austin English
On Thu, Jul 29, 2010 at 1:13 PM, Alexandre Julliard wrote: > Paul Vriens writes: > >> I've been in talks with a Hebrew translator for some time now and I'd >> like to have Wine being able to start doing more RTL stuff. >> >> I'm looking for example at http://bugs.winehq.org/show_bug.cgi?id=1158 >

Re: Right-To-Left (RTL) languages and Wine

2010-07-29 Thread Alexandre Julliard
Paul Vriens writes: > I've been in talks with a Hebrew translator for some time now and I'd > like to have Wine being able to start doing more RTL stuff. > > I'm looking for example at http://bugs.winehq.org/show_bug.cgi?id=1158 > > If I run an English winmine.exe on an Arabic box (thanks to the

Re: krnl386.exe: Fix last error check for DOS compatibility hack.

2010-07-29 Thread Alexandre Julliard
Andrew Nguyen writes: > Hmm, is there any situation where CreateFile yields a last error of > ERROR_WRITE_PROTECT? If an application requests GENERIC_WRITE access > on a file residing on a read-only file system, CreateFile on NT > platforms seems to always set the last error to ERROR_ACCESS_DENIE

Re: wiki slightly broken still?

2010-07-29 Thread Dan Kegel
On Thu, Jul 29, 2010 at 9:01 AM, Dimi Paun wrote: >> Should we also add another hurdle (possibly even manual approval) >> to make it harder for spammers to get accounts? > > Now that this issue is fixed, we can look again at the spam > problem. It was suggested that we use a 'TextChas' for non > l

Re: wiki slightly broken still?

2010-07-29 Thread Dimi Paun
On Thu, 2010-07-29 at 18:17 +0200, Michael Stefaniuc wrote: > Yes, the LocalBadContent page got pretty long; I'm fairly sure it's > the spam checking that takes so long. I tried to empty it, and it does seem to help. However, it's not the only cause of the problem, it's still not fast even with an

Re: [PATCH] mmdevapi/tests: Prevent crash when GetMixFormat fails.

2010-07-29 Thread Octavian Voicu
On Thu, Jul 29, 2010 at 6:50 PM, Alexandre Julliard wrote: > That's ugly, you should check the function result, not a magic pointer > value. I wanted to differentiate between the various cases in which the function can fail, but I guess that's not really required. I'll send another version. What

Re: wiki slightly broken still?

2010-07-29 Thread Michael Stefaniuc
Dimi Paun wrote: > On Wed, 2010-07-28 at 22:35 +0100, David Gerard wrote: >> Ubuntu hit this one: >> >> https://bugs.edge.launchpad.net/ubuntu/+source/moin/+bug/217191 >> http://moinmo.in/MoinMoinBugs/AllPagesSavedToSingleDirectory > > Thanks David for the links. > > I've run the cleanup scripts,

Re: krnl386.exe: Fix last error check for DOS compatibility hack.

2010-07-29 Thread Andrew Nguyen
On 07/29/2010 10:48 AM, Alexandre Julliard wrote: Andrew Nguyen writes: @@ -1092,7 +1092,7 @@ static BOOL INT21_CreateFile( CONTEXT86 *context, winMode, winAttributes, 0 ); /* DOS allows to open files on a CDROM R/W */ if( winHandle == INV

Re: wiki slightly broken still?

2010-07-29 Thread Dimi Paun
On Wed, 2010-07-28 at 15:06 -0700, Dan Kegel wrote: > > I'm looking into how we can clean this up. > > Should we also add another hurdle (possibly even manual approval) > to make it harder for spammers to get accounts? Now that this issue is fixed, we can look again at the spam problem. It was su

Re: wiki slightly broken still?

2010-07-29 Thread Dimi Paun
On Wed, 2010-07-28 at 22:35 +0100, David Gerard wrote: > Ubuntu hit this one: > > https://bugs.edge.launchpad.net/ubuntu/+source/moin/+bug/217191 > http://moinmo.in/MoinMoinBugs/AllPagesSavedToSingleDirectory Thanks David for the links. I've run the cleanup scripts, and we are now down to ~5K pa

Re: [PATCH] mmdevapi/tests: Prevent crash when GetMixFormat fails.

2010-07-29 Thread Alexandre Julliard
Octavian Voicu writes: > @@ -190,25 +190,31 @@ static void test_audioclient(IAudioClient *ac) > hr = IAudioClient_GetMixFormat(ac, NULL); > ok(hr == E_POINTER, "GetMixFormat returns %08x\n", hr); > > +pwfx = (void *)0xdeadbeef; > hr = IAudioClient_GetMixFormat(ac, &pwfx); >

Re: msi: prevent cryptical errors

2010-07-29 Thread Alexandre Julliard
André Hentschel writes: > when accidently using the wrong path then > err:msi:MSI_OpenPackageW can't find L"asf.msi" > is more readable than > err:msi:copy_package_to_temp failed to copy package L"asf.msi" to > L"C:\\users\\dawncrow\\Temp\\msi71e7.tmp" (2) Then you should fix that f

Re: krnl386.exe: Fix last error check for DOS compatibility hack.

2010-07-29 Thread Alexandre Julliard
Andrew Nguyen writes: > @@ -1092,7 +1092,7 @@ static BOOL INT21_CreateFile( CONTEXT86 *context, > winMode, winAttributes, 0 ); > /* DOS allows to open files on a CDROM R/W */ > if( winHandle == INVALID_HANDLE_VALUE && > -GetLastE

Re: explorer: implement X session management

2010-07-29 Thread Dmitry Timoshkov
Damjan Jovanovic wrote: > Changelog: > * explorer: implement X session management Explorer should not have X11 as a dependency. This should be implemented inside of winex11.drv. -- Dmitry.

Right-To-Left (RTL) languages and Wine

2010-07-29 Thread Paul Vriens
Hi, I've been in talks with a Hebrew translator for some time now and I'd like to have Wine being able to start doing more RTL stuff. I'm looking for example at http://bugs.winehq.org/show_bug.cgi?id=1158 If I run an English winmine.exe on an Arabic box (thanks to the testbot) the main windo

Re: GetVolumeInformationA: please test this on MS-Windows

2010-07-29 Thread Jeff Zaroyko
On Thu, Jul 29, 2010 at 11:17 PM, Andrew Eikum wrote: > On 07/29/2010 03:43 AM, joerg-cyril.hoe...@t-systems.com wrote: >> >> Andrew, >> >>> Run on a Win98SE VM.  The E drive is a CDROM drive. >> >> Thank you very much for the result. I added the broken(GetLastError()) for >> Win9x >> based on you

Re: GetVolumeInformationA: please test this on MS-Windows

2010-07-29 Thread Andrew Eikum
On 07/29/2010 03:43 AM, joerg-cyril.hoe...@t-systems.com wrote: Andrew, Run on a Win98SE VM. The E drive is a CDROM drive. Thank you very much for the result. I added the broken(GetLastError()) for Win9x based on your data. Now is your chance to repeat the test with https://testbot.winehq.or

Re: user32: Add a test for GetClassInfo, make it pass under Wine.

2010-07-29 Thread Dmitry Timoshkov
Paul Vriens wrote: > On 07/29/2010 08:55 AM, Dmitry Timoshkov wrote: > > +SetLastError(0xdeadbeef); > > +ret = GetClassInfoEx(0, "static", NULL); > > Why not the explicit A-function? I see there is already an existing call > in the current tests, but still. An API without a suffix is A

Re: user32: Add a test for GetClassInfo, make it pass under Wine.

2010-07-29 Thread Paul Vriens
On 07/29/2010 08:55 AM, Dmitry Timoshkov wrote: +SetLastError(0xdeadbeef); +ret = GetClassInfoEx(0, "static", NULL); Why not the explicit A-function? I see there is already an existing call in the current tests, but still. +ok(!ret, "GetClassInfoEx() should fail\n"); +ok(Get

Re: user32: Add a test for GetClassInfo, make it pass under Wine.

2010-07-29 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4013 Your paranoid android.