Re: [2/3] shlwapi/ordinal: Partially implement SHGetShellKey

2010-07-28 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4012 Your paranoid android.

Re: [1/3] shlwapi/tests: Fix some test failures on Win2000

2010-07-28 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4011 Your paranoid android.

Re: [PATCH] mmdevapi/tests: Prevent crash when GetMixFormat fails.

2010-07-28 Thread Octavian Voicu
On Thu, Jul 29, 2010 at 3:57 AM, Octavian Voicu wrote: > Test results from test.winehq.org show that GetMixFormat consistently > fails on some configurations (usually for both capture and render, > sometimes only for capture). I also found out why GetMixFormat fails on my system (Kubuntu 10.04).

Re: siggraph / opengl BOF tonight

2010-07-28 Thread Dan Kegel
On Wed, Jul 28, 2010 at 3:12 PM, Dan Kegel wrote: > Siggraph happens to be a stone's throw from my house > this year, and one of the presenters was my frosh roommate :-), > so I'm heading over to the opengl BOF to listen in. > ( http://www.khronos.org/news/events/detail/siggraph-la-2010/#topengl_b

Re: [6/6] urlmon/tests: Added some more test URIs (resend)

2010-07-28 Thread Thomas Mullaly
On Wed, Jul 28, 2010 at 8:09 PM, Marvin wrote: > > === WXPPROSP3 (32 bit uri) === > uri.c:2169: Test failed: Expected http://google.com:00035 but got L" > http://google.com:35"; on uri_tests[60].str_props[2]. > uri.c:2400: Test failed: Error: Expected http://google.com:00035 but got > L"http://goo

Re: [6/6] urlmon/tests: Added some more test URIs (resend)

2010-07-28 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4009 Your paranoid android.

siggraph / opengl BOF tonight

2010-07-28 Thread Dan Kegel
Siggraph happens to be a stone's throw from my house this year, and one of the presenters was my frosh roommate :-), so I'm heading over to the opengl BOF to listen in. ( http://www.khronos.org/news/events/detail/siggraph-la-2010/#topengl_bof ) Email me or google chat me if you want me to try to f

Re: wiki slightly broken still?

2010-07-28 Thread Frédéric Delanoy
On Wed, Jul 28, 2010 at 23:35, David Gerard wrote: > On 28 July 2010 21:49, Dimi Paun wrote: >> On Wed, 2010-07-28 at 13:05 -0700, Dan Kegel wrote: > >>> Creating new wiki pages seems broken today... > >> Yes, due to all the spam, we've hit the ext3 limit >> of subdirectories (32k). More here: >>

Re: wiki slightly broken still?

2010-07-28 Thread Dan Kegel
On Wed, Jul 28, 2010 at 1:49 PM, Dimi Paun wrote: > Yes, due to all the spam, we've hit the ext3 limit > of subdirectories (32k). More here: >    http://www.rooftopsolutions.nl/blog/135 > > I'm looking into how we can clean this up. Should we also add another hurdle (possibly even manual approval

Re: wiki slightly broken still?

2010-07-28 Thread David Gerard
On 28 July 2010 21:49, Dimi Paun wrote: > On Wed, 2010-07-28 at 13:05 -0700, Dan Kegel wrote: >> Creating new wiki pages seems broken today... > Yes, due to all the spam, we've hit the ext3 limit > of subdirectories (32k). More here: >    http://www.rooftopsolutions.nl/blog/135 > I'm looking int

Re: shdocvw: Add French translation

2010-07-28 Thread Frédéric Delanoy
2010/7/28 Alexander Nicolaysen Sørnes : >  Onsdag 28. juli 2010 18.24.23 skrev Paul Vriens : >> On 07/27/2010 10:28 AM, Frédéric Delanoy wrote: >> >> >> We now have an error on the translation site as you've merged 'New' and >> 'Window'. >> >> I know you brought this up on wine-devel but until agre

Re: shdocvw: Add French translation

2010-07-28 Thread Frédéric Delanoy
2010/7/28 Paul Vriens : > On 07/27/2010 10:28 AM, Frédéric Delanoy wrote: >> > > We now have an error on the translation site as you've merged 'New' and > 'Window'. > > I know you brought this up on wine-devel but until agreed upon we should > stick to the English one IMHO. > > -- > Cheers, > > Pau

Re: wiki slightly broken still?

2010-07-28 Thread Dimi Paun
On Wed, 2010-07-28 at 13:05 -0700, Dan Kegel wrote: > Creating new wiki pages seems broken today... Yes, due to all the spam, we've hit the ext3 limit of subdirectories (32k). More here: http://www.rooftopsolutions.nl/blog/135 I'm looking into how we can clean this up. -- Dimi Paun Lattica

wiki slightly broken still?

2010-07-28 Thread Dan Kegel
Creating new wiki pages seems broken today...

Re: shdocvw: Add French translation

2010-07-28 Thread Alexander Nicolaysen Sørnes
Onsdag 28. juli 2010 18.24.23 skrev Paul Vriens : > On 07/27/2010 10:28 AM, Frédéric Delanoy wrote: > > > We now have an error on the translation site as you've merged 'New' and > 'Window'. > > I know you brought this up on wine-devel but until agreed upon we should > stick to the English one I

Re: imm32: Set size of OSVERSIONINFOA before calling GetVersionExA

2010-07-28 Thread Andrew Nguyen
On Wed, Jul 28, 2010 at 12:46 PM, Matt 'Murph' Finnicum wrote: > This was causing console spam when I played Starcraft 2 (since > dwPlatformId was used uninitialized and thus was invalid). > > > > Hi Matt, Your patch causes declarations and code in the ImmGetVirtualKey function to be mixed, some

Re: shdocvw: Add French translation

2010-07-28 Thread Paul Vriens
On 07/27/2010 10:28 AM, Frédéric Delanoy wrote: We now have an error on the translation site as you've merged 'New' and 'Window'. I know you brought this up on wine-devel but until agreed upon we should stick to the English one IMHO. -- Cheers, Paul.

Re: [PATCH 1/4] ddraw: Use a less offensive handle table implementation for materials.

2010-07-28 Thread Henri Verbeet
Oh, I see what happens there. IDirect3DImpl_7_CreateDevice() doesn't zero it's fields during creation. I'll send a patch to have ddraw_handle_table_init() do explicitly itself tomorrow.

Re: [2/4] tools: enable .lnk thumbnailing in Gnome

2010-07-28 Thread Damjan Jovanovic
On Wed, Jul 28, 2010 at 5:11 PM, Frank Richter wrote: > On 28.07.2010 09:36, Damjan Jovanovic wrote: >> thumbnails that are missing on every startup. But even if this is >> acceptable solution, it's still hard to implement, because the >> thumbnail cache spec requires specific thumbnail sizes (128

Re: [2/4] tools: enable .lnk thumbnailing in Gnome

2010-07-28 Thread Frank Richter
On 28.07.2010 09:36, Damjan Jovanovic wrote: > thumbnails that are missing on every startup. But even if this is > acceptable solution, it's still hard to implement, because the > thumbnail cache spec requires specific thumbnail sizes (128x128 or > 256x256) and a special pixel format (256 colour in

Re: [PATCH 1/4] ddraw: Use a less offensive handle table implementation for materials.

2010-07-28 Thread Alexandre Julliard
Henri Verbeet writes: > IDirect3DDeviceImpl_CreateHandle() is particular is just awful. > --- > dlls/ddraw/ddraw_private.h | 30 - > dlls/ddraw/device.c| 63 - > dlls/ddraw/direct3d.c | 10 > dlls/ddraw/executebuffer.c | 26 --

Re: [PATCH] comdlg32/tests: Use GetOpenFileNameA instead of GetOpenFileNameW

2010-07-28 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3990 Your paranoid android.

Re: [3/5] urlmon: Implemented canonicalization for ports in URIs

2010-07-28 Thread Thomas Mullaly
On Wed, Jul 28, 2010 at 8:14 AM, Alexandre Julliard wrote: > Thomas Mullaly writes: > > > --- > > dlls/urlmon/uri.c | 88 > > +++- > > 1 files changed, 86 insertions(+), 2 deletions(-) > > It doesn't work here: > > ../../../tools/runtest -q -P wi

Re: [2/4] tools: enable .lnk thumbnailing in Gnome

2010-07-28 Thread Vincent Povirk
According to MSDN http://msdn.microsoft.com/en-us/library/ee719797%28VS.85%29.aspx#png__image_format, WIC can save indexed color PNG's on Windows. You just need to give it 8-bit indexed image data. Wine's WIC does not support this, but I can work on adding support if there's a real need.

Re: [3/5] urlmon: Implemented canonicalization for ports in URIs

2010-07-28 Thread Alexandre Julliard
Thomas Mullaly writes: > --- > dlls/urlmon/uri.c | 88 > +++- > 1 files changed, 86 insertions(+), 2 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so uri.c && touch uri.ok uri

Re: [PATCH 5/11] quartz: Add MediaSeekingPassThru to video renderer

2010-07-28 Thread Alexandre Julliard
Maarten Lankhorst writes: > From 42723d1e254d1fa5b6a64a56d895e05c035780bc Mon Sep 17 00:00:00 2001 > From: Maarten Lankhorst > Date: Sat, 22 May 2010 15:58:15 +0200 > Subject: [PATCH 13/32] quartz: Add MediaSeekingPassThru to video renderer It doesn't work here: ../../../tools/runtest -q -P wi

Re: comctl32/treeview: Fix a crash in TVS_SINGELEXPAND helper (Coverity)

2010-07-28 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3980 Your paranoid android.

Re: [1/2] d3dx9_36: Handle parent_data parameter of D3DXInclude.Open() function.

2010-07-28 Thread Henri Verbeet
On 27 July 2010 23:32, Matteo Bruni wrote: > +if(parent_include == NULL) > +ERR("Parent include file missing\n"); If that's an internal error, shouldn't the call fail? Similar for the wpp_open_mem() changes.

Re: [2/2] d3dx9: Implement D3DXAssembleShaderFromFile.

2010-07-28 Thread Henri Verbeet
On 27 July 2010 23:32, Matteo Bruni wrote: > +if(parent_data != NULL) > +parent_name = *((char **)parent_data - 1); That casts away const. The ID3DXInclude interface itself looks somewhat broken to me, but I don't think you need to modify the parent name here. Please use "const char *"

Re: [2/4] tools: enable .lnk thumbnailing in Gnome

2010-07-28 Thread Scott Ritchie
On 07/28/2010 12:36 AM, Damjan Jovanovic wrote: >> > > freedesktop.org has a spec for a shared thumbnail cache > (http://triq.net/~jens/thumbnail-spec/index.html), but no accepted > spec for a file browser to request that a file be thumbnailed: there's > a draft DBUS thumbnailing spec that's been h

Re: ddraw: Added a todo_wine test for SetCooperativeLevel

2010-07-28 Thread Stefan Dösinger
Am 28.07.2010 um 00:39 schrieb Johan Gill: > > The test seems OK to me. Not sure why patchbot is complaining, but it is running in virtual machines, so I guess we can blame its ddraw setup.

Re: [2/4] tools: enable .lnk thumbnailing in Gnome

2010-07-28 Thread Damjan Jovanovic
On Wed, Jul 28, 2010 at 2:54 AM, Scott Ritchie wrote: > On 07/26/2010 03:57 AM, Alexandre Julliard wrote: >> Damjan Jovanovic writes: >> >>> diff --git a/tools/Makefile.in b/tools/Makefile.in >>> index a9ec324..a0c9c99 100644 >>> --- a/tools/Makefile.in >>> +++ b/tools/Makefile.in >>> @@ -75,6 +7