Re: Any more infos about the build failure for my (small) patch

2010-07-23 Thread James McKenzie
James Mckenzie wrote: Octavian Voicu wrote: On Fri, Jul 23, 2010 at 12:32 PM, Uwe Bonnes wrote: Paul> SSL_CTX *SSL_CTX_new(SSL_METHOD *meth); 61557 88 -rw-r--r-- 1 root Paul> root 87238 Jun 2 11:11 ./usr/include/openssl/ssl.h Ah, Readhat defining in it's own way. What about debi

Re: [1/5] gameux: Add initial implementation of gameux.dll

2010-07-23 Thread James McKenzie
Dan McDonald wrote: On 07/21/2010 11:10 AM, André Hentschel wrote: Am 21.07.2010 19:01, schrieb Mariusz Pluciński: W dniu 19.07.2010 15:02, Henri Verbeet pisze: 2010/7/18 Mariusz Pluciński: +static HINSTANCE hInstance; This is unused. You're mixing tabs an

Re: [1/5] shdocvw: Add menu bar to Internet Explorer (try2)

2010-07-23 Thread Frédéric Delanoy
2010/7/21 Alexander Nicolaysen Sørnes : > This series adds a menu bar and Open URL dialog box to Wine's IE. > > try2: > - Fix errors pointed out by Jacek > - Don't use  ExecWB() until we can be sure it uses CGID_MSHTML > Alexander N. Sørnes You should merge the "New" and "Window" in a single menu

Re: [1/5] gameux: Add initial implementation of gameux.dll

2010-07-23 Thread Dan McDonald
On 07/21/2010 11:10 AM, André Hentschel wrote: > Am 21.07.2010 19:01, schrieb Mariusz Pluciński: >> W dniu 19.07.2010 15:02, Henri Verbeet pisze: >>> 2010/7/18 Mariusz Pluciński: +static HINSTANCE hInstance; >>> This is unused. >>> >>> You're mixing tabs and spaces, and have a couple of traili

re: RFC: draft HLSL test suite

2010-07-23 Thread Dan Kegel
Henri wrote: >> http://wiki.winehq.org/HLSLTestSuite > That page is pretty awful. Yep, it was written very quickly by somebody who doesn't know d3d at all. Now that somebody's working on an HLSL test suite, it can fade away, or maybe be replaced with a description of the final test suite, if that

Re: Build error introduced by f1ea06375d76c9f8e181e3ee4874ddef661e80c2

2010-07-23 Thread André Hentschel
Am 23.07.2010 18:26, schrieb Octavian Voicu: > Seems that f1ea06375d76c9f8e181e3ee4874ddef661e80c2 introduces a build > error on Ubuntu with gcc 4.4.3. > > [...] > ccache gcc -m32 -c -I../../../wine-git/dlls/user32 -I. > -I../../../wine-git/include -I../../include -D__WINESRC__ -D_USER32_ > -D_WI

Build error introduced by f1ea06375d76c9f8e181e3ee4874ddef661e80c2

2010-07-23 Thread Octavian Voicu
Seems that f1ea06375d76c9f8e181e3ee4874ddef661e80c2 introduces a build error on Ubuntu with gcc 4.4.3. [...] ccache gcc -m32 -c -I../../../wine-git/dlls/user32 -I. -I../../../wine-git/include -I../../include -D__WINESRC__ -D_USER32_ -D_WINABLE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing

Re: Any more infos about the build failure for my (small) patch

2010-07-23 Thread Austin English
On Fri, Jul 23, 2010 at 8:50 AM, James Mckenzie wrote: > Octavian Voicu wrote: >>On Fri, Jul 23, 2010 at 12:32 PM, Uwe Bonnes >> wrote: >>>    Paul> SSL_CTX *SSL_CTX_new(SSL_METHOD *meth); 61557 88 -rw-r--r-- 1 root >>>    Paul> root 87238 Jun 2 11:11 ./usr/include/openssl/ssl.h >>> >>> Ah, Readha

Re: [PATCH 1/2] shlwapi: Implement SHGetIniStringW

2010-07-23 Thread Paul Vriens
On 07/23/2010 04:19 PM, Andrew Eikum wrote: +memset(out, 0, sizeof(out)); It's usually better to fill it with something other than '0'. Checking later for '0' could mean that either the rest of the buffer is indeed untouched or is cleared/zeroed. -- Cheers, Paul.

Re: [PATCH 1/2] shlwapi: Implement SHGetIniStringW

2010-07-23 Thread Andrew Eikum
On 07/23/2010 08:57 AM, Vitaliy Margolen wrote: On 07/21/2010 10:23 AM, Andrew Eikum wrote: Please more-less follow the format of the file and don't add yet one more. +if(outLen == 0) +return 0; Need space between "if" and "(". +if(!buf){ Curly bracket goes on to separate

Re: [PATCH 1/2] shlwapi: Implement SHGetIniStringW

2010-07-23 Thread Vitaliy Margolen
On 07/21/2010 10:23 AM, Andrew Eikum wrote: Please more-less follow the format of the file and don't add yet one more. +if(outLen == 0) +return 0; Need space between "if" and "(". +if(!buf){ Curly bracket goes on to separate line. +buf = HeapAlloc(GetProcessHeap(), 0, o

Re: Any more infos about the build failure for my (small) patch

2010-07-23 Thread James Mckenzie
Octavian Voicu wrote: >On Fri, Jul 23, 2010 at 12:32 PM, Uwe Bonnes > wrote: >>    Paul> SSL_CTX *SSL_CTX_new(SSL_METHOD *meth); 61557 88 -rw-r--r-- 1 root >>    Paul> root 87238 Jun 2 11:11 ./usr/include/openssl/ssl.h >> >> Ah, Readhat defining in it's own way. >> What about debian? >> >> Isn't th

Re: Any more infos about the build failure for my (small) patch

2010-07-23 Thread Octavian Voicu
On Fri, Jul 23, 2010 at 12:32 PM, Uwe Bonnes wrote: >    Paul> SSL_CTX *SSL_CTX_new(SSL_METHOD *meth); 61557 88 -rw-r--r-- 1 root >    Paul> root 87238 Jun 2 11:11 ./usr/include/openssl/ssl.h > > Ah, Readhat defining in it's own way. > What about debian? > > Isn't the OpenSSL documentation way th

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere.

2010-07-23 Thread Henri Verbeet
2010/7/23 Misha Koshelev : > Please find attached the relevant data. > > I do not see a way from this data to generate the faces a vertex is part of > that would be simpler > than what I am doing for indices. > Well, if you look at e.g. the data for slices 6, stacks 7, there indices are certainly

Re: cmd: Fix cmd's mishandling of quote-enclosed command strings

2010-07-23 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3778 Your paranoid android.

Re: Any more infos about the build failure for my (small) patch

2010-07-23 Thread Uwe Bonnes
> "Paul" == Paul Vriens writes: >> Paul> And this is what my include file shows: Paul> SSL_CTX *SSL_CTX_new(SSL_METHOD *meth); 61557 88 -rw-r--r-- 1 root Paul> root 87238 Jun 2 11:11 ./usr/include/openssl/ssl.h Ah, Readhat defining in it's own way. What about debian? Isn'

Re: Any more infos about the build failure for my (small) patch

2010-07-23 Thread Paul Vriens
On 07/23/2010 11:18 AM, Paul Vriens wrote: On 07/23/2010 10:53 AM, Uwe Bonnes wrote: Hello, on my Suse 11.3, /usr/include/ssl/ssl.h defines const SSL_METHOD *method; as does http://www.openssl.org/docs/ssl/ssl.html and so in ../dlls/winhttp/net.c and ../dlls/wininet/netconnection.c static SSL_

Re: Any more infos about the build failure for my (small) patch

2010-07-23 Thread Paul Vriens
On 07/23/2010 10:53 AM, Uwe Bonnes wrote: Hello, on my Suse 11.3, /usr/include/ssl/ssl.h defines const SSL_METHOD *method; as does http://www.openssl.org/docs/ssl/ssl.html and so in ../dlls/winhttp/net.c and ../dlls/wininet/netconnection.c static SSL_METHOD *method; is flagges as an warning. M

Re: [6/9] msi: Add some tests for MsiGetSourcePath.

2010-07-23 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3772 Your paranoid android.

Re: [5/9] msi: Set/unset the SourceDir property at the right stage in the execution sequence.

2010-07-23 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3771 Your paranoid android.

Any more infos about the build failure for my (small) patch

2010-07-23 Thread Uwe Bonnes
Hello, on my Suse 11.3, /usr/include/ssl/ssl.h defines const SSL_METHOD *method; as does http://www.openssl.org/docs/ssl/ssl.html and so in ../dlls/winhttp/net.c and ../dlls/wininet/netconnection.c static SSL_METHOD *method; is flagges as an warning. My patch exchanged -static SSL_METHOD *metho

Re: [3/9] msi/tests: Properly contruct the icon path for win9x.

2010-07-23 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3770 Your paranoid android.

Re: [PATCH 1/4] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests.

2010-07-23 Thread Stefan Dösinger
Am 22.07.2010 um 22:15 schrieb Oldřich Jedlička: > > This is redundant, lpDD is already an IDirectDraw interface. > You are right, I thought it is some default (=latest, V7) interface. I will > change it. Fyi: static LPDIRECTDRAW lpDD = NULL; LPDIRECTDRAW is just a typedef for IDirectDraw * . I