Re: How about a registry key/environment variable to disable creation of .desktop files?

2010-07-22 Thread Austin English
On Thu, Jul 22, 2010 at 11:56 PM, Scott Ritchie wrote: > In my automated testing I've noticed that some apps create desktop links > without asking and there's no way to avoid them.  It's a similar > situation for start menu entries. > > It would be nice to be able to have an entire install fully c

How about a registry key/environment variable to disable creation of .desktop files?

2010-07-22 Thread Scott Ritchie
In my automated testing I've noticed that some apps create desktop links without asking and there's no way to avoid them. It's a similar situation for start menu entries. It would be nice to be able to have an entire install fully contained in a .wine folder that could be cleanly deleted after th

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere. (try 2)

2010-07-22 Thread Misha Koshelev
I hate to do this but I would rather look bad as a person than taint Wine with imperfect code. Thus, I will please ask to hold my very own patch for the moment. I don't honestly know that there is a better way to come up with indices but I have some ideas, mainly looking at: http://local.wasp.uwa

Re: [1/2] gdiplus: Fixed GdipFillClosedCurve2 and GdipFillClosedCurve2I in the cases that count <= 1.

2010-07-22 Thread Andrew Nguyen
On 07/22/2010 09:12 PM, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/Job

Re: [2/2] gdiplus: Implemented GdipFillClosedCurve and GdipFillClosedCurveI.

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3764 Your paranoid android.

Re: [1/2] gdiplus: Fixed GdipFillClosedCurve2 and GdipFillClosedCurve2I in the cases that count <= 1.

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3763 Your paranoid android.

Re: [PATCH 2/4] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3756 Your paranoid android.

Re: [try 2] [2/4] d3dx9: Add basic implementation of D3DXFilterTexture, plus tests

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3760 Your paranoid android.

Re: user32: Implement GetUserObjectInformation with index=UOI_USER_SID

2010-07-22 Thread Dmitry Timoshkov
Wolfgang Schwotzer wrote: > +size = 0; > +GetUserNameW( NULL, &size ); > + > +user_name = HeapAlloc( GetProcessHeap(), 0, (size + 1) * > sizeof(WCHAR) ); > +if (!user_name) { > +SetLastError(ERROR_OUTOFMEMORY); > +re

Re: [PATCH 1/2] comdlg32/tests: Untie ok_testcases from test_ok()

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3754 Your paranoid android.

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere.

2010-07-22 Thread Misha Koshelev
> > +static DWORD compute_sphere_test_index_data(FLOAT radius, UINT slices, > > UINT stacks) > I haven't really thought this through yet, but would it perhaps be > simpler to calculate the faces a vertex is part of, instead of the > other way around? > Please find attached the relevant data. I

Re: [PATCH 2/2] comdlg32: Store and use save/open dialogs' most-recently-used data

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3755 Your paranoid android.

Re: [PATCH 1/4] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests.

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3753 Your paranoid android.

Re: [PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

2010-07-22 Thread Oldřich Jedlička
Hi Roderick, On Thursday 22 July 2010 22:26:39 Roderick Colenbrander wrote: > On Thu, Jul 22, 2010 at 10:14 PM, Stefan Dösinger > > wrote: > > Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: > >> DirectX 1 interface allowed creation of explicit back buffers, so move > >> the restrictive checks

Re: [PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

2010-07-22 Thread Roderick Colenbrander
On Thu, Jul 22, 2010 at 10:14 PM, Stefan Dösinger wrote: > > Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: > >> DirectX 1 interface allowed creation of explicit back buffers, so move the >> restrictive checks to DirectX 2+ implementations. > It is still missing testing/handling of AddAttachedSu

Re: [PATCH 1/4] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests.

2010-07-22 Thread Oldřich Jedlička
Hi Stefan, On Thursday 22 July 2010 22:05:21 Stefan Dösinger wrote: > Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: > > +hr = IDirectDraw_QueryInterface(lpDD, &IID_IDirectDraw, (void **) > > &dd); +ok(SUCCEEDED(hr), "IDirectDraw_QueryInterface failed: > > 0x%08x\n", hr); > > This is re

Re: [PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

2010-07-22 Thread Stefan Dösinger
Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: > DirectX 1 interface allowed creation of explicit back buffers, so move the > restrictive checks to DirectX 2+ implementations. It is still missing testing/handling of AddAttachedSurface

Re: [PATCH 1/4] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests.

2010-07-22 Thread Stefan Dösinger
Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: > +hr = IDirectDraw_QueryInterface(lpDD, &IID_IDirectDraw, (void **) &dd); > +ok(SUCCEEDED(hr), "IDirectDraw_QueryInterface failed: 0x%08x\n", hr); This is redundant, lpDD is already an IDirectDraw interface. > +hr = IDirectDraw_Create

Re: [PATCH 1/3] msvcp90: Added allocator implementation

2010-07-22 Thread Alexandre Julliard
Alexandre Julliard writes: > Piotr Caban writes: > >> + >> +#include "config.h" >> +#include "wine/port.h" > > You can't use port.h in files that use msvcrt headers, it will cause > conflicts. Most likely you don't want to import msvcrt in msvcp90, only > load it at run-time. Actually it turns

Re: [shlwapi/tests] Load shell32 explicitly

2010-07-22 Thread Paul Vriens
On 07/22/2010 05:34 PM, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/Job

Re: [shlwapi/tests] Load shell32 explicitly

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3738 Your paranoid android.

Re: [PATCH 2/3] msvcp90/tests: Added allocator tests

2010-07-22 Thread Alexandre Julliard
Piotr Caban writes: > Almost all tests will need macros for calling functions. Should I > define them in every test file? You can have a header in the tests if absolutely necessary. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 1/3] msvcp90: Added allocator implementation

2010-07-22 Thread Alexandre Julliard
Piotr Caban writes: > + > +#include "config.h" > +#include "wine/port.h" You can't use port.h in files that use msvcrt headers, it will cause conflicts. Most likely you don't want to import msvcrt in msvcp90, only load it at run-time. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 2/3] msvcp90/tests: Added allocator tests

2010-07-22 Thread Piotr Caban
On 07/22/10 17:04, Alexandre Julliard wrote: Piotr Caban writes: diff --git a/dlls/msvcp90/tests/Makefile.in b/dlls/msvcp90/tests/Makefile.in index b7fb8e5..9ac5ef5 100644 --- a/dlls/msvcp90/tests/Makefile.in +++ b/dlls/msvcp90/tests/Makefile.in @@ -5,7 +5,7 @@ VPATH = @srcdir@ TESTDLL

Re: RFC: draft HLSL test suite

2010-07-22 Thread Henri Verbeet
On 21 July 2010 23:46, Travis Athougies wrote: > an HLSL test suite might be a good place to start, so here's a draft > of a test framework and a few tests that use it.  It's not complete, I > know (for one, I need to write tests for vertex shaders), but before I > go any farther, I'd like to know

Re: [7/7] msi/tests: Fix some more wow64 test failures.

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3722 Your paranoid android.

Re: [1/5] kernel32: only strip the wine_get_dos_file_name NTDLL path prefix if is present

2010-07-22 Thread Alexandre Julliard
Damjan Jovanovic writes: > It won't always be present when the next patch is applied, which > returns \\?\unix/... The next patch is wrong then. NT filename don't start with \\?\. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 3/3] msvcp90: Add exception throwing function

2010-07-22 Thread Alexandre Julliard
Piotr Caban writes: > Some of the exception data is filled in fill_exception_data > function. Is it acceptable? It would be nicer to avoid calling thiscall functions across dlls. The exception vtable is exported so you can access it directly, and replicate the constructor code. -- Alexandre Ju

Re: [PATCH 2/3] msvcp90/tests: Added allocator tests

2010-07-22 Thread Alexandre Julliard
Piotr Caban writes: > diff --git a/dlls/msvcp90/tests/Makefile.in b/dlls/msvcp90/tests/Makefile.in > index b7fb8e5..9ac5ef5 100644 > --- a/dlls/msvcp90/tests/Makefile.in > +++ b/dlls/msvcp90/tests/Makefile.in > @@ -5,7 +5,7 @@ VPATH = @srcdir@ > TESTDLL = msvcp90.dll > APPMODE = -mno-cy

Re: [1/5] kernel32: only strip the wine_get_dos_file_name NTDLL path prefix if is present

2010-07-22 Thread Damjan Jovanovic
On Thu, Jul 22, 2010 at 4:26 PM, Alexandre Julliard wrote: > Damjan Jovanovic writes: > >> Changelog: >> * kernel32: only strip the wine_get_dos_file_name NTDLL path prefix if >> is present > > It will always be present. \\?\ is used by kernel, not ntdll. > > -- > Alexandre Julliard > julli...@wi

Re: [6/7] msi/tests: Avoid a long timeout in the test for DeleteServices.

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3721 Your paranoid android.

Re: [1/5] kernel32: only strip the wine_get_dos_file_name NTDLL path prefix if is present

2010-07-22 Thread Alexandre Julliard
Damjan Jovanovic writes: > Changelog: > * kernel32: only strip the wine_get_dos_file_name NTDLL path prefix if > is present It will always be present. \\?\ is used by kernel, not ntdll. -- Alexandre Julliard julli...@winehq.org

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview. (try 2)

2010-07-22 Thread Alexandre Julliard
David Hedberg writes: > + > +/* Check that all the messages received can be found in > vista_plus_msgs. */ > +#define verify_vista_plus_msgs()\ > +do {\ > +UINT

Re: [5/7] msi/tests: Skip tests when the current user has insufficient rights.

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3720 Your paranoid android.

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Alexandre Julliard
Paul Vriens writes: > So something like the attached? Not fully tested yet. Yes. -- Alexandre Julliard julli...@winehq.org

Re: [1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info.

2010-07-22 Thread Henri Verbeet
On 22 July 2010 10:45, Louis Lenders wrote: > Hi Henri > >>I mean that I don't think the "rotation" argument to >> GetAdapterDisplayMode() should be allowed to be NULL. > > I tested IDirect3D9Ex::GetAdapterDisplayModeEx and that allows pRotation to > be NULL, and still happily retrieves all  othe

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Paul Vriens
On 07/22/2010 02:55 PM, Alexandre Julliard wrote: Paul Vriens writes: On 07/22/2010 02:03 PM, Andrew Nguyen wrote: There are a few things I'm wondering about: When the winetest shlwapi binary was built, what made the compiler decide to import shell32 for the problematic string functions? Ne

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Greg Geldorp
> From: Paul Vriens > > The first thing winetest does is run a "_test.exe --list" for each > dll. If there is a missing export (or import library) it will not > include this dll in the tests (so none of the subtests will run). Just ran shlwapi_test.exe --list manually on WVISTAADM, "The procedu

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere.

2010-07-22 Thread Henri Verbeet
On 21 July 2010 21:56, Misha Koshelev wrote: > +/* first vertex and normal */ > +vertex = 0; > +test_vertex_data[vertex].position.x = 0.0f; > +test_vertex_data[vertex].position.y = 0.0f; > +test_vertex_data[vertex].position.z = radius; > +test_vertex_data[vertex].normal.x =

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Alexandre Julliard
Paul Vriens writes: > On 07/22/2010 02:03 PM, Andrew Nguyen wrote: >> >> There are a few things I'm wondering about: >> >> When the winetest shlwapi binary was built, what made the compiler >> decide to import shell32 for the problematic string functions? Neither >> my local cross-compile build n

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Paul Vriens
On 07/22/2010 02:36 PM, Andrew Nguyen wrote: On 07/22/2010 07:21 AM, Paul Vriens wrote: On 07/22/2010 02:03 PM, Andrew Nguyen wrote: There are a few things I'm wondering about: When the winetest shlwapi binary was built, what made the compiler decide to import shell32 for the problematic stri

Re: [4/5] d3dx9: Implement D3DXCreateTexture plus tests

2010-07-22 Thread Henri Verbeet
On 21 July 2010 16:06, Owen Rudge wrote: > +hr = D3DXCreateTexture(device, D3DX_DEFAULT, 63, 0, 0, 0, > D3DPOOL_DEFAULT, &texture); > +ok(hr == D3D_OK, "D3DXCreateTexture returned %#x, expected %#x\n", hr, > D3D_OK); > + > +if (texture) > +{ > +hr = IDirect3DTexture9_GetL

Re: [2/5] d3dx9: Implement D3DXCheckTextureRequirements

2010-07-22 Thread Henri Verbeet
On 21 July 2010 16:06, Owen Rudge wrote: > +/* Returns TRUE if num is a power of 2, FALSE otherwise */ > +BOOL is_pow2(UINT num) > +{ > +return !(num & (num - 1)); > +} Minor, but this returns TRUE if num is power of two, *or zero*. That's fine for how it's used, but please mention it. > +/*

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Andrew Nguyen
On 07/22/2010 07:21 AM, Paul Vriens wrote: On 07/22/2010 02:03 PM, Andrew Nguyen wrote: There are a few things I'm wondering about: When the winetest shlwapi binary was built, what made the compiler decide to import shell32 for the problematic string functions? Neither my local cross-compile b

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Paul Vriens
On 07/22/2010 02:03 PM, Andrew Nguyen wrote: There are a few things I'm wondering about: When the winetest shlwapi binary was built, what made the compiler decide to import shell32 for the problematic string functions? Neither my local cross-compile build nor the build that the test bot perform

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Andrew Nguyen
On 07/22/2010 06:03 AM, Paul Vriens wrote: On 07/22/2010 12:31 PM, Andrew Nguyen wrote: On 07/22/2010 04:32 AM, Paul Vriens wrote: On 07/20/2010 06:14 AM, Andrew Nguyen wrote: --- dlls/shlwapi/tests/string.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) This patchset introduces cra

Re: [4/7] msi/tests: Return an error code from helper_createpackage and package_from_db.

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3719 Your paranoid android.

Re: [3/7] msi/tests: Fix test failures on wow64.

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3718 Your paranoid android.

Re: winex11.drv: Remember last window that had the XIC focus and use it in ToUnicode() to make dead keys work more reliably.

2010-07-22 Thread Alexandre Julliard
Dmitry Timoshkov writes: > @@ -2541,9 +2541,13 @@ INT CDECL X11DRV_ToUnicodeEx(UINT virtKey, UINT > scanCode, const BYTE *lpKeyState > e.state = 0; > e.type = KeyPress; > > -focus = GetFocus(); > -if (focus) focus = GetAncestor( focus, GA_ROOT ); > -if (!focus) focus = Ge

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Paul Vriens
On 07/22/2010 12:31 PM, Andrew Nguyen wrote: On 07/22/2010 04:32 AM, Paul Vriens wrote: On 07/20/2010 06:14 AM, Andrew Nguyen wrote: --- dlls/shlwapi/tests/string.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) This patchset introduces crashes in these tests on W2K, XP and W2K3: ht

Re: wordpad: Allow objects & images to be added with native riched20. (resend)

2010-07-22 Thread Alexandre Julliard
Dylan Smith writes: > @@ -264,3 +267,6 @@ void registry_read_maximized(DWORD*); > void registry_set_filelist(LPCWSTR, HWND); > void registry_set_formatopts_all(DWORD[], DWORD[]); > void registry_set_options(HWND); > + > +/* olecallback.c */ > +HRESULT SetupRichEditOleCallback(HWND hEditorWnd);

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Andrew Nguyen
On 07/22/2010 04:32 AM, Paul Vriens wrote: On 07/20/2010 06:14 AM, Andrew Nguyen wrote: --- dlls/shlwapi/tests/string.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) This patchset introduces crashes in these tests on W2K, XP and W2K3: http://test.winehq.org/data/tests/shlwapi:string

Re: include/wine/debug.h: ... and uses of '_ONCE' variants.

2010-07-22 Thread Alexandre Julliard
Max TenEyck Woodbury writes: >> No, the current implementation is correct, debug.h should be usable from >> Winelib apps where you don't have access to Wine configure checks. >> > Ahh. Should the list of compilers that support varadic macros be > updated? If you have a compiler that you have ver

Re: include/wine/debug.h: ... and uses of '_ONCE' variants.

2010-07-22 Thread Max TenEyck Woodbury
On 07/22/2010 03:35 AM, Alexandre Julliard wrote: Max TenEyck Woodbury writes: Also, the current implementation is imperfect. There should be a test in 'configure' for the various kinds of variadic macro support and the conditionals should be based on what configure finds, not on the use of an

[1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info.

2010-07-22 Thread Louis Lenders
ok, now i really need a break, the test i wrote 10 minutes ago had a mistake, IDirect3D9Ex::GetAdapterDisplayModeEx _does_ allow D3DDISPLAYROTATION pointer to be NULL. I'll just send the test to wine-patches. Again sorry for the noise

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Paul Vriens
On 07/20/2010 06:14 AM, Andrew Nguyen wrote: --- dlls/shlwapi/tests/string.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) This patchset introduces crashes in these tests on W2K, XP and W2K3: http://test.winehq.org/data/tests/shlwapi:string.html Further than that it seems tha

[1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info.

2010-07-22 Thread Louis Lenders
Hi Henri >>I mean that I don't think the "rotation" argument to >> GetAdapterDisplayMode() should be allowed to be NULL. >I tested IDirect3D9Ex::GetAdapterDisplayModeEx and that allows pRotation to >>be NULL, hmm, I remembered to have tested this, but to be sure I tested again a few minutes ago

[1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info.

2010-07-22 Thread Louis Lenders
Hi Henri >I mean that I don't think the "rotation" argument to > GetAdapterDisplayMode() should be allowed to be NULL. I tested IDirect3D9Ex::GetAdapterDisplayModeEx and that allows pRotation to be NULL, and still happily retrieves all other (D3DDISPLAYMODEEX) info. So it's seems logical IWin

Re: [PATCH 2/3] msvcp90/tests: Added allocator tests

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3704 Your paranoid android.

Re: shlwapi: Improved UrlCanonicalizeW implementation

2010-07-22 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3702 Your paranoid android.

Re: include/wine/debug.h: ... and uses of '_ONCE' variants.

2010-07-22 Thread Alexandre Julliard
Max TenEyck Woodbury writes: > Also, the current implementation is imperfect. There should be a test > in 'configure' for the various kinds of variadic macro support and the > conditionals should be based on what configure finds, not on the use of > any particular compiler. No, the current imple