Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 2)

2010-07-21 Thread Oldřich Jedlička
Hi Roderick, On Thursday 22 July 2010 00:23:46 Roderick Colenbrander wrote: > Hi Oldřich, > > Not to discourage you, but in Wine tests serve as proof to show that a > patch is right, so you should first get all the tests you want in. The > bug should be fixed afterward. It is likely that the test

RFC: draft HLSL test suite

2010-07-21 Thread Travis Athougies
Hi, First of all, let me introduce myself. I'm a young software developer entering college this fall. I've always been interested in helping out the WINE project, especially in the areas of DirectX and Direct3D. Dan Kegel suggested in http://wiki.winehq.org/HLSLTestSuite that writing an HLSL test

Re: oleaut32: Remove the ignored common resource attributes.

2010-07-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3687 Your paranoid android.

Re: user32: Remove the ignored common resource attributes.

2010-07-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3686 Your paranoid android.

Re: comdlg32: Remove the ignored common resource attributes.

2010-07-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3685 Your paranoid android.

Re: include/wine/debug.h: ... and uses of '_ONCE' variants.

2010-07-21 Thread Max TenEyck Woodbury
Please discard this series of patches. They will not work with compilers that do not support macros with variable numbers of arguments. While most modern compilers do provide variadic macros, some older compilers do not. To do this right a non-intuitive syntax would be required. (i.e. 'FIXME_ONCE

Re: comctl32: Remove the ignored common resource attributes.

2010-07-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3684 Your paranoid android.

Re: [PATCH 2/2] shlwapi: Implement SHSetIniStringW

2010-07-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3668 Your paranoid android.

Re: [PATCH 1/2] shlwapi: Implement SHGetIniStringW

2010-07-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3667 Your paranoid android.

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 2)

2010-07-21 Thread Roderick Colenbrander
Hi Oldřich, Not to discourage you, but in Wine tests serve as proof to show that a patch is right, so you should first get all the tests you want in. The bug should be fixed afterward. It is likely that the test will reveal new issues. Like I mentioned yesterday, checking memory location related

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 2)

2010-07-21 Thread Oldřich Jedlička
Hi all, I've made one discovery - the explicit BACKBUFFER creation (as shown in logs) works only for IID_IDirectDraw interface, not for any newer (on my Windows XP). I will do some more testing, add tests into a separate patch and send it afterwards. Regards, Oldrich. On Wednesday 21 July 20

Re: winhlp32 italian translation update

2010-07-21 Thread Paul Vriens
Hi Davide, On 07/21/2010 11:31 PM, Davide Pizzetti wrote: @@ -53,9 +53,9 @@ MAIN_MENU MENU LANGUAGE LANG_ITALIAN, SUBLANG_NEUTRAL Your tree is not up-to-date. The above per-resource LANGUAGE settings have been removed by 6e8c900d1960e804227e83826a529f075e09443e. -- Cheers, Paul.

Re: [1/5] gameux: Add initial implementation of gameux.dll

2010-07-21 Thread André Hentschel
Am 21.07.2010 19:01, schrieb Mariusz Pluciński: > W dniu 19.07.2010 15:02, Henri Verbeet pisze: >> 2010/7/18 Mariusz Pluciński: >>> +static HINSTANCE hInstance; >> This is unused. >> >> You're mixing tabs and spaces, and have a couple of trailing spaces. >> >> Also: >>> + * DllRegisterServer (

Re: [1/5] gameux: Add initial implementation of gameux.dll

2010-07-21 Thread Mariusz Pluciński
W dniu 19.07.2010 15:02, Henri Verbeet pisze: 2010/7/18 Mariusz Pluciński: +static HINSTANCE hInstance; This is unused. You're mixing tabs and spaces, and have a couple of trailing spaces. Also: + * DllRegisterServer (OLEAUT32.@) The code of "my" regsvr.c is almost non-modified copy of

Re: [PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

2010-07-21 Thread Henri Verbeet
On 21 July 2010 18:29, Stefan Dösinger wrote: > I'd consider normalized_texrect a GL extension for WineD3D's purposes, mostly > due to lack of reasons not to consider it a GL extension, If it's not on http://www.opengl.org/registry/, or at least making progress towards going there, it's not a GL e

Re: [PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

2010-07-21 Thread Stefan Dösinger
Am Mittwoch 21 Juli 2010, 14:13:59 schrieb Henri Verbeet: > On 21 July 2010 14:12, Stefan Dösinger wrote: > > Am 21.07.2010 um 13:01 schrieb Henri Verbeet: > >> Consistency with the enum name, and WINED3D_GL_EXT_NONE, > >> WINED3D_GL_EXT_COUNT and WINED3D_GL_VERSION_2_0. > > > > But those aren't

Re: [1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info. Henri Verbeet hverbeet at gmail.com

2010-07-21 Thread Henri Verbeet
On 21 July 2010 17:18, Louis Lenders wrote: > also thanks, i made a new patch here: http://pastebin.com/y5Kv52h0 > would that be ok? > Well, that patch can never work, but the change to WINED3DDISPLAYMODE struct is what I meant, yes. >>I also think the wined3d call should simply >>retrieve all in

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-21 Thread Henri Verbeet
On 21 July 2010 17:30, Roderick Colenbrander wrote: > Sure, GL_*_memory_info extensions could help there but I think we > should be cautious with just adding such support to there. Over the > past few months I have seen various reports of users who run games > which say to require lets say 128MB o

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-21 Thread Roderick Colenbrander
On Wed, Jul 21, 2010 at 4:02 AM, Henri Verbeet wrote: > On 21 July 2010 05:08, Roderick Colenbrander wrote: >> I think 'select_card_*' should just return the pci device id and the >> default amount of video memory should be stored in lets say the driver >> version table (a different name for the

[1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info. Henri Verbeet hverbeet at gmail.com

2010-07-21 Thread Louis Lenders
Hi, @Chris: thanks for the remarks, i'll adjust patch [3\4] accordingly @Henry also thanks, i made a new patch here: http://pastebin.com/y5Kv52h0 would that be ok? >I also think the wined3d call should simply >retrieve all info, d3d9ex can discard it again if it feels like it. I don't exactly

Re: [2/6] shdocvw: Implement InterneExplorer::ExecWB

2010-07-21 Thread Alexander Nicolaysen Sørnes
Onsdag 21. juli 2010 15.39.56 skrev Alexander Nicolaysen Sørnes : > Onsdag 21. juli 2010 14.43.59 skrev Jacek Caban : > > On 7/21/10 2:08 PM, Alexander Nicolaysen Sørnes wrote: > > > Implement InterneExplorer::ExecWB > > > > + > > > > if(IUnknown_QueryInterface(This->doc_host.document,&IID_IOl

Re: D3DXCreateTeapot

2010-07-21 Thread mellery
Why not a tea pot pouring into a wine glass then? On Wed, Jul 21, 2010 at 10:12 AM, Peter Urbanec wrote: >  On 20/07/10 04:54, Ian Macfarlane wrote: >> >> Following the question as to how to implement D3DXCreateTeapot, might I >> suggest making it in the form of a wine glass? >> >> Given that is

Re: D3DXCreateTeapot

2010-07-21 Thread Peter Urbanec
On 20/07/10 04:54, Ian Macfarlane wrote: Following the question as to how to implement D3DXCreateTeapot, might I suggest making it in the form of a wine glass? Given that is unlikely to negatively affect anything (indeed the entire method does border on the ridiculous) I think it would make a

Re: kernel32: make wine_get_dos_file_name independent from drive mappings

2010-07-21 Thread Alexandre Julliard
Damjan Jovanovic writes: > Changelog: > * kernel32: make wine_get_dos_file_name independent from drive mappings > > ... by returning \\?\unix/home/user/path/to/file.txt style paths. That should actually be done in wine_unix_to_nt_file_name, and only when there is no suitable DOS drive. -- Alex

Re: kernel32.dll: implementation of GetVolumePathNamesForVolumeNameA/W (try 2)

2010-07-21 Thread Vitaliy Margolen
Thanks for the patch. However it has number of issues: On 07/20/2010 08:33 PM, Tuomo Mattila wrote: @ stdcall GetVolumeNameForVolumeMountPointW(wstr ptr long) @ stdcall GetVolumePathNameA(str ptr long) @ stdcall GetVolumePathNameW(wstr ptr long) -# @ stub GetVolumePathNamesForVolumeNameA +

Re: [2/6] shdocvw: Implement InterneExplorer::ExecWB

2010-07-21 Thread Alexander Nicolaysen Sørnes
Onsdag 21. juli 2010 14.43.59 skrev Jacek Caban : > On 7/21/10 2:08 PM, Alexander Nicolaysen Sørnes wrote: > > Implement InterneExplorer::ExecWB > > + > if(IUnknown_QueryInterface(This->doc_host.document,&IID_IOleCommandTarget, > (LPVOID*)&Target) != S_OK) +{ > +return E_NOTIMP

Re: [4/6] shdocvw: Add About dialog to IE

2010-07-21 Thread Jacek Caban
On 7/21/10 2:09 PM, Alexander Nicolaysen Sørnes wrote: Add About dialog to IE +static void ie_dialog_about(HWND hwnd) +{ +HICON icon = LoadImageW(GetModuleHandleW(0), MAKEINTRESOURCEW(IDI_APPICON), IMAGE_ICON, 48, 48, LR_SHARED); + +ShellAboutW(hwnd, wszWineInternetExplorer, NULL, ic

Re: [2/6] shdocvw: Implement InterneExplorer::ExecWB

2010-07-21 Thread Jacek Caban
On 7/21/10 2:08 PM, Alexander Nicolaysen Sørnes wrote: Implement InterneExplorer::ExecWB +if(IUnknown_QueryInterface(This->doc_host.document,&IID_IOleCommandTarget, (LPVOID*)&Target) != S_OK) +{ +return E_NOTIMPL; It doesn't seem like a right error code. +} else +{

Re: [1/2] shlwapi: Partially implement SHGetShellKey (try2)

2010-07-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3649 Your paranoid android.

Re: [1/6] shdocvw: Add menu bar to Internet Explorer

2010-07-21 Thread Jacek Caban
Hi Alexander, On 7/21/10 2:07 PM, Alexander Nicolaysen Sørnes wrote: This series adds a menu bar and Open URL dialog box to Wine's IE. -FIXME("(%p)->(%x)\n", This, Value); -return E_NOTIMPL; +HMENU hMenu = NULL; Please use better names (without type prefix) like 'menu'. + +T

Re: [PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

2010-07-21 Thread Henri Verbeet
On 21 July 2010 14:12, Stefan Dösinger wrote: > > Am 21.07.2010 um 13:01 schrieb Henri Verbeet: > >> On 20 July 2010 22:05, Stefan Dösinger wrote: >>> >>> Am 20.07.2010 um 18:51 schrieb Henri Verbeet: -            || gl_info->supported[WINE_NORMALIZED_TEXRECT]) +            || gl_info->

Re: [PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

2010-07-21 Thread Stefan Dösinger
Am 21.07.2010 um 13:01 schrieb Henri Verbeet: > On 20 July 2010 22:05, Stefan Dösinger wrote: >> >> Am 20.07.2010 um 18:51 schrieb Henri Verbeet: >>> -|| gl_info->supported[WINE_NORMALIZED_TEXRECT]) >>> +|| gl_info->supported[WINED3D_GL_NORMALIZED_TEXRECT]) >> I understa

Re: dmusic: remove unused variable

2010-07-21 Thread Henri Verbeet
On 21 July 2010 09:21, Nikolay Sivov wrote: >  On 7/21/2010 11:16, Austin English wrote: >> Hm, good point. How's this? >> >> diff --git a/dlls/dmusic/port.c b/dlls/dmusic/port.c >> index 021f1e2..23fa1b8 100644 >> --- a/dlls/dmusic/port.c >> +++ b/dlls/dmusic/port.c >> @@ -382,7 +382,8 @@ HRESULT

Re: [PATCH 4/7] msvcp90: Added char_traits implementation (try3)

2010-07-21 Thread Paul Vriens
(Forgot to cc: wine-devel). On 07/21/2010 11:10 AM, Piotr Caban wrote: +void CDECL MSVCP_char_trauts_short_assign(unsigned short *ch, ^ I guess his should have been "MSVCP_char_traits_short_assign" -- Cheers, Paul.

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-21 Thread Henri Verbeet
On 21 July 2010 05:08, Roderick Colenbrander wrote: > I think 'select_card_*' should just return the pci device id and the > default amount of video memory should be stored in lets say the driver > version table (a different name for the table might make sense). It Yeah, this should be based on th

Re: [1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info.

2010-07-21 Thread Henri Verbeet
On 20 July 2010 23:25, Louis Lenders wrote: > +struct wined3d_adapter_info_ex > +{ > +WINED3DSCANLINEORDERING ScanLineOrdering; > +WINED3DDISPLAYROTATION Rotation; > +}; You can at least add the scanline ordering to WINED3DDISPLAYMODE, it doesn't need to be compatible with D3DDISPLAYMODE.

Re: [PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

2010-07-21 Thread Henri Verbeet
On 20 July 2010 22:05, Stefan Dösinger wrote: > > Am 20.07.2010 um 18:51 schrieb Henri Verbeet: >> -            || gl_info->supported[WINE_NORMALIZED_TEXRECT]) >> +            || gl_info->supported[WINED3D_GL_NORMALIZED_TEXRECT]) > I understand the WINE->WINED3D part - it's a wined3d specific thin

Re: [PATCH 4/7] msvcp90: Added char_traits implementation (try2)

2010-07-21 Thread Piotr Caban
On 07/21/10 10:14, Alexandre Julliard wrote: Piotr Caban writes: +/* ?not_...@?$char_traits@g...@std@@sag...@z */ +unsigned short CDECL MSVCP_char_traits_short_not_eof(const unsigned short *in) +{ +return (*in==0 ? !0 : *in); +} Aren't you supposed to return 0 for eof? eof should be equ

Re: [7/8] msi/tests: Double null-terminate a REG_MULTI_SZ string.

2010-07-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3642 Your paranoid android.

Re: [3/8] msi: Move the component enabled check into the standard actions.

2010-07-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3641 Your paranoid android.

Re: [PATCH 4/7] msvcp90: Added char_traits implementation (try2)

2010-07-21 Thread Alexandre Julliard
Piotr Caban writes: > +/* ?not_...@?$char_traits@g...@std@@sag...@z */ > +unsigned short CDECL MSVCP_char_traits_short_not_eof(const unsigned short > *in) > +{ > +return (*in==0 ? !0 : *in); > +} Aren't you supposed to return 0 for eof? -- Alexandre Julliard julli...@winehq.org

Re: dmusic: remove unused variable

2010-07-21 Thread Nikolay Sivov
On 7/21/2010 11:16, Austin English wrote: On Wed, Jul 21, 2010 at 12:41 AM, Nikolay Sivov wrote: On 7/21/2010 08:31, Austin English wrote: HRESULT WINAPI DMUSIC_CreateDirectMusicPortImpl (LPCGUID lpcGUID, LPVOID *ppobj, LPUNKNOWN pUnkOuter, LPDMUS_PORTPARAMS pPortParams, LPDMUS_PORTCAPS p

Re: dmusic: remove unused variable

2010-07-21 Thread Austin English
On Wed, Jul 21, 2010 at 12:41 AM, Nikolay Sivov wrote: >  On 7/21/2010 08:31, Austin English wrote: >> >>  HRESULT WINAPI DMUSIC_CreateDirectMusicPortImpl (LPCGUID lpcGUID, LPVOID >> *ppobj, LPUNKNOWN pUnkOuter, LPDMUS_PORTPARAMS pPortParams, LPDMUS_PORTCAPS >> pPortCaps) { >>        IDirectMusicP