Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-20 Thread Roderick Colenbrander
2010/7/20 Roderick Colenbrander : > 2010/7/20 Oldřich Jedlička : >> Hi Stefan, >> >> On Tuesday 20 July 2010 00:01:13 Stefan Dösinger wrote: >>> Am 19.07.2010 um 21:24 schrieb Oldřich Jedlička: >>> > Hi Stefan, >>> > >>> > On Monday 19 July 2010 20:56:35 Stefan Dösinger wrote: >>> >> Allowing the c

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Chris Robinson
On Tuesday, July 20, 2010 2:54:24 pm Luke Bratch wrote: > The attached uses that experimental extension [1] to report the correct > total memory for cards that support it, while sticking with the existing > hard coded values and code layout for those that don't. I think the extension should be che

Re: dmusic: remove unused variable

2010-07-20 Thread Nikolay Sivov
On 7/21/2010 08:31, Austin English wrote: HRESULT WINAPI DMUSIC_CreateDirectMusicPortImpl (LPCGUID lpcGUID, LPVOID *ppobj, LPUNKNOWN pUnkOuter, LPDMUS_PORTPARAMS pPortParams, LPDMUS_PORTCAPS pPortCaps) { IDirectMusicPortImpl *obj; - HRESULT hr = E_FAIL; UINT j;

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-20 Thread Roderick Colenbrander
2010/7/20 Oldřich Jedlička : > Hi Stefan, > > On Tuesday 20 July 2010 00:01:13 Stefan Dösinger wrote: >> Am 19.07.2010 um 21:24 schrieb Oldřich Jedlička: >> > Hi Stefan, >> > >> > On Monday 19 July 2010 20:56:35 Stefan Dösinger wrote: >> >> Allowing the creation of the surface is most likely not en

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Roderick Colenbrander
On Wed, Jul 21, 2010 at 3:59 AM, Roderick Colenbrander wrote: > On Tue, Jul 20, 2010 at 11:54 PM, Luke Bratch wrote: >> --- On Tue, 20/7/10, Henri Verbeet wrote: >> >>> Negative on using experimental extensions I'm afraid. >>> Writing a proof >>> of concept patch is ok, of course, and I'd be wil

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Roderick Colenbrander
On Wed, Jul 21, 2010 at 1:57 AM, Seth Shelnutt wrote: > For ati there is also GL_ATI_mem_info [1] or WGL_AMD_gpu_association [2] . I > believe that [1] is now obsolete as from reading some of the wine-dev > mailing list [3], and some other site it seems AMD is now pushing the using > of WGL_AMD_gp

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Roderick Colenbrander
On Tue, Jul 20, 2010 at 11:54 PM, Luke Bratch wrote: > --- On Tue, 20/7/10, Henri Verbeet wrote: > >> Negative on using experimental extensions I'm afraid. >> Writing a proof >> of concept patch is ok, of course, and I'd be willing to >> review that, >> but it can't go in until the extension is f

Re: [2/2] user32: Prevent resize of minimized windows from SetWindowPos (Bug 1719).

2010-07-20 Thread Dylan Smith
On Tue, Jul 20, 2010 at 8:34 PM, Marvin wrote: > === W7PRO (32 bit win) === > win.c:823: Test failed: wrong dwWindowStatus: != 0001 active 006E01AE > fg 00030050 in hook HCBT_SETFOCUS > win.c:823: Test failed: wrong dwWindowStatus: != 0001 active 007001AE > fg 00030050 in hook HCBT_SETF

Re: [2/2] user32: Prevent resize of minimized windows from SetWindowPos (Bug 1719).

2010-07-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3631 Your paranoid android.

Re: [1/2] user32/tests: Minimized windows shouldn't be resizable.

2010-07-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3630 Your paranoid android.

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Seth Shelnutt
For ati there is also GL_ATI_mem_info [1] or WGL_AMD_gpu_association [2] . I believe that [1] is now obsolete as from reading some of the wine-dev mailing list [3], and some other site it seems AMD is now pushing the using of WGL_AMD_gpu_association instead. A patch could be written in the exact sa

Re: [PATCH] shlwapi: Be less strict on which type of IShellFolder can be enumerated

2010-07-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3623 Your paranoid android.

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Luke Bratch
--- On Tue, 20/7/10, Henri Verbeet wrote: > Negative on using experimental extensions I'm afraid. > Writing a proof > of concept patch is ok, of course, and I'd be willing to > review that, > but it can't go in until the extension is finalized. Note > that this > wouldn't allow you to get rid of

Re: [3\4] d3d9: Partially implement GetAdapterDisplayModeEx

2010-07-20 Thread Chris Robinson
On Tuesday, July 20, 2010 2:28:44 pm Louis Lenders wrote: > +TRACE("iface %p, adapter %u, mode %p.\n", iface, adapter, mode); > +TRACE("iface %p, adapter %u, mode %p, rotation %p\n", iface, adapter, > mode, rotation); This doesn't look right. You probably only need the second TRACE stateme

Re: [PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".

2010-07-20 Thread Stefan Dösinger
Am 20.07.2010 um 18:51 schrieb Henri Verbeet: > -|| gl_info->supported[WINE_NORMALIZED_TEXRECT]) > +|| gl_info->supported[WINED3D_GL_NORMALIZED_TEXRECT]) I understand the WINE->WINED3D part - it's a wined3d specific thing, nothing wine global. But why did you add GL to the

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-20 Thread Oldřich Jedlička
Hi Stefan, On Tuesday 20 July 2010 00:01:13 Stefan Dösinger wrote: > Am 19.07.2010 um 21:24 schrieb Oldřich Jedlička: > > Hi Stefan, > > > > On Monday 19 July 2010 20:56:35 Stefan Dösinger wrote: > >> Allowing the creation of the surface is most likely not enough, the > >> backbuffer has to be us

Re: Quick legal question... teapot related

2010-07-20 Thread David Gerard
On 20 July 2010 20:20, Avery Pennarun wrote: > On Tue, Jul 20, 2010 at 10:35 AM, David Gerard wrote: >> On 20 July 2010 14:52, Dan McDonald wrote: >>> On 07/20/2010 06:44 AM, Misha Koshelev wrote: If I take a publicly available teaset: http://www.sjbaker.org/teapot/teaset.tgz And

Re: Fyi patch submission information on wiki updated for GitHub

2010-07-20 Thread Misha Koshelev
On Mon, 2010-07-19 at 22:48 -0600, Vitaliy Margolen wrote: > On 07/19/2010 08:59 PM, Misha Koshelev wrote: > > Unfortunately, the more intuitive > > git format-patch -k --stdout HEAD~79..HEAD~78> /tmp/patch.old > > > > does not seem to result in patches that can be properly applied onto a > > diff

Re: Quick legal question... teapot related

2010-07-20 Thread Avery Pennarun
On Tue, Jul 20, 2010 at 10:35 AM, David Gerard wrote: > On 20 July 2010 14:52, Dan McDonald wrote: >> On 07/20/2010 06:44 AM, Misha Koshelev wrote: >>> If I take a publicly available teaset: >>> http://www.sjbaker.org/teapot/teaset.tgz >>> And run it through a Microsoft function: >>> http://msdn.

Re: [PATCH 7/7] d3d10: Implement D3D10ReflectShader().

2010-07-20 Thread Rico Schüller
Am 20.07.2010 11:26, schrieb Henri Verbeet: 2010/7/19 Rico Schüller: +e[i].SemanticName = get_semantic(data + name_offset); I'm not sure this will work, I was under the impression semantics can be arbitrary strings. (Which is also why d3d10core goes through the trouble of copy

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Henri Verbeet
On 20 July 2010 19:46, Roderick Colenbrander wrote: > It is quite easy to add some basic support for it (I > would not use the free video memory code yet) but I'm not sure if we > want to support this yet since the extension is experimental. If it is > fine by Henri, I can add it as it would help

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Roderick Colenbrander
On Tue, Jul 20, 2010 at 1:54 PM, Henri Verbeet wrote: > On 20 July 2010 15:49, Luke Bratch wrote: >> Adds detection for the Nvidia 8800GTX card and sets its video memory >> correctly. >> >> I have sent this patch in the past but it got rejected, as this method of >> calculating video card type/

Re: dlls/kernel32/volume

2010-07-20 Thread Stephen Mark Smith
On 20/07/10 14:54, Stephen Mark Smith wrote: On 20/07/10 14:00, Alexandre Julliard wrote: stephenmsm...@blueyonder.co.uk writes: diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c index 7596864..4908739 100644 --- a/dlls/kernel32/volume.c +++ b/dlls/kernel32/volume.c @@ -526,10 +526,

Re: dlls/kernel32/volume

2010-07-20 Thread Stephen Mark Smith
On 20/07/10 14:00, Alexandre Julliard wrote: stephenmsm...@blueyonder.co.uk writes: diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c index 7596864..4908739 100644 --- a/dlls/kernel32/volume.c +++ b/dlls/kernel32/volume.c @@ -526,10 +526,17 @@ BOOL WINAPI GetVolumeInformationW( L

Re: kernel32: Enhance EndUpdateResource

2010-07-20 Thread Alexandre Julliard
Andrey Turkin writes: > Fixes bugs 12017 and 22812 > --- > dlls/kernel32/resource.c | 113 +++ > dlls/kernel32/tests/resource.c | 307 > +++- > 2 files changed, 326 insertions(+), 94 deletions(-) It breaks the tests: ../../../tools/runte

Re: [1/5] msi: Add a test for MsiSetFeatureState.

2010-07-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3600 Your paranoid android.

NPTL and kthreads in the developer guide

2010-07-20 Thread Peter Davies
Since kthreads has now been removed, references to it in the developer's guide should presumably be removed. What about NPTL? Should discussion comparing it to kthreads be removed? Peter

Re: D3DXCreateTeapot

2010-07-20 Thread GOUJON Alexandre
On 07/20/2010 01:39 PM, Reece Dunn wrote: On 19 July 2010 19:54, Ian Macfarlane wrote: Following the question as to how to implement D3DXCreateTeapot, might I suggest making it in the form of a wine glass? Given that is unlikely to negatively affect anything (indeed the entire method does

Re: [2/2] winhttp: Handle errors from SSL_read.

2010-07-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3599 Your paranoid android.

Re: Quick legal question... teapot related

2010-07-20 Thread David Gerard
On 20 July 2010 14:52, Dan McDonald wrote: > On 07/20/2010 06:44 AM, Misha Koshelev wrote: >> If I take a publicly available teaset: >> http://www.sjbaker.org/teapot/teaset.tgz >> And run it through a Microsoft function: >> http://msdn.microsoft.com/en-us/library/bb205470%28v=VS.85%29.aspx >> D3D

Re: [1/2] winhttp: Add a partial implementation of WINHTTP_OPTION_SECURITY_CERTIFICATE_STRUCT.

2010-07-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3598 Your paranoid android.

Re: [PATCH 4/8] include: Add INameSpaceTreeControlCustomDraw interface declaration. (try 2)

2010-07-20 Thread Alexandre Julliard
David Hedberg writes: > +/* > + * INameSpaceTreeControlCustomDraw interface > + */ > +[ > + object, > + uuid(2D3BA758-33EE-42D5-BB7B-5F3431D86C78), > + local > +] > + > +interface INameSpaceTreeControlCustomDraw : IUnknow

Re: [2/4] d3dx9: Add shift modifiers parsing to the shader assembler.

2010-07-20 Thread Henri Verbeet
On 20 July 2010 15:11, Matteo Bruni wrote: > +const char *shiftstrings[] = { Minor, but you should probably declare that as "static const char * const shiftstrings[]".

Re: wined3d: Add Nvidia 8800GTX detection

2010-07-20 Thread Henri Verbeet
On 20 July 2010 15:49, Luke Bratch wrote: > Adds detection for the Nvidia 8800GTX card and sets its video memory > correctly. > > I have sent this patch in the past but it got rejected, as this method of > calculating video card type/memory wasn't supposed to stay around forever, > but another

Re: Quick legal question... teapot related

2010-07-20 Thread Dan McDonald
On 07/20/2010 06:44 AM, Misha Koshelev wrote: > If I take a publicly available teaset: > http://www.sjbaker.org/teapot/teaset.tgz > > And run it through a Microsoft function: > http://msdn.microsoft.com/en-us/library/bb205470%28v=VS.85%29.aspx > D3DXTesselateRectPatch for example > > And then cop

Re: user32: warnings (around uninitialized variables).

2010-07-20 Thread Alexandre Julliard
Gerald Pfeifer writes: > @@ -388,6 +388,8 @@ static int DIB_GetBitmapInfo( const BITMAPINFOHEADER > *header, LONG *width, > *compr = header->biCompression; > return 1; > } > + > +*width = *height = 0; > ERR("(%d): unknown/wrong size for header\n", header->biSize

Re: mmio: Wrap TRACE strings with debugstr_a / debugstr_an (try 2)

2010-07-20 Thread Nicolas Le Cam
2010/7/20 Tim Cadogan-Cowper : > Fixes bug 10280 (http://bugs.winehq.org/show_bug.cgi?id=10280).  Thanks to > Eric > Pouech for some feedback on previous attempt and to Maarten Lankhorst for > pointing out a more appropriate way to solve the mmio TRACE buffer overflow > problem. > > IDs of the pre

Re: [5/5] msi: Set feature states to the installed state if the Preselected property is not set.

2010-07-20 Thread Hans Leidekker
Please ignore this one.

Re: [PATCH 1/7] msvcp90: Added stub dll

2010-07-20 Thread Piotr Caban
On 07/20/10 14:53, Alexandre Julliard wrote: Piotr Caban writes: @@ -0,0 +1,3189 @@ +#stub ??$?5du?$char_tra...@d@std@@@std@@yaaav?$basic_istr...@du?$char_traits@d...@std@@@0...@aav10@a...@z +#stub ??$?5du?$char_tra...@d@std@@@std@@yaaav?$basic_istr...@du?$char_traits@d...@std@@@0...@aav10@p

Re: dlls/kernel32/volume

2010-07-20 Thread Alexandre Julliard
stephenmsm...@blueyonder.co.uk writes: > diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c > index 7596864..4908739 100644 > --- a/dlls/kernel32/volume.c > +++ b/dlls/kernel32/volume.c > @@ -526,10 +526,17 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root, LPWSTR > label, DWORD label_

Re: ntdll: Add an error code

2010-07-20 Thread Alexandre Julliard
André Hentschel writes: > @@ -670,7 +670,7 @@ static const DWORD table_c001[411] = > 0, /* c116 > (STATUS_ABIOS_INVALID_SELECTOR) */ > ERROR_INVALID_THREAD_ID,/* c117 (STATUS_NO_LDT) */ > 0,

Re: ole32: Implement cross-process drag and drop.

2010-07-20 Thread Huw Davies
On Mon, Jul 19, 2010 at 04:42:40PM +0100, Huw Davies wrote: > Fix a typo in a comment spotted by Detlef. > --- > dlls/ole32/ole2.c | 199 > 1 files changed, 168 insertions(+), 31 deletions(-) Sorry, this is still broken, please ignore. Huw.

Re: [PATCH 1/7] msvcp90: Added stub dll

2010-07-20 Thread Alexandre Julliard
Piotr Caban writes: > @@ -0,0 +1,3189 @@ > +#stub > ??$?5du?$char_tra...@d@std@@@std@@yaaav?$basic_istr...@du?$char_traits@d...@std@@@0...@aav10@a...@z > +#stub > ??$?5du?$char_tra...@d@std@@@std@@yaaav?$basic_istr...@du?$char_traits@d...@std@@@0...@aav10@p...@z > +#stub > ??$?5du?$char_tra...

Re: [1/2] shlwapi/ordinal: Partially implement SHGetShellKey

2010-07-20 Thread Alexandre Julliard
Nikolay Sivov writes: > @@ -2398,6 +2457,7 @@ START_TEST(ordinal) > { > hShlwapi = GetModuleHandleA("shlwapi.dll"); > is_win2k_and_lower = GetProcAddress(hShlwapi, "StrChrNW") == 0; > +is_win9x = (GetVersion() & 0x8000); You should never check the version, check for features i

Re: Fyi patch submission information on wiki updated for GitHub

2010-07-20 Thread Misha Koshelev
On Mon, 2010-07-19 at 22:48 -0600, Vitaliy Margolen wrote: > On 07/19/2010 08:59 PM, Misha Koshelev wrote: > > Unfortunately, the more intuitive > > git format-patch -k --stdout HEAD~79..HEAD~78> /tmp/patch.old > > > > does not seem to result in patches that can be properly applied onto a > > diff

Quick legal question... teapot related

2010-07-20 Thread Misha Koshelev
If I take a publicly available teaset: http://www.sjbaker.org/teapot/teaset.tgz And run it through a Microsoft function: http://msdn.microsoft.com/en-us/library/bb205470%28v=VS.85%29.aspx D3DXTesselateRectPatch for example And then copy the vertex buffer and index buffer and save them... Do I ha

Re: [PATCH 4/9] include: Add INameSpaceTreeControl, INameSpaceTreeControl2 and INameSpaceTreeControlEvents interface declarations.

2010-07-20 Thread Alexandre Julliard
David Hedberg writes: > +HRESULT OnItemClick( > +[in, annotation("__in")] IShellItem *psi, > +[in, annotation("__in")] NSTCEHITTEST nstceHitTest, > +[in, annotation("__in")] NSTCECLICKTYPE nstceClickType); > + > +HRESULT OnPropertyItemCommit( > +[in, annota

Re: [1/3] winemenubuilder: use windowscodecs for some ICO to PNG conversion

2010-07-20 Thread Alexandre Julliard
Damjan Jovanovic writes: > +dosPNGFileName = wine_get_dos_file_name(pngFileName); > +if (dosPNGFileName == NULL) > +{ > +WINE_ERR("error converting %s to DOS file name\n", pngFileName); > +goto end; > +} You can't rely on having a valid DOS name here. You should u

Re: D3DXCreateTeapot

2010-07-20 Thread Reece Dunn
On 19 July 2010 19:54, Ian Macfarlane wrote: > Following the question as to how to implement D3DXCreateTeapot, might I > suggest making it in the form of a wine glass? > > Given that is unlikely to negatively affect anything (indeed the entire > method does border on the ridiculous) I think it wou

Re: D3DXCreateTeapot

2010-07-20 Thread David Gerard
On 19 July 2010 19:54, Ian Macfarlane wrote: > Following the question as to how to implement D3DXCreateTeapot, might I > suggest making it in the form of a wine glass? > Given that is unlikely to negatively affect anything (indeed the entire > method does border on the ridiculous) I think it woul

Re: [PATCH 1/2] include/shell32: Shell_MergeMenus should be declared in shlobj.h and exported by name. (try 2)

2010-07-20 Thread David Hedberg
On Tue, Jul 20, 2010 at 10:51 AM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://tes

Re: [PATCH 7/7] d3d10: Implement D3D10ReflectShader().

2010-07-20 Thread Henri Verbeet
2010/7/19 Rico Schüller : > +e[i].SemanticName = get_semantic(data + name_offset); I'm not sure this will work, I was under the impression semantics can be arbitrary strings. (Which is also why d3d10core goes through the trouble of copying the string data.)

Re: [PATCH 02/18] xstat: Add a pair of system calls to make extended file stats available [ver #6]

2010-07-20 Thread Luke Benstead
On 20 July 2010 04:37, Dan Kegel wrote: > Quoth Linus: > > "Ask the Wine people what strange open-function-from-hell they are > interested in." > > Full message follows. Discussion archived at e.g. > http://marc.info/?l=linux-kernel&m=127955270231189&w=2 > > That link didn't work for me, it's on

Re: [PATCH 1/2] include/shell32: Shell_MergeMenus should be declared in shlobj.h and exported by name. (try 2)

2010-07-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3576 Your paranoid android.

Re: shell32_test64.exe shlexec: 5-6 DDE tests always fail on testbot W7PROX64

2010-07-20 Thread Nicolas Le Cam
2010/7/20 Ilya Basin : > M> VM                   Status    Number of test failures > M> WINEBUILD            completed > M> W98SE                completed 0 > M> WNT4WSSP6            completed 0 > M> W2KPROSP4            completed 0 > M> WXPPROSP3            completed 0 > M> W2K3R2SESP2          co

Re: shell32_test64.exe shlexec: 5-6 DDE tests always fail on testbot W7PROX64

2010-07-20 Thread Paul Vriens
On 07/20/2010 07:51 AM, Ilya Basin wrote: Another question: winetest64-latest.exe extracts individual test binaries to the temp folder and runs them. How do you extract the binaries without running? winetest -x Usage: winetest [OPTION]... [TESTS] --helpprint this message and exit --ver