Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Dmitry Timoshkov
Max TenEyck Woodbury wrote: > I may be new to Wine, but I have a substantial amount of experience > designing, writing and fixing code. I learned programming by fixing my > fathers code. I more than understand and accept your desire to decide > that '_ONCE' is appropriate in special situations bu

added some Git morsels

2010-07-14 Thread Misha Koshelev
Dear All: Hope you are all doing well. Per Dan's suggestions, and since I have been working with GitHub, I have added some morsels to the Wiki page: http://wiki.winehq.org/GitWine * Per Mike Kaplinskiy's great advice, removing trailing whitespace: http://wiki.winehq.org/GitWine * For git-rebase

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Max TenEyck Woodbury
On 07/14/2010 08:53 PM, Chris Robinson wrote: On Wednesday, July 14, 2010 5:02:59 pm Max TenEyck Woodbury wrote: 'FIXME's that contain no variable information are completely redundant after their first report. After the first reminder, the additional reports are just noise. They add no additiona

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Chris Robinson
On Wednesday, July 14, 2010 5:02:59 pm Max TenEyck Woodbury wrote: > 'FIXME's that contain no variable > information are completely redundant after their first report. After > the first reminder, the additional reports are just noise. They add no > additional information in terms of action required

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Max TenEyck Woodbury
On 07/14/2010 05:57 PM, Henri Verbeet wrote: On 14 July 2010 22:57, Max TenEyck Woodbury wrote: 1) No, I am not replacing all 'FIXME's with 'FIXME_ONCE's. I'm working on things labeled 'stub' or equivalent. Also 'FIXME's that do not have any additional information. I went over the files that bu

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Henri Verbeet
On 14 July 2010 22:57, Max TenEyck Woodbury wrote: > 1) No, I am not replacing all 'FIXME's with 'FIXME_ONCE's. I'm working > on things labeled 'stub' or equivalent. Also 'FIXME's that do not have > any additional information. I went over the files that bug 15435 said > were too noisy. There are a

Re: dlls/wined3d/query.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Henri Verbeet
As others have already pointed out, I don't think so. I'd accept patches replacing existing constructions with FIXME_ONCE though.

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Max TenEyck Woodbury
On 07/14/2010 03:57 PM, Sven Baars wrote: Michael Stefaniuc wrote: Hello Max, are you replacing all FIXME with FIXME_ONCE? While I do agree that we need the _ONCE variant changing all FIXME is not useful. bye michael On 07/14/2010 09:02 PM, Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c |

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Sven Baars
Michael Stefaniuc wrote: Hello Max, are you replacing all FIXME with FIXME_ONCE? While I do agree that we need the _ONCE variant changing all FIXME is not useful. bye michael On 07/14/2010 09:02 PM, Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c | 40 ++---

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

2010-07-14 Thread Michael Stefaniuc
Hello Max, are you replacing all FIXME with FIXME_ONCE? While I do agree that we need the _ONCE variant changing all FIXME is not useful. bye michael On 07/14/2010 09:02 PM, Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c | 40 ++-- 1 files

Re: Please remove / block user from bugzilla

2010-07-14 Thread Rosanne DiMesio
On Wed, 14 Jul 2010 07:26:40 -0700 Dan Kegel wrote: > I only see one post from him ever, and he was *trying* to be > helpful. Everybody should get a few chances. A warning > should suffice. > Dan, A lot of new users mistake bugzilla for a support forum, and bug reports are littered with com

Re: Please remove / block user from bugzilla

2010-07-14 Thread André Hentschel
Am 14.07.2010 16:26, schrieb Dan Kegel: > I only see one post from him ever, and he was *trying* to be > helpful. Everybody should get a few chances. A warning > should suffice. > > If you ask me, > http://bugs.winehq.org/show_bug.cgi?id=6971#c371 > is more objectionable, because it shows the W

re: Please remove / block user from bugzilla

2010-07-14 Thread Dan Kegel
I only see one post from him ever, and he was *trying* to be helpful. Everybody should get a few chances. A warning should suffice. If you ask me, http://bugs.winehq.org/show_bug.cgi?id=6971#c371 is more objectionable, because it shows the Wine community to be ill-mannered and hostile to newbie

Re: cryptdlg: Add Norwegian Bokmål translatio n

2010-07-14 Thread Paul Vriens
On 07/13/2010 01:37 PM, Alexander Nicolaysen Sørnes wrote: This should bring the Norwegian translation to 100% :D And indeed it does!! Many thanks for that. -- Cheers, Paul.

Re: wineboot: fix Serbian Latin translation

2010-07-14 Thread Damjan Jovanovic
On Wed, Jul 14, 2010 at 9:49 AM, Paul Vriens wrote: > On 07/14/2010 09:40 AM, Damjan Jovanovic wrote: >> >> Changelog: >> * wineboot: fix Serbian Latin translation >> >> Damjan Jovanovic >> > > Hi Damjan, > > Thanks for looking into this. I guess we need the pragma statement now as > you are intro

Re: Please remove / block user from bugzilla

2010-07-14 Thread James Mckenzie
Austin English wrote: >Sent: Jul 13, 2010 10:57 PM >To: Vitaliy Margolen >Cc: Wine Develop , matthewdchish...@gmail.com >Subject: Re: Please remove / block user from bugzilla > >On Tue, Jul 13, 2010 at 11:12 PM, Vitaliy Margolen > wrote: >> Please remove Matt Chisholm from bugazilla >> and/or bl

Re: wineboot: fix Serbian Latin translation

2010-07-14 Thread Paul Vriens
On 07/14/2010 09:49 AM, Paul Vriens wrote: On 07/14/2010 09:40 AM, Damjan Jovanovic wrote: Changelog: * wineboot: fix Serbian Latin translation Damjan Jovanovic Hi Damjan, Thanks for looking into this. I guess we need the pragma statement now as you are introducing UTF-8, not? This patch

Re: wineboot: fix Serbian Latin translation

2010-07-14 Thread Paul Vriens
On 07/14/2010 09:40 AM, Damjan Jovanovic wrote: Changelog: * wineboot: fix Serbian Latin translation Damjan Jovanovic Hi Damjan, Thanks for looking into this. I guess we need the pragma statement now as you are introducing UTF-8, not? I did talk to Nenad about the fact that his translatio