Re: sorry one more question: assert statements in tests

2010-07-09 Thread Reece Dunn
On 10 July 2010 03:40, Misha Koshelev wrote: > I am implementing my tests as follows: > > * patch 1: general test for a D3DX function (D3DXCreateBox for example, > testing specific vertices and indices for _specific_ dimensions). > * patch 2: separate into function that works with arbitrary dimens

Re: git rebase to _insert_ commits?

2010-07-09 Thread David Hedberg
On Sat, Jul 10, 2010 at 2:54 AM, Misha Koshelev wrote: > Dear All: > > I am still learning git and it seems that my solution does not quite > work. > > Specifically, my idea was to use: > git rebase -i upstream/master > > Mark the commit _after_ which I'd like to insert a commit with edit. > > The

sorry one more question: assert statements in tests

2010-07-09 Thread Misha Koshelev
I am implementing my tests as follows: * patch 1: general test for a D3DX function (D3DXCreateBox for example, testing specific vertices and indices for _specific_ dimensions). * patch 2: separate into function that works with arbitrary dimensions for the box, etc. I restrict to the dimensions fro

Re: git rebase to _insert_ commits?

2010-07-09 Thread Misha Koshelev
On Fri, 2010-07-09 at 21:02 -0400, Mike Kaplinskiy wrote: > You can move commits around in an interactive rebase. Just create an > empty commit, move it into place with rebase and edit it. > > Sorry for top post, mobile gmail doesn't let you bottom post. > > > On Jul 9, 2010 8:56 PM, "Misha Koshe

Re: please don't shoot from the hip ;)

2010-07-09 Thread James McKenzie
Misha Koshelev wrote: Hi Guys: I really appreciate all the responses to my work on this bug http://bugs.winehq.org/show_bug.cgi?id=22918 Misha: Not everyone gets or reads the wine-devel mailing list. It is good to duplicate what appears in the mailing list into the bug report that it af

Re: git rebase to _insert_ commits?

2010-07-09 Thread Misha Koshelev
On Fri, 2010-07-09 at 21:02 -0400, Mike Kaplinskiy wrote: > You can move commits around in an interactive rebase. Just create an > empty commit, move it into place with rebase and edit it. > > Sorry for top post, mobile gmail doesn't let you bottom post. > > > On Jul 9, 2010 8:56 PM, "Misha Koshe

Re: git rebase to _insert_ commits?

2010-07-09 Thread Mike Kaplinskiy
You can move commits around in an interactive rebase. Just create an empty commit, move it into place with rebase and edit it. Sorry for top post, mobile gmail doesn't let you bottom post. On Jul 9, 2010 8:56 PM, "Misha Koshelev" wrote: Dear All: I am still learning git and it seems that my so

git rebase to _insert_ commits?

2010-07-09 Thread Misha Koshelev
Dear All: I am still learning git and it seems that my solution does not quite work. Specifically, my idea was to use: git rebase -i upstream/master Mark the commit _after_ which I'd like to insert a commit with edit. Then, when I am at that commit, I do: git commit --amend -a save commit Th

Re: [PATCH] Fix EndDialog behaviour for OrCad.

2010-07-09 Thread Dan Kegel
On Fri, Jul 9, 2010 at 1:04 PM, Eliot Blennerhassett wrote: > Now I see that revised patch 63334 is in "Needs Tests" state, I'm not a > windows application developer... > > I am not able to write any new test for this. > > There are already 52 uses of EndDialog in dlls/user32/tests > If these stil

Re: Can Relay miss some calls in initialization stage?

2010-07-09 Thread Vitaliy Margolen
On 07/09/2010 12:47 PM, Hayan Lee wrote: > Thanks, Marcus. > > In detail, I can see SelectObject in Relay mode. > > 000d:Call gdi32.SelectObject(022c,0244) ret=68951b54 > > The time when the handle 0x22c is created, however, is not caught in > relay mode > and I don't know what function

Re: Can Relay miss some calls in initialization stage?

2010-07-09 Thread Hayan Lee
Thanks, Marcus. In detail, I can see SelectObject in Relay mode. 000d:Call gdi32.SelectObject(022c,0244) ret=68951b54 The time when the handle 0x22c is created, however, is not caught in relay mode and I don't know what function or dll create it, either. Any idea? Thanks, Hayan On

Re: Can Relay miss some calls in initialization stage?

2010-07-09 Thread Marcus Meissner
On Fri, Jul 09, 2010 at 10:34:10AM -0400, Hayan Lee wrote: > Hi, all > > I'm working on relay layer in WINE. > When I turn on WINEDEBUG=+relay, relay looks to miss some calls. > > When is the relay layer loaded? > Before dll loaded or after? > > If WINE does something in its initialization step,

please don't shoot from the hip ;)

2010-07-09 Thread Misha Koshelev
Hi Guys: I really appreciate all the responses to my work on this bug http://bugs.winehq.org/show_bug.cgi?id=22918 Especially the fact that you guys are looking at this code is very very important to me, as it will have to be eventually reviewed to be submitted to Wine. However, I am a little fr

Re: Portuguese (Brazil) translation of Wine at 100%

2010-07-09 Thread Gustavo
Hello everybody, It was my pleasure to conclude the translation, I'm glad I could help :) I could only finish this job because more than half of the work was already done. I reused many of old pt_BR translations and also the current pt_PT translation. Cheers to free software. Let's hope that goo

Re: [RFC] gameux.dll partial implementation

2010-07-09 Thread Vincent Povirk
Overall, I don't feel this series is "ready" yet, or that it will be ready if you address all of my comments. I'm intentionally keeping quiet about some things because I think it will be better for you to address them when the code freeze is over and you can send things to wine-patches. This is mos

Re: WINED3DUSAGE_MASK?

2010-07-09 Thread Misha Koshelev
On Fri, 2010-07-09 at 11:31 +0200, Stefan Dösinger wrote: > Am 09.07.2010 um 03:21 schrieb Misha Koshelev: > >wined3d: Add WINED3DUSAGE_OVERLAY. > This was added for overlay surfaces that only exist in ddraw. The mask is to > make sure d3d9 apps don't accidentally pass this flag to wined3d. I

Can Relay miss some calls in initialization stage?

2010-07-09 Thread Hayan Lee
Hi, all I'm working on relay layer in WINE. When I turn on WINEDEBUG=+relay, relay looks to miss some calls. When is the relay layer loaded? Before dll loaded or after? If WINE does something in its initialization step, relay can catch those or not? Thanks in advance. Hayan

Re: Portuguese (Brazil) translation of Wine at 100%

2010-07-09 Thread Ricardo Filipe
2010/7/9 Paul Vriens : > On 07/09/2010 12:56 PM, Michael Stefaniuc wrote: >> >> Paul, >> >> Paul Vriens wrote: >>> >>> Many thanks to Gustavo who brought the Portuguese (Brazil) translation >>> to a 100%. >>> >>> The list of 100% translations is slowly growing, we now have 7 (not >>> counting the o

Re: Portuguese (Brazil) translation of Wine at 100%

2010-07-09 Thread Paul Vriens
On 07/09/2010 12:56 PM, Michael Stefaniuc wrote: Paul, Paul Vriens wrote: Many thanks to Gustavo who brought the Portuguese (Brazil) translation to a 100%. The list of 100% translations is slowly growing, we now have 7 (not counting the ones that are mostly inherited from the neutral ones)!!

Re: Portuguese (Brazil) translation of Wine at 100%

2010-07-09 Thread Michael Stefaniuc
Paul, Paul Vriens wrote: > Many thanks to Gustavo who brought the Portuguese (Brazil) translation > to a 100%. > > The list of 100% translations is slowly growing, we now have 7 (not > counting the ones that are mostly inherited from the neutral ones)!! I count 8 translations at 100% (pt_BR and p

Re: [1/8] msi/tests: Run the automation tests in silent mode to avoid a dialog.

2010-07-09 Thread Andrew Nguyen
I just wanted to note that the test bot failures for the patch series are pre-existing, and aren't due to the changes in the series. On 07/09/2010 04:19 AM, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at

Re: kernel32: Loosen trailing \ requirement on GetVolumeInformationAW.

2010-07-09 Thread Alexandre Julliard
writes: >>In any case, if you think the existing tests are not good enough, you >>can certainly add more of them to clarify things. > > I'd like to, but how to change a drive's directory from within a program? Set the corresponding "=X:" environment variable. -- Alexandre Julliard julli...@win

Re: WINED3DUSAGE_MASK?

2010-07-09 Thread Stefan Dösinger
Am 09.07.2010 um 03:21 schrieb Misha Koshelev: >wined3d: Add WINED3DUSAGE_OVERLAY. This was added for overlay surfaces that only exist in ddraw. The mask is to make sure d3d9 apps don't accidentally pass this flag to wined3d. I don't think a test is needed, unless we find a windows app that

Re: [1/8] msi/tests: Run the automation tests in silent mode to avoid a dialog.

2010-07-09 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3251 Your paranoid android.

kernel32: Loosen trailing \ requirement on GetVolumeInformationAW.

2010-07-09 Thread Joerg-Cyril.Hoehle
Hi, The kernel32/volume test either passes or fails depending on C:'s current directory prior to invocation in the shell. C: CD \ # Use CD \windows or CD \anydir to obtain opposite results D: CD \somesubdir X:\path\to\kernel32_test.exe volume volume.c:328: Test failed: GetVolumeInformationA w/o '

Portuguese (Brazil) translation of Wine at 100%

2010-07-09 Thread Paul Vriens
Hi, Many thanks to Gustavo who brought the Portuguese (Brazil) translation to a 100%. The list of 100% translations is slowly growing, we now have 7 (not counting the ones that are mostly inherited from the neutral ones)!! -- Cheers, Paul.