Re: [PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 4)

2010-07-07 Thread James McKenzie
Misha Koshelev wrote: Misha Koshelev wrote: Ok per Dan's comments back to Misha: Alexandre rejects 'white space' changes, that is changes that fix indentation, remove extraneous or trailing spaces and tabs unless there is another change needed. If there is a needed change in th

Re: d3d9: add a few tests for GetAdapterDisplayModeEx

2010-07-07 Thread Henri Verbeet
On 8 July 2010 00:14, Louis Lenders wrote: >>These obviously depend on the actual setup of the machine running the >>test. > > yeah, you have a suggestion how to change the test, or should i just leave > them out of the test? > > Perhaps you can use EnumDisplaySettingsEx() or similar functions to

Re: d3d9: add a few tests for GetAdapterDisplayModeEx

2010-07-07 Thread Louis Lenders
On 7 July 2010 23:39, Louis Lenders wrote: > +todo_wine ok(mode_ex.ScanLineOrdering == > D3DSCANLINEORDERING_PROGRESSIVE, >"ScanLineOrdering is %d instead of %d\n", mode_ex.ScanLineOrdering, >D3DSCANLINEORDERING_PROGRESSIVE); > +todo_wine ok(rotation == D3DDISPLAYROTATION_IDENTITY, "rot

Re: d3d9: add a few tests for GetAdapterDisplayModeEx

2010-07-07 Thread Henri Verbeet
On 7 July 2010 23:39, Louis Lenders wrote: > +todo_wine ok(mode_ex.ScanLineOrdering == > D3DSCANLINEORDERING_PROGRESSIVE, "ScanLineOrdering is %d instead of %d\n", > mode_ex.ScanLineOrdering, D3DSCANLINEORDERING_PROGRESSIVE); > +todo_wine ok(rotation == D3DDISPLAYROTATION_IDENTITY, "rota

fyi d3dx work

2010-07-07 Thread Misha Koshelev
I did end up going with a github repo as I've finally figured out git pretty well (thanks a lot to you guys!) It is here: http://github.com/misha680/wine/commits/master In any case, feel free to peruse if interested. Hopefully when 1.2 is done I can start submitting to wine. Henri especially has

Re: [PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 4)

2010-07-07 Thread Misha Koshelev
> Misha Koshelev wrote: > > > >Ok per Dan's comments back to > > Misha: > > Alexandre rejects 'white space' changes, that is changes that fix > indentation, remove extraneous or trailing spaces and tabs unless there is > another change needed. If there is a needed change in this file, go ahea

Re: [PATCH 2/2] d3dx9: Test penultimate declaration element in D3DXDeclaratorFromFVFTest.

2010-07-07 Thread James Mckenzie
Alexandre Julliard wrote: >James McKenzie writes: > >> Misha Koshelev wrote: >>> --- >>> dlls/d3dx9_36/tests/mesh.c |6 +++--- >>> 1 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c >>> index a2fb6d8..2952e23 100644 >

Re: [PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 4)

2010-07-07 Thread James Mckenzie
Misha Koshelev wrote: > >Ok per Dan's comments back to Misha: Alexandre rejects 'white space' changes, that is changes that fix indentation, remove extraneous or trailing spaces and tabs unless there is another change needed. If there is a needed change in this file, go ahead and fixup white

Re: kernel32 translation

2010-07-07 Thread Paul Vriens
On 07/07/2010 06:25 PM, Michael Stefaniuc wrote: If Portuguese(Brazil) needs a separate winerr file that would also means we need to change winerr_ptg.mc to show 0x816, not? Well we can change it but there is no need. Hmmm... I wonder if we can put part of the messages in a SUBLANG_NEUTRAL Portu

Re: kernel32 translation

2010-07-07 Thread Gustavo
2010/7/7 Michael Stefaniuc : > Paul Vriens wrote: >> On 07/07/2010 01:13 PM, Michael Stefaniuc wrote: >>> Gustavo wrote: Em 7 de julho de 2010 05:36, Michael Stefaniuc escreveu: > Hello Gustavo, > > Gustavo wrote: >> I'm approaching 100% of translation of wine to Brazilian

Re: kernel32 translation

2010-07-07 Thread Michael Stefaniuc
Paul Vriens wrote: > On 07/07/2010 01:13 PM, Michael Stefaniuc wrote: >> Gustavo wrote: >>> Em 7 de julho de 2010 05:36, Michael Stefaniuc >>> escreveu: Hello Gustavo, Gustavo wrote: > I'm approaching 100% of translation of wine to Brazilian Portuguese :D Cool, great job! >

Re: [PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 3)

2010-07-07 Thread Frédéric Delanoy
On Wed, Jul 7, 2010 at 15:55, Misha Koshelev wrote: > Ok, sorry, fixed per Henri's _and_ James' comments. > > Misha > > p.s. If I can ask for a _huge_ favor, I read wine-devel online and I guess I > miss some of the messages. If you guys wouldn't mind > cc'ing me on my patches just in case much a

Re: kernel32 translation

2010-07-07 Thread Paul Vriens
On 07/07/2010 01:13 PM, Michael Stefaniuc wrote: Gustavo wrote: Em 7 de julho de 2010 05:36, Michael Stefaniuc escreveu: Hello Gustavo, Gustavo wrote: I'm approaching 100% of translation of wine to Brazilian Portuguese :D Cool, great job! As can be seen in wine statistics, the MESSAGE #1

Re: shlwapi/tests: set last error like Win7

2010-07-07 Thread Alexandre Julliard
André Hentschel writes: > This only applies to SHFormatDateTimeA, not to SHFormatDateTimeW... There's no reason to do this. 0 is not a valid last error anyway. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 4)

2010-07-07 Thread Marcus Meissner
On Wed, Jul 07, 2010 at 10:28:17AM -0500, Misha Koshelev wrote: > Ok per Dan's comments back to > This is my last try on these patches unless I hear from Alexandre. > > Misha > --- > dlls/d3dx9_36/tests/mesh.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/

Re: sane.ds: Change "ns" to "ms" in resource files

2010-07-07 Thread Steve Brown
On Wed, 7 Jul 2010, Ken Sharp wrote: On 7/7/2010 10:30 AM, Alexandre Julliard wrote: Ken Sharp writes: Apparently the English resource file should show "ms" (microseconds) instead of "ns". This error has been copied too all the .rc files. "ms" doesn't mean microseconds. What does it me

bug or feature: libd3dx9.cross.a

2010-07-07 Thread Misha Koshelev
Dear All: I have run into another slight issue and, as this may affect others, was wondering whether or not I am (i) doing something wrong or (ii) this is something that should be corrected (in that case I am happy to submit a patch but need a bit of guidance as to where this could be fixed as I

Re: [PATCH 2/2] d3dx9: Test penultimate declaration element in D3DXDeclaratorFromFVFTest.

2010-07-07 Thread Alexandre Julliard
James McKenzie writes: > Misha Koshelev wrote: >> --- >> dlls/d3dx9_36/tests/mesh.c |6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c >> index a2fb6d8..2952e23 100644 >> --- a/dlls/d3dx9_36/tests/mesh.c >

one more git trick - how to add (try x) automatically?

2010-07-07 Thread Misha Koshelev
Any hints. Since I'll probably be trying more than once for patches, good to know. Thank you! Misha

Re: Should include files be bug for bug compatible?

2010-07-07 Thread Alexandre Julliard
Dylan Smith writes: > In richedit.h CHARFORMAT2[AW] is padded differently on the Windows > PSDK depending on whether it is included for a c or c++ source file. > > Should the include file be fixed, or does bug for bug compatibility > mean that a correct CHARFORMAT2 structure should be declared in

Re: wine explorer /desktop=Title,0x0 app.exe for fullscreen?

2010-07-07 Thread Alexandre Julliard
writes: > What I need is the exact opposite. > > Looking at the source, I found out that the converse works using > wine explorer /desktop=Title,0x0 regedit.exe > opens a regedit window without a virtual desktop one. > > Can that behaviour be blessed officially and documented? Or is it accidental

Re: sane.ds: Change "ns" to "ms" in resource files

2010-07-07 Thread Ken Sharp
On 7/7/2010 11:56 AM, Huw Davies wrote: On Wed, Jul 07, 2010 at 11:45:59AM +0100, Ken Sharp wrote: On 7/7/2010 11:39 AM, Huw Davies wrote: On Wed, Jul 07, 2010 at 11:28:21AM +0100, Ken Sharp wrote: On 7/7/2010 10:30 AM, Alexandre Julliard wrote: Ken Sharpwrites: Apparently the English r

Re: kernel32 translation

2010-07-07 Thread Michael Stefaniuc
Gustavo wrote: > Em 7 de julho de 2010 05:36, Michael Stefaniuc escreveu: >> Hello Gustavo, >> >> Gustavo wrote: >>> I'm approaching 100% of translation of wine to Brazilian Portuguese :D >> Cool, great job! >> >>> As can be seen in wine statistics, the MESSAGE #1 from dlls/kernel32 in >>> Brazili

Re: sane.ds: Change "ns" to "ms" in resource files

2010-07-07 Thread Huw Davies
On Wed, Jul 07, 2010 at 11:45:59AM +0100, Ken Sharp wrote: > On 7/7/2010 11:39 AM, Huw Davies wrote: >> On Wed, Jul 07, 2010 at 11:28:21AM +0100, Ken Sharp wrote: >>> On 7/7/2010 10:30 AM, Alexandre Julliard wrote: Ken Sharp writes: > Apparently the English resource file should show

Re: d3d9/tests: Add test for surface format conversion

2010-07-07 Thread Henri Verbeet
On 7 July 2010 12:32, Bjørnar Hansen wrote: > On Tue, Jul 6, 2010 at 23:00, Henri Verbeet wrote: >> Depends. What are you trying to prove / find out with this test? >> > I started out by testing the Frameranger demo in Wine. A fixme printed > was that conversion from D3DFMT_A16B16G16R16F to D3DFM

Re: sane.ds: Change "ns" to "ms" in resource files

2010-07-07 Thread Ken Sharp
On 7/7/2010 11:39 AM, Huw Davies wrote: On Wed, Jul 07, 2010 at 11:28:21AM +0100, Ken Sharp wrote: On 7/7/2010 10:30 AM, Alexandre Julliard wrote: Ken Sharp writes: Apparently the English resource file should show "ms" (microseconds) instead of "ns". This error has been copied too all the

Re: mapi32: Add Gaelic resource (try4)

2010-07-07 Thread Michael Stefaniuc
GOUJON Alexandre wrote: > On 07/06/2010 11:51 PM, Michael Stefaniuc wrote: >> Did you test it with a fresh branch? You don't even need a named >> branch for that; one with the detached HEAD works as well for the test: >> - git checkout origin/master >> - git am $email > > I'm not an expert but her

Re: sane.ds: Change "ns" to "ms" in resource files

2010-07-07 Thread Huw Davies
On Wed, Jul 07, 2010 at 11:28:21AM +0100, Ken Sharp wrote: > On 7/7/2010 10:30 AM, Alexandre Julliard wrote: >> Ken Sharp writes: >> >>> Apparently the English resource file should show "ms" (microseconds) >>> instead of "ns". This error has been copied too all the .rc files. >> >> "ms" doesn't m

Re: kernel32 translation

2010-07-07 Thread Gustavo
Em 7 de julho de 2010 05:36, Michael Stefaniuc escreveu: > Hello Gustavo, > > Gustavo wrote: >> I'm approaching 100% of translation of wine to Brazilian Portuguese :D > Cool, great job! > >> As can be seen in wine statistics, the MESSAGE #1 from dlls/kernel32 in >> Brazilian Portuguese is actually

Re: d3d9/tests: Add test for surface format conversion

2010-07-07 Thread Bjørnar Hansen
On Tue, Jul 6, 2010 at 23:00, Henri Verbeet wrote: > Depends. What are you trying to prove / find out with this test? > I started out by testing the Frameranger demo in Wine. A fixme printed was that conversion from D3DFMT_A16B16G16R16F to D3DFMT_A8R8G8B8 was unimplemented, so I implemented that.

Re: mapi32: Add Gaelic resource (try4)

2010-07-07 Thread Ken Sharp
On 7/7/2010 10:34 AM, GOUJON Alexandre wrote: On 07/06/2010 11:51 PM, Michael Stefaniuc wrote: Did you test it with a fresh branch? You don't even need a named branch for that; one with the detached HEAD works as well for the test: - git checkout origin/master - git am $email I'm not an expert

Re: sane.ds: Change "ns" to "ms" in resource files

2010-07-07 Thread Ken Sharp
On 7/7/2010 10:30 AM, Alexandre Julliard wrote: Ken Sharp writes: Apparently the English resource file should show "ms" (microseconds) instead of "ns". This error has been copied too all the .rc files. "ms" doesn't mean microseconds. What does it mean? I couldn't find a definition.

wine explorer /desktop=Title,0x0 app.exe for fullscreen?

2010-07-07 Thread Joerg-Cyril.Hoehle
Hi, on MacOS, I've setup winecfg with a default virtual desktop because full screen apps generally don't work. However, all windowing apps (e.g. notepad, regedit) would benefit from not using this desktop window. They nicely open resizable windows when run in full screen. The FAQ recommends win

Re: [PATCH] ntdll: Fix QueryVirtual information on builtin DLLs

2010-07-07 Thread Alexandre Julliard
Marcus Meissner writes: > On Wed, Jul 07, 2010 at 11:29:25AM +0200, Alexandre Julliard wrote: >> You can't do that, it needs to be a single view. > > Umm, why? Because that's how Windows does it. Otherwise you are not making it more compatible, just differently broken. -- Alexandre Julliard ju

Re: [PATCH] ntdll: Fix QueryVirtual information on builtin DLLs

2010-07-07 Thread Marcus Meissner
On Wed, Jul 07, 2010 at 11:29:25AM +0200, Alexandre Julliard wrote: > Marcus Meissner writes: > > > @@ -1404,9 +1406,20 @@ static void load_builtin_callback( void *module, > > const char *filename ) > > builtin_load_info->status = STATUS_INVALID_IMAGE_FORMAT; > > return; > >

Re: mapi32: Add Gaelic resource (try4)

2010-07-07 Thread GOUJON Alexandre
On 07/06/2010 11:51 PM, Michael Stefaniuc wrote: Did you test it with a fresh branch? You don't even need a named branch for that; one with the detached HEAD works as well for the test: - git checkout origin/master - git am $email I'm not an expert but here is what I do in these cases: git res

Re: sane.ds: Change "ns" to "ms" in resource files

2010-07-07 Thread Alexandre Julliard
Ken Sharp writes: > Apparently the English resource file should show "ms" (microseconds) > instead of "ns". This error has been copied too all the .rc files. "ms" doesn't mean microseconds. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] ntdll: Fix QueryVirtual information on builtin DLLs

2010-07-07 Thread Alexandre Julliard
Marcus Meissner writes: > @@ -1404,9 +1406,20 @@ static void load_builtin_callback( void *module, const > char *filename ) > builtin_load_info->status = STATUS_INVALID_IMAGE_FORMAT; > return; > } > -virtual_create_system_view( module, nt->OptionalHeader.SizeOfImage, >

Re: [PATCH] riched20: Process WM_GETMINMAXINFO which arrives before WM_NCCREATE.

2010-07-07 Thread Dmitry Timoshkov
Austin Lund wrote: > This unconditional initialization isn't what windows does. Windows > only creates something at GetWindowLongPtr(hwnd,0) when WM_NCCREATE is > called. I'm not sure how to start to write a test for that, but I > have an app which uses hooks to show this (see below). Then doi

Re: kernel32 translation

2010-07-07 Thread Michael Stefaniuc
Hello Gustavo, Gustavo wrote: > I'm approaching 100% of translation of wine to Brazilian Portuguese :D Cool, great job! > As can be seen in wine statistics, the MESSAGE #1 from dlls/kernel32 in > Brazilian Portuguese is actually translated in European Portuguese. As I > can see, only the "default