Re: fusion: Implement IAssemblyNameImpl_GetDisplayName more completely

2010-07-06 Thread Nikolay Sivov
On 7/7/2010 03:04, Owen Rudge wrote: This should have been sent with my earlier fusion patch. It provides a more complete implementation of IAssemblyNameImpl_GetDisplayName, and is also required to fix the slow DirectX installer bug (22774). --- dlls/fusion/Makefile.in |2 +- dlls/fu

Should include files be bug for bug compatible?

2010-07-06 Thread Dylan Smith
In richedit.h CHARFORMAT2[AW] is padded differently on the Windows PSDK depending on whether it is included for a c or c++ source file. Should the include file be fixed, or does bug for bug compatibility mean that a correct CHARFORMAT2 structure should be declared in a private include file? I tri

Re: ntdll: Tests for i386 system service requests (Int 2E and SYSENTER) (try 2)

2010-07-06 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3197 Your paranoid android.

Re: [PATCH] riched20: Process WM_GETMINMAXINFO which arrives before WM_NCCREATE.

2010-07-06 Thread Austin Lund
>>> I'm reading this comment carefully for a suggestion as to how to "fix" >>> things, but it seems totally obfuscated. >> >> Editor should be unconditionally initialized if it's NULL, and WM_NCDESTROY >> should be made an explicit case in the 'switch' statement. > > Of course with appropriate test

Re: one more legal/protocol question

2010-07-06 Thread Misha Koshelev
On Tue, 2010-07-06 at 19:08 -0700, Juan Lang wrote: > > My question: > > Can I simply > > 1) look at the relevant DirectX 9 Microsoft .h files and add the > > constants (rewriting of course not copy paste) from there? > > I believe you can. > > > 2) do I have to do something more complicated? >

Re: one more legal/protocol question

2010-07-06 Thread Juan Lang
> My question: > Can I simply > 1) look at the relevant DirectX 9 Microsoft .h files and add the > constants (rewriting of course not copy paste) from there? I believe you can. > 2) do I have to do something more complicated? No, I don't think so. There are legal precedents if you like, e.g. th

Re: [PATCH 2/2] d3dx9: Test penultimate declaration element in D3DXDeclaratorFromFVFTest.

2010-07-06 Thread James McKenzie
Misha Koshelev wrote: --- dlls/d3dx9_36/tests/mesh.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c index a2fb6d8..2952e23 100644 --- a/dlls/d3dx9_36/tests/mesh.c +++ b/dlls/d3dx9_36/tests/mesh.c @@ -262,7 +26

Re: one more legal/protocol question

2010-07-06 Thread James McKenzie
Misha Koshelev wrote: Dear All: I may be mistaken, but it appears that the constants used for D3DX Mesh Options: http://msdn.microsoft.com/en-us/library/bb205746%28v=VS.85%29.aspx are not yet present in Wine. For example, in the main Wine source directory the command: find . -name \*.h -exec

Re: fusion: Implement IAssemblyNameImpl_GetDisplayName more completely

2010-07-06 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3196 Your paranoid android.

one more legal/protocol question

2010-07-06 Thread Misha Koshelev
Dear All: I may be mistaken, but it appears that the constants used for D3DX Mesh Options: http://msdn.microsoft.com/en-us/library/bb205746%28v=VS.85%29.aspx are not yet present in Wine. For example, in the main Wine source directory the command: find . -name \*.h -exec grep D3DXMESH_32BIT {} \

Re: ntdll: Tests for i386 system service requests (Int 2E and SYSENTER)

2010-07-06 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3194 Your paranoid android.

Re: Update - no wine repo on github

2010-07-06 Thread Misha Koshelev
On Tue, Jul 6, 2010 at 2:04 PM, Misha Koshelev wrote: > On Tue, 2010-07-06 at 14:50 -0400, Mike Kaplinskiy wrote: >> On Tue, Jul 6, 2010 at 2:31 PM, Misha Koshelev wrote: >> > On Tue, Jul 6, 2010 at 12:42 PM, Misha Koshelev wrote: >> >> Thank you so much for the info. I will probably just keep t

Re: [2/2] shell32/tests: CommandLineToArgvW("") shouldn't truncate returned exe path.

2010-07-06 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3190 Your paranoid android.

kernel32 translation

2010-07-06 Thread Gustavo
Hello, I'm approaching 100% of translation of wine to Brazilian Portuguese :D As can be seen in wine statistics, the MESSAGE #1 from dlls/kernel32 in Brazilian Portuguese is actually translated in European Portuguese. As I can see, only the "default sublanguages" languages have that file translat

Re: shlwapi/tests: set last error like Win7

2010-07-06 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3187 Your paranoid android.

Re: ok sorry dumb question... running make test with native DLLs

2010-07-06 Thread Misha Koshelev
On Wed, 2010-07-07 at 00:17 +0200, Matteo Bruni wrote: > 2010/7/6 Misha Koshelev : > > Oops good thing I did not yet figure out how to use a native d3dx9_36 then > > so no compromise of my ability to contribute. > > > > Just to clarify then... I may NOT use wine to monitor calls within a native > >

Re: ok sorry dumb question... running make test with native DLLs

2010-07-06 Thread Matteo Bruni
2010/7/6 Misha Koshelev : > Oops good thing I did not yet figure out how to use a native d3dx9_36 then > so no compromise of my ability to contribute. > > Just to clarify then... I may NOT use wine to monitor calls within a native > DLL? Specifically, I may not determine what parameters one native

Re: mapi32: Add Gaelic resource (try4)

2010-07-06 Thread Michael Stefaniuc
On 07/06/2010 11:36 PM, Ken Sharp wrote: On 6/7/2010 9:51 PM, Paul Vriens wrote: On 07/06/2010 08:45 PM, Ken Sharp wrote: Works fine here, but I've changed the encoding of the patch to see if that helps. Hi Ken, This one is even worse: ../../../wine-git/dlls/mapi32/Ga.rc:32:87: Error: Inva

Re: mapi32: Add Gaelic resource (try4)

2010-07-06 Thread Ken Sharp
On 6/7/2010 9:51 PM, Paul Vriens wrote: On 07/06/2010 08:45 PM, Ken Sharp wrote: Works fine here, but I've changed the encoding of the patch to see if that helps. Hi Ken, This one is even worse: ../../../wine-git/dlls/mapi32/Ga.rc:32:87: Error: Invalid character in string 'R-phost a sheolad

Re: ok sorry dumb question... running make test with native DLLs

2010-07-06 Thread Misha Koshelev
Oops good thing I did not yet figure out how to use a native d3dx9_36 then so no compromise of my ability to contribute. Just to clarify then... I may NOT use wine to monitor calls within a native DLL? Specifically, I may not determine what parameters one native function passes to another? Thank

Re: ok sorry dumb question... running make test with native DLLs

2010-07-06 Thread Austin English
On Tue, Jul 6, 2010 at 3:39 PM, Austin English wrote: > On Tue, Jul 6, 2010 at 3:29 PM, Misha Koshelev wrote: >> I am now trying to debug the exact parameters D3DXCreateBox uses in its >> call to D3DXCreateMesh to create its mesh. >> >> I would like to run make test with a native DLL. >> >> I hav

Re: kernel32: Update Welsh resource

2010-07-06 Thread Paul Vriens
On 07/06/2010 10:58 PM, Paul Vriens wrote: On 07/06/2010 08:40 PM, Ken Sharp wrote: Could someone take a look at this for me? http://source.winehq.org/patches/data/63232 It applies fine here but http://source.winehq.org/patches/ says it fails. I can't see what's wrong. :( Thanks. It's the

Re: d3d9/tests: Add test for surface format conversion

2010-07-06 Thread Henri Verbeet
On 6 July 2010 22:38, Bjørnar Hansen wrote: > On Mon, Jul 5, 2010 at 21:23, Henri Verbeet wrote: >> You're supposed to call IDirect3D9_CheckDeviceFormatConversion() to >> determine which conversions are supported. >> > > Currently, that method always returns OK. Seems pointless to use it, > but I

Re: kernel32: Update Welsh resource

2010-07-06 Thread Paul Vriens
On 07/06/2010 08:40 PM, Ken Sharp wrote: Could someone take a look at this for me? http://source.winehq.org/patches/data/63232 It applies fine here but http://source.winehq.org/patches/ says it fails. I can't see what's wrong. :( Thanks. It's the changes to Makefile.in that are the issue.

Re: kernel32: Update Welsh resource

2010-07-06 Thread Michael Stefaniuc
On 07/06/2010 08:40 PM, Ken Sharp wrote: Could someone take a look at this for me? http://source.winehq.org/patches/data/63232 It applies fine here but http://source.winehq.org/patches/ says it fails. I can't see what's wrong. :( How did you test it? The way to go is: - Save the email from the

Re: mapi32: Add Gaelic resource (try4)

2010-07-06 Thread Paul Vriens
On 07/06/2010 08:45 PM, Ken Sharp wrote: Works fine here, but I've changed the encoding of the patch to see if that helps. Hi Ken, This one is even worse: ../../../wine-git/dlls/mapi32/Ga.rc:32:87: Error: Invalid character in string 'R-phost a sheoladh mar a theip n� g� duit a cliant r�omhp

Re: ok sorry dumb question... running make test with native DLLs

2010-07-06 Thread Austin English
On Tue, Jul 6, 2010 at 3:29 PM, Misha Koshelev wrote: > I am now trying to debug the exact parameters D3DXCreateBox uses in its > call to D3DXCreateMesh to create its mesh. > > I would like to run make test with a native DLL. > > I have tried both: > * using winecfg to set native overrides > * WIN

d3d9/tests: Add test for surface format conversion

2010-07-06 Thread Bjørnar Hansen
On Mon, Jul 5, 2010 at 21:37, Stefan Dösinger wrote: > The DirectX9 SDK "Blobs" sample needs it. It creates a R32F surface, stretches > to a R16F and then uses it for drawing. Later on I realized that DirectX9 > cards(at least my GF7400) don't support R16F, so the sample uses the original > R32F

Re: [PATCH 2/2] d3dx9: Test penultimate declaration element in D3DXDeclaratorFromFVFTest.

2010-07-06 Thread Henri Verbeet
Should probably use the size of the expected declaration anyway.

ok sorry dumb question... running make test with native DLLs

2010-07-06 Thread Misha Koshelev
I am now trying to debug the exact parameters D3DXCreateBox uses in its call to D3DXCreateMesh to create its mesh. I would like to run make test with a native DLL. I have tried both: * using winecfg to set native overrides * WINEDLLOVERRIDES="d3dx9_36=n" make test but neither seems to do the tri

Re: Update - no wine repo on github

2010-07-06 Thread Misha Koshelev
On Tue, 2010-07-06 at 14:50 -0400, Mike Kaplinskiy wrote: > On Tue, Jul 6, 2010 at 2:31 PM, Misha Koshelev wrote: > > On Tue, Jul 6, 2010 at 12:42 PM, Misha Koshelev wrote: > >> Thank you so much for the info. I will probably just keep the Zip file for > >> now but if the number of patches gets o

Re: Update - no wine repo on github

2010-07-06 Thread Mike Kaplinskiy
On Tue, Jul 6, 2010 at 2:31 PM, Misha Koshelev wrote: > On Tue, Jul 6, 2010 at 12:42 PM, Misha Koshelev wrote: >> Thank you so much for the info. I will probably just keep the Zip file for >> now but if the number of patches gets out of hand will try git again :-) >> Thanks again >> >> Misha >> >

kernel32: Update Welsh resource

2010-07-06 Thread Ken Sharp
Could someone take a look at this for me? http://source.winehq.org/patches/data/63232 It applies fine here but http://source.winehq.org/patches/ says it fails. I can't see what's wrong. :( Thanks.

Re: Update - no wine repo on github

2010-07-06 Thread Misha Koshelev
On Tue, Jul 6, 2010 at 12:42 PM, Misha Koshelev wrote: > Thank you so much for the info. I will probably just keep the Zip file for > now but if the number of patches gets out of hand will try git again :-) > Thanks again > > Misha > > On Jul 6, 2010 12:18 PM, "Mike Kaplinskiy" > wrote: > > On Tu

Re: Update - no wine repo on github

2010-07-06 Thread Misha Koshelev
Thank you so much for the info. I will probably just keep the Zip file for now but if the number of patches gets out of hand will try git again :-) Thanks again Misha On Jul 6, 2010 12:18 PM, "Mike Kaplinskiy" wrote: On Tue, Jul 6, 2010 at 11:27 AM, Misha Koshelev wrote: > Fyi I am just going

Re: Update - no wine repo on github

2010-07-06 Thread Mike Kaplinskiy
On Tue, Jul 6, 2010 at 11:27 AM, Misha Koshelev wrote: > Fyi I am just going to keep my latest patches here: > http://www.mkosh.com/wine-d3dx9.zip > > I have struggled for an hour trying to remove a remote commit on github, > and that's an hour I'd rather spend implementing D3DX functions. > > Any

Re: [2/5] d3d9: Skip YUV tests when encountering a broken driver

2010-07-06 Thread Alexandre Julliard
Stefan Dösinger writes: > Using win_skip this time It fails here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:7975: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests visual.c:10076: Test fa

Re: [4/5] d3d9: Accept the d3d10 fog+sRGB behavior as broken

2010-07-06 Thread Henri Verbeet
On 6 July 2010 17:41, Stefan Dösinger wrote: >> Sure, I just don't think either behaviour should be considered broken >> at this point. > Do you think we should just accept both behaviors as OK? > Yeah.

Re: [4/5] d3d9: Accept the d3d10 fog+sRGB behavior as broken

2010-07-06 Thread Stefan Dösinger
Am Dienstag 06 Juli 2010 17:02:23 schrieb Henri Verbeet: > > I haven't seen any game that depends on the new behavior. Since the > > Source 2003 engine is pretty popular it would be a lot of pain to try to > > adopt the dx10 fog-sRGB behavior with no gain. > > We may want to use the framebuffer_sR

Update - no wine repo on github

2010-07-06 Thread Misha Koshelev
Fyi I am just going to keep my latest patches here: http://www.mkosh.com/wine-d3dx9.zip I have struggled for an hour trying to remove a remote commit on github, and that's an hour I'd rather spend implementing D3DX functions. Anyway sorry for the mailbox clutter :) Misha

Re: [4/5] d3d9: Accept the d3d10 fog+sRGB behavior as broken

2010-07-06 Thread Henri Verbeet
On 6 July 2010 16:50, Stefan Dösinger wrote: > Am Dienstag 06 Juli 2010 16:23:51 schrieb Henri Verbeet: >> It's really HL2 that's broken then, I don't think it would be >> unreasonable for wined3d to adapt the newer behaviour on appropriate >> cards in the future. > I haven't seen any game that de

Re: WineD3D: Only perform sRGB write correction on formats that advertise it

2010-07-06 Thread Stefan Dösinger
Am Dienstag 06 Juli 2010 16:24:02 schrieb Henri Verbeet: > IMO this should be deferred. fine with me

Re: [4/5] d3d9: Accept the d3d10 fog+sRGB behavior as broken

2010-07-06 Thread Stefan Dösinger
Am Dienstag 06 Juli 2010 16:23:51 schrieb Henri Verbeet: > It's really HL2 that's broken then, I don't think it would be > unreasonable for wined3d to adapt the newer behaviour on appropriate > cards in the future. I haven't seen any game that depends on the new behavior. Since the Source 2003 eng

Re: sane.ds: Add Welsh resource

2010-07-06 Thread Ken Sharp
On 6/7/2010 9:55 AM, Huw Davies wrote: On Mon, Jul 05, 2010 at 06:51:36PM +0100, Ken Sharp wrote: +{ + 0 "" + 1 "px" + 2 "b" /* What is "b" ? */ + 3 "mm" + 4 "dpi" /* dotiau fesul modfedd */ + 5 "%" + 6 "ns" /* What is "ns" ? */ +} See the SANE_UNIT_ defines in /usr/include/sane/sane.h 'b' i

Re: mapi32: Add Gaelic resource (try2)

2010-07-06 Thread Ken Sharp
On 6/7/2010 7:30 AM, Paul Vriens wrote: On 07/05/2010 07:38 PM, Ken Sharp wrote: Hi Ken, Next to fixing the apply failure you should also add the "#pragma code_page(65001)" statement to avoid these warnings: Warning: string "R-phost a sheoladh mar a theip ní gá duit a cliant ríomhphoist MA

Re: base addresses of kernel32

2010-07-06 Thread Vitaliy Margolen
On 07/05/2010 11:53 AM, Ilya Basin wrote: > I Wonder why our package maintainers didn't mark prelink as > makedepends. Report that as a bug to your distro. > Maybe it's not 100% reliable? It is 100% reliable, if prelink works of course. > For example if one of the wine's dependencies, say, libpth

Re: base addresses of kernel32

2010-07-06 Thread Vitaliy Margolen
On 07/04/2010 12:08 PM, James McKenzie wrote: > Marcus Meissner wrote: >> kernel32 is also loaded to the same base address. > Is there a good reason for this? Otherwise, this opens a security > vulnerability in Wine that does not exist in Windows Yes, safedisk. Vitaliy

Re: shlwapi: Partially implement SHGetShellKey (try4)

2010-07-06 Thread Nikolay Sivov
On 7/6/2010 17:52, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDeta

Re: back from Russia... learning d3dx9

2010-07-06 Thread Misha Koshelev
On Tue, 2010-07-06 at 15:10 +0200, Matteo Bruni wrote: > 2010/7/6 Misha Koshelev : > > Thank you for the well wishes James and Dan. Will def keep the test bot in > > mind. > > Unfortunately no WineTestBot machine has any d3dx9_xx.dll installed > (or so it was last time I checked), so no luck there

Re: [4/5] d3d9: Accept the d3d10 fog+sRGB behavior as broken

2010-07-06 Thread Henri Verbeet
On 6 July 2010 14:53, Stefan Dösinger wrote: > + * DirectX9 cards return 0.5, DirectX10 cards return 0.73. Some > games(Half Life 2 based ones > + * specifically) need the DX9 behavior. DX10 Windows drivers apparently > have a quirk for HL2. Wine > + * emulates the DX9 behavior, this

Re: WineD3D: Only perform sRGB write correction on formats that advertise it

2010-07-06 Thread Henri Verbeet
IMO this should be deferred.

Re: [PATCH] riched20: Process WM_GETMINMAXINFO which arrives before WM_NCCREATE.

2010-07-06 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Austin Lund wrote: >> I'm not sure how that's relevant because if the messages aren't passed >> then as long as a WM_NCCREATE is passed then the editor variable is >> initialised by this. > > What happens if an application doesn't pass WM_NCCREATE? It would be legitim

Re: [PATCH] riched20: Process WM_GETMINMAXINFO which arrives before WM_NCCREATE.

2010-07-06 Thread James Mckenzie
Austin Lund wrote: >Subject: [PATCH] riched20: Process WM_GETMINMAXINFO which arrives before >WM_NCCREATE. > > Austin: Does this solve a regression bug? If not this will have to wait until Wine 1.2 is released. Also, a conformance test that demonstrates this is what Windows does helps a grea

Re: shlwapi: Partially implement SHGetShellKey (try4)

2010-07-06 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3178 Your paranoid android.

Re: [PATCH] riched20: Process WM_GETMINMAXINFO which arrives before WM_NCCREATE.

2010-07-06 Thread Dmitry Timoshkov
Austin Lund wrote: > > This code is completely broken. An app can decide to not even pass these > > messages to a subclassed richedit control. > > I'm not sure how that's relevant because if the messages aren't passed > then as long as a WM_NCCREATE is passed then the editor variable is > initia

Re: back from Russia... learning d3dx9

2010-07-06 Thread Matteo Bruni
2010/7/6 Misha Koshelev : > Thank you for the well wishes James and Dan. Will def keep the test bot in > mind. Unfortunately no WineTestBot machine has any d3dx9_xx.dll installed (or so it was last time I checked), so no luck there. I don't know if it's possible to install the latest DirectX SDK t

Re: shlwapi: Partially implement SHGetShellKey (try3)

2010-07-06 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3171 Your paranoid android.

Re: [PATCH] riched20: Process WM_GETMINMAXINFO which arrives before WM_NCCREATE.

2010-07-06 Thread Austin Lund
On 6 July 2010 17:39, Dmitry Timoshkov wrote: > Austin Lund wrote: > >> --- a/dlls/riched20/editor.c >> +++ b/dlls/riched20/editor.c >> @@ -4406,7 +4406,7 @@ static LRESULT RichEditWndProc_common(HWND hWnd, UINT >> msg, WPARAM wParam, >>        texthost = ME_CreateTextHost(hWnd, pcs, FALSE); >>

Re: Have we finalized the gecko version for 1.2?

2010-07-06 Thread Jacek Caban
On 7/6/10 3:55 AM, Scott Ritchie wrote: I'm wondering if I'll need to update the gecko packages too. No, there is no Gecko update for Wine 1.2. See http://www.winehq.org/pipermail/wine-devel/2010-June/084102.html for more details. Jacek

Re: sane.ds: Add Welsh resource

2010-07-06 Thread Huw Davies
On Mon, Jul 05, 2010 at 06:51:36PM +0100, Ken Sharp wrote: > +{ > + 0 "" > + 1 "px" > + 2 "b" /* What is "b" ? */ > + 3 "mm" > + 4 "dpi" /* dotiau fesul modfedd */ > + 5 "%" > + 6 "ns" /* What is "ns" ? */ > +} See the SANE_UNIT_ defines in /usr/include/sane/sane.h 'b' is bits and 'ns' should be

Re: [PATCH] riched20: Process WM_GETMINMAXINFO which arrives before WM_NCCREATE.

2010-07-06 Thread Dmitry Timoshkov
Austin Lund wrote: > --- a/dlls/riched20/editor.c > +++ b/dlls/riched20/editor.c > @@ -4406,7 +4406,7 @@ static LRESULT RichEditWndProc_common(HWND hWnd, UINT > msg, WPARAM wParam, >texthost = ME_CreateTextHost(hWnd, pcs, FALSE); >return texthost != NULL; > } > -else if