Re: usp10/tests: having numbers in the ScriptStringXtoCP tests causes unpredictable behavior

2010-06-15 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2695 Your paranoid android.

Re: winex11.drv: Post a WM_SYSCOMMAND SC_CLOSE when the Window Manager asks to close a window

2010-06-15 Thread Vitaliy Margolen
On 06/15/2010 05:36 AM, Paul Chitescu wrote: > Changelog: > winex11.drv: Post a WM_SYSCOMMAND SC_CLOSE when the Window Manager asks > to > close a window > +GetCursorPos( &pt ); > +PostMessageW( hwnd, WM_SYSCOMMAND, SC_CLOSE, MAKELPARAM( pt.x, > pt.y ) ); You can't

Re: [PATCH] winspool: Return ERROR_MORE_DATA, when the app probe for the needed buffersize [BUG 19624]

2010-06-15 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2686 Your paranoid android.

Re: propsys: mention that the functions are stubs

2010-06-15 Thread Francois Gouget
On Tue, 15 Jun 2010, James Mckenzie wrote: [...] > >I'd say we need turn those into traces and add fixmes for the > >unimplemented parts, if needed. > > > This actually might be better, but don't TRACES only appear if you are > running in debug mode? We do want to inform our user base that a > f

Re: avifil32: Update English resource

2010-06-15 Thread Frédéric Delanoy
> So whoever accepts or rejects the patches Alexandre Julliard is the commit imperator >, you may as well reject all of > mine (if you haven't already).  I'll send them again once I'm on the right > track. > > Thanks all.

Re: avifil32: Update English resource

2010-06-15 Thread Ken Sharp
On 15/06/10 20:26, Michael Stefaniuc wrote: On 06/15/2010 08:53 PM, Ken Sharp wrote: On 15/06/10 10:28, Michael Stefaniuc wrote: That's just an artifact of how the translation statistics tool works. But Wine will use LANG_ENGLISH SUBLANG_DEFAULT if there is no SUBLANG_NEUTRAL translation.

Re: avifil32: Update English resource

2010-06-15 Thread André Hentschel
Am 15.06.2010 21:47, schrieb Ken Sharp: > > > On 15/06/10 20:34, André Hentschel wrote: > >> BTW: Placing your Copyrights in the translation files for some text >> copying is somehow naughty... >> > > I asked about that in #winehackers and I was told I should add my own > copyright. Personally

Re: avifil32: Update English resource

2010-06-15 Thread Ken Sharp
On 15/06/10 20:34, André Hentschel wrote: BTW: Placing your Copyrights in the translation files for some text copying is somehow naughty... I asked about that in #winehackers and I was told I should add my own copyright. Personally, I couldn't care less.

Re: avifil32: Update English resource

2010-06-15 Thread André Hentschel
Am 15.06.2010 20:53, schrieb Ken Sharp: > > > On 15/06/10 10:28, Michael Stefaniuc wrote: > >> That's just an artifact of how the translation statistics tool works. >> But Wine will use LANG_ENGLISH SUBLANG_DEFAULT if there is no >> SUBLANG_NEUTRAL translation. Duplicating unneeded resources mak

Re: avifil32: Update English resource

2010-06-15 Thread Michael Stefaniuc
On 06/15/2010 08:53 PM, Ken Sharp wrote: On 15/06/10 10:28, Michael Stefaniuc wrote: That's just an artifact of how the translation statistics tool works. But Wine will use LANG_ENGLISH SUBLANG_DEFAULT if there is no SUBLANG_NEUTRAL translation. Duplicating unneeded resources makes them prone

Re: propsys: mention that the functions are stubs

2010-06-15 Thread James Mckenzie
Hans Leidekker wrote: > >On Tue, 2010-06-15 at 10:25 +0200, Francois Gouget wrote: > >> Just to confirm what André said, if the FIXME does not contain the word >> 'stub', then apistats has no way to know it's a (pseudo-)stub. > >Wouldn't it be sufficient for our purposes to just count every first

Re: avifil32: Update English resource

2010-06-15 Thread Ken Sharp
On 15/06/10 10:28, Michael Stefaniuc wrote: That's just an artifact of how the translation statistics tool works. But Wine will use LANG_ENGLISH SUBLANG_DEFAULT if there is no SUBLANG_NEUTRAL translation. Duplicating unneeded resources makes them prone for bitrotting. bye michael I

Gcov and PGO

2010-06-15 Thread Peter Davies
After applying my "[RESEND 2] Changes to enable the use of gcov and PGO" patch To use gcov: Run "make EXTRACFLAGS=--coverage LDFLAGS=--coverage" Run program (presumably test suite) Run "gcov file.c" (multiple files like "gcov *.c" doesn't work for some reason) To use PGO Run "make EXTRA

Re: propsys: mention that the functions are stubs

2010-06-15 Thread Juan Lang
> Can you show me at least 3 stub functions with a fixme and without the stub > keyword grep can do that for you. One file alone will do this: dlls/itss/protocol.c. There are many more. --Juan

Re: propsys: mention that the functions are stubs

2010-06-15 Thread André Hentschel
Am 15.06.2010 11:25, schrieb Hans Leidekker: > Wouldn't it be sufficient for our purposes to just count every first > fixme in a WINAPI function as a stub? As it is now there's a large > percentage of fixmes that don't include the 'stub' keyword. Can you show me at least 3 stub functions with a fi

Re: [PATCH 2/2] winspool/tests: Test GetPrinterData/Ex for the printspooler

2010-06-15 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2673 Your paranoid android.

Re: Anotated 'make test' log

2010-06-15 Thread Dan Kegel
Max wrote: > A little reassurance that I am not crazy and > have the social skills needed to contribute to the community > are what I need at the moment. OK. I'd suggest starting by looking at http://bugs.winehq.org/show_bug.cgi?id=15435 "Wine logs too verbose, quieter fixme's needed" and sending

Re: propsys: mention that the functions are stubs

2010-06-15 Thread Francois Gouget
On Tue, 15 Jun 2010, Hans Leidekker wrote: [...] > Wouldn't it be sufficient for our purposes to just count every first > fixme in a WINAPI function as a stub? As it is now there's a large > percentage of fixmes that don't include the 'stub' keyword. > > > I would further argue that even a human r

Re: [8/9] setupapi: Only extract the first MSZIP cabinet file in SetupDecompressOrExtractFile.

2010-06-15 Thread Alexandre Julliard
Andrew Nguyen writes: > @@ -1458,24 +1458,25 @@ static DWORD decompress_file_lz( LPCWSTR source, > LPCWSTR target ) > > static UINT CALLBACK decompress_or_copy_callback( PVOID context, UINT > notification, UINT_PTR param1, UINT_PTR param2 ) > { > +static int has_extracted; > + This is

Re: propsys: mention that the functions are stubs

2010-06-15 Thread Hans Leidekker
On Tue, 2010-06-15 at 12:41 +0100, Peter Davies wrote: > > Wouldn't it be sufficient for our purposes to just count every first > > fixme in a WINAPI function as a stub? As it is now there's a large > > percentage of fixmes that don't include the 'stub' keyword. > > A FIXME doesn't neccesarily in

Re: propsys: mention that the functions are stubs

2010-06-15 Thread Peter Davies
> Wouldn't it be sufficient for our purposes to just count every first > fixme in a WINAPI function as a stub? As it is now there's a large > percentage of fixmes that don't include the 'stub' keyword. A FIXME doesn't neccesarily indicate a stub. It sometimes is like "Flag FOO unsupported", which

Re: Changes to enable the use of gcov

2010-06-15 Thread Peter Davies
> Somehow this patch got munged in transit and will not apply to current git. > Can you update it and send it again? I think my mail client (gmail) line wraps. I discovered when trying to apply it myself. > As an aside, if gcov compilation finally starts working that means we > can build Wine u

Re: avifil32: Update English resource

2010-06-15 Thread Michael Stefaniuc
Ken Sharp wrote: > > > On 15/06/10 09:00, Alexandre Julliard wrote: >> Ken Sharp writes: >> >>> @@ -50,3 +51,43 @@ STRINGTABLE DISCARDABLE >>> IDS_AVIFILETYPE"Wine AVI-default-filehandler" >>> IDS_UNCOMPRESSED "uncompressed" >>> } >>> + >>> +LANGUAGE LANG_ENGLISH, SUBLANG_NEUT

Re: propsys: mention that the functions are stubs

2010-06-15 Thread Hans Leidekker
On Tue, 2010-06-15 at 10:25 +0200, Francois Gouget wrote: > Just to confirm what André said, if the FIXME does not contain the word > 'stub', then apistats has no way to know it's a (pseudo-)stub. Wouldn't it be sufficient for our purposes to just count every first fixme in a WINAPI function as

Re: avifil32: Update English resource

2010-06-15 Thread Ken Sharp
On 15/06/10 09:00, Alexandre Julliard wrote: Ken Sharp writes: @@ -50,3 +51,43 @@ STRINGTABLE DISCARDABLE IDS_AVIFILETYPE "Wine AVI-default-filehandler" IDS_UNCOMPRESSED "uncompressed" } + +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL +/* Same as SUBLANG_DEFAULT */ If they are

Re: New Wine stuff in FreeWear.org

2010-06-15 Thread Ismael Barros²
Hi again, As the design seems to be liked, we just made the garments available for sale. As always, you can find them at http://www.freewear.org/?org=Wine Cheers! Ismael

Re: propsys: mention that the functions are stubs

2010-06-15 Thread Francois Gouget
On Mon, 14 Jun 2010, André Hentschel wrote: > Am 14.06.2010 22:01, schrieb Hans Leidekker: > > On Mon, 2010-06-14 at 21:26 +0200, André Hentschel wrote: > > > >> Hans might have missed that > > > > No, to me a fixme that prints a parameter list without further > > explanation implies that the fu

Re: [PATCH] atl: allow additioanl struct size on 64bit and test for it

2010-06-15 Thread Alexandre Julliard
Marcus Meissner writes: > Testruns show that on 32bit we have 100 and 132 as struct size, > while on 64bit we have 176, 240, and also 248. > > See this page for a loop from 1..300: > https://testbot.winehq.org/JobDetails.pl?Key=2643 So why aren't you doing that loop in the final test? As it is,

Re: avifil32: Update English resource

2010-06-15 Thread Alexandre Julliard
Ken Sharp writes: > @@ -50,3 +51,43 @@ STRINGTABLE DISCARDABLE >IDS_AVIFILETYPE"Wine AVI-default-filehandler" >IDS_UNCOMPRESSED "uncompressed" > } > + > +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL > +/* Same as SUBLANG_DEFAULT */ If they are the same there's no reason to duplicate

Re:Anotated 'make test' log

2010-06-15 Thread Max TenEyck Woodbury
Thank you Dan. > What problem are you trying to solve? Curing my ignorance and rebuild my self-confidence. :) > I gather you're just plowing through the output of 'make test', > looking at each bit of noise, and trying to figure out a way > to improve the tests? Sort of. I needed a place to st