Re: Two enhancement requests for winetricks

2010-06-08 Thread Dan Kegel
On Tue, Jun 8, 2010 at 11:09 PM, Jan Hoogenraad wrote: >> http://code.google.com/p/winezeug/issues/detail?id=127 "want uninstall" > > Could this useage (use winetricks ONLY on a relatively empty .wine directory > to troubleshoot) be documented on every place in the winetricks > documentation direc

Re: Change a malloc() to a HeapAlloc()

2010-06-08 Thread James McKenzie
Ultra two wrote: --- We use real names here. This patch probably will not be committed until it is resubmitted. James McKenzie

Two enhancement requests for winetricks

2010-06-08 Thread Dan Kegel
OK, filed http://code.google.com/p/winezeug/issues/detail?id=127 "want uninstall" and http://code.google.com/p/winezeug/issues/detail?id=128 "want status" - Dan

Two enhancement requests for winetricks

2010-06-08 Thread Jan Hoogenraad
I cannot access the login to Google (Google won't let me for some technical reason) , into http://code.google.com/p/winezeug/issues/list so I use this mail list to report 2 enhancement requests 1) Can winetricks also include a REMOVE script for each of the tricks ? It seems that a user is now ad

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel

2010-06-08 Thread Joel Holdsworth
> > Does it fix a bug? If not, AJ may have placed it aside until after Wine 1.2 > > is released. > > Indeed. Adding new strings to translate will/should probably have to > wait until after Wine 1.2, so we can get as many languages as possible > at 100% when 1.2 is released. > > OTOH, if it new s

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel

2010-06-08 Thread Joel Holdsworth
> It says apply failure for 3/3, so that's probably why 2/3 wasn't committed > also. > > Problem is that there are a lot of translation updates these days and > some patches affect winecfg .rc files. I guess you should rebase on > git head and resend patch. However, I see there is still one patch

Re: gameux.dll implementation stub

2010-06-08 Thread Vincent Povirk
+HRESULT IGameExplorer_create(IUnknown *pUnkOuter, REFIID riid, LPVOID *ppObj) +{ +TRACE("(%p, %s, %p)\n", pUnkOuter, debugstr_guid(riid), ppObj); + +if( IsEqualIID( riid, &IID_IGameExplorer )) This won't work if the caller asks for IUnknown. In general, if you get a REFIID and void**, you

Re: gameux.dll implementation stub

2010-06-08 Thread James Mckenzie
Mariusz Pluciński wrote at Jun 8, 2010 6:56 AM > >Hello Greetings. >As you maybe know, I'm working on implementation of Game Explorer in >the Google Summer of Code. Main part of my work is now implementing >gaming APIs stored in gameux.dll library. I already sent patches >with headers, and I'm c

Re: Implement ID3DXConstantTable::GetConstantDesc

2010-06-08 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2526 Your paranoid android.

Re: Implement ID3DXConstantTable::GetConstantDesc

2010-06-08 Thread Matijn Woudt
On Tue, Jun 8, 2010 at 3:09 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testb

Re: msvcrt printf test failed on NT4,win95

2010-06-08 Thread Alexander Scott-Johns
On 8 June 2010 00:56, Alexander Scott-Johns wrote: > Thomas, > > On 7 June 2010 20:04, Thomas Heckel wrote: >> Hi Alexander, >> >> I was wondering why your patch b205fd8108eca2fd29705875e53ed852f56a6b6d >> "Proberly skip if functions are not available" made test errors on NT4 >> and Win95 test in

Re: kernel32: CopyFile cannot overwrite a file with itself (try 2)

2010-06-08 Thread Alexandre Julliard
Damjan Jovanovic writes: > Changelog: > * kernel32: CopyFile cannot overwrite a file with itself This breaks a number of things, particularly msi. It would need much more detailed tests. -- Alexandre Julliard julli...@winehq.org

Re: regedit: use binary mode when doing file import/export (try 2)

2010-06-08 Thread Alexandre Julliard
Damjan Jovanovic writes: > Changelog: > * regedit: use binary mode when doing file import/export I don't think it will work properly for output. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel

2010-06-08 Thread Frédéric Delanoy
On Tue, Jun 8, 2010 at 03:41, James McKenzie wrote: > Joel Holdsworth wrote: >> >> On Wed, 2010-06-02 at 23:56 +0100, Joel Holdsworth wrote: >> >>> >>> Signed-off-by: Joel Holdsworth >>> --- >>>  programs/winecfg/Bg.rc        |   19 + >>> >>> >> >> Any thoughts about this patch? I guess t

Making AppDB look nice

2010-06-08 Thread Alexandru Băluț
Hi, I think the AppDB pages look bad, and I want to spend some time to make them look better. For example: - In the page that shows a version of an application, the background color in the list of test results depends on the rating of each test result, and it looks very messy, that rating color sh