Re: Wine code comments

2010-06-05 Thread John Voltz
Thanks for all the input. I forgot about using #if (0). That will make life much easier. John

Re: Advice about a new project, and similarity to Wine's start

2010-06-05 Thread Edward Savage
On Sun, Jun 6, 2010 at 7:23 AM, Dan Kegel wrote: >> Did people use the early releases of Wine, even if they were missing >> features? > > Yes, as soon as they ran their favorite app. > > So in your case, as soon as your flash player can handle youtube.com > (or whatever free software afficianados

Re: Advice about a new project, and similarity to Wine's start

2010-06-05 Thread Wolfram Sang
> Is the AppDB software available for use on other projects? It is here and being GPL, I think you can use it :) http://source.winehq.org/git/appdb.git/ Good luck, Wolfram

Re: Wine code comments

2010-06-05 Thread James McKenzie
Octavian Voicu wrote: 2010/6/5 James McKenzie : Also if (0)'d code should have a comment block on when and why it was removed and what must be done to re-incorporate it and if someone is working on it, a name and durable contact information. Also, an anticpated completion date, if known, sho

re: Advice about a new project, and similarity to Wine's start

2010-06-05 Thread Dan Kegel
Alessandro Pignotti wrote: > how did Wine choose the feature set to support first? Pragmatically - by trying to get particular popular apps running. (Starting with solitaire :-) > Did people use the early releases of Wine, even if they were missing features? Yes, as soon as they ran their favori

Gecko64 status

2010-06-05 Thread Jacek Caban
Hi all, I'd like to share with you progress on gecko64. First of all, I think that it was never said in public, although I've been asked about it: there won't be gecko64 for 1.2 release. I think we will have Gecko release in the second half of this year it will support 64-bit, but it's not ye

Re: shdoclc: Add the Polish translation (try 2)

2010-06-05 Thread Paul Vriens
On 06/05/2010 01:38 PM, Łukasz Wojniłowicz wrote: +MENUITEM "&Odœwie¿ +", _IDM_REFRESH Hi Łukasz, Something went wrong here. -- Cheers, Paul.

Re: Wine code comments

2010-06-05 Thread Octavian Voicu
2010/6/5 James McKenzie : > Also if (0)'d code should have a comment block on when and why it was > removed and what must be done to re-incorporate it and if someone is working > on it, a name and durable contact information.  Also, an anticpated > completion date, if known, should be entered.  Rel

Advice about a new project, and similarity to Wine's start

2010-06-05 Thread Alessandro Pignotti
Hi everyone, first of all congratulations. The current maturity of Wine is really, really impressive. Thanks for your work. Let's introduce myself, I'm the author of the Lightspark project (http://lightspark.sf.net): a modern, open source, flash player implementation. The project is currently

Re: Wine code comments

2010-06-05 Thread James McKenzie
Frédéric Delanoy wrote: On Sat, Jun 5, 2010 at 05:38, James McKenzie mailto:jjmckenzi...@earthlink.net>> wrote: John Voltz wrote: Hi everyone, I have a question about comments in the Wine code. I noticed while tracking down a bug that a lot of the code comments are

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated

2010-06-05 Thread Andrew Eikum
> On 6/5/2010 19:09, Andrew Eikum wrote: >> I'm not sure I follow. As the tests in the patch show, QI is called up >> to >> two times, once for IPersist and once for IPersistFolder if the first >> fails. I can certainly add tests for returning different CLSIDs, though >> that seems uninteresting

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated

2010-06-05 Thread Andrew Eikum
> On 6/5/2010 19:09, Andrew Eikum wrote: >> I'm not sure I follow. As the tests in the patch show, QI is called up >> to >> two times, once for IPersist and once for IPersistFolder if the first >> fails. I can certainly add tests for returning different CLSIDs, though >> that seems uninteresting

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated

2010-06-05 Thread Nikolay Sivov
On 6/5/2010 19:09, Andrew Eikum wrote: Trouble is, I have no idea what it is used for. I tried testing most of the CLSIDs in shlguid.h with different combinations of flags, none of which had any effect. It must just be looking out for a small number of specific CLSIDs. One possible guess is th

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated

2010-06-05 Thread Andrew Eikum
> On 6/4/2010 22:13, Andrew Eikum wrote: >> On 06/03/2010 03:47 PM, Andrew Eikum wrote: >> So, with this in mind, here are some much more extensive tests. As is >> explained in the comment, Windows _does_ get the ClassID of the object >> in this call. But, Windows crashes when a non-IShellFolder

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated

2010-06-05 Thread Nikolay Sivov
On 6/4/2010 22:13, Andrew Eikum wrote: On 06/03/2010 03:47 PM, Andrew Eikum wrote: On 06/03/2010 03:12 PM, Nikolay Sivov wrote: No, this is not what I meant actually. The possible reason it was named as IUnknown_EnumObjects is the same as for the rest of similar calls. IUknown is a valid input

Re: shdoclc: Add the Polish translation

2010-06-05 Thread Paul Vriens
On 06/04/2010 04:33 PM, Łukasz Wojniłowicz wrote: + +LANGUAGE LANG_POLISH, SUBLANG_NEUTRAL + +IDR_BROWSE_CONTEXT_MENU MENU Hi Łukasz, Sorry if I wasn't clearer before. You are having effectively two blocks with the same translations now. The reason the English resource file has two blocks is

Wine on MIPS?

2010-06-05 Thread André Hentschel
Hi, i just read that MIPS is planning to get on the mobil market. It will be available in 4G Smartphones with Android. Wine has a MIPS port which should also run those obsolete Win32 MIPS Apps, so i guess the winelib side is more interesting. So here my question: did anyone recently tried to compi