Re: Wine code comments

2010-06-04 Thread Frédéric Delanoy
On Sat, Jun 5, 2010 at 05:38, James McKenzie wrote: > John Voltz wrote: > >> Hi everyone, >> >> I have a question about comments in the Wine code. I noticed while >> tracking down a bug that a lot of the code comments are using the >> block comment marker /*. This is a royal pain when trying to co

Re: Wine code comments

2010-06-04 Thread James McKenzie
John Voltz wrote: Hi everyone, I have a question about comments in the Wine code. I noticed while tracking down a bug that a lot of the code comments are using the block comment marker /*. This is a royal pain when trying to comment out large sections of code where there are a bunch of /* foo */

Re: Wine code comments

2010-06-04 Thread Andrew Nguyen
On Fri, Jun 4, 2010 at 3:35 PM, John Voltz wrote: > Is there are way around it without having to change them all to //? > For private, ad-hoc use, you could possibly use a preprocessor #if 0 block to achieve the desired comment effect.

Re: Wine code comments

2010-06-04 Thread Erich Hoover
On Fri, Jun 4, 2010 at 2:35 PM, John Voltz wrote: > ... > I have a question about comments in the Wine code. I noticed while > tracking down a bug that a lot of the code comments are using the > block comment marker /*. > ... See the wiki page on patches: http://wiki.winehq.org/SubmittingPatches

Wine code comments

2010-06-04 Thread John Voltz
Hi everyone, I have a question about comments in the Wine code. I noticed while tracking down a bug that a lot of the code comments are using the block comment marker /*. This is a royal pain when trying to comment out large sections of code where there are a bunch of /* foo */ comments. Why is th

xrender.c is does not find fontconfig.h on OS X Tiger

2010-06-04 Thread Mike Kronenberg
Dear List OS X Tiger does has not have fontconfig, so I'm building it in ~/buildwine/usr to keep it out of /usr. I include the headers and libs from ~/buildwine/usr with CPPFLAGS and CFLAGS. This worked fine until 1.2-rc1 and 1.2-rc2. Compiling xrender.c now exits with an error that FC_WEIGHT_

Re: [RFC] advapi32 -- GetNamedSecurityInfo

2010-06-04 Thread Austin English
On Thu, Jun 3, 2010 at 7:57 AM, GOUJON Alexandre wrote: > Hi, > > I'm trying to fix bug 18071 but I don't know anything about ACLs. > I wrote some tests (see attached patch and > https://testbot.winehq.org/JobDetails.pl?Key=2442) > and I modified the source according to my understanding of the iss

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated

2010-06-04 Thread Andrew Eikum
On 06/03/2010 03:47 PM, Andrew Eikum wrote: On 06/03/2010 03:12 PM, Nikolay Sivov wrote: No, this is not what I meant actually. The possible reason it was named as IUnknown_EnumObjects is the same as for the rest of similar calls. IUknown is a valid input for all of them and another _QueryInterf

Re: [1/2]wineps.drv: make use of MAKEINTRESOURCEW

2010-06-04 Thread Dmitry Timoshkov
André Hentschel wrote: > +#define PAPER 99 > #define IDD_PAPERS 100 > #define IDD_ORIENT_PORTRAIT 101 > #define IDD_ORIENT_LANDSCAPE 102 You could try to find a less generic name for this. -- Dmitry.

Re: [2/2]wineps.drv: Import comctl32 instead of loading it

2010-06-04 Thread Dmitry Timoshkov
André Hentschel wrote: > -IMPORTS = user32 gdi32 winspool advapi32 kernel32 > +IMPORTS = user32 gdi32 winspool advapi32 kernel32 comctl32 It's being loaded for a reason. You can make it delay loaded though. -- Dmitry.

Re: [PATCH] msi/tests: Fix install tests for Win9x

2010-06-04 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2470 Your paranoid android.

Re: shdoclc: Add the Polish translation

2010-06-04 Thread Paul Vriens
On 06/04/2010 01:05 PM, Łukasz Wojniłowicz wrote: + +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL This doesn't look correct for Polish ;) -- Cheers, Paul.

Re: appwiz: Add the Polish translation

2010-06-04 Thread Paul Vriens
On 06/04/2010 01:05 PM, Łukasz Wojniłowicz wrote: dlls/appwiz.cpl/Makefile.in |1 + dlls/appwiz.cpl/Pl.rc | 84 +++ 2 files changed, 85 insertions(+), 0 deletions(-) create mode 100755 dlls/appwiz.cpl/Pl.rc Hi Łukasz, Wrong mode here. S

Re: [PATCH 2/2] cmd: Update Dutch translation

2010-06-04 Thread Sven Baars
Hello Frédéric, Frédéric Delanoy wrote: 2010/6/2 Sven Baars mailto:sven.w...@gmail.com>> --- programs/cmd/Nl.rc | 194 --- 1 files changed, 106 insertions(+), 88 deletions(-) Hi Sven, Some remarks: - You shouldn't change the l