Re: bricscad goes native

2010-05-25 Thread Scott Ritchie
On 05/25/2010 11:39 AM, Dan Kegel wrote: > On Tue, May 25, 2010 at 10:58 AM, Avery Pennarun wrote: >>> In either case, you probably want to bundle the Wine runtime >>> with the app rather than trying to run against whatever Wine >>> the user has. >> >> I guess this is because wine is such a moving

Re: Voting for own bugs not allowed?

2010-05-25 Thread James Mckenzie
> >On Tue, May 25, 2010 at 8:59 AM, Vitaliy Margolen > wrote: >> On 05/25/2010 03:50 AM, Maarten Lankhorst wrote: >>> I'm for a patch to remove voting altogether. >> +1 >> Actually no patch needed. Voting can be disabled via option "usevotes". > >Let's disable it then, but that's no reason to close

Re: Voting for own bugs not allowed?

2010-05-25 Thread Wolfram Sang
> Let's disable it then, but that's no reason to close otherwise valid > bugs as invalid. Hmm, I am currently abusing the vote-system to mark bugs I am especially interested in right now. Is there any better way to do this? Searching for CC is not quite the same (but will do if needed). Regards,

Re: Voting for own bugs not allowed?

2010-05-25 Thread Wolfram Sang
> Voting for your own bug confirms it (changes status to NEW). You can not > confirm your own bugs. As simple as that. While I generally agree, the "status-changing" is an effect a number of bugzilla-users (especially new ones) are probably not aware of. Documentation helps here (on the voting-pag

Re: bricscad goes native

2010-05-25 Thread Dan Kegel
On Tue, May 25, 2010 at 10:58 AM, Avery Pennarun wrote: >> In either case, you probably want to bundle the Wine runtime >> with the app rather than trying to run against whatever Wine >> the user has. > > I guess this is because wine is such a moving target?  It seems a > shame to bundle a copy of

Re: bricscad goes native

2010-05-25 Thread Avery Pennarun
On Tue, May 25, 2010 at 1:47 PM, Dan Kegel wrote: > On Tue, May 25, 2010 at 10:21 AM, Avery Pennarun wrote: the winelib version was quite a flop too many problems >>> >>> Indeed.  One should never release naked winelib apps. >>> Instead, one should bundle the windows version >>> with a p

Re: bricscad goes native

2010-05-25 Thread Dan Kegel
On Tue, May 25, 2010 at 10:21 AM, Avery Pennarun wrote: >>> the winelib version was quite a flop too many problems >> >> Indeed.  One should never release naked winelib apps. >> Instead, one should bundle the windows version >> with a private copy of Wine, like Picasa (and >> now at least one

Re: bricscad goes native

2010-05-25 Thread Avery Pennarun
On Mon, May 24, 2010 at 6:46 PM, Dan Kegel wrote: > Max wrote: >> the winelib version was quite a flop too many problems > > Indeed.  One should never release naked winelib apps. > Instead, one should bundle the windows version > with a private copy of Wine, like Picasa (and > now at least one

Re: atl: reuse code of AtlModuleRegisterWndClassInfoW for AtlModuleRegisterWndClassInfoA (try 2)

2010-05-25 Thread Andrey Turkin
25.05.2010 19:58, André Hentschel wrote: Am 25.05.2010 17:05, schrieb Andrey Turkin: 25.05.2010 18:51, André Hentschel wrote: --- a/dlls/atl/atlwin.h +++ b/dlls/atl/atlwin.h @@ -43,7 +43,7 @@ typedef struct _ATL_WNDCLASSINFOW_TAG WCHAR m_szAutoName[14]; } _ATL_WNDCLASSINFOW;

Re: atl: reuse code of AtlModuleRegisterWndClassInfoW for AtlModuleRegisterWndClassInfoA (try 2)

2010-05-25 Thread André Hentschel
Am 25.05.2010 17:05, schrieb Andrey Turkin: > 25.05.2010 18:51, André Hentschel wrote: >> --- a/dlls/atl/atlwin.h >> +++ b/dlls/atl/atlwin.h >> @@ -43,7 +43,7 @@ typedef struct _ATL_WNDCLASSINFOW_TAG >> WCHAR m_szAutoName[14]; >> } _ATL_WNDCLASSINFOW; >> >> -ATOM WINAPI AtlModuleRegisterWnd

Re: Voting for own bugs not allowed?

2010-05-25 Thread Austin English
On Tue, May 25, 2010 at 8:59 AM, Vitaliy Margolen wrote: > On 05/25/2010 03:50 AM, Maarten Lankhorst wrote: >> I'm for a patch to remove voting altogether. > +1 > Actually no patch needed. Voting can be disabled via option "usevotes". Let's disable it then, but that's no reason to close otherwise

Re: Voting for own bugs not allowed?

2010-05-25 Thread Florian Köberle
On 05/25/2010 03:55 PM, Vitaliy Margolen wrote: > On 05/25/2010 12:46 AM, Florian Köberle wrote: > >> Hello, >> >> just someone informed me that I MUST NOT vote for my own bugs. Is there >> a reason for it? >> > Voting for your own bug confirms it (changes status to NEW). You can not > conf

Re: atl: reuse code of AtlModuleRegisterWndClassInfoW for AtlModuleRegisterWndClassInfoA (try 2)

2010-05-25 Thread Andrey Turkin
25.05.2010 18:51, André Hentschel wrote: --- a/dlls/atl/atlwin.h +++ b/dlls/atl/atlwin.h @@ -43,7 +43,7 @@ typedef struct _ATL_WNDCLASSINFOW_TAG WCHAR m_szAutoName[14]; } _ATL_WNDCLASSINFOW; -ATOM WINAPI AtlModuleRegisterWndClassInfoA(_ATL_MODULEW *pm, _ATL_WNDCLASSINFOA *wci, WNDPROC *

Re: Voting for own bugs not allowed?

2010-05-25 Thread Vitaliy Margolen
On 05/25/2010 03:50 AM, Maarten Lankhorst wrote: > I'm for a patch to remove voting altogether. +1 Actually no patch needed. Voting can be disabled via option "usevotes". Vitaliy.

Re: Voting for own bugs not allowed?

2010-05-25 Thread Vitaliy Margolen
On 05/25/2010 12:46 AM, Florian Köberle wrote: > Hello, > > just someone informed me that I MUST NOT vote for my own bugs. Is there > a reason for it? Voting for your own bug confirms it (changes status to NEW). You can not confirm your own bugs. As simple as that. And honestly for most develope

Re: Voting for own bugs not allowed?

2010-05-25 Thread David Gerard
On 25 May 2010 14:45, Rosanne DiMesio wrote: > It's definitely misleading to users. There are sporadic posts on the forum > urging people to vote for a bug, as if it made a difference, and angry posts > that bugs that have lots of votes aren't fixed yet. The one purpose I can see > it serving

Re: Voting for own bugs not allowed?

2010-05-25 Thread Rosanne DiMesio
On Tue, 25 May 2010 10:27:00 +0200 Roderick Colenbrander wrote: > > For users votes might be confusing as well. They think voting gives a > bug more priority to fix but as I already mentioned > I doubt it helps (it could help for commercial Wine distributions). > +1 It's definitely misleading

Re: winemenubuilder: use the full path to start.exe (try 2)

2010-05-25 Thread Alexandre Julliard
Damjan Jovanovic writes: > There might be a start.[exe/com/bat/whatever] in the directory wine > starts up in, which would get called instead of the one in > C:\Windows\... OK, makes sense. -- Alexandre Julliard julli...@winehq.org

Re: [4/4] wininet: Add tests for setting and retrieving the context value.

2010-05-25 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2306 Your paranoid android.

Re: [3/3] msi: End the search for a directory signature if the parent cannot be found.

2010-05-25 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2305 Your paranoid android.

Re: winemenubuilder: use the full path to start.exe (try 2)

2010-05-25 Thread Damjan Jovanovic
On Tue, May 25, 2010 at 11:57 AM, Alexandre Julliard wrote: > Damjan Jovanovic writes: > >> Changelog: >> * use the full path to start.exe > > Why do you need this? > > -- > Alexandre Julliard > julli...@winehq.org > There might be a start.[exe/com/bat/whatever] in the directory wine starts up i

Re: [PATCH] shlwapi: initial implement of SHAutoComplete (Retry)

2010-05-25 Thread Nikolay Sivov
On 5/25/2010 03:29, Hirofumi Katayama wrote: See attachment. Hi. +list = (LPWSTR) malloc(len); +free(list); Use HeapAlloc()/HeapFree() for that and others allocations. +fUnicode = IsWindowUnicode(hwndEdit); +if (fUnicode) +pProp = (AUTOCOMPLETEPROP *) GetP

Re: winemenubuilder: use the full path to start.exe (try 2)

2010-05-25 Thread Alexandre Julliard
Damjan Jovanovic writes: > Changelog: > * use the full path to start.exe Why do you need this? -- Alexandre Julliard julli...@winehq.org

Re: Voting for own bugs not allowed?

2010-05-25 Thread Maarten Lankhorst
Hi Florian, On 25-05-10 10:59, Florian Köberle wrote: Hello, I got some replys at other places (bug tracker and private email). As I want to keep the discussion on the mailinglist I will place my arguments for voting here: 1. Not all bugs I report are important to me. I sometimes just fill in

Re: Voting for own bugs not allowed?

2010-05-25 Thread David Gerard
On 25 May 2010 09:27, Roderick Colenbrander wrote: > On Tue, May 25, 2010 at 8:46 AM, Florian Köberle wrote: >> just someone informed me that I MUST NOT vote for my own bugs. Is there >> a reason for it? > I think it is disallowed because self promotion can make an app more > important while on

Re: Remove code which has been #if 0-ed for 11 years from DOSCONF_Device and DOSCONF_Install. (RESEND)

2010-05-25 Thread Alexandre Julliard
Gerald Pfeifer writes: > An alternate patch would be putting #if 0 around the first occurrence > of loadhigh, too, but this code has been marked dead for more than 11 > years, so I really think it can / should go? It doesn't make sense to parse and not do anything with it. If you want to remove

Re: gdi32: Properly restore the DC in MF_PlayMetaFile. (RESEND)

2010-05-25 Thread Alexandre Julliard
Gerald Pfeifer writes: > Any reason why this hasn't been applied yet? It's the updated/fixed > patch per Alexandre's guidance. It breaks the tests. -- Alexandre Julliard julli...@winehq.org

Re: Voting for own bugs not allowed?

2010-05-25 Thread Florian Köberle
Hello, I got some replys at other places (bug tracker and private email). As I want to keep the discussion on the mailinglist I will place my arguments for voting here: 1. Not all bugs I report are important to me. I sometimes just fill in bugs when I find them but they don't mean much to me. 2.

Re: Voting for own bugs not allowed?

2010-05-25 Thread Roderick Colenbrander
On Tue, May 25, 2010 at 8:46 AM, Florian Köberle wrote: > Hello, > > just someone informed me that I MUST NOT vote for my own bugs. Is there > a reason for it? > I think it is disallowed because self promotion can make an app more important while only few people may use it. To be honest I would