Re: software built and worked under wine but not in vista?

2010-05-20 Thread Hin-Tak Leung
--- On Thu, 20/5/10, Saulius Krasuckas wrote: > > > http://www.ghostscript.com/~hintak/setupgs-vista.exe > > > http://www.ghostscript.com/~hintak/setupgs-wine.exe > > > > There are a few differences I spotted between the two > executables: > > 1) setupgs-wine.exe has wrong image size, changing

Re: software built and worked under wine but not in vista?

2010-05-20 Thread Hin-Tak Leung
--- On Thu, 20/5/10, Matijn Woudt wrote: > >> * On Tue, 18 May 2010, Hin-Tak Leung wrote: > >>> > >>> So it seems that setupgs.exe is mis-compiled > under wine with win7 sdk but > >>> just happened to also work under wine. Any > idea how it might happen? > > I have gone ahead and done exactly th

Re: dinput2

2010-05-20 Thread Scott Ritchie
On 05/20/2010 06:15 PM, Vitaliy Margolen wrote: > On 05/20/2010 12:49 AM, David Adam wrote: >> Hello >> >> many distro ship the X-server with dinput2. More and more old games work >> pretty well now with Wine, but the mouse. Does anyone plan to work on >> the infamous bug 6971? > If you talking abo

Re: dinput2

2010-05-20 Thread Vitaliy Margolen
On 05/20/2010 12:49 AM, David Adam wrote: > Hello > > many distro ship the X-server with dinput2. More and more old games work > pretty well now with Wine, but the mouse. Does anyone plan to work on > the infamous bug 6971? If you talking about XI2 then see my notes about it in that bug. XI2 is un

Re: [5/6] d3dx9: Add basic implementation of D3DXFilterTexture, plus tests

2010-05-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2207 Your paranoid android.

Re: [2/2] shell32: Export ILFree by name

2010-05-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2202 Your paranoid android.

Re: comctl32/listview: Don't forward WM_COMMAND to parent if we don't have an Edit box (resent)

2010-05-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2201 Your paranoid android.

Re: Release plans

2010-05-20 Thread Steven Edwards
On Thu, May 20, 2010 at 4:17 PM, Steven Edwards wrote: > I've tried with other PNGs before that we've not generated. Take a > third party png, edit the Info.plist and change the icon entry to > instead of pointing at the icns file point at the new Png image. Of > course I've tried this on Leopard,

Re: Release plans

2010-05-20 Thread Steven Edwards
On Thu, May 20, 2010 at 4:13 PM, Damjan Jovanovic wrote: > Everything in the .png generation looks bog standard, but maybe MacOS > doesn't like our PNG comment. Try remove that ppng_set_text call in > winemenubuilder's SaveIconResAsPNG and see if it helps? I've tried with other PNGs before that w

Re: Release plans

2010-05-20 Thread Damjan Jovanovic
On Thu, May 20, 2010 at 9:51 PM, Steven Edwards wrote: > > > On Thu, May 20, 2010 at 3:44 PM, Steven Edwards > wrote: >> >> I have a hacked version in the Bordeaux tree that uses sips to create >> icns icons and working Application bundles. If they have time, Austin >> or Tom can send it along fo

Re: Release plans

2010-05-20 Thread Steven Edwards
On Thu, May 20, 2010 at 3:44 PM, Steven Edwards wrote: > I have a hacked version in the Bordeaux tree that uses sips to create > icns icons and working Application bundles. If they have time, Austin > or Tom can send it along for your review if your interested. The > 'right' solution would be to f

Re: Release plans

2010-05-20 Thread Steven Edwards
On Thu, May 20, 2010 at 3:08 PM, Damjan Jovanovic wrote: > winemenubuilder generates .png only for 24 and 32 bits-per-pixel > icons, all other resolutions get converted to .xpm. I am planning to > change it to make .png's for everything, since thumbnailing .lnk files > requires .png as output, and

Re: Release plans

2010-05-20 Thread Damjan Jovanovic
On Fri, May 14, 2010 at 12:31 PM, wrote: > Hi, Hi >>The 64-bit support is now more or less complete > I hope I can finish my MCI parser patches in time. Without them, > every 64bit app using MCI string commands is likely to crash (OTOH > MCI commands work (those using the MCI_*_PARAMS structure

Re: software built and worked under wine but not in vista?

2010-05-20 Thread Saulius Krasuckas
* On Thu, 20 May 2010, Matijn Woudt wrote: > On Thu, May 20, 2010 at 3:54 AM, Hin-Tak Leung > wrote: > > > > I have gone ahead and done exactly that - the correct behavior should > > be a msg box saying filelist.txt is missing, rather than setupgs.exe > > not a valid win32 application. > > > >

Re: dinput2

2010-05-20 Thread Austin English
On Thu, May 20, 2010 at 1:49 AM, David Adam wrote: > Hello > > many distro ship the X-server with dinput2. More and more old games work > pretty well now with Wine, but the mouse. Does anyone plan to work on the > infamous bug 6971? > It would be great if it could be implemented for the official r

Re: [3/9] ole32: Validate pointer parameters in MkParseDisplayName.

2010-05-20 Thread Alexandre Julliard
Andrew Nguyen writes: > @@ -814,12 +814,53 @@ static void test_MkParseDisplayName(void) > static const WCHAR wszDisplayNameProgId1[] = > {'S','t','d','F','o','n','t',':',0}; > static const WCHAR wszDisplayNameProgId2[] = > {'@','S','t','d','F','o','n','t',0}; > static const WCHAR

winecfg audio tab contents

2010-05-20 Thread Joerg-Cyril.Hoehle
Hi, Maarten Lankhorst wrote: >After 1.2 is shipped the audio tab will be all gone anyhow. :) You wrote "After" and not "With/when". Experience with 1.0 is that it's used even nowadays by some, so we can assume the same with 1.2. Therefore, the audio tab ought to work in 1.2 even if 1.3 switches to

Re: software built and worked under wine but not in vista?

2010-05-20 Thread Matijn Woudt
On Thu, May 20, 2010 at 3:54 AM, Hin-Tak Leung wrote: > Saulius Krasuckas wrote: >> >> I sorry for stepping into Alexandre's or Dmitry's shoes, but.. >> >> * On Tue, 18 May 2010, Hin-Tak Leung wrote: >>> >>> So it seems that setupgs.exe is mis-compiled under wine with win7 sdk but >>> just happene

Re: msi: Avoid a potential NULL pointer dereference (coccicheck).

2010-05-20 Thread Hans Leidekker
On Thu, 2010-05-20 at 12:49 +0200, Michael Stefaniuc wrote: > > It's a header construction where you typically exploit the fact that the > > header and extended structure start at the same address. So yes, we > > could leave the code as is. > "exploit" doesn't sound like a clean approach to me. Th

Re: msi: Avoid a potential NULL pointer dereference (coccicheck).

2010-05-20 Thread Marcus Meissner
On Thu, May 20, 2010 at 12:36:21PM +0200, Michael Stefaniuc wrote: > Paul Vriens wrote: > > On 05/20/2010 01:15 AM, Michael Stefaniuc wrote: > >> The last "goto done" is for si == NULL. When MSI_GetSummaryInformationW > >> returns NULL there is a crash. > >> --- > >> dlls/msi/msi.c |3 ++- > >

Re: msi: Avoid a potential NULL pointer dereference (coccicheck).

2010-05-20 Thread Michael Stefaniuc
Hans Leidekker wrote: > On Thu, 2010-05-20 at 10:03 +0200, Paul Vriens wrote: > The main reason I'm asking is because we have several of these lingering around (and marked as 'FALSE' in Coverity). >>> In this particular case we should just get rid of the goto. >>> >>> >> But is it a (pot

Re: [7/7] msi: Add more tests for feature overrides.

2010-05-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2196 Your paranoid android.

Re: msi: Avoid a potential NULL pointer dereference (coccicheck).

2010-05-20 Thread Michael Stefaniuc
Paul Vriens wrote: > On 05/20/2010 01:15 AM, Michael Stefaniuc wrote: >> The last "goto done" is for si == NULL. When MSI_GetSummaryInformationW >> returns NULL there is a crash. >> --- >> dlls/msi/msi.c |3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/dlls/msi/

Re: [6/7] msi: Test the reference count on the installer object retrieved from a session object.

2010-05-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2195 Your paranoid android.

Re: [TRY 2] shdocvw: Added IOleLink stub implementation.

2010-05-20 Thread Jacek Caban
On 5/20/10 9:33 AM, Ilya Shpigor wrote: +void WebBrowser_OleLink_Init(WebBrowser *This) +{ +This->lpOleLinkVtbl =&OleLinkVtbl; +} You don't need a separated function for that. Just use WebBrowser_OleObject_Init. Jacek

D3DX9: how to implement D3DXDeclaratorFromFVF

2010-05-20 Thread David Adam
Hello, I would like to implement the function D3DXDeclaratorFromFVF. My numerous attempts to do this were rejected (specially my copy/paste of the function vdecl_convert_fvf from d3d9/vertexdeclaration.c. Does anyone know a way to implement it? Thanks in advance David

dinput2

2010-05-20 Thread David Adam
Hello many distro ship the X-server with dinput2. More and more old games work pretty well now with Wine, but the mouse. Does anyone plan to work on the infamous bug 6971? It would be great if it could be implemented for the official release of Wine. It would do a big buzz :D Cheers David

Re: software built and worked under wine but not in vista?

2010-05-20 Thread Hin-Tak Leung
Saulius Krasuckas wrote: I sorry for stepping into Alexandre's or Dmitry's shoes, but.. * On Tue, 18 May 2010, Hin-Tak Leung wrote: So it seems that setupgs.exe is mis-compiled under wine with win7 sdk but just happened to also work under wine. Any idea how it might happen? ... there could b

Re: msi: Avoid a potential NULL pointer dereference (coccicheck).

2010-05-20 Thread Hans Leidekker
On Thu, 2010-05-20 at 10:03 +0200, Paul Vriens wrote: > >> The main reason I'm asking is because we have several of these lingering > >> around (and marked as 'FALSE' in Coverity). > > > > In this particular case we should just get rid of the goto. > > > > > But is it a (potential) issue? I guess

winmm: Have MCI drivers handle notification for MCI_OPEN.

2010-05-20 Thread Joerg-Cyril.Hoehle
Hi, >http://testbot.winehq.org/JobDetails.pl?Key=2193 >While running your changed tests on Windows, I think I found new failures. These are among the known set of 7 flaky tests (in vmware only?), e.g. see http://test.winehq.org/data/f00d44f0f63a66b9157ff7334f6b54c8b079c1ee/98_wtb-w98se/winmm:mci.

Re: winmm: Have MCI drivers handle notification for MCI_OPEN.

2010-05-20 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2193 Your paranoid android.

Re: quartz: Avoid using the long type.

2010-05-20 Thread Michael Stefaniuc
(Marvin) wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? Double checked and Marvin is wrong. > Full results can be found at > http://testbo

Re: msi: Avoid a potential NULL pointer dereference (coccicheck).

2010-05-20 Thread Paul Vriens
On 05/20/2010 10:00 AM, Hans Leidekker wrote: On Thu, 2010-05-20 at 08:04 +0200, Paul Vriens wrote: The main reason I'm asking is because we have several of these lingering around (and marked as 'FALSE' in Coverity). In this particular case we should just get rid of the goto. But is it a (p

Re: msi: Avoid a potential NULL pointer dereference (coccicheck).

2010-05-20 Thread Hans Leidekker
On Thu, 2010-05-20 at 08:04 +0200, Paul Vriens wrote: > The main reason I'm asking is because we have several of these lingering > around (and marked as 'FALSE' in Coverity). In this particular case we should just get rid of the goto.

Re: comctl32/listview: Don't forward WM_COMMAND to parent if we don't have an Edit box

2010-05-20 Thread Nikolay Sivov
On 5/20/2010 04:22, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDeta